On Thu, Feb 20, 2020 at 01:26:51AM +0530, Kaaira Gupta wrote:

Fix checkpatch.pl warning of alignment should match open parenthesis in audio_codec.c

Signed-off-by: Kaaira Gupta kgupta@es.iitr.ac.in

drivers/staging/greybus/audio_codec.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c index 08746c85dea6..d62f91f4e9a2 100644 --- a/drivers/staging/greybus/audio_codec.c +++ b/drivers/staging/greybus/audio_codec.c @@ -70,7 +70,7 @@ static int gbaudio_module_enable_tx(struct gbaudio_codec_info *codec, i2s_port = 0; /* fixed for now */ cportid = data->connection->hd_cport_id; ret = gb_audio_apbridgea_register_cport(data->connection,

• 				i2s_port, cportid,
  

• 					i2s_port, cportid,
  			AUDIO_APBRIDGEA_DIRECTION_TX);
  

You can't do it for one line, and not all of the lines.

And if you do it for all lines, then you push past the line-length.

So you are back to what we currently have, which is the best we can do, sorry.

greg k-h

On Mon, Feb 24, 2020 at 01:49:29PM +0200, Laurent Pinchart wrote:

Hi Kaaira,

Thank you for the patch.

On Thu, Feb 20, 2020 at 01:26:51AM +0530, Kaaira Gupta wrote:

...

Fix checkpatch.pl warning of alignment should match open parenthesis in audio_codec.c

Signed-off-by: Kaaira Gupta kgupta@es.iitr.ac.in

drivers/staging/greybus/audio_codec.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c index 08746c85dea6..d62f91f4e9a2 100644 --- a/drivers/staging/greybus/audio_codec.c +++ b/drivers/staging/greybus/audio_codec.c @@ -70,7 +70,7 @@ static int gbaudio_module_enable_tx(struct gbaudio_codec_info *codec, i2s_port = 0; /* fixed for now */ cportid = data->connection->hd_cport_id; ret = gb_audio_apbridgea_register_cport(data->connection,

• 				i2s_port, cportid,
  

• 					i2s_port, cportid,
  			AUDIO_APBRIDGEA_DIRECTION_TX);
  

I'm curious to know why you think the line you changed deserves a modification, while the next one doesn't :-)

According to me, both the lines deserve a modification. But I did not do that as changing the other line was throwing 'greater than 80 characters' warning and I wasn't sure if I should go ahead with the changes anyhow.

...

if (ret) {
	dev_err_ratelimited(module->dev,

@@ -160,7 +160,7 @@ static int gbaudio_module_disable_tx(struct gbaudio_module_info *module, int id) i2s_port = 0; /* fixed for now */ cportid = data->connection->hd_cport_id; ret = gb_audio_apbridgea_unregister_cport(data->connection,

• 				i2s_port, cportid,
  

• 					  i2s_port, cportid,
  			AUDIO_APBRIDGEA_DIRECTION_TX);
  

  if (ret) { dev_err_ratelimited(module->dev,

@@ -205,7 +205,7 @@ static int gbaudio_module_enable_rx(struct gbaudio_codec_info *codec, i2s_port = 0; /* fixed for now */ cportid = data->connection->hd_cport_id; ret = gb_audio_apbridgea_register_cport(data->connection,

• 				i2s_port, cportid,
  

• 					i2s_port, cportid,
  			AUDIO_APBRIDGEA_DIRECTION_RX);
  

  if (ret) { dev_err_ratelimited(module->dev,

@@ -295,7 +295,7 @@ static int gbaudio_module_disable_rx(struct gbaudio_module_info *module, int id) i2s_port = 0; /* fixed for now */ cportid = data->connection->hd_cport_id; ret = gb_audio_apbridgea_unregister_cport(data->connection,

• 				i2s_port, cportid,
  

• 					  i2s_port, cportid,
  			AUDIO_APBRIDGEA_DIRECTION_RX);
  

  if (ret) { dev_err_ratelimited(module->dev,

-- Regards,

Laurent Pinchart