Inside a block of if..else conditional, else structure does not contain brackets. This is not following regular policies of good coding style. All parts of this conditional blocks should respect brackets inclusion.
Signed-off-by: Julio Faracco jcfaracco@gmail.com --- drivers/staging/greybus/tools/loopback_test.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/tools/loopback_test.c b/drivers/staging/greybus/tools/loopback_test.c index ba6f905f2..d46721502 100644 --- a/drivers/staging/greybus/tools/loopback_test.c +++ b/drivers/staging/greybus/tools/loopback_test.c @@ -801,8 +801,9 @@ static void prepare_devices(struct loopback_test *t) write_sysfs_val(t->devices[i].sysfs_entry, "outstanding_operations_max", t->async_outstanding_operations); - } else + } else { write_sysfs_val(t->devices[i].sysfs_entry, "async", 0); + } } }
On Wed, Sep 04, 2019 at 08:32:09PM +0000, Julio Faracco wrote:
Inside a block of if..else conditional, else structure does not contain brackets. This is not following regular policies of good coding style.
s/good/kernel/ ?
All parts of this conditional blocks should respect brackets inclusion.
Did you check that there aren't further instances of this style issue in this file? If so, please them all in one go.
Also please include greybus component you are changing in your subject prefix:
staging: greybus: loopback_test: ...
Signed-off-by: Julio Faracco jcfaracco@gmail.com
drivers/staging/greybus/tools/loopback_test.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/tools/loopback_test.c b/drivers/staging/greybus/tools/loopback_test.c index ba6f905f2..d46721502 100644 --- a/drivers/staging/greybus/tools/loopback_test.c +++ b/drivers/staging/greybus/tools/loopback_test.c @@ -801,8 +801,9 @@ static void prepare_devices(struct loopback_test *t) write_sysfs_val(t->devices[i].sysfs_entry, "outstanding_operations_max", t->async_outstanding_operations);
} else
} else { write_sysfs_val(t->devices[i].sysfs_entry, "async", 0);}}
Johan
-
Johan Hovold -
Julio Faracco