The original dev_info call was intentionally temporary, with a FIXME comment noting it should be downgraded to dev_dbg once modules with valid VID/PID values were common. Project Ara was cancelled in 2016, so that time has long passed.
Remove the FIXME comment and downgrade to dev_dbg as originally intended.
Tested via code inspection only, as Project Ara hardware is no longer available.
Signed-off-by: Bentley Blacketer sonionwhat@gmail.com --- drivers/staging/greybus/bootrom.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/greybus/bootrom.c b/drivers/staging/greybus/bootrom.c index 83921d90c..757460c8b 100644 --- a/drivers/staging/greybus/bootrom.c +++ b/drivers/staging/greybus/bootrom.c @@ -168,12 +168,9 @@ static int find_firmware(struct gb_bootrom *bootrom, u8 stage) intf->ddbl1_manufacturer_id, intf->ddbl1_product_id, intf->vendor_id, intf->product_id);
- // FIXME: - // Turn to dev_dbg later after everyone has valid bootloaders with good - // ids, but leave this as dev_info for now to make it easier to track - // down "empty" vid/pid modules. - dev_info(&connection->bundle->dev, "Firmware file '%s' requested\n", - firmware_name); + + dev_dbg(&connection->bundle->dev, "Firmware file '%s' requested\n", + firmware_name);
rc = request_firmware(&bootrom->fw, firmware_name, &connection->bundle->dev);
On Mon, Apr 27, 2026 at 08:24:48PM -0400, kernelcoredev wrote:
The original dev_info call was intentionally temporary, with a FIXME comment noting it should be downgraded to dev_dbg once modules with valid VID/PID values were common. Project Ara was cancelled in 2016, so that time has long passed.
Remove the FIXME comment and downgrade to dev_dbg as originally intended.
Tested via code inspection only, as Project Ara hardware is no longer available.
Put this meta commentary
Signed-off-by: Bentley Blacketer sonionwhat@gmail.com
^^^ Under the --- cut off line.
drivers/staging/greybus/bootrom.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/greybus/bootrom.c b/drivers/staging/greybus/bootrom.c index 83921d90c..757460c8b 100644 --- a/drivers/staging/greybus/bootrom.c +++ b/drivers/staging/greybus/bootrom.c @@ -168,12 +168,9 @@ static int find_firmware(struct gb_bootrom *bootrom, u8 stage) intf->ddbl1_manufacturer_id, intf->ddbl1_product_id, intf->vendor_id, intf->product_id);
- // FIXME:
- // Turn to dev_dbg later after everyone has valid bootloaders with good
- // ids, but leave this as dev_info for now to make it easier to track
- // down "empty" vid/pid modules.
- dev_info(&connection->bundle->dev, "Firmware file '%s' requested\n",
firmware_name);
- dev_dbg(&connection->bundle->dev, "Firmware file '%s' requested\n",
firmware_name);
Please run your patches through checkpatch.pl.
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
regards, dan carpenter
rc = request_firmware(&bootrom->fw, firmware_name, &connection->bundle->dev); -- 2.54.0
Thanks Dan.
Will run checkpatch and fix the meta commentary location for v2.
On Tue, Apr 28, 2026 at 5:14 AM Dan Carpenter error27@gmail.com wrote:
On Mon, Apr 27, 2026 at 08:24:48PM -0400, kernelcoredev wrote:
The original dev_info call was intentionally temporary, with a FIXME comment noting it should be downgraded to dev_dbg once modules with valid VID/PID values were common. Project Ara was cancelled in 2016, so that time has long passed.
Remove the FIXME comment and downgrade to dev_dbg as originally intended.
Tested via code inspection only, as Project Ara hardware is no longer available.
Put this meta commentary
Signed-off-by: Bentley Blacketer sonionwhat@gmail.com
^^^ Under the --- cut off line.
drivers/staging/greybus/bootrom.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/greybus/bootrom.c
b/drivers/staging/greybus/bootrom.c
index 83921d90c..757460c8b 100644 --- a/drivers/staging/greybus/bootrom.c +++ b/drivers/staging/greybus/bootrom.c @@ -168,12 +168,9 @@ static int find_firmware(struct gb_bootrom
*bootrom, u8 stage)
intf->ddbl1_manufacturer_id, intf->ddbl1_product_id, intf->vendor_id, intf->product_id);
// FIXME:// Turn to dev_dbg later after everyone has valid bootloaders withgood
// ids, but leave this as dev_info for now to make it easier totrack
// down "empty" vid/pid modules.dev_info(&connection->bundle->dev, "Firmware file '%s'requested\n",
firmware_name);
- dev_dbg(&connection->bundle->dev, "Firmware file '%s' requested\n",
firmware_name);Please run your patches through checkpatch.pl.
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
regards, dan carpenter
rc = request_firmware(&bootrom->fw, firmware_name, &connection->bundle->dev);-- 2.54.0
-
Bentley Blacketer -
Dan Carpenter -
kernelcoredev