ida_simple_get could fail. The fix inserts a check for its return value.
Signed-off-by: Kangjie Lu kjlu@umn.edu --- drivers/staging/greybus/audio_manager.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/drivers/staging/greybus/audio_manager.c b/drivers/staging/greybus/audio_manager.c index d44b070d8862..c2a4af4c1d06 100644 --- a/drivers/staging/greybus/audio_manager.c +++ b/drivers/staging/greybus/audio_manager.c @@ -45,6 +45,9 @@ int gb_audio_manager_add(struct gb_audio_manager_module_descriptor *desc) int err;
id = ida_simple_get(&module_id, 0, 0, GFP_KERNEL); + if (id < 0) + return id; + err = gb_audio_manager_module_create(&module, manager_kset, id, desc); if (err) {
On 14-03-19, 01:45, Kangjie Lu wrote:
ida_simple_get could fail. The fix inserts a check for its return value.
Signed-off-by: Kangjie Lu kjlu@umn.edu
drivers/staging/greybus/audio_manager.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/drivers/staging/greybus/audio_manager.c b/drivers/staging/greybus/audio_manager.c index d44b070d8862..c2a4af4c1d06 100644 --- a/drivers/staging/greybus/audio_manager.c +++ b/drivers/staging/greybus/audio_manager.c @@ -45,6 +45,9 @@ int gb_audio_manager_add(struct gb_audio_manager_module_descriptor *desc) int err; id = ida_simple_get(&module_id, 0, 0, GFP_KERNEL);
- if (id < 0)
return id;- err = gb_audio_manager_module_create(&module, manager_kset, id, desc); if (err) {
Acked-by: Viresh Kumar viresh.kumar@linaro.org
On Thu, Mar 14, 2019 at 12:15 PM Kangjie Lu kjlu@umn.edu wrote:
ida_simple_get could fail. The fix inserts a check for its return value.
Signed-off-by: Kangjie Lu kjlu@umn.edu
drivers/staging/greybus/audio_manager.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/drivers/staging/greybus/audio_manager.c b/drivers/staging/greybus/audio_manager.c index d44b070d8862..c2a4af4c1d06 100644 --- a/drivers/staging/greybus/audio_manager.c +++ b/drivers/staging/greybus/audio_manager.c @@ -45,6 +45,9 @@ int gb_audio_manager_add(struct gb_audio_manager_module_descriptor *desc) int err;
id = ida_simple_get(&module_id, 0, 0, GFP_KERNEL);
if (id < 0)return id;err = gb_audio_manager_module_create(&module, manager_kset, id, desc); if (err) {
Reviewed-by: Vaibhav Agarwal vaibhav.sr@gmail.com
-- ./va
On Fri, Mar 15, 2019 at 10:49:46AM +0530, Vaibhav Agarwal wrote:
On Thu, Mar 14, 2019 at 12:15 PM Kangjie Lu kjlu@umn.edu wrote:
ida_simple_get could fail. The fix inserts a check for its return value.
Signed-off-by: Kangjie Lu kjlu@umn.edu
drivers/staging/greybus/audio_manager.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/drivers/staging/greybus/audio_manager.c b/drivers/staging/greybus/audio_manager.c index d44b070d8862..c2a4af4c1d06 100644 --- a/drivers/staging/greybus/audio_manager.c +++ b/drivers/staging/greybus/audio_manager.c @@ -45,6 +45,9 @@ int gb_audio_manager_add(struct gb_audio_manager_module_descriptor *desc) int err;
id = ida_simple_get(&module_id, 0, 0, GFP_KERNEL);
if (id < 0)return id;err = gb_audio_manager_module_create(&module, manager_kset, id, desc); if (err) {Reviewed-by: Vaibhav Agarwal vaibhav.sr@gmail.com
I am sorry for not responding until now. For some strange reason, email from this list are being delayed. I just got this today (April 30).
Thanks for the patch, Kangjie, and thanks for the review, Vaibhav.
And FWIW,
Reviewed-by: Mark Greer mgreer@animalcreek.com
Mark --
-
Kangjie Lu -
Mark Greer -
Vaibhav Agarwal -
Viresh Kumar