Make device_type const. Done using Coccinelle.
Bhumika Goyal (15): EDAC: make device_type const drm: make device_type const [media] i2c: make device_type const [media] rc: make device_type const mei: make device_type const mtd: make device_type const mux: make device_type const PCI: make device_type const phy: tegra: make device_type const platform/x86: wmi: make device_type const remoteproc: make device_type const s390/zcrypt: make device_type const scsi: make device_type const staging: greybus: make device_type const usb: make device_type const
drivers/edac/edac_mc_sysfs.c | 8 ++++---- drivers/edac/i7core_edac.c | 4 ++-- drivers/gpu/drm/drm_sysfs.c | 2 +- drivers/gpu/drm/ttm/ttm_module.c | 2 +- drivers/media/i2c/soc_camera/mt9t031.c | 2 +- drivers/media/rc/rc-main.c | 2 +- drivers/misc/mei/bus.c | 2 +- drivers/mtd/mtdcore.c | 2 +- drivers/mux/mux-core.c | 2 +- drivers/pci/endpoint/pci-epf-core.c | 4 ++-- drivers/phy/tegra/xusb.c | 4 ++-- drivers/platform/x86/wmi.c | 6 +++--- drivers/remoteproc/remoteproc_core.c | 2 +- drivers/s390/crypto/ap_card.c | 2 +- drivers/s390/crypto/ap_queue.c | 2 +- drivers/scsi/fcoe/fcoe_sysfs.c | 4 ++-- drivers/scsi/scsi_transport_iscsi.c | 4 ++-- drivers/staging/greybus/gbphy.c | 2 +- drivers/usb/common/ulpi.c | 2 +- 19 files changed, 29 insertions(+), 29 deletions(-)
Make these const as they are only stored in the type field of a device structure, which is const. Done using Coccinelle.
Signed-off-by: Bhumika Goyal bhumirks@gmail.com --- drivers/edac/edac_mc_sysfs.c | 8 ++++---- drivers/edac/i7core_edac.c | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/edac/edac_mc_sysfs.c b/drivers/edac/edac_mc_sysfs.c index dbc6446..e4fcfa8 100644 --- a/drivers/edac/edac_mc_sysfs.c +++ b/drivers/edac/edac_mc_sysfs.c @@ -304,7 +304,7 @@ static void csrow_attr_release(struct device *dev) kfree(csrow); }
-static struct device_type csrow_attr_type = { +static const struct device_type csrow_attr_type = { .groups = csrow_attr_groups, .release = csrow_attr_release, }; @@ -644,7 +644,7 @@ static void dimm_attr_release(struct device *dev) kfree(dimm); }
-static struct device_type dimm_attr_type = { +static const struct device_type dimm_attr_type = { .groups = dimm_attr_groups, .release = dimm_attr_release, }; @@ -920,7 +920,7 @@ static void mci_attr_release(struct device *dev) kfree(mci); }
-static struct device_type mci_attr_type = { +static const struct device_type mci_attr_type = { .groups = mci_attr_groups, .release = mci_attr_release, }; @@ -1074,7 +1074,7 @@ static void mc_attr_release(struct device *dev) kfree(dev); }
-static struct device_type mc_attr_type = { +static const struct device_type mc_attr_type = { .release = mc_attr_release, }; /* diff --git a/drivers/edac/i7core_edac.c b/drivers/edac/i7core_edac.c index d36cc84..c16c3b9 100644 --- a/drivers/edac/i7core_edac.c +++ b/drivers/edac/i7core_edac.c @@ -1094,7 +1094,7 @@ static void addrmatch_release(struct device *device) kfree(device); }
-static struct device_type addrmatch_type = { +static const struct device_type addrmatch_type = { .groups = addrmatch_groups, .release = addrmatch_release, }; @@ -1125,7 +1125,7 @@ static void all_channel_counts_release(struct device *device) kfree(device); }
-static struct device_type all_channel_counts_type = { +static const struct device_type all_channel_counts_type = { .groups = all_channel_counts_groups, .release = all_channel_counts_release, };
On Sat, Aug 19, 2017 at 01:52:12PM +0530, Bhumika Goyal wrote:
Make these const as they are only stored in the type field of a device structure, which is const. Done using Coccinelle.
Signed-off-by: Bhumika Goyal bhumirks@gmail.com
drivers/edac/edac_mc_sysfs.c | 8 ++++---- drivers/edac/i7core_edac.c | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-)
Applied, thanks.
Make these const as they are only stored in the type field of a device structure, which is const. Done using Coccinelle. --- drivers/gpu/drm/drm_sysfs.c | 2 +- drivers/gpu/drm/ttm/ttm_module.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_sysfs.c b/drivers/gpu/drm/drm_sysfs.c index 1c5b5ce..84e4ebe 100644 --- a/drivers/gpu/drm/drm_sysfs.c +++ b/drivers/gpu/drm/drm_sysfs.c @@ -39,7 +39,7 @@ * drm_connector_unregister(). */
-static struct device_type drm_sysfs_device_minor = { +static const struct device_type drm_sysfs_device_minor = { .name = "drm_minor" };
diff --git a/drivers/gpu/drm/ttm/ttm_module.c b/drivers/gpu/drm/ttm/ttm_module.c index 66fc639..e6604e0 100644 --- a/drivers/gpu/drm/ttm/ttm_module.c +++ b/drivers/gpu/drm/ttm/ttm_module.c @@ -37,7 +37,7 @@ static DECLARE_WAIT_QUEUE_HEAD(exit_q); static atomic_t device_released;
-static struct device_type ttm_drm_class_type = { +static const struct device_type ttm_drm_class_type = { .name = "ttm", /** * Add pm ops here.
On Sat, Aug 19, 2017 at 01:52:13PM +0530, Bhumika Goyal wrote:
Make these const as they are only stored in the type field of a device structure, which is const. Done using Coccinelle.
I can't apply this, it's missing your s-o-b line. You can just replay with that.
Thanks, Daniel
drivers/gpu/drm/drm_sysfs.c | 2 +- drivers/gpu/drm/ttm/ttm_module.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_sysfs.c b/drivers/gpu/drm/drm_sysfs.c index 1c5b5ce..84e4ebe 100644 --- a/drivers/gpu/drm/drm_sysfs.c +++ b/drivers/gpu/drm/drm_sysfs.c @@ -39,7 +39,7 @@
- drm_connector_unregister().
*/ -static struct device_type drm_sysfs_device_minor = { +static const struct device_type drm_sysfs_device_minor = { .name = "drm_minor" }; diff --git a/drivers/gpu/drm/ttm/ttm_module.c b/drivers/gpu/drm/ttm/ttm_module.c index 66fc639..e6604e0 100644 --- a/drivers/gpu/drm/ttm/ttm_module.c +++ b/drivers/gpu/drm/ttm/ttm_module.c @@ -37,7 +37,7 @@ static DECLARE_WAIT_QUEUE_HEAD(exit_q); static atomic_t device_released; -static struct device_type ttm_drm_class_type = { +static const struct device_type ttm_drm_class_type = { .name = "ttm", /** * Add pm ops here. -- 1.9.1
dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Make this const as it is only stored in the type field of a device structure, which is const. Done using Coccinelle.
Signed-off-by: Bhumika Goyal bhumirks@gmail.com --- drivers/media/i2c/soc_camera/mt9t031.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/soc_camera/mt9t031.c b/drivers/media/i2c/soc_camera/mt9t031.c index 714fb35..4802d30 100644 --- a/drivers/media/i2c/soc_camera/mt9t031.c +++ b/drivers/media/i2c/soc_camera/mt9t031.c @@ -592,7 +592,7 @@ static int mt9t031_runtime_resume(struct device *dev) .runtime_resume = mt9t031_runtime_resume, };
-static struct device_type mt9t031_dev_type = { +static const struct device_type mt9t031_dev_type = { .name = "MT9T031", .pm = &mt9t031_dev_pm_ops, };
On Sat, 19 Aug 2017, Bhumika Goyal wrote:
Make this const as it is only stored in the type field of a device structure, which is const. Done using Coccinelle.
Signed-off-by: Bhumika Goyal bhumirks@gmail.com
Acked-by: Guennadi Liakhovetski g.liakhovetski@gmx.de
Thanks Guennadi
drivers/media/i2c/soc_camera/mt9t031.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/soc_camera/mt9t031.c b/drivers/media/i2c/soc_camera/mt9t031.c index 714fb35..4802d30 100644 --- a/drivers/media/i2c/soc_camera/mt9t031.c +++ b/drivers/media/i2c/soc_camera/mt9t031.c @@ -592,7 +592,7 @@ static int mt9t031_runtime_resume(struct device *dev) .runtime_resume = mt9t031_runtime_resume, }; -static struct device_type mt9t031_dev_type = { +static const struct device_type mt9t031_dev_type = { .name = "MT9T031", .pm = &mt9t031_dev_pm_ops, }; -- 1.9.1
Make this const as it is only stored in the type field of a device structure, which is const. Done using Coccinelle.
Signed-off-by: Bhumika Goyal bhumirks@gmail.com --- drivers/media/rc/rc-main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/rc/rc-main.c b/drivers/media/rc/rc-main.c index a9eba00..ea3da3e 100644 --- a/drivers/media/rc/rc-main.c +++ b/drivers/media/rc/rc-main.c @@ -1532,7 +1532,7 @@ static RC_FILTER_ATTR(wakeup_filter_mask, S_IRUGO|S_IWUSR, .attrs = rc_dev_wakeup_filter_attrs, };
-static struct device_type rc_dev_type = { +static const struct device_type rc_dev_type = { .release = rc_dev_release, .uevent = rc_dev_uevent, };
Make this const as it is only stored in the type field of a device structure, which is const. Done using Coccinelle.
Signed-off-by: Bhumika Goyal bhumirks@gmail.com --- drivers/misc/mei/bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/mei/bus.c b/drivers/misc/mei/bus.c index 40c7908..1ac10cb 100644 --- a/drivers/misc/mei/bus.c +++ b/drivers/misc/mei/bus.c @@ -845,7 +845,7 @@ static void mei_cl_bus_dev_release(struct device *dev) kfree(cldev); }
-static struct device_type mei_cl_device_type = { +static const struct device_type mei_cl_device_type = { .release = mei_cl_bus_dev_release, };
Subject: [PATCH 05/15] mei: make device_type const
Make this const as it is only stored in the type field of a device structure, which is const. Done using Coccinelle.
Signed-off-by: Bhumika Goyal bhumirks@gmail.com
drivers/misc/mei/bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/mei/bus.c b/drivers/misc/mei/bus.c index 40c7908..1ac10cb 100644 --- a/drivers/misc/mei/bus.c +++ b/drivers/misc/mei/bus.c @@ -845,7 +845,7 @@ static void mei_cl_bus_dev_release(struct device *dev) kfree(cldev); }
-static struct device_type mei_cl_device_type = { +static const struct device_type mei_cl_device_type = { .release = mei_cl_bus_dev_release, };
LGTM Thanks Tomas
Make this const as it is only stored in the type field of a device structure, which is const. Done using Coccinelle.
Signed-off-by: Bhumika Goyal bhumirks@gmail.com --- drivers/mtd/mtdcore.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c index f872a99..e7ea842 100644 --- a/drivers/mtd/mtdcore.c +++ b/drivers/mtd/mtdcore.c @@ -340,7 +340,7 @@ static ssize_t mtd_bbtblocks_show(struct device *dev, }; ATTRIBUTE_GROUPS(mtd);
-static struct device_type mtd_devtype = { +static const struct device_type mtd_devtype = { .name = "mtd", .groups = mtd_groups, .release = mtd_release,
Le Sat, 19 Aug 2017 13:52:17 +0530, Bhumika Goyal bhumirks@gmail.com a écrit :
Make this const as it is only stored in the type field of a device structure, which is const. Done using Coccinelle.
Applied to l2-mtd/master.
Thanks,
Boris
Signed-off-by: Bhumika Goyal bhumirks@gmail.com
drivers/mtd/mtdcore.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c index f872a99..e7ea842 100644 --- a/drivers/mtd/mtdcore.c +++ b/drivers/mtd/mtdcore.c @@ -340,7 +340,7 @@ static ssize_t mtd_bbtblocks_show(struct device *dev, }; ATTRIBUTE_GROUPS(mtd); -static struct device_type mtd_devtype = { +static const struct device_type mtd_devtype = { .name = "mtd", .groups = mtd_groups, .release = mtd_release,
Make this const as it is only stored in the type field of a device structure, which is const. Done using Coccinelle.
Signed-off-by: Bhumika Goyal bhumirks@gmail.com --- drivers/mux/mux-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mux/mux-core.c b/drivers/mux/mux-core.c index 2fe96c4..68bd16d 100644 --- a/drivers/mux/mux-core.c +++ b/drivers/mux/mux-core.c @@ -58,7 +58,7 @@ static void mux_chip_release(struct device *dev) kfree(mux_chip); }
-static struct device_type mux_type = { +static const struct device_type mux_type = { .name = "mux-chip", .release = mux_chip_release, };
Make this const as it is only stored in the type field of a device structure, which is const. Done using Coccinelle.
Signed-off-by: Bhumika Goyal bhumirks@gmail.com --- drivers/pci/endpoint/pci-epf-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/endpoint/pci-epf-core.c b/drivers/pci/endpoint/pci-epf-core.c index 6877d6a..9d0de12 100644 --- a/drivers/pci/endpoint/pci-epf-core.c +++ b/drivers/pci/endpoint/pci-epf-core.c @@ -27,7 +27,7 @@ #include <linux/pci-ep-cfs.h>
static struct bus_type pci_epf_bus_type; -static struct device_type pci_epf_type; +static const struct device_type pci_epf_type;
/** * pci_epf_linkup() - Notify the function driver that EPC device has @@ -275,7 +275,7 @@ static void pci_epf_dev_release(struct device *dev) kfree(epf); }
-static struct device_type pci_epf_type = { +static const struct device_type pci_epf_type = { .release = pci_epf_dev_release, };
On Sat, Aug 19, 2017 at 01:52:19PM +0530, Bhumika Goyal wrote:
Make this const as it is only stored in the type field of a device structure, which is const. Done using Coccinelle.
Signed-off-by: Bhumika Goyal bhumirks@gmail.com
Applied to pci/misc for v4.14, thanks!
drivers/pci/endpoint/pci-epf-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/endpoint/pci-epf-core.c b/drivers/pci/endpoint/pci-epf-core.c index 6877d6a..9d0de12 100644 --- a/drivers/pci/endpoint/pci-epf-core.c +++ b/drivers/pci/endpoint/pci-epf-core.c @@ -27,7 +27,7 @@ #include <linux/pci-ep-cfs.h> static struct bus_type pci_epf_bus_type; -static struct device_type pci_epf_type; +static const struct device_type pci_epf_type; /**
- pci_epf_linkup() - Notify the function driver that EPC device has
@@ -275,7 +275,7 @@ static void pci_epf_dev_release(struct device *dev) kfree(epf); } -static struct device_type pci_epf_type = { +static const struct device_type pci_epf_type = { .release = pci_epf_dev_release, }; -- 1.9.1
Make these const as they are only stored in the type field of a device structure, which is const. Done using Coccinelle.
Signed-off-by: Bhumika Goyal bhumirks@gmail.com --- drivers/phy/tegra/xusb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c index 3cbcb25..bd3f1b6 100644 --- a/drivers/phy/tegra/xusb.c +++ b/drivers/phy/tegra/xusb.c @@ -155,7 +155,7 @@ static void tegra_xusb_pad_release(struct device *dev) pad->soc->ops->remove(pad); }
-static struct device_type tegra_xusb_pad_type = { +static const struct device_type tegra_xusb_pad_type = { .release = tegra_xusb_pad_release, };
@@ -512,7 +512,7 @@ static void tegra_xusb_port_release(struct device *dev) { }
-static struct device_type tegra_xusb_port_type = { +static const struct device_type tegra_xusb_port_type = { .release = tegra_xusb_port_release, };
Make these const as they are only stored in the type field of a device structure, which is const. Done using Coccinelle.
Signed-off-by: Bhumika Goyal bhumirks@gmail.com --- drivers/platform/x86/wmi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c index e32ba57..a37c253 100644 --- a/drivers/platform/x86/wmi.c +++ b/drivers/platform/x86/wmi.c @@ -810,19 +810,19 @@ static int wmi_dev_remove(struct device *dev) .remove = wmi_dev_remove, };
-static struct device_type wmi_type_event = { +static const struct device_type wmi_type_event = { .name = "event", .groups = wmi_event_groups, .release = wmi_dev_release, };
-static struct device_type wmi_type_method = { +static const struct device_type wmi_type_method = { .name = "method", .groups = wmi_method_groups, .release = wmi_dev_release, };
-static struct device_type wmi_type_data = { +static const struct device_type wmi_type_data = { .name = "data", .groups = wmi_data_groups, .release = wmi_dev_release,
Make this const as it is only stored in the type field of a device structure, which is const. Done using Coccinelle.
Signed-off-by: Bhumika Goyal bhumirks@gmail.com --- drivers/remoteproc/remoteproc_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c index 364ef28..48b2c5d 100644 --- a/drivers/remoteproc/remoteproc_core.c +++ b/drivers/remoteproc/remoteproc_core.c @@ -1360,7 +1360,7 @@ static void rproc_type_release(struct device *dev) kfree(rproc); }
-static struct device_type rproc_type = { +static const struct device_type rproc_type = { .name = "remoteproc", .release = rproc_type_release, };
On Sat 19 Aug 01:22 PDT 2017, Bhumika Goyal wrote:
Make this const as it is only stored in the type field of a device structure, which is const. Done using Coccinelle.
Signed-off-by: Bhumika Goyal bhumirks@gmail.com
Applied, thanks.
Regards, Bjorn
drivers/remoteproc/remoteproc_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c index 364ef28..48b2c5d 100644 --- a/drivers/remoteproc/remoteproc_core.c +++ b/drivers/remoteproc/remoteproc_core.c @@ -1360,7 +1360,7 @@ static void rproc_type_release(struct device *dev) kfree(rproc); } -static struct device_type rproc_type = { +static const struct device_type rproc_type = { .name = "remoteproc", .release = rproc_type_release, }; -- 1.9.1
Make these const as they are only stored in the type field of a device structure, which is const. Done using Coccinelle.
Signed-off-by: Bhumika Goyal bhumirks@gmail.com --- drivers/s390/crypto/ap_card.c | 2 +- drivers/s390/crypto/ap_queue.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/s390/crypto/ap_card.c b/drivers/s390/crypto/ap_card.c index 836efac9..0329148 100644 --- a/drivers/s390/crypto/ap_card.c +++ b/drivers/s390/crypto/ap_card.c @@ -153,7 +153,7 @@ static ssize_t ap_modalias_show(struct device *dev, NULL };
-static struct device_type ap_card_type = { +static const struct device_type ap_card_type = { .name = "ap_card", .groups = ap_card_dev_attr_groups, }; diff --git a/drivers/s390/crypto/ap_queue.c b/drivers/s390/crypto/ap_queue.c index 0f1a5d0..e2a85c26 100644 --- a/drivers/s390/crypto/ap_queue.c +++ b/drivers/s390/crypto/ap_queue.c @@ -577,7 +577,7 @@ static ssize_t ap_interrupt_show(struct device *dev, NULL };
-static struct device_type ap_queue_type = { +static const struct device_type ap_queue_type = { .name = "ap_queue", .groups = ap_queue_dev_attr_groups, };
Make these const as they are only stored in the type field of a device structure, which is const. Done using Coccinelle.
Signed-off-by: Bhumika Goyal bhumirks@gmail.com --- drivers/scsi/fcoe/fcoe_sysfs.c | 4 ++-- drivers/scsi/scsi_transport_iscsi.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/fcoe/fcoe_sysfs.c b/drivers/scsi/fcoe/fcoe_sysfs.c index 9cf3d56..5c8310b 100644 --- a/drivers/scsi/fcoe/fcoe_sysfs.c +++ b/drivers/scsi/fcoe/fcoe_sysfs.c @@ -659,13 +659,13 @@ static void fcoe_fcf_device_release(struct device *dev) kfree(fcf); }
-static struct device_type fcoe_ctlr_device_type = { +static const struct device_type fcoe_ctlr_device_type = { .name = "fcoe_ctlr", .groups = fcoe_ctlr_attr_groups, .release = fcoe_ctlr_device_release, };
-static struct device_type fcoe_fcf_device_type = { +static const struct device_type fcoe_fcf_device_type = { .name = "fcoe_fcf", .groups = fcoe_fcf_attr_groups, .release = fcoe_fcf_device_release, diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c index a424eae..b9513f8 100644 --- a/drivers/scsi/scsi_transport_iscsi.c +++ b/drivers/scsi/scsi_transport_iscsi.c @@ -1009,7 +1009,7 @@ static void iscsi_flashnode_sess_release(struct device *dev) kfree(fnode_sess); }
-static struct device_type iscsi_flashnode_sess_dev_type = { +static const struct device_type iscsi_flashnode_sess_dev_type = { .name = "iscsi_flashnode_sess_dev_type", .groups = iscsi_flashnode_sess_attr_groups, .release = iscsi_flashnode_sess_release, @@ -1195,7 +1195,7 @@ static void iscsi_flashnode_conn_release(struct device *dev) kfree(fnode_conn); }
-static struct device_type iscsi_flashnode_conn_dev_type = { +static const struct device_type iscsi_flashnode_conn_dev_type = { .name = "iscsi_flashnode_conn_dev_type", .groups = iscsi_flashnode_conn_attr_groups, .release = iscsi_flashnode_conn_release,
Make this const as it is only stored in the type field of a device structure, which is const. Done using Coccinelle.
Signed-off-by: Bhumika Goyal bhumirks@gmail.com --- drivers/staging/greybus/gbphy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/gbphy.c b/drivers/staging/greybus/gbphy.c index 603de6f..80c1da8 100644 --- a/drivers/staging/greybus/gbphy.c +++ b/drivers/staging/greybus/gbphy.c @@ -66,7 +66,7 @@ static int gb_gbphy_idle(struct device *dev) gb_gbphy_idle) };
-static struct device_type greybus_gbphy_dev_type = { +static const struct device_type greybus_gbphy_dev_type = { .name = "gbphy_device", .release = gbphy_dev_release, .pm = &gb_gbphy_pm_ops,
Make this const as it is only stored in the type field of a device structure, which is const. Done using Coccinelle.
Signed-off-by: Bhumika Goyal bhumirks@gmail.com --- drivers/usb/common/ulpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/common/ulpi.c b/drivers/usb/common/ulpi.c index 930e8f3..4aa5195 100644 --- a/drivers/usb/common/ulpi.c +++ b/drivers/usb/common/ulpi.c @@ -135,7 +135,7 @@ static void ulpi_dev_release(struct device *dev) kfree(to_ulpi_dev(dev)); }
-static struct device_type ulpi_dev_type = { +static const struct device_type ulpi_dev_type = { .name = "ulpi_device", .groups = ulpi_dev_attr_groups, .release = ulpi_dev_release,
On Sat, Aug 19, 2017 at 01:52:26PM +0530, Bhumika Goyal wrote:
Make this const as it is only stored in the type field of a device structure, which is const. Done using Coccinelle.
Signed-off-by: Bhumika Goyal bhumirks@gmail.com
Acked-by: Heikki Krogerus heikki.krogerus@linux.intel.com
drivers/usb/common/ulpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/common/ulpi.c b/drivers/usb/common/ulpi.c index 930e8f3..4aa5195 100644 --- a/drivers/usb/common/ulpi.c +++ b/drivers/usb/common/ulpi.c @@ -135,7 +135,7 @@ static void ulpi_dev_release(struct device *dev) kfree(to_ulpi_dev(dev)); } -static struct device_type ulpi_dev_type = { +static const struct device_type ulpi_dev_type = { .name = "ulpi_device", .groups = ulpi_dev_attr_groups, .release = ulpi_dev_release,
Thanks,
-
Bhumika Goyal -
Bjorn Andersson -
Bjorn Helgaas -
Boris Brezillon -
Borislav Petkov -
Daniel Vetter -
Guennadi Liakhovetski -
Heikki Krogerus -
Martin K. Petersen -
Winkler, Tomas