drivers/staging/greybus/pwm.c uses the old style PWM callbacks, new drivers should stick to the atomic API instead.

Signed-off-by: Uwe Kleine-König uwe@kleine-koenig.org --- On 12/8/20 10:39 AM, Johan Hovold wrote:

No sign off?

Please also add a staging prefix since this part of greybus still lives there.

That after all these years I still fail occasionally to add a sign-off ... /me shakes his head about himself.

Anyhow, here comes a v2, also with the requested prefix.

drivers/staging/greybus/TODO | 2 ++ 1 file changed, 2 insertions(+)

diff --git a/drivers/staging/greybus/TODO b/drivers/staging/greybus/TODO index 31f1f2cb401c..6461e0132fe3 100644 --- a/drivers/staging/greybus/TODO +++ b/drivers/staging/greybus/TODO @@ -1,3 +1,5 @@ * Convert all uses of the old GPIO API from <linux/gpio.h> to the GPIO descriptor API in <linux/gpio/consumer.h> and look up GPIO lines from device tree or ACPI. +* Make pwm.c use the struct pwm_ops::apply instead of ::config, ::set_polarity, + ::enable and ::disable.