devm_request_threaded_irq() and devm_request_any_context_irq() automatically log detailed error messages on failure via the devm_request_result() helper, which prints device name, IRQ number, handler functions, and error code.
Since devm_request_irq() is a static inline wrapper around devm_request_threaded_irq(), it also benefits from this automatic logging.
Remove the now-redundant dev_err() and dev_err_probe() calls in staging drivers that follow these devm_request_*_irq() functions, as the core now provides more detailed diagnostic information on failure.
Pan Chuang (7): staging: axis-fifo: Remove redundant dev_err() staging: fbtft: Remove redundant dev_err_probe() staging: greybus: arche-platform: Remove redundant dev_err() staging: iio: adt7316: Remove redundant dev_err() media: atomisp: Remove redundant dev_err() staging: most: dim2: Remove redundant dev_err() staging: nvec: Remove redundant dev_err_probe()
drivers/staging/axis-fifo/axis-fifo.c | 5 +---- drivers/staging/fbtft/fb_st7789v.c | 2 +- drivers/staging/greybus/arche-platform.c | 4 +--- drivers/staging/iio/addac/adt7316.c | 5 +---- drivers/staging/media/atomisp/pci/atomisp_v4l2.c | 4 +--- drivers/staging/most/dim2/dim2.c | 8 ++------ drivers/staging/nvec/nvec.c | 2 +- 7 files changed, 8 insertions(+), 22 deletions(-)
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_threaded_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err() calls.
Signed-off-by: Pan Chuang panchuang@vivo.com --- drivers/staging/greybus/arche-platform.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/greybus/arche-platform.c b/drivers/staging/greybus/arche-platform.c index de5de59ea8ab..075717b8aef6 100644 --- a/drivers/staging/greybus/arche-platform.c +++ b/drivers/staging/greybus/arche-platform.c @@ -503,10 +503,8 @@ static int arche_platform_probe(struct platform_device *pdev) IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING | IRQF_ONESHOT, dev_name(dev), arche_pdata); - if (ret) { - dev_err(dev, "failed to request wake detect IRQ %d\n", ret); + if (ret) return ret; - } disable_irq(arche_pdata->wake_detect_irq);
ret = device_create_file(dev, &dev_attr_state);