On 05/12/2018 21:00, Sicilia Cristian wrote:
It doesn't change the result string
So why do it then ?
On Thu, Dec 06, 2018 at 09:43:46AM +0000, Bryan O'Donoghue wrote:
On 05/12/2018 21:00, Sicilia Cristian wrote:
It doesn't change the result string
So why do it then ?
Because it is easier to read this way and odds are checkpatch is happier.
thanks,
greg k-h
On 06/12/2018 15:05, Greg Kroah-Hartman wrote:
On Thu, Dec 06, 2018 at 09:43:46AM +0000, Bryan O'Donoghue wrote:
On 05/12/2018 21:00, Sicilia Cristian wrote:
It doesn't change the result string
So why do it then ?
Because it is easier to read this way and odds are checkpatch is happier.
Fine.
Sicilia could you please amend your commit.
'This patch fixes the checkpatch error "CHECK: Concatenated strings should use spaces between elements"'
and then feel free to add my
Acked-by: Bryan O'Donoghue pure.logic@nexus-software.ie
--- bod
On Thu, Dec 06, 2018 at 04:14:53PM +0000, Bryan O'Donoghue wrote:
On 06/12/2018 15:05, Greg Kroah-Hartman wrote:
On Thu, Dec 06, 2018 at 09:43:46AM +0000, Bryan O'Donoghue wrote:
On 05/12/2018 21:00, Sicilia Cristian wrote:
It doesn't change the result string
So why do it then ?
Because it is easier to read this way and odds are checkpatch is happier.
Fine.
Sicilia could you please amend your commit.
'This patch fixes the checkpatch error "CHECK: Concatenated strings should use spaces between elements"'
and then feel free to add my
Acked-by: Bryan O'Donoghue pure.logic@nexus-software.ie
It's already in my tree, no need to ammend it, sorry :)
greg k-h
On 06/12/2018 16:23, Greg Kroah-Hartman wrote:
On Thu, Dec 06, 2018 at 04:14:53PM +0000, Bryan O'Donoghue wrote:
On 06/12/2018 15:05, Greg Kroah-Hartman wrote:
On Thu, Dec 06, 2018 at 09:43:46AM +0000, Bryan O'Donoghue wrote:
On 05/12/2018 21:00, Sicilia Cristian wrote:
It doesn't change the result string
So why do it then ?
Because it is easier to read this way and odds are checkpatch is happier.
Fine.
Sicilia could you please amend your commit.
'This patch fixes the checkpatch error "CHECK: Concatenated strings should use spaces between elements"'
and then feel free to add my
Acked-by: Bryan O'Donoghue pure.logic@nexus-software.ie
It's already in my tree, no need to ammend it, sorry :)
greg k-h
thanks greg !
-
Bryan O'Donoghue -
Greg Kroah-Hartman