Fixes the following coding style issue as noted by checkpatch.pl at multiple lines:
Comparison to NULL could be written "!token"
Signed-off-by: Sumit Pundir pundirsumit11@gmail.com --- drivers/staging/greybus/camera.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/greybus/camera.c b/drivers/staging/greybus/camera.c index f13f16b..07ebfb8 100644 --- a/drivers/staging/greybus/camera.c +++ b/drivers/staging/greybus/camera.c @@ -918,7 +918,7 @@ static ssize_t gb_camera_debugfs_configure_streams(struct gb_camera *gcam,
/* Retrieve number of streams to configure */ token = strsep(&buf, ";"); - if (token == NULL) + if (!token) return -EINVAL;
ret = kstrtouint(token, 10, &nstreams); @@ -929,7 +929,7 @@ static ssize_t gb_camera_debugfs_configure_streams(struct gb_camera *gcam, return -EINVAL;
token = strsep(&buf, ";"); - if (token == NULL) + if (!token) return -EINVAL;
ret = kstrtouint(token, 10, &flags); @@ -946,7 +946,7 @@ static ssize_t gb_camera_debugfs_configure_streams(struct gb_camera *gcam,
/* width */ token = strsep(&buf, ";"); - if (token == NULL) { + if (!token) { ret = -EINVAL; goto done; } @@ -956,7 +956,7 @@ static ssize_t gb_camera_debugfs_configure_streams(struct gb_camera *gcam,
/* height */ token = strsep(&buf, ";"); - if (token == NULL) + if (!token) goto done;
ret = kstrtouint(token, 10, &stream->height); @@ -965,7 +965,7 @@ static ssize_t gb_camera_debugfs_configure_streams(struct gb_camera *gcam,
/* Image format code */ token = strsep(&buf, ";"); - if (token == NULL) + if (!token) goto done;
ret = kstrtouint(token, 16, &stream->format); @@ -1009,7 +1009,7 @@ static ssize_t gb_camera_debugfs_capture(struct gb_camera *gcam,
/* Request id */ token = strsep(&buf, ";"); - if (token == NULL) + if (!token) return -EINVAL; ret = kstrtouint(token, 10, &request_id); if (ret < 0) @@ -1017,7 +1017,7 @@ static ssize_t gb_camera_debugfs_capture(struct gb_camera *gcam,
/* Stream mask */ token = strsep(&buf, ";"); - if (token == NULL) + if (!token) return -EINVAL; ret = kstrtouint(token, 16, &streams_mask); if (ret < 0) @@ -1025,7 +1025,7 @@ static ssize_t gb_camera_debugfs_capture(struct gb_camera *gcam,
/* number of frames */ token = strsep(&buf, ";"); - if (token == NULL) + if (!token) return -EINVAL; ret = kstrtouint(token, 10, &num_frames); if (ret < 0)
On Mon, Jan 08, 2018 at 11:28:13AM +0530, Sumit Pundir wrote:
Fixes the following coding style issue as noted by checkpatch.pl at multiple lines:
Comparison to NULL could be written "!token"
Signed-off-by: Sumit Pundir pundirsumit11@gmail.com
Since you're not really fixing anything here, besides silencing a checkpatch suggestion when run with the --strict option (or on staging code), I suggest you reword you commit summary (Subject) to, for example:
staging: greybus: camera: clean up NULL checks
or similar.
Note that I also added "camera" as a module prefix above.
Thanks, Johan
On Mon, Jan 8, 2018 at 8:15 PM, Johan Hovold johan@kernel.org wrote:
Since you're not really fixing anything here, besides silencing a checkpatch suggestion when run with the --strict option (or on staging code), I suggest you reword you commit summary (Subject) to, for example:
staging: greybus: camera: clean up NULL checks
or similar.
Note that I also added "camera" as a module prefix above.
Hi Johan,
I will send a v2 of this patch with all the prescribed changes.
Thanks, Sumit