From: Bartosz Golaszewski bartosz.golaszewski@linaro.org
As of commit 92ac7de3175e3 ("gpiolib: don't allow setting values on input lines"), the GPIO core makes sure values cannot be set on input lines. Remove the unnecessary check.
Signed-off-by: Bartosz Golaszewski bartosz.golaszewski@linaro.org --- drivers/staging/greybus/gpio.c | 6 ------ 1 file changed, 6 deletions(-)
diff --git a/drivers/staging/greybus/gpio.c b/drivers/staging/greybus/gpio.c index f81c34160f720..1280530c8987a 100644 --- a/drivers/staging/greybus/gpio.c +++ b/drivers/staging/greybus/gpio.c @@ -192,12 +192,6 @@ static int gb_gpio_set_value_operation(struct gb_gpio_controller *ggc, struct gb_gpio_set_value_request request; int ret;
- if (ggc->lines[which].direction == 1) { - dev_warn(dev, "refusing to set value of input gpio %u\n", - which); - return -EPERM; - } - request.which = which; request.value = value_high ? 1 : 0; ret = gb_operation_sync(ggc->connection, GB_GPIO_TYPE_SET_VALUE,
Hey Bartosz, Thanks for the patch.
On Tue Jun 10, 2025 at 4:20 PM WEST, Bartosz Golaszewski wrote:
From: Bartosz Golaszewski bartosz.golaszewski@linaro.org
As of commit 92ac7de3175e3 ("gpiolib: don't allow setting values on input lines"), the GPIO core makes sure values cannot be set on input lines. Remove the unnecessary check.
Signed-off-by: Bartosz Golaszewski bartosz.golaszewski@linaro.org
LGTM.
Reviewed-by: Rui Miguel Silva rui.silva@linaro.org
Cheers, Rui
drivers/staging/greybus/gpio.c | 6 ------ 1 file changed, 6 deletions(-)
diff --git a/drivers/staging/greybus/gpio.c b/drivers/staging/greybus/gpio.c index f81c34160f720..1280530c8987a 100644 --- a/drivers/staging/greybus/gpio.c +++ b/drivers/staging/greybus/gpio.c @@ -192,12 +192,6 @@ static int gb_gpio_set_value_operation(struct gb_gpio_controller *ggc, struct gb_gpio_set_value_request request; int ret;
- if (ggc->lines[which].direction == 1) {
dev_warn(dev, "refusing to set value of input gpio %u\n",which);return -EPERM;- }
- request.which = which; request.value = value_high ? 1 : 0; ret = gb_operation_sync(ggc->connection, GB_GPIO_TYPE_SET_VALUE,
-- 2.48.1
-
Bartosz Golaszewski -
Rui Miguel Silva