Fix the following checkpatch.pl warning and check: - Warning: Prefer 'unsigned long long' over 'unsigned long long int' - Check: Alignment should match open parenthesis
Signed-off-by: Kosugi Souta k.souta0926@gmail.com --- drivers/staging/greybus/Documentation/firmware/authenticate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/greybus/Documentation/firmware/authenticate.c b/drivers/staging/greybus/Documentation/firmware/authenticate.c index 3d2c6f88a138..ba4b16b04557 100644 --- a/drivers/staging/greybus/Documentation/firmware/authenticate.c +++ b/drivers/staging/greybus/Documentation/firmware/authenticate.c @@ -58,7 +58,7 @@ int main(int argc, char *argv[]) goto close_fd; }
- printf("UID received: 0x%llx\n", *(unsigned long long int *)(uid.uid)); + printf("UID received: 0x%llx\n", *(unsigned long long *)(uid.uid));
/* Get certificate */ printf("Get IMS certificate\n"); @@ -85,7 +85,7 @@ int main(int argc, char *argv[]) }
printf("Authenticated, result (%02x), sig-size (%02x)\n", - authenticate.result_code, authenticate.signature_size); + authenticate.result_code, authenticate.signature_size);
close_fd: close(fd);
On Mon, Mar 23, 2026 at 03:10:17AM +0000, Kosugi Souta wrote:
Fix the following checkpatch.pl warning and check:
- Warning: Prefer 'unsigned long long' over 'unsigned long long int'
- Check: Alignment should match open parenthesis
That is two different things, so this should be two different patches, right?
thanks,
greg k-h
This series splits the previous single patch into two separate patches to address style issues in authenticate.c, as requested by Greg KH.
Changes in v2: - Split the single patch into two separate commits: one for type warnings and one for alignment checks.
Kosugi (2): staging: greybus: fix unsigned long long type warning staging: greybus: fix alignment to match open parenthesis
drivers/staging/greybus/Documentation/firmware/authenticate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Signed-off-by: Kosugi Souta k.souta0926@gmail.com --- drivers/staging/greybus/Documentation/firmware/authenticate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/Documentation/firmware/authenticate.c b/drivers/staging/greybus/Documentation/firmware/authenticate.c index 3d2c6f88a138a..0ef88b7d24de0 100644 --- a/drivers/staging/greybus/Documentation/firmware/authenticate.c +++ b/drivers/staging/greybus/Documentation/firmware/authenticate.c @@ -58,7 +58,7 @@ int main(int argc, char *argv[]) goto close_fd; }
- printf("UID received: 0x%llx\n", *(unsigned long long int *)(uid.uid)); + printf("UID received: 0x%llx\n", *(unsigned long long *)(uid.uid));
/* Get certificate */ printf("Get IMS certificate\n");
On Thu, Apr 02, 2026 at 02:11:23PM +0900, Kosugi Souta wrote:
Signed-off-by: Kosugi Souta k.souta0926@gmail.com
drivers/staging/greybus/Documentation/firmware/authenticate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/Documentation/firmware/authenticate.c b/drivers/staging/greybus/Documentation/firmware/authenticate.c index 3d2c6f88a138a..0ef88b7d24de0 100644 --- a/drivers/staging/greybus/Documentation/firmware/authenticate.c +++ b/drivers/staging/greybus/Documentation/firmware/authenticate.c @@ -58,7 +58,7 @@ int main(int argc, char *argv[]) goto close_fd; }
- printf("UID received: 0x%llx\n", *(unsigned long long int *)(uid.uid));
- printf("UID received: 0x%llx\n", *(unsigned long long *)(uid.uid));
/* Get certificate */ printf("Get IMS certificate\n"); -- 2.43.0
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.
You are receiving this message because of the following common error(s) as indicated below:
- You did not specify a description of why the patch is needed, or possibly, any description at all, in the email body. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what is needed in order to properly describe the change.
If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.
thanks,
greg k-h's patch email bot
Signed-off-by: Kosugi Souta k.souta0926@gmail.com --- drivers/staging/greybus/Documentation/firmware/authenticate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/Documentation/firmware/authenticate.c b/drivers/staging/greybus/Documentation/firmware/authenticate.c index 0ef88b7d24de0..ba4b16b045571 100644 --- a/drivers/staging/greybus/Documentation/firmware/authenticate.c +++ b/drivers/staging/greybus/Documentation/firmware/authenticate.c @@ -85,7 +85,7 @@ int main(int argc, char *argv[]) }
printf("Authenticated, result (%02x), sig-size (%02x)\n", - authenticate.result_code, authenticate.signature_size); + authenticate.result_code, authenticate.signature_size);
close_fd: close(fd);
This series addresses checkpatch.pl warnings and checks in the authenticate.c file within the greybus subsystem.
Changes in v3: - Added detailed commit descriptions to each patch to explain the motivation for the changes, as requested by Greg KH's patch bot. - Ensured Signed-off-by names are consistent and complete.
Changes in v2: - Split the original single patch into two separate patches: one for the 'unsigned long long' type warning and another for the alignment check, as requested by Greg KH.
Changes in v1: - Initial submission with combined fixes.
Kosugi Souta (2): staging: greybus: fix unsigned long long type warning staging: greybus: fix alignment to match open parenthesis
drivers/staging/greybus/Documentation/firmware/authenticate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Fix the checkpatch.pl warning "Prefer 'unsigned long long' over 'unsigned long long int'". This cleans up the code style in authenticate.c.
Signed-off-by: Kosugi Souta k.souta0926@gmail.com --- drivers/staging/greybus/Documentation/firmware/authenticate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/Documentation/firmware/authenticate.c b/drivers/staging/greybus/Documentation/firmware/authenticate.c index 3d2c6f88a138a5..0ef88b7d24de02 100644 --- a/drivers/staging/greybus/Documentation/firmware/authenticate.c +++ b/drivers/staging/greybus/Documentation/firmware/authenticate.c @@ -58,7 +58,7 @@ int main(int argc, char *argv[]) goto close_fd; }
- printf("UID received: 0x%llx\n", *(unsigned long long int *)(uid.uid)); + printf("UID received: 0x%llx\n", *(unsigned long long *)(uid.uid));
/* Get certificate */ printf("Get IMS certificate\n");
On Sat, Apr 04, 2026 at 09:59:37AM +0900, Kosugi Souta wrote:
Fix the checkpatch.pl warning "Prefer 'unsigned long long' over 'unsigned long long int'". This cleans up the code style in authenticate.c.
Signed-off-by: Kosugi Souta k.souta0926@gmail.com
drivers/staging/greybus/Documentation/firmware/authenticate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/Documentation/firmware/authenticate.c b/drivers/staging/greybus/Documentation/firmware/authenticate.c index 3d2c6f88a138a5..0ef88b7d24de02 100644 --- a/drivers/staging/greybus/Documentation/firmware/authenticate.c +++ b/drivers/staging/greybus/Documentation/firmware/authenticate.c @@ -58,7 +58,7 @@ int main(int argc, char *argv[]) goto close_fd; }
- printf("UID received: 0x%llx\n", *(unsigned long long int *)(uid.uid));
- printf("UID received: 0x%llx\n", *(unsigned long long *)(uid.uid));
/* Get certificate */ printf("Get IMS certificate\n"); -- 2.43.0
Does not apply to the tree anymore :(
Fix the checkpatch.pl check "Alignment should match open parenthesis" by adjusting the indentation in authenticate.c.
Signed-off-by: Kosugi Souta k.souta0926@gmail.com --- drivers/staging/greybus/Documentation/firmware/authenticate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/Documentation/firmware/authenticate.c b/drivers/staging/greybus/Documentation/firmware/authenticate.c index 0ef88b7d24de02..ba4b16b0455717 100644 --- a/drivers/staging/greybus/Documentation/firmware/authenticate.c +++ b/drivers/staging/greybus/Documentation/firmware/authenticate.c @@ -85,7 +85,7 @@ int main(int argc, char *argv[]) }
printf("Authenticated, result (%02x), sig-size (%02x)\n", - authenticate.result_code, authenticate.signature_size); + authenticate.result_code, authenticate.signature_size);
close_fd: close(fd);
-
Greg KH -
Kosugi Souta