Hello everyone. This is my first patch to linux kernel. Once I get the hang of this process, I will be sending patches form GSoC 2023 greybus driver. Feel free to tell me if I am doing something wrong here
Ayush Singh (1): Remove extra newline
drivers/greybus/es2.c | 1 - 1 file changed, 1 deletion(-)
From: Ayush Singh ayushsingh1325@gmail.com
This change was suggested by checkpatch
Signed-off-by: Ayush Singh ayushdevel1325@gmail.com --- drivers/greybus/es2.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/greybus/es2.c b/drivers/greybus/es2.c index e89cca015095..1727914dd1a4 100644 --- a/drivers/greybus/es2.c +++ b/drivers/greybus/es2.c @@ -17,7 +17,6 @@ #include "arpc.h" #include "greybus_trace.h"
- /* Default timeout for USB vendor requests. */ #define ES2_USB_CTRL_TIMEOUT 500
On Fri, Jul 28, 2023 at 10:21:55PM +0530, Ayush Singh wrote:
From: Ayush Singh ayushsingh1325@gmail.com
This change was suggested by checkpatch
Signed-off-by: Ayush Singh ayushdevel1325@gmail.com
drivers/greybus/es2.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/greybus/es2.c b/drivers/greybus/es2.c index e89cca015095..1727914dd1a4 100644 --- a/drivers/greybus/es2.c +++ b/drivers/greybus/es2.c @@ -17,7 +17,6 @@ #include "arpc.h" #include "greybus_trace.h"
/* Default timeout for USB vendor requests. */ #define ES2_USB_CTRL_TIMEOUT 500 -- 2.41.0
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.
You are receiving this message because of the following common error(s) as indicated below:
- You did not specify a description of why the patch is needed, or possibly, any description at all, in the email body. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what is needed in order to properly describe the change.
- You did not write a descriptive Subject: for the patch, allowing Greg, and everyone else, to know what this patch is all about. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what a proper Subject: line should look like.
If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.
thanks,
greg k-h's patch email bot
So my first patch description seemed to be immproper. So now using subject and description from a successful patch
Ayush Singh (1): greybus: es2: Remove extra newline
drivers/greybus/es2.c | 1 - 1 file changed, 1 deletion(-)
This patch removes some blank lines in order to fix a checkpatch issue.
Signed-off-by: Ayush Singh ayushdevel1325@gmail.com --- drivers/greybus/es2.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/greybus/es2.c b/drivers/greybus/es2.c index e89cca015095..1727914dd1a4 100644 --- a/drivers/greybus/es2.c +++ b/drivers/greybus/es2.c @@ -17,7 +17,6 @@ #include "arpc.h" #include "greybus_trace.h"
- /* Default timeout for USB vendor requests. */ #define ES2_USB_CTRL_TIMEOUT 500
On Mon, Jul 31, 2023 at 01:17:52AM +0530, Ayush Singh wrote:
This patch removes some blank lines in order to fix a checkpatch issue.
No it did not :(
If you wish to learn how to send a proper patch, please work in the drivers/staging/ portion of the kernel, as that's the recommended place for this.
good luck!
greg k-h
On Mon, Jul 31, 2023 at 01:17:51AM +0530, Ayush Singh wrote:
So my first patch description seemed to be immproper. So now using subject and description from a successful patch
Ayush Singh (1): greybus: es2: Remove extra newline
drivers/greybus/es2.c | 1 - 1 file changed, 1 deletion(-)
-- 2.41.0
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.
You are receiving this message because of the following common error(s) as indicated below:
- You did not write a descriptive Subject: for the patch, allowing Greg, and everyone else, to know what this patch is all about. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what a proper Subject: line should look like.
- This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what needs to be done here to properly describe this.
If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.
thanks,
greg k-h's patch email bot
On 7/30/23 2:47 PM, Ayush Singh wrote:
This patch removes some blank lines in order to fix a checkpatch issue.
Signed-off-by: Ayush Singh ayushdevel1325@gmail.com
FYI, others have suggested making a change like this before. This additional blank line is not harmful, and is used in several places in the Greybus code. It is coding style that makes a bit clearer separation between sections of code. It is not typical Linux kernel coding style, and yes, checkpatch.pl reports it, but when it has been suggested in the past Johan said he preferred to keep it the way it is now.
So if you'd like to do another trivial patch (in the Greybus code), please find a different "error" reported by checkpatch.pl to fix.
-Alex
drivers/greybus/es2.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/greybus/es2.c b/drivers/greybus/es2.c index e89cca015095..1727914dd1a4 100644 --- a/drivers/greybus/es2.c +++ b/drivers/greybus/es2.c @@ -17,7 +17,6 @@ #include "arpc.h" #include "greybus_trace.h"
- /* Default timeout for USB vendor requests. */ #define ES2_USB_CTRL_TIMEOUT 500
Thanks, Alex Elder and Greg KH. I created the patch since I wanted to check out the whole git-send-email patch workflow and get better acquainted with things before submitting the beagle play greybus driver[1] I have been working on.
I will probably ask a few questions pertaining to the driver organization over at kernelnewbies before creating a full patch for the driver.
Ayush Singh
[1]: https://git.beagleboard.org/gsoc/greybus/beagleplay-greybus-driver/-/tree/de...
On 7/31/23 17:02, Alex Elder wrote:
On 7/30/23 2:47 PM, Ayush Singh wrote:
This patch removes some blank lines in order to fix a checkpatch issue.
Signed-off-by: Ayush Singh ayushdevel1325@gmail.com
FYI, others have suggested making a change like this before. This additional blank line is not harmful, and is used in several places in the Greybus code. It is coding style that makes a bit clearer separation between sections of code. It is not typical Linux kernel coding style, and yes, checkpatch.pl reports it, but when it has been suggested in the past Johan said he preferred to keep it the way it is now.
So if you'd like to do another trivial patch (in the Greybus code), please find a different "error" reported by checkpatch.pl to fix.
-Alex
drivers/greybus/es2.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/greybus/es2.c b/drivers/greybus/es2.c index e89cca015095..1727914dd1a4 100644 --- a/drivers/greybus/es2.c +++ b/drivers/greybus/es2.c @@ -17,7 +17,6 @@ #include "arpc.h" #include "greybus_trace.h" - /* Default timeout for USB vendor requests. */ #define ES2_USB_CTRL_TIMEOUT 500
A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail?
A: No. Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
On Mon, Jul 31, 2023 at 06:28:25PM +0530, Ayush Singh wrote:
Thanks, Alex Elder and Greg KH. I created the patch since I wanted to check out the whole git-send-email patch workflow and get better acquainted with things before submitting the beagle play greybus driver[1] I have been working on.
Again, you should try to get experience in the drivers/staging/* subsystem first before branching out to other subsystems that might not want checkpatch changes.
I will probably ask a few questions pertaining to the driver organization over at kernelnewbies before creating a full patch for the driver.
You should work with your gsoc mentor on getting this cleaned up properly to be submitted first, don't lean on the kernelnewbies community for something that they should be helping out with :)
good luck!
greg k-h
-
Alex Elder -
Ayush Singh -
Greg KH