Align the wrapped function parameter declaration with the kernel coding style to improve readability.
Signed-off-by: Pedro Amorim pedro.aml.dev@gmail.com --- drivers/staging/greybus/loopback.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c index ea57b1f5d156..374ff4c4ca15 100644 --- a/drivers/staging/greybus/loopback.c +++ b/drivers/staging/greybus/loopback.c @@ -589,7 +589,7 @@ static int gb_loopback_async_sink(struct gb_loopback *gb, u32 len) }
static int gb_loopback_async_transfer_complete( - struct gb_loopback_async_operation *op_async) + struct gb_loopback_async_operation *op_async) { struct gb_loopback *gb; struct gb_operation *operation;
On Mon, Aug 03, 2026 at 04:47:43PM -0400, Pedro Amorim wrote:
Align the wrapped function parameter declaration with the kernel coding style to improve readability.
Ok, but:
Signed-off-by: Pedro Amorim pedro.aml.dev@gmail.com
drivers/staging/greybus/loopback.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c index ea57b1f5d156..374ff4c4ca15 100644 --- a/drivers/staging/greybus/loopback.c +++ b/drivers/staging/greybus/loopback.c @@ -589,7 +589,7 @@ static int gb_loopback_async_sink(struct gb_loopback *gb, u32 len) } static int gb_loopback_async_transfer_complete(
struct gb_loopback_async_operation *op_async)
- struct gb_loopback_async_operation *op_async)
You didn't align it here :(
Fix two alignment warnings reported by checkpatch.pl: the wrapped function declaration for gb_loopback_async_transfer_complete(), and the continuation line in the gb_operation_response_alloc() call.
Signed-off-by: Pedro Amorim pedro.aml.dev@gmail.com --- v2: Fix remaining checkpatch alignment warnings in the file
drivers/staging/greybus/loopback.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c index ea57b1f5d156..87fbeaf0eeb9 100644 --- a/drivers/staging/greybus/loopback.c +++ b/drivers/staging/greybus/loopback.c @@ -588,8 +588,7 @@ static int gb_loopback_async_sink(struct gb_loopback *gb, u32 len) return retval; }
-static int gb_loopback_async_transfer_complete( - struct gb_loopback_async_operation *op_async) +static int gb_loopback_async_transfer_complete(struct gb_loopback_async_operation *op_async) { struct gb_loopback *gb; struct gb_operation *operation; @@ -679,7 +678,7 @@ static int gb_loopback_request_handler(struct gb_operation *operation) }
if (!gb_operation_response_alloc(operation, - len + sizeof(*response), GFP_KERNEL)) { + len + sizeof(*response), GFP_KERNEL)) { dev_err(dev, "error allocating response\n"); return -ENOMEM; }
-
Greg KH -
Pedro Amorim