Signed-off-by: Jonathan Bowie eudjtb@gmail.com ---
v1: * Fixed inconsistent spacing around an arithmetic operator
v2: * Corrected summary and commit message
drivers/staging/greybus/tools/loopback_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/tools/loopback_test.c b/drivers/staging/greybus/tools/loopback_test.c index 18d7a3d..d5bb8d2 100644 --- a/drivers/staging/greybus/tools/loopback_test.c +++ b/drivers/staging/greybus/tools/loopback_test.c @@ -476,7 +476,7 @@ int format_output(struct loopback_test *t, r->gbphy_firmware_latency_jitter);
} else { - len += snprintf(&buf[len], buf_len- len, ",%s,%s,%u,%u,%u", + len += snprintf(&buf[len], buf_len - len, ",%s,%s,%u,%u,%u", t->test_name, dev_name, t->size, t->iteration_max, r->error);
On Wed, Mar 01, 2017 at 01:42:13AM -0800, Jonathan Bowie wrote:
Signed-off-by: Jonathan Bowie eudjtb@gmail.com
v1:
- Fixed inconsistent spacing around an arithmetic operator
Almost right. This sentence should go in the commit message which is otherwise now empty (i.e. above you Signed-off-by).
v2:
- Corrected summary and commit message
And this is the change log that goes below the cut-off line, just like you do here.
And you forgot to CC the staging list.
Third time's a charm? :)
Thanks, Johan
On Wed, Mar 01, 2017 at 10:46:01AM +0100, Johan Hovold wrote:
On Wed, Mar 01, 2017 at 01:42:13AM -0800, Jonathan Bowie wrote:
Signed-off-by: Jonathan Bowie eudjtb@gmail.com
v1:
- Fixed inconsistent spacing around an arithmetic operator
Almost right. This sentence should go in the commit message which is otherwise now empty (i.e. above you Signed-off-by).
v2:
- Corrected summary and commit message
And this is the change log that goes below the cut-off line, just like you do here.
And you forgot to CC the staging list.
Third time's a charm? :)
Thanks, Johan
Was going by this guide https://kernelnewbies.org/PatchTipsAndTricks which said changelog could be added prior to file name at the top of the patch.
I'll try again :)
--j
On Wed, Mar 01, 2017 at 01:49:44AM -0800, Jonathan Bowie wrote:
On Wed, Mar 01, 2017 at 10:46:01AM +0100, Johan Hovold wrote:
On Wed, Mar 01, 2017 at 01:42:13AM -0800, Jonathan Bowie wrote:
Signed-off-by: Jonathan Bowie eudjtb@gmail.com
v1:
- Fixed inconsistent spacing around an arithmetic operator
Almost right. This sentence should go in the commit message which is otherwise now empty (i.e. above you Signed-off-by).
v2:
- Corrected summary and commit message
And this is the change log that goes below the cut-off line, just like you do here.
And you forgot to CC the staging list.
Third time's a charm? :)
Thanks, Johan
Was going by this guide https://kernelnewbies.org/PatchTipsAndTricks which said changelog could be added prior to file name at the top of the patch.
And that's correct, changelogs go below the cut-off line (---), it was just that you commit message was now empty (in v2), and you do not need a changelog entry for "v1:". The sentence you put there would do for a good commit message however.
Thanks, Johan
-
Johan Hovold -
Jonathan Bowie