If the list does not exit early then data == NULL and 'module' does not point to a valid list element. Using 'module' in such a case is not valid and was therefore removed.
Fixes: 6dd67645f22c ("greybus: audio: Use single codec driver registration") Signed-off-by: Jakob Koschel jakobkoschel@gmail.com --- drivers/staging/greybus/audio_codec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c index b589cf6b1d03..e19b91e7a72e 100644 --- a/drivers/staging/greybus/audio_codec.c +++ b/drivers/staging/greybus/audio_codec.c @@ -599,8 +599,8 @@ static int gbcodec_mute_stream(struct snd_soc_dai *dai, int mute, int stream) break; } if (!data) { - dev_err(dai->dev, "%s:%s DATA connection missing\n", - dai->name, module->name); + dev_err(dai->dev, "%s DATA connection missing\n", + dai->name); mutex_unlock(&codec->lock); return -ENODEV; }
base-commit: f443e374ae131c168a065ea1748feac6b2e76613
On Mon, Mar 21, 2022 at 01:36:26PM +0100, Jakob Koschel wrote:
If the list does not exit early then data == NULL and 'module' does not point to a valid list element. Using 'module' in such a case is not valid and was therefore removed.
Fixes: 6dd67645f22c ("greybus: audio: Use single codec driver registration") Signed-off-by: Jakob Koschel jakobkoschel@gmail.com
Thanks!
Reviewed-by: Dan Carpenter dan.carpenter@oracle.com
regards, dan carpenter
On Mon, Mar 21, 2022 at 01:36:26PM +0100, Jakob Koschel wrote:
If the list does not exit early then data == NULL and 'module' does not point to a valid list element. Using 'module' in such a case is not valid and was therefore removed.
Fixes: 6dd67645f22c ("greybus: audio: Use single codec driver registration") Signed-off-by: Jakob Koschel jakobkoschel@gmail.com
drivers/staging/greybus/audio_codec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c index b589cf6b1d03..e19b91e7a72e 100644 --- a/drivers/staging/greybus/audio_codec.c +++ b/drivers/staging/greybus/audio_codec.c @@ -599,8 +599,8 @@ static int gbcodec_mute_stream(struct snd_soc_dai *dai, int mute, int stream) break; } if (!data) {
dev_err(dai->dev, "%s:%s DATA connection missing\n",dai->name, module->name);
dev_err(dai->dev, "%s DATA connection missing\n",dai->name);base-commit: f443e374ae131c168a065ea1748feac6b2e76613
Reviewed-by: Mark Greer mgreer@animalcreek.com
On Mon, Mar 21, 2022 at 6:07 PM Jakob Koschel jakobkoschel@gmail.com wrote:
If the list does not exit early then data == NULL and 'module' does not point to a valid list element. Using 'module' in such a case is not valid and was therefore removed.
Fixes: 6dd67645f22c ("greybus: audio: Use single codec driver registration") Signed-off-by: Jakob Koschel jakobkoschel@gmail.com
drivers/staging/greybus/audio_codec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c index b589cf6b1d03..e19b91e7a72e 100644 --- a/drivers/staging/greybus/audio_codec.c +++ b/drivers/staging/greybus/audio_codec.c @@ -599,8 +599,8 @@ static int gbcodec_mute_stream(struct snd_soc_dai *dai, int mute, int stream) break; } if (!data) {
dev_err(dai->dev, "%s:%s DATA connection missing\n",dai->name, module->name);
dev_err(dai->dev, "%s DATA connection missing\n",dai->name); mutex_unlock(&codec->lock); return -ENODEV; }base-commit: f443e374ae131c168a065ea1748feac6b2e76613
Reviewed-by: Vaibhav Agarwal vaibhav.sr@gmail.com
-- 2.25.1
-
Dan Carpenter -
Jakob Koschel -
Mark Greer -
Vaibhav Agarwal