Make the envp char array a const in the send_add_uevent function since the value will never change. It will remain an array of the pointers to the various char arrays.
There does exist a warning when running the checkpatch script to make this a static variable, but there does not appear to be any advantage to make this change.
Signed-off-by: Ian Cowan ian@linux.cowan.aero --- drivers/staging/greybus/audio_manager_module.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/audio_manager_module.c b/drivers/staging/greybus/audio_manager_module.c index 0a0f0a394c84..c9d223b0e541 100644 --- a/drivers/staging/greybus/audio_manager_module.c +++ b/drivers/staging/greybus/audio_manager_module.c @@ -159,7 +159,7 @@ static void send_add_uevent(struct gb_audio_manager_module *module) char ip_devices_string[64]; char op_devices_string[64];
- char *envp[] = { + const char *envp[] = { name_string, vid_string, pid_string,
On Wed, Apr 20, 2022 at 01:37:55AM -0400, Ian Cowan wrote:
There does exist a warning when running the checkpatch script to make this a static variable, but there does not appear to be any advantage to make this change.
Heh. Don't send patches unless there is an advantage.
This patch breaks the build. You need to at least try to compile your changes before you send them.
regards, dan carpenter
-
Dan Carpenter -
Ian Cowan