checkpatch.pl line over 80 characters so fix the formatting for coding style compliance.
Signed-off-by: Deb McLemore debmc@linux.vnet.ibm.com --- drivers/staging/greybus/spilib.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/spilib.h b/drivers/staging/greybus/spilib.h index 566d0dd..cb60925 100644 --- a/drivers/staging/greybus/spilib.h +++ b/drivers/staging/greybus/spilib.h @@ -18,7 +18,8 @@ struct spilib_ops { void (*unprepare_transfer_hardware)(struct device *dev); };
-int gb_spilib_master_init(struct gb_connection *connection, struct device *dev, struct spilib_ops *ops); +int gb_spilib_master_init(struct gb_connection *connection, + struct device *dev, struct spilib_ops *ops); void gb_spilib_master_exit(struct gb_connection *connection);
#endif /* __SPILIB_H */
On 26-07-17, 17:13, Deb McLemore wrote:
checkpatch.pl line over 80 characters so fix the formatting for coding style compliance.
Signed-off-by: Deb McLemore debmc@linux.vnet.ibm.com
drivers/staging/greybus/spilib.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/spilib.h b/drivers/staging/greybus/spilib.h index 566d0dd..cb60925 100644 --- a/drivers/staging/greybus/spilib.h +++ b/drivers/staging/greybus/spilib.h @@ -18,7 +18,8 @@ struct spilib_ops { void (*unprepare_transfer_hardware)(struct device *dev); }; -int gb_spilib_master_init(struct gb_connection *connection, struct device *dev, struct spilib_ops *ops); +int gb_spilib_master_init(struct gb_connection *connection,
struct device *dev, struct spilib_ops *ops);
It was intentionally written so and you will find tons of examples of such declarations in the .h files specially.
Hi Viresh,
So does greybus not follow the coding style from checkpatch.pl ?
On 07/26/2017 10:32 PM, Viresh Kumar wrote:
On 26-07-17, 17:13, Deb McLemore wrote:
checkpatch.pl line over 80 characters so fix the formatting for coding style compliance.
Signed-off-by: Deb McLemore debmc@linux.vnet.ibm.com
drivers/staging/greybus/spilib.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/spilib.h b/drivers/staging/greybus/spilib.h index 566d0dd..cb60925 100644 --- a/drivers/staging/greybus/spilib.h +++ b/drivers/staging/greybus/spilib.h @@ -18,7 +18,8 @@ struct spilib_ops { void (*unprepare_transfer_hardware)(struct device *dev); }; -int gb_spilib_master_init(struct gb_connection *connection, struct device *dev, struct spilib_ops *ops); +int gb_spilib_master_init(struct gb_connection *connection,
struct device *dev, struct spilib_ops *ops);It was intentionally written so and you will find tons of examples of such declarations in the .h files specially.
On Thu, Jul 27, 2017 at 08:10:35AM -0500, Deb McLemore wrote:
Hi Viresh,
So does greybus not follow the coding style from checkpatch.pl ?
Sometimes people go over the 80 character limit if we think it's more readable.
regards, dan carpenter
Hi Dan,
Understand the readability issue, but this patch seems readable.
On 07/27/2017 08:16 AM, Dan Carpenter wrote:
On Thu, Jul 27, 2017 at 08:10:35AM -0500, Deb McLemore wrote:
Hi Viresh,
So does greybus not follow the coding style from checkpatch.pl ?
Sometimes people go over the 80 character limit if we think it's more readable.
regards, dan carpenter
On Thu, Jul 27, 2017 at 08:23:41AM -0500, Deb McLemore wrote:
Hi Dan,
Understand the readability issue, but this patch seems readable.
I would have probably merged the patch, but whatever... Ignoring long lines in .h files is within normal bounds of "being special" for maintainers.
regards, dan carpenter
Hi Dan, thanks.
I'll look for another subsystem to help improve the quality and standards.
On 07/27/2017 08:35 AM, Dan Carpenter wrote:
On Thu, Jul 27, 2017 at 08:23:41AM -0500, Deb McLemore wrote:
Hi Dan,
Understand the readability issue, but this patch seems readable.
I would have probably merged the patch, but whatever... Ignoring long lines in .h files is within normal bounds of "being special" for maintainers.
regards, dan carpenter
On 27-07-17, 08:37, Deb McLemore wrote:
Hi Dan, thanks.
I'll look for another subsystem to help improve the quality and standards.
Please don't do *top-posting*.
On 07/27/2017 08:35 AM, Dan Carpenter wrote:
On Thu, Jul 27, 2017 at 08:23:41AM -0500, Deb McLemore wrote:
Hi Dan,
Understand the readability issue, but this patch seems readable.
I would have probably merged the patch, but whatever... Ignoring long lines in .h files is within normal bounds of "being special" for maintainers.
Yeah, I am not saying that this patch is completely wrong and I Nack it, but that it was left like this intentionally. If Greg want's he can apply that patch, I wouldn't mind. Its up to him really.
On Thu, Jul 27, 2017 at 04:35:32PM +0300, Dan Carpenter wrote:
On Thu, Jul 27, 2017 at 08:23:41AM -0500, Deb McLemore wrote:
Hi Dan,
Understand the readability issue, but this patch seems readable.
I would have probably merged the patch, but whatever... Ignoring long lines in .h files is within normal bounds of "being special" for maintainers.
I merged it :)
-
Dan Carpenter -
Deb McLemore -
Greg KH -
Viresh Kumar