Remove unnecessary blank line before struct as reported by checkpatch:
" CHECK: Please don't use multiple blank lines "
Signed-off-by: Menna Mahmoud eng.mennamahmoud.mm@gmail.com --- change in v2: add patches that have same edit in sigle patch. --- drivers/staging/greybus/greybus_authentication.h | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/staging/greybus/greybus_authentication.h b/drivers/staging/greybus/greybus_authentication.h index 7edc7295b7ab..48b4a9794d3c 100644 --- a/drivers/staging/greybus/greybus_authentication.h +++ b/drivers/staging/greybus/greybus_authentication.h @@ -41,7 +41,6 @@ #define CAP_AUTH_RESULT_CR_NO_KEY 0x03 #define CAP_AUTH_RESULT_CR_SIG_FAIL 0x04
- /* IOCTL support */ struct cap_ioc_get_endpoint_uid { __u8 uid[8];
On Tue, 21 Mar 2023, Menna Mahmoud wrote:
Remove unnecessary blank line before struct as reported by checkpatch:
" CHECK: Please don't use multiple blank lines "
Signed-off-by: Menna Mahmoud eng.mennamahmoud.mm@gmail.com
change in v2: add patches that have same edit in sigle patch.
drivers/staging/greybus/greybus_authentication.h | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/staging/greybus/greybus_authentication.h b/drivers/staging/greybus/greybus_authentication.h index 7edc7295b7ab..48b4a9794d3c 100644 --- a/drivers/staging/greybus/greybus_authentication.h +++ b/drivers/staging/greybus/greybus_authentication.h @@ -41,7 +41,6 @@ #define CAP_AUTH_RESULT_CR_NO_KEY 0x03 #define CAP_AUTH_RESULT_CR_SIG_FAIL 0x04
/* IOCTL support */ struct cap_ioc_get_endpoint_uid { __u8 uid[8]; -- 2.34.1
From 6f56ebcda89f91cdfe6e64c0707dc476ebc1e819 Mon Sep 17 00:00:00 2001 From: Menna Mahmoud eng.mennamahmoud.mm@gmail.com Date: Tue, 21 Mar 2023 00:03:32 +0200 Subject: [PATCH v2 2/2] staging: greybus: remove unnecessary blank line
This doesn't look right. If you put two changes in a single message, you shouldn't repeat the log message etc. Use git log -p to look at what others have done.
julia
Remove unnecessary blank line before struct as reported by checkpatch:
" CHECK: Please don't use multiple blank lines "
Signed-off-by: Menna Mahmoud eng.mennamahmoud.mm@gmail.com
change in v2: add patches that have same edit in sigle patch.
drivers/staging/greybus/pwm.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/staging/greybus/pwm.c b/drivers/staging/greybus/pwm.c index 3fda172239d2..26d39e08c3b6 100644 --- a/drivers/staging/greybus/pwm.c +++ b/drivers/staging/greybus/pwm.c @@ -24,7 +24,6 @@ struct gb_pwm_chip { #define pwm_chip_to_gb_pwm_chip(chip) \ container_of(chip, struct gb_pwm_chip, chip)
static int gb_pwm_count_operation(struct gb_pwm_chip *pwmc) { struct gb_pwm_count_response response; -- 2.34.1