Free memory region, if gb_lights_channel_config is not successful.
Signed-off-by: Arvind Yadav arvind.yadav.cs@gmail.com --- changes in v2: - Subject line changed. - add kfree in __gb_lights_led_unregister(). - No need to check return value of gb_lights_channel_flash_config().
changes ib v3: - separate patch for "No need to check return value of gb_lights_channel_flash_config()".
drivers/staging/greybus/light.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/light.c index 3f4148c..0f538b8 100644 --- a/drivers/staging/greybus/light.c +++ b/drivers/staging/greybus/light.c @@ -925,6 +925,8 @@ static void __gb_lights_led_unregister(struct gb_channel *channel) return;
led_classdev_unregister(cdev); + kfree(cdev->name); + cdev->name = NULL; channel->led = NULL; }
Hi, On Sat, Sep 23, 2017 at 01:25:30PM +0530, Arvind Yadav wrote:
Free memory region, if gb_lights_channel_config is not successful.
Signed-off-by: Arvind Yadav arvind.yadav.cs@gmail.com
Thanks for the patch, looks good to me.
Reviewed-by: Rui Miguel Silva rmfrfs@gmail.com
--- Cheers, Rui
changes in v2: - Subject line changed. - add kfree in __gb_lights_led_unregister(). - No need to check return value of gb_lights_channel_flash_config().
changes ib v3: - separate patch for "No need to check return value of gb_lights_channel_flash_config()".
drivers/staging/greybus/light.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/light.c index 3f4148c..0f538b8 100644 --- a/drivers/staging/greybus/light.c +++ b/drivers/staging/greybus/light.c @@ -925,6 +925,8 @@ static void __gb_lights_led_unregister(struct gb_channel *channel) return; led_classdev_unregister(cdev);
- kfree(cdev->name);
- cdev->name = NULL; channel->led = NULL;
} -- 2.7.4
-
Arvind Yadav -
Rui Miguel Silva