Fix a missing unlock in the error branch.
Signed-off-by: Zheng Yongjun zhengyongjun3@huawei.com --- drivers/staging/greybus/audio_helper.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/staging/greybus/audio_helper.c b/drivers/staging/greybus/audio_helper.c index 237531ba60f3..293675dbea10 100644 --- a/drivers/staging/greybus/audio_helper.c +++ b/drivers/staging/greybus/audio_helper.c @@ -135,6 +135,7 @@ int gbaudio_dapm_free_controls(struct snd_soc_dapm_context *dapm, if (!w) { dev_err(dapm->dev, "%s: widget not found\n", widget->name); + mutex_unlock(&dapm->card->dapm_mutex); return -EINVAL; } widget++;
On Mon, Dec 21, 2020 at 09:02:46PM +0800, Zheng Yongjun wrote:
Fix a missing unlock in the error branch.
Signed-off-by: Zheng Yongjun zhengyongjun3@huawei.com
drivers/staging/greybus/audio_helper.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/staging/greybus/audio_helper.c b/drivers/staging/greybus/audio_helper.c index 237531ba60f3..293675dbea10 100644 --- a/drivers/staging/greybus/audio_helper.c +++ b/drivers/staging/greybus/audio_helper.c @@ -135,6 +135,7 @@ int gbaudio_dapm_free_controls(struct snd_soc_dapm_context *dapm, if (!w) { dev_err(dapm->dev, "%s: widget not found\n", widget->name);
mutex_unlock(&dapm->card->dapm_mutex); return -EINVAL;
This has already been fixed in mainline by your colleague:
e77b259f67ab ("staging: greybus: audio: Fix possible leak free widgets in gbaudio_dapm_free_controls")
It seems you're all working on reports from your "Hulk Robot" so perhaps you can try to coordinate that internally.
Johan
-
Johan Hovold -
Zheng Yongjun