On Mon, Aug 26, 2024 at 08:32:12AM +0000, Dorine Tipo wrote:

Update the gb_loopback_stats_attrs() macro to use a do-while(0) loop. This ensures that it is treated as a single statement, preventing potential issues when used in conditional or loop constructs.

Signed-off-by: Dorine Tipo dorine.a.tipo@gmail.com

drivers/staging/greybus/loopback.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c index 1f19323b0e1a..0f3e4c43e2de 100644 --- a/drivers/staging/greybus/loopback.c +++ b/drivers/staging/greybus/loopback.c @@ -163,9 +163,11 @@ static ssize_t name##_avg_show(struct device *dev, \ static DEVICE_ATTR_RO(name##_avg)

#define gb_loopback_stats_attrs(field) \

• gb_loopback_ro_stats_attr(field, min, u); \
• gb_loopback_ro_stats_attr(field, max, u); \
• gb_loopback_ro_avg_attr(field)

• do {

• gb_loopback_ro_stats_attr(field, min, u);		\
  

• gb_loopback_ro_stats_attr(field, max, u);		\
  

• gb_loopback_ro_avg_attr(field);
  

• } while (0)

Please always test-build your patches before sending them out :(