disable_irq() after request_irq() still has a time gap in which interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will disable IRQ auto-enable because of requesting.
this patch is made base on "add IRQF_NO_AUTOEN for request_irq" which is being merged: https://lore.kernel.org/patchwork/patch/1388765/
Signed-off-by: Tian Tao tiantao6@hisilicon.com --- drivers/staging/greybus/arche-platform.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/greybus/arche-platform.c b/drivers/staging/greybus/arche-platform.c index e374dfc..be27ace 100644 --- a/drivers/staging/greybus/arche-platform.c +++ b/drivers/staging/greybus/arche-platform.c @@ -500,13 +500,13 @@ static int arche_platform_probe(struct platform_device *pdev) arche_platform_wd_irq, arche_platform_wd_irq_thread, IRQF_TRIGGER_FALLING | - IRQF_TRIGGER_RISING | IRQF_ONESHOT, + IRQF_TRIGGER_RISING | IRQF_ONESHOT | + IRQF_NO_AUTOEN, dev_name(dev), arche_pdata); if (ret) { dev_err(dev, "failed to request wake detect IRQ %d\n", ret); return ret; } - disable_irq(arche_pdata->wake_detect_irq);
ret = device_create_file(dev, &dev_attr_state); if (ret) {
On Wed, Apr 07, 2021 at 02:50:03PM +0800, Tian Tao wrote:
disable_irq() after request_irq() still has a time gap in which interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will disable IRQ auto-enable because of requesting.
this patch is made base on "add IRQF_NO_AUTOEN for request_irq" which is being merged: https://lore.kernel.org/patchwork/patch/1388765/
Can you wait until that is merged before sending this out to us as we can't do anything until then.
thanks,
greg k-h
在 2021/4/7 16:22, Greg KH 写道:
On Wed, Apr 07, 2021 at 02:50:03PM +0800, Tian Tao wrote:
disable_irq() after request_irq() still has a time gap in which interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will disable IRQ auto-enable because of requesting.
this patch is made base on "add IRQF_NO_AUTOEN for request_irq" which is being merged: https://lore.kernel.org/patchwork/patch/1388765/
Can you wait until that is merged before sending this out to us as we can't do anything until then.
this is already in linux-next.git.
cbe16f3 genirq: Add IRQF_NO_AUTOEN for request_irq/nmi()
thanks,
greg k-h .
On Wed, Apr 07, 2021 at 04:29:59PM +0800, tiantao (H) wrote:
在 2021/4/7 16:22, Greg KH 写道:
On Wed, Apr 07, 2021 at 02:50:03PM +0800, Tian Tao wrote:
disable_irq() after request_irq() still has a time gap in which interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will disable IRQ auto-enable because of requesting.
this patch is made base on "add IRQF_NO_AUTOEN for request_irq" which is being merged: https://lore.kernel.org/patchwork/patch/1388765/
Can you wait until that is merged before sending this out to us as we can't do anything until then.
this is already in linux-next.git.
cbe16f3 genirq: Add IRQF_NO_AUTOEN for request_irq/nmi()
That's great, but note that linux-next is a combined tree of all subsystem trees. It's impossible for a subsystem tree to include linux-next :)
So how about we wait until this gets into Linus's tree so that we do not all suddenly get problems in our individual subsystem trees.
thanks,
greg k-h
在 2021/4/7 16:40, Greg KH 写道:
On Wed, Apr 07, 2021 at 04:29:59PM +0800, tiantao (H) wrote:
在 2021/4/7 16:22, Greg KH 写道:
On Wed, Apr 07, 2021 at 02:50:03PM +0800, Tian Tao wrote:
disable_irq() after request_irq() still has a time gap in which interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will disable IRQ auto-enable because of requesting.
this patch is made base on "add IRQF_NO_AUTOEN for request_irq" which is being merged: https://lore.kernel.org/patchwork/patch/1388765/
Can you wait until that is merged before sending this out to us as we can't do anything until then.
this is already in linux-next.git.
cbe16f3 genirq: Add IRQF_NO_AUTOEN for request_irq/nmi()
That's great, but note that linux-next is a combined tree of all subsystem trees. It's impossible for a subsystem tree to include linux-next :)
So how about we wait until this gets into Linus's tree so that we do not all suddenly get problems in our individual subsystem trees.
thanks,
ok，I will resend later.
greg k-h .
在 2021/4/7 16:40, Greg KH 写道:
On Wed, Apr 07, 2021 at 04:29:59PM +0800, tiantao (H) wrote:
在 2021/4/7 16:22, Greg KH 写道:
On Wed, Apr 07, 2021 at 02:50:03PM +0800, Tian Tao wrote:
disable_irq() after request_irq() still has a time gap in which interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will disable IRQ auto-enable because of requesting.
this patch is made base on "add IRQF_NO_AUTOEN for request_irq" which is being merged: https://lore.kernel.org/patchwork/patch/1388765/
Can you wait until that is merged before sending this out to us as we can't do anything until then.
this is already in linux-next.git.
cbe16f3 genirq: Add IRQF_NO_AUTOEN for request_irq/nmi()
That's great, but note that linux-next is a combined tree of all subsystem trees. It's impossible for a subsystem tree to include linux-next :)
Maybe you can referencethis tag https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/tag/?h=irq-no-au...
So how about we wait until this gets into Linus's tree so that we do not all suddenly get problems in our individual subsystem trees.
thanks,
greg k-h .
On Thu, Apr 08, 2021 at 08:51:09AM +0800, tiantao (H) wrote:
在 2021/4/7 16:40, Greg KH 写道:
On Wed, Apr 07, 2021 at 04:29:59PM +0800, tiantao (H) wrote:
在 2021/4/7 16:22, Greg KH 写道:
On Wed, Apr 07, 2021 at 02:50:03PM +0800, Tian Tao wrote:
disable_irq() after request_irq() still has a time gap in which interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will disable IRQ auto-enable because of requesting.
this patch is made base on "add IRQF_NO_AUTOEN for request_irq" which is being merged: https://lore.kernel.org/patchwork/patch/1388765/
Can you wait until that is merged before sending this out to us as we can't do anything until then.
this is already in linux-next.git.
cbe16f3 genirq: Add IRQF_NO_AUTOEN for request_irq/nmi()
That's great, but note that linux-next is a combined tree of all subsystem trees. It's impossible for a subsystem tree to include linux-next :)
Maybe you can referencethis tag https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/tag/?h=irq-no-au...
In what way?
-
Greg KH -
Tian Tao -
tiantao (H)