checkpatch.pl warning: Symbolic permissions are not preferred. Consider using octal permissions.
Signed-off-by: Igor Pylypiv igor.pylypiv@gmail.com --- drivers/staging/greybus/tools/loopback_test.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/greybus/tools/loopback_test.c b/drivers/staging/greybus/tools/loopback_test.c index 5312b2a..18d7a3d 100644 --- a/drivers/staging/greybus/tools/loopback_test.c +++ b/drivers/staging/greybus/tools/loopback_test.c @@ -521,7 +521,6 @@ static int log_results(struct loopback_test *t) int fd, i, len, ret; struct tm tm; time_t local_time; - mode_t mode = S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH; char file_name[MAX_SYSFS_PATH]; char data[CSV_MAX_LINE];
@@ -538,7 +537,7 @@ static int log_results(struct loopback_test *t) snprintf(file_name, sizeof(file_name), "%s_%d_%d.csv", t->test_name, t->size, t->iteration_max);
- fd = open(file_name, O_WRONLY | O_CREAT | O_APPEND, mode); + fd = open(file_name, O_WRONLY | O_CREAT | O_APPEND, 0644); if (fd < 0) { fprintf(stderr, "unable to open %s for appendation\n", file_name); abort(); -- 2.7.4
On Wed, Jan 18, 2017 at 06:21:23PM -0800, Igor Pylypiv wrote:
checkpatch.pl warning: Symbolic permissions are not preferred. Consider using octal permissions.
Signed-off-by: Igor Pylypiv igor.pylypiv@gmail.com
Reviewed-by: Johan Hovold johan@kernel.org