On Thu, May 21, 2026 at 08:42:06PM +0200, Alexander A. Klimov wrote:
On 5/21/26 10:38, Greg Kroah-Hartman wrote:
On Wed, May 20, 2026 at 08:03:59PM +0200, Alexander A. Klimov wrote:
kstrtoint() returns "0 on success, -ERANGE on overflow and -EINVAL on parsing error". In contrast, manager_sysfs_remove_store() and manager_sysfs_dump_store() checked for 1 which always failed the operation. I fixed this.
Fixes: f9a21a3f4919 ("staging: greybus: audio_manager_sysfs: Replace sscanf with kstrto* to single variable conversion.") Signed-off-by: Alexander A. Klimov grandmaster@al2klimov.de
drivers/staging/greybus/audio_manager_sysfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/greybus/audio_manager_sysfs.c b/drivers/staging/greybus/audio_manager_sysfs.c index fcd518f9540c..581791d566e3 100644 --- a/drivers/staging/greybus/audio_manager_sysfs.c +++ b/drivers/staging/greybus/audio_manager_sysfs.c @@ -44,7 +44,7 @@ static ssize_t manager_sysfs_remove_store(struct kobject *kobj, int num = kstrtoint(buf, 10, &id);
- if (num != 1)
- if (num != 0)
Doesn't checkpatch now complain about this?
No.
$ curl -fsSL https://lkml.org/lkml/diff/2026/5/20/2139/1 | scripts/checkpatch.pl
Please use lore.kernel.org, not lkml.
Also, when using b4 to apply this, it sucked in a bunch of other random patches for you, please make new threads for everything you send.
ERROR: Missing Signed-off-by: line(s)
Why is that showing up?
total: 1 errors, 0 warnings, 0 checks, 16 lines checked
NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace.
What about trying --strict?
Anyway, think about rewriting the check for "== 0" now, that is not normal kernel style.
thanks,
greg k-h
-
Greg Kroah-Hartman