According to checkpatch warning, block comments should align the * on each line.
Signed-off-by: Aleksey Rybalkin aleksey@rybalkin.org --- drivers/staging/greybus/tools/loopback_test.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/greybus/tools/loopback_test.c b/drivers/staging/greybus/tools/loopback_test.c index 32a43693181c..bcb1c36889ce 100644 --- a/drivers/staging/greybus/tools/loopback_test.c +++ b/drivers/staging/greybus/tools/loopback_test.c @@ -528,11 +528,11 @@ static int log_results(struct loopback_test *t) tm = *localtime(&local_time);
/* - * file name will test_name_size_iteration_max.csv - * every time the same test with the same parameters is run we will then - * append to the same CSV with datestamp - representing each test - * dataset. - */ + * file name will test_name_size_iteration_max.csv + * every time the same test with the same parameters is run we will then + * append to the same CSV with datestamp - representing each test + * dataset. + */ if (t->file_output && !t->porcelain) { snprintf(file_name, sizeof(file_name), "%s_%d_%d.csv", t->test_name, t->size, t->iteration_max);
On Fri, Jun 30, 2017 at 09:43:44PM +0500, Aleksey Rybalkin wrote:
According to checkpatch warning, block comments should align the * on each line.
How about "fixing" the other multi-line comment ("Cancel any running..."), which isn't on the normal kernel format either while at it?
/* * blah */
You also forgot to CC the staging list (and the Greybus maintainers) (see scripts/get_maintainer.pl).
Care to address that in a v2?
Thanks, Johan
According to checkpatch warning, block comments should align the * on each line. Also, preferred style for multi-line comments is starting the comment text after the second *.
Signed-off-by: Aleksey Rybalkin aleksey@rybalkin.org --- drivers/staging/greybus/tools/loopback_test.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/greybus/tools/loopback_test.c b/drivers/staging/greybus/tools/loopback_test.c index 32a43693181c..d86bcce53e6b 100644 --- a/drivers/staging/greybus/tools/loopback_test.c +++ b/drivers/staging/greybus/tools/loopback_test.c @@ -528,11 +528,11 @@ static int log_results(struct loopback_test *t) tm = *localtime(&local_time);
/* - * file name will test_name_size_iteration_max.csv - * every time the same test with the same parameters is run we will then - * append to the same CSV with datestamp - representing each test - * dataset. - */ + * file name will test_name_size_iteration_max.csv + * every time the same test with the same parameters is run we will then + * append to the same CSV with datestamp - representing each test + * dataset. + */ if (t->file_output && !t->porcelain) { snprintf(file_name, sizeof(file_name), "%s_%d_%d.csv", t->test_name, t->size, t->iteration_max); @@ -779,7 +779,8 @@ static void prepare_devices(struct loopback_test *t) { int i;
- /* Cancel any running tests on enabled devices. If + /* + * Cancel any running tests on enabled devices. If * stop_all option is given, stop test on all devices. */ for (i = 0; i < t->device_count; i++)
+ Greg
On 03-07-17, 23:27, Aleksey Rybalkin wrote:
According to checkpatch warning, block comments should align the * on each line. Also, preferred style for multi-line comments is starting the comment text after the second *.
Signed-off-by: Aleksey Rybalkin aleksey@rybalkin.org
drivers/staging/greybus/tools/loopback_test.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/greybus/tools/loopback_test.c b/drivers/staging/greybus/tools/loopback_test.c index 32a43693181c..d86bcce53e6b 100644 --- a/drivers/staging/greybus/tools/loopback_test.c +++ b/drivers/staging/greybus/tools/loopback_test.c @@ -528,11 +528,11 @@ static int log_results(struct loopback_test *t) tm = *localtime(&local_time); /*
- file name will test_name_size_iteration_max.csv
- every time the same test with the same parameters is run we will then
- append to the same CSV with datestamp - representing each test
- dataset.
- */
* file name will test_name_size_iteration_max.csv* every time the same test with the same parameters is run we will then* append to the same CSV with datestamp - representing each test* dataset.*/@@ -779,7 +779,8 @@ static void prepare_devices(struct loopback_test *t) { int i;
- /* Cancel any running tests on enabled devices. If
- /*
* Cancel any running tests on enabled devices. If*/ for (i = 0; i < t->device_count; i++)
- stop_all option is given, stop test on all devices.
Reviewed-by: Viresh Kumar viresh.kumar@linaro.org
On Tue, Jul 04, 2017 at 11:47:51AM +0530, Viresh Kumar wrote:
- Greg
On 03-07-17, 23:27, Aleksey Rybalkin wrote:
According to checkpatch warning, block comments should align the * on each line. Also, preferred style for multi-line comments is starting the comment text after the second *.
Signed-off-by: Aleksey Rybalkin aleksey@rybalkin.org
Thanks for the v2. Next time remember to include a short changelog here after the cut-off line.
drivers/staging/greybus/tools/loopback_test.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/greybus/tools/loopback_test.c b/drivers/staging/greybus/tools/loopback_test.c index 32a43693181c..d86bcce53e6b 100644 --- a/drivers/staging/greybus/tools/loopback_test.c +++ b/drivers/staging/greybus/tools/loopback_test.c @@ -528,11 +528,11 @@ static int log_results(struct loopback_test *t) tm = *localtime(&local_time); /*
- file name will test_name_size_iteration_max.csv
- every time the same test with the same parameters is run we will then
- append to the same CSV with datestamp - representing each test
- dataset.
- */
* file name will test_name_size_iteration_max.csv* every time the same test with the same parameters is run we will then* append to the same CSV with datestamp - representing each test* dataset.*/@@ -779,7 +779,8 @@ static void prepare_devices(struct loopback_test *t) { int i;
- /* Cancel any running tests on enabled devices. If
- /*
* Cancel any running tests on enabled devices. If*/ for (i = 0; i < t->device_count; i++)
- stop_all option is given, stop test on all devices.
Reviewed-by: Viresh Kumar viresh.kumar@linaro.org
Acked-by: Johan Hovold johan@kernel.org
Thanks, Johan
On Tue, Jul 04, 2017 at 10:28:10AM +0200, Johan Hovold wrote:
On Tue, Jul 04, 2017 at 11:47:51AM +0530, Viresh Kumar wrote:
- Greg
On 03-07-17, 23:27, Aleksey Rybalkin wrote:
According to checkpatch warning, block comments should align the * on each line. Also, preferred style for multi-line comments is starting the comment text after the second *.
Signed-off-by: Aleksey Rybalkin aleksey@rybalkin.org
Thanks for the v2. Next time remember to include a short changelog here after the cut-off line.
Will do next time. And will send more meaningful patches, too. This was "learning the ropes" patch. Thanks for the feedback.
Also a question - is it ok to send "thanks for the feedback" emails with minimum substance like this one? I was hesitating for a minute to send it.
drivers/staging/greybus/tools/loopback_test.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/greybus/tools/loopback_test.c b/drivers/staging/greybus/tools/loopback_test.c index 32a43693181c..d86bcce53e6b 100644 --- a/drivers/staging/greybus/tools/loopback_test.c +++ b/drivers/staging/greybus/tools/loopback_test.c @@ -528,11 +528,11 @@ static int log_results(struct loopback_test *t) tm = *localtime(&local_time); /*
- file name will test_name_size_iteration_max.csv
- every time the same test with the same parameters is run we will then
- append to the same CSV with datestamp - representing each test
- dataset.
- */
* file name will test_name_size_iteration_max.csv* every time the same test with the same parameters is run we will then* append to the same CSV with datestamp - representing each test* dataset.*/@@ -779,7 +779,8 @@ static void prepare_devices(struct loopback_test *t) { int i;
- /* Cancel any running tests on enabled devices. If
- /*
* Cancel any running tests on enabled devices. If*/ for (i = 0; i < t->device_count; i++)
- stop_all option is given, stop test on all devices.
Reviewed-by: Viresh Kumar viresh.kumar@linaro.org
Acked-by: Johan Hovold johan@kernel.org
Thanks, Johan
On Wed, Jul 05, 2017 at 10:01:09AM +0500, Aleksey Rybalkin wrote:
On Tue, Jul 04, 2017 at 10:28:10AM +0200, Johan Hovold wrote:
On Tue, Jul 04, 2017 at 11:47:51AM +0530, Viresh Kumar wrote:
- Greg
On 03-07-17, 23:27, Aleksey Rybalkin wrote:
According to checkpatch warning, block comments should align the * on each line. Also, preferred style for multi-line comments is starting the comment text after the second *.
Signed-off-by: Aleksey Rybalkin aleksey@rybalkin.org
Thanks for the v2. Next time remember to include a short changelog here after the cut-off line.
Will do next time. And will send more meaningful patches, too. This was "learning the ropes" patch. Thanks for the feedback.
Sounds good, looks like you've got the hang of it.
Also a question - is it ok to send "thanks for the feedback" emails with minimum substance like this one? I was hesitating for a minute to send it.
It certainly is.
Johan
-
Aleksey Rybalkin -
Johan Hovold -
Viresh Kumar