Fixes: $ make versioncheck | grep staging ./drivers/staging/greybus/light.c: 15 linux/version.h not needed.
Signed-off-by: Darryl T. Agostinelli dagostinelli@gmail.com --- drivers/staging/greybus/light.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/light.c index 8dffd8a..1681362 100644 --- a/drivers/staging/greybus/light.c +++ b/drivers/staging/greybus/light.c @@ -12,7 +12,6 @@ #include <linux/led-class-flash.h> #include <linux/module.h> #include <linux/slab.h> -#include <linux/version.h> #include <media/v4l2-flash-led-class.h>
#include "greybus.h"
$ make includecheck | grep staging ./drivers/staging/greybus/uart.c: linux/serial.h is included more than once.
Signed-off-by: Darryl T. Agostinelli dagostinelli@gmail.com --- drivers/staging/greybus/uart.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/staging/greybus/uart.c b/drivers/staging/greybus/uart.c index b72693e..c6d01b8 100644 --- a/drivers/staging/greybus/uart.c +++ b/drivers/staging/greybus/uart.c @@ -23,7 +23,6 @@ #include <linux/serial.h> #include <linux/tty_driver.h> #include <linux/tty_flip.h> -#include <linux/serial.h> #include <linux/idr.h> #include <linux/fs.h> #include <linux/kdev_t.h>
On 04/12/2017 08:36 PM, Darryl T. Agostinelli wrote:
Fixes: $ make versioncheck | grep staging ./drivers/staging/greybus/light.c: 15 linux/version.h not needed.
Signed-off-by: Darryl T. Agostinelli dagostinelli@gmail.com
Looks good.
Reviewed-by: Alex Elder elder@linaro.org
drivers/staging/greybus/light.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/light.c index 8dffd8a..1681362 100644 --- a/drivers/staging/greybus/light.c +++ b/drivers/staging/greybus/light.c @@ -12,7 +12,6 @@ #include <linux/led-class-flash.h> #include <linux/module.h> #include <linux/slab.h> -#include <linux/version.h> #include <media/v4l2-flash-led-class.h> #include "greybus.h"
On 04/12/2017 08:36 PM, Darryl T. Agostinelli wrote:
$ make includecheck | grep staging ./drivers/staging/greybus/uart.c: linux/serial.h is included more than once.
Signed-off-by: Darryl T. Agostinelli dagostinelli@gmail.com
Looks good.
Reviewed-by: Alex Elder elder@linaro.org
drivers/staging/greybus/uart.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/staging/greybus/uart.c b/drivers/staging/greybus/uart.c index b72693e..c6d01b8 100644 --- a/drivers/staging/greybus/uart.c +++ b/drivers/staging/greybus/uart.c @@ -23,7 +23,6 @@ #include <linux/serial.h> #include <linux/tty_driver.h> #include <linux/tty_flip.h> -#include <linux/serial.h> #include <linux/idr.h> #include <linux/fs.h> #include <linux/kdev_t.h>
Hi Darryl, Thanks for the patch. On Wed, Apr 12, 2017 at 08:36:14PM -0500, Darryl T. Agostinelli wrote:
Fixes: $ make versioncheck | grep staging ./drivers/staging/greybus/light.c: 15 linux/version.h not needed.
Signed-off-by: Darryl T. Agostinelli dagostinelli@gmail.com
drivers/staging/greybus/light.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/light.c index 8dffd8a..1681362 100644 --- a/drivers/staging/greybus/light.c +++ b/drivers/staging/greybus/light.c @@ -12,7 +12,6 @@ #include <linux/led-class-flash.h> #include <linux/module.h> #include <linux/slab.h> -#include <linux/version.h> #include <media/v4l2-flash-led-class.h>
#include "greybus.h"
You only forgot the version, v2, in patch subject.
But, Looks good to me: Reviewed-by: Rui Miguel Silva rmfrfs@gmail.com
Cheers, Rui
-
Alex Elder -
Darryl T. Agostinelli -
Rui Miguel Silva