Refactor sprintf to sysfs_emit in all show functions of the greybus audio manager module. This follows the standard kernel practice of using sysfs_emit for sysfs attributes, ensuring consistent output formatting and newline handling.
Signed-off-by: Shubham Chakraborty chakrabortyshubham66@gmail.com ---
v3: - Add patch history below the --- line as requested by Greg KH.
v2: - Add missing Signed-off-by line. - Wrap commit message at 72 characters.
drivers/staging/greybus/audio_manager_module.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/greybus/audio_manager_module.c b/drivers/staging/greybus/audio_manager_module.c index e87b82ca6..f22ee73eb 100644 --- a/drivers/staging/greybus/audio_manager_module.c +++ b/drivers/staging/greybus/audio_manager_module.c @@ -76,7 +76,7 @@ static void gb_audio_module_release(struct kobject *kobj) static ssize_t gb_audio_module_name_show(struct gb_audio_manager_module *module, struct gb_audio_manager_module_attribute *attr, char *buf) { - return sprintf(buf, "%s", module->desc.name); + return sysfs_emit(buf, "%s\n", module->desc.name); }
static struct gb_audio_manager_module_attribute gb_audio_module_name_attribute = @@ -85,7 +85,7 @@ static struct gb_audio_manager_module_attribute gb_audio_module_name_attribute = static ssize_t gb_audio_module_vid_show(struct gb_audio_manager_module *module, struct gb_audio_manager_module_attribute *attr, char *buf) { - return sprintf(buf, "%d", module->desc.vid); + return sysfs_emit(buf, "%d\n", module->desc.vid); }
static struct gb_audio_manager_module_attribute gb_audio_module_vid_attribute = @@ -94,7 +94,7 @@ static struct gb_audio_manager_module_attribute gb_audio_module_vid_attribute = static ssize_t gb_audio_module_pid_show(struct gb_audio_manager_module *module, struct gb_audio_manager_module_attribute *attr, char *buf) { - return sprintf(buf, "%d", module->desc.pid); + return sysfs_emit(buf, "%d\n", module->desc.pid); }
static struct gb_audio_manager_module_attribute gb_audio_module_pid_attribute = @@ -104,7 +104,7 @@ static ssize_t gb_audio_module_intf_id_show(struct gb_audio_manager_module *modu struct gb_audio_manager_module_attribute *attr, char *buf) { - return sprintf(buf, "%d", module->desc.intf_id); + return sysfs_emit(buf, "%d\n", module->desc.intf_id); }
static struct gb_audio_manager_module_attribute @@ -115,7 +115,7 @@ static ssize_t gb_audio_module_ip_devices_show(struct gb_audio_manager_module *m struct gb_audio_manager_module_attribute *attr, char *buf) { - return sprintf(buf, "0x%X", module->desc.ip_devices); + return sysfs_emit(buf, "0x%X\n", module->desc.ip_devices); }
static struct gb_audio_manager_module_attribute @@ -126,7 +126,7 @@ static ssize_t gb_audio_module_op_devices_show(struct gb_audio_manager_module *m struct gb_audio_manager_module_attribute *attr, char *buf) { - return sprintf(buf, "0x%X", module->desc.op_devices); + return sysfs_emit(buf, "0x%X\n", module->desc.op_devices); }
static struct gb_audio_manager_module_attribute
On Mon, Feb 23, 2026 at 11:41:58PM +0530, Shubham Chakraborty wrote:
Refactor sprintf to sysfs_emit in all show functions of the greybus audio manager module. This follows the standard kernel practice of using sysfs_emit for sysfs attributes, ensuring consistent output formatting and newline handling.
Signed-off-by: Shubham Chakraborty chakrabortyshubham66@gmail.com
v3:
- Add patch history below the --- line as requested by Greg KH.
v2:
- Add missing Signed-off-by line.
- Wrap commit message at 72 characters.
drivers/staging/greybus/audio_manager_module.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/greybus/audio_manager_module.c b/drivers/staging/greybus/audio_manager_module.c index e87b82ca6..f22ee73eb 100644 --- a/drivers/staging/greybus/audio_manager_module.c +++ b/drivers/staging/greybus/audio_manager_module.c @@ -76,7 +76,7 @@ static void gb_audio_module_release(struct kobject *kobj) static ssize_t gb_audio_module_name_show(struct gb_audio_manager_module *module, struct gb_audio_manager_module_attribute *attr, char *buf) {
return sprintf(buf, "%s", module->desc.name);
return sysfs_emit(buf, "%s\n", module->desc.name);
You just changed the output of all of these sysfs files by adding "\n" to the end. Why?
I don't think that's wrong, BUT it is a user/kernel api change, so you need to document it, and ideally, that would happen in a separate change from this one.
So can you do the conversion to sysfs_emit() with NO change in the output, and a second one to add the \n if you really think it is needed.
And is it needed? If so, why? What tool uses these files and does it now still work?
thanks,
greg k-h
Hi Greg,
You are right. The \n additions were a mistake on my part — the original sprintf calls did not include \n and I should not have changed the output behavior in the same patch.
I will send a v4 that does a pure mechanical conversion from sprintf to sysfs_emit with no change in output, keeping the format strings identical to the originals.
Thank you for the review.
Shubham
On Tue, Feb 24, 2026 at 11:40 PM Greg Kroah-Hartman < gregkh@linuxfoundation.org> wrote:
On Mon, Feb 23, 2026 at 11:41:58PM +0530, Shubham Chakraborty wrote:
Refactor sprintf to sysfs_emit in all show functions of the greybus audio manager module. This follows the standard kernel practice of using sysfs_emit for sysfs attributes, ensuring consistent output formatting and newline handling.
Signed-off-by: Shubham Chakraborty chakrabortyshubham66@gmail.com
v3:
- Add patch history below the --- line as requested by Greg KH.
v2:
- Add missing Signed-off-by line.
- Wrap commit message at 72 characters.
drivers/staging/greybus/audio_manager_module.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/greybus/audio_manager_module.c
b/drivers/staging/greybus/audio_manager_module.c
index e87b82ca6..f22ee73eb 100644 --- a/drivers/staging/greybus/audio_manager_module.c +++ b/drivers/staging/greybus/audio_manager_module.c @@ -76,7 +76,7 @@ static void gb_audio_module_release(struct kobject
*kobj)
static ssize_t gb_audio_module_name_show(struct gb_audio_manager_module
*module,
structgb_audio_manager_module_attribute *attr, char *buf)
{
return sprintf(buf, "%s", module->desc.name);
return sysfs_emit(buf, "%s\n", module->desc.name);You just changed the output of all of these sysfs files by adding "\n" to the end. Why?
I don't think that's wrong, BUT it is a user/kernel api change, so you need to document it, and ideally, that would happen in a separate change from this one.
So can you do the conversion to sysfs_emit() with NO change in the output, and a second one to add the \n if you really think it is needed.
And is it needed? If so, why? What tool uses these files and does it now still work?
thanks,
greg k-h
Hi Greg,
You are right. The \n additions were a mistake on my part — the original sprintf calls did not include \n and I should not have changed the output behavior in the same patch.
I will send a v4 that does a pure mechanical conversion from sprintf to sysfs_emit with no change in output, keeping the format strings identical to the originals.
Thank you for the review.
Shubham
-
Greg Kroah-Hartman -
Shubham Chakraborty