Hi, Maxim,

Thanks for your quick reply.

Yes, I see now.

However, my patch set includes 4 patches, and the last one is the testing case adjustment patch that should fix all the testing failures. I am not sure whether the last patch was applied or not (from my understanding, the last patch was not applied).

Another question is, are all the patches posted to GNU toolchain mailing lists tested by Linaro?

Qing

On Apr 22, 2024, at 09:45, Maxim Kuvyrkov maxim.kuvyrkov@linaro.org wrote:

Hi Qing,

Linaro runs pre-commit CI in which we test patches posted to GNU toolchain mailing lists. Your patch series showed regressions in our pre-commit testing, and CI sent you below report.

The goal of pre-commit CI is catch problematic patches before they are merged.

Does this answer your question?

Kind regards,

-- Maxim Kuvyrkov https://www.linaro.orghttps://www.linaro.org/

On Apr 22, 2024, at 17:33, Qing Zhao <qing.zhao@oracle.commailto:qing.zhao@oracle.com> wrote:

Hi,

I am wondering why I got the following message?

I only sent patch review request to gcc-patches@gcc.gnu.orgmailto:gcc-patches@gcc.gnu.orgmailto:gcc-patches@gcc.gnu.org, never committed the patches to any public repository. Are there anyone else applied the patches to sourceware and tested them? I have posted many patch review request to gcc-patches@gcc.gnu.orgmailto:gcc-patches@gcc.gnu.orgmailto:gcc-patches@gcc.gnu.org, this is the first time I got such message.

Thanks a lot for your help.

Qing

On Apr 20, 2024, at 00:27, ci_notify@linaro.org wrote:

Dear contributor, our automatic CI has detected problems related to your patch(es). Please find some details below. If you have any questions, please follow up on linaro-toolchain@lists.linaro.org mailing list, Libera's #linaro-tcwg channel, or ping your favourite Linaro toolchain developer on the usual project channel.

We appreciate that it might be difficult to find the necessary logs or reproduce the issue locally. If you can't get what you need from our CI within minutes, let us know and we will be happy to help.

In gcc_check master-arm after:

| 3 patches in gcc | Patchwork URL: https://patchwork.sourceware.org/patch/88759 | da63cf36d84 Add testing cases for flexible array members in unions and alone in structures. | 9a83cd642a0 C and C++ FE changes to support flexible array members in unions and alone in structures. | 513291ec443 Documentation change | ... applied on top of baseline commit: | 9f10005dbc9 RISC-V: Add xfail test case for wv insn register overlap

FAIL: 260 regressions

regressions.sum: === g++ tests ===

Running g++:g++.dg/dg.exp ... FAIL: c-c++-common/builtin-clear-padding-3.c -std=gnu++14 (test for errors, line 5) FAIL: c-c++-common/builtin-clear-padding-3.c -std=gnu++14 (test for excess errors) FAIL: c-c++-common/builtin-clear-padding-3.c -std=gnu++17 (test for errors, line 5) FAIL: c-c++-common/builtin-clear-padding-3.c -std=gnu++17 (test for excess errors) FAIL: c-c++-common/builtin-clear-padding-3.c -std=gnu++20 (test for errors, line 5) FAIL: c-c++-common/builtin-clear-padding-3.c -std=gnu++20 (test for excess errors) FAIL: c-c++-common/builtin-clear-padding-3.c -std=gnu++98 (test for errors, line 5) ... and 259 more entries

You can find the failure logs in *.log.1.xz files in - https://ci.linaro.org/job/tcwg_gcc_check--master-arm-precommit/6897/artifact... The full lists of regressions and progressions as well as configure and make commands are in - https://ci.linaro.org/job/tcwg_gcc_check--master-arm-precommit/6897/artifact... The list of [ignored] baseline and flaky failures are in - https://ci.linaro.org/job/tcwg_gcc_check--master-arm-precommit/6897/artifact...

The configuration of this build is: CI config tcwg_gcc_check master-arm

-----------------8<--------------------------8<--------------------------8<-------------------------- The information below can be used to reproduce a debug environment:

Current build : https://ci.linaro.org/job/tcwg_gcc_check--master-arm-precommit/6897/artifact... Reference build : https://ci.linaro.org/job/tcwg_gcc_check--master-arm-build/1997/artifact/art...

Warning: we do not enable maintainer-mode nor automatically update generated files, which may lead to failures if the patch modifies the master files.

_______________________________________________ linaro-toolchain mailing list -- linaro-toolchain@lists.linaro.orgmailto:linaro-toolchain@lists.linaro.org To unsubscribe send an email to linaro-toolchain-leave@lists.linaro.orgmailto:linaro-toolchain-leave@lists.linaro.org

On Apr 23, 2024, at 02:57, Maxim Kuvyrkov maxim.kuvyrkov@linaro.org wrote:

Hi Qing,

On Apr 22, 2024, at 17:53, Qing Zhao qing.zhao@oracle.com wrote:

Hi, Maxim,

Thanks for your quick reply.

Yes, I see now.

However, my patch set includes 4 patches, and the last one is the testing case adjustment patch that should fix all the testing failures. I am not sure whether the last patch was applied or not (from my understanding, the last patch was not applied).

Correct. The report says ... | 3 patches in gcc | Patchwork URL: https://patchwork.sourceware.org/patch/88759 | da63cf36d84 Add testing cases for flexible array members in unions and alone in structures. | 9a83cd642a0 C and C++ FE changes to support flexible array members in unions and alone in structures. | 513291ec443 Documentation change | ... applied on top of baseline commit: | 9f10005dbc9 RISC-V: Add xfail test case for wv insn register overlap ... which means the results are for the first 3 patches.

You can also see at [1] that results when all 4 patches are applied are OK.

It's fine for review purposes to separate test-case adjustments into a standalone patch, but please squash them with the main patch when merging, so that GCC history does not include unnecessary regressions.

This is good to know. Will merge the patches before I commit the whole patch set.

Another question is, are all the patches posted to GNU toolchain mailing lists tested by Linaro?

We aim to test all patches processed by patchwork. However, patchwork can process only patches that follow standard git patch rules. Also, some patches fail to apply to current mainline, so we skip them. See [2] for more details.

Okay, I see.

Thanks for all these information.

Qing

[1] https://patchwork.sourceware.org/project/gcc/list/?series=33005 [2] https://patchwork.sourceware.org/project/gcc/list/

Kind regards,

-- Maxim Kuvyrkov https://www.linaro.orghttps://www.linaro.org/

Qing

On Apr 22, 2024, at 09:45, Maxim Kuvyrkov maxim.kuvyrkov@linaro.org wrote:

Hi Qing,

Linaro runs pre-commit CI in which we test patches posted to GNU toolchain mailing lists. Your patch series showed regressions in our pre-commit testing, and CI sent you below report.

The goal of pre-commit CI is catch problematic patches before they are merged.

Does this answer your question?

Kind regards,

-- Maxim Kuvyrkov https://www.linaro.org

On Apr 22, 2024, at 17:33, Qing Zhao qing.zhao@oracle.com wrote:

Hi,

I am wondering why I got the following message?

I only sent patch review request to gcc-patches@gcc.gnu.orgmailto:gcc-patches@gcc.gnu.org, never committed the patches to any public repository. Are there anyone else applied the patches to sourceware and tested them? I have posted many patch review request to gcc-patches@gcc.gnu.orgmailto:gcc-patches@gcc.gnu.org, this is the first time I got such message.

Thanks a lot for your help.

Qing

On Apr 20, 2024, at 00:27, ci_notify@linaro.org wrote:

Dear contributor, our automatic CI has detected problems related to your patch(es). Please find some details below. If you have any questions, please follow up on linaro-toolchain@lists.linaro.org mailing list, Libera's #linaro-tcwg channel, or ping your favourite Linaro toolchain developer on the usual project channel.

We appreciate that it might be difficult to find the necessary logs or reproduce the issue locally. If you can't get what you need from our CI within minutes, let us know and we will be happy to help.

In gcc_check master-arm after:

| 3 patches in gcc | Patchwork URL: https://patchwork.sourceware.org/patch/88759 | da63cf36d84 Add testing cases for flexible array members in unions and alone in structures. | 9a83cd642a0 C and C++ FE changes to support flexible array members in unions and alone in structures. | 513291ec443 Documentation change | ... applied on top of baseline commit: | 9f10005dbc9 RISC-V: Add xfail test case for wv insn register overlap

FAIL: 260 regressions

regressions.sum: === g++ tests ===

Running g++:g++.dg/dg.exp ... FAIL: c-c++-common/builtin-clear-padding-3.c -std=gnu++14 (test for errors, line 5) FAIL: c-c++-common/builtin-clear-padding-3.c -std=gnu++14 (test for excess errors) FAIL: c-c++-common/builtin-clear-padding-3.c -std=gnu++17 (test for errors, line 5) FAIL: c-c++-common/builtin-clear-padding-3.c -std=gnu++17 (test for excess errors) FAIL: c-c++-common/builtin-clear-padding-3.c -std=gnu++20 (test for errors, line 5) FAIL: c-c++-common/builtin-clear-padding-3.c -std=gnu++20 (test for excess errors) FAIL: c-c++-common/builtin-clear-padding-3.c -std=gnu++98 (test for errors, line 5) ... and 259 more entries

You can find the failure logs in *.log.1.xz files in - https://ci.linaro.org/job/tcwg_gcc_check--master-arm-precommit/6897/artifact... The full lists of regressions and progressions as well as configure and make commands are in - https://ci.linaro.org/job/tcwg_gcc_check--master-arm-precommit/6897/artifact... The list of [ignored] baseline and flaky failures are in - https://ci.linaro.org/job/tcwg_gcc_check--master-arm-precommit/6897/artifact...

The configuration of this build is: CI config tcwg_gcc_check master-arm

-----------------8<--------------------------8<--------------------------8<-------------------------- The information below can be used to reproduce a debug environment:

Current build : https://ci.linaro.org/job/tcwg_gcc_check--master-arm-precommit/6897/artifact... Reference build : https://ci.linaro.org/job/tcwg_gcc_check--master-arm-build/1997/artifact/art...

Warning: we do not enable maintainer-mode nor automatically update generated files, which may lead to failures if the patch modifies the master files.

_______________________________________________ linaro-toolchain mailing list -- linaro-toolchain@lists.linaro.org To unsubscribe send an email to linaro-toolchain-leave@lists.linaro.org