On Wed, Jan 11, 2017 at 02:05:59PM +0100, Marcin Wojtas wrote:
Hi Leif
2017-01-11 13:46 GMT+01:00 Leif Lindholm leif.lindholm@linaro.org:
On Thu, Jan 05, 2017 at 12:03:39PM +0100, Marcin Wojtas wrote:
This patch enables per-interface configuration of used bus width. For this purpose new PCD is added (PcdXenon8BitBusEnable). Porting guide documentation is updated accordingly.
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Marcin Wojtas mw@semihalf.com
Documentation/Marvell/PortingGuide/Xenon.txt | 7 +++++++ Drivers/SdMmc/XenonDxe/SdMmcPciHcDxe.c | 7 ++++++- Drivers/SdMmc/XenonDxe/SdMmcPciHcDxe.inf | 1 + Platforms/Marvell/Marvell.dec | 1 + 4 files changed, 15 insertions(+), 1 deletion(-)
diff --git a/Documentation/Marvell/PortingGuide/Xenon.txt b/Documentation/Marvell/PortingGuide/Xenon.txt index 566884b..297e179 100644 --- a/Documentation/Marvell/PortingGuide/Xenon.txt +++ b/Documentation/Marvell/PortingGuide/Xenon.txt @@ -12,6 +12,10 @@ PciEmulation driver (see Documentation/Marvell/PortingGuide/PciEmulation.txt):
Indicates, whether the interface is supplied with 1.8V.
- gMarvellTokenSpaceGuid.PcdXenon8BitBusEnable
+Indicates, whether the interface is using 8-bit bus.
No ','. What is used if the bus is not 8-bit?
Highest from what SD/MMC can negotiate with card - in EmmcDevice.c configuration is done with 1bit and then there is attempt to switch to 4 or 8 bits, depending on Private->Capability[Slot].BusWidth8 value.
No, just a clarification of the documentation: "Indicates whether the interface is using an 8-bit bus or (the default) a 4-bit bus."
In SdDevice.c however, the field is ignored and the driver attempts always to switch from 1bit to 4bits. In such circumstances, do you wish any changes around this PCD?
If there is a good reason for that difference in behaviour, then I'd say a further comment of "Note: the SD driver supports a maximum of 4-bit bus and will ignore this setting." is motivated.
/ Leif