On 23 November 2016 at 17:14, Ard Biesheuvel ard.biesheuvel@linaro.org wrote:
Hi Haojian,
Thanks a lot for sticking with this.
On 23 November 2016 at 07:12, Haojian Zhuang haojian.zhuang@linaro.org wrote:
Only add the skeleton of HiKey platform.
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang haojian.zhuang@linaro.org
Chips/Hisilicon/Hi6220/Hi6220.dec | 33 ++ Chips/Hisilicon/Hi6220/Include/Hi6220.h | 75 +++ Platforms/Hisilicon/HiKey/HiKey.dec | 42 ++ Platforms/Hisilicon/HiKey/HiKey.dsc | 503 +++++++++++++++++++++ Platforms/Hisilicon/HiKey/HiKey.fdf | 352 ++++++++++++++ Platforms/Hisilicon/HiKey/Include/ArmPlatform.h | 27 ++ Platforms/Hisilicon/HiKey/Library/HiKeyLib/HiKey.c | 160 +++++++ .../Hisilicon/HiKey/Library/HiKeyLib/HiKeyHelper.S | 49 ++ .../Hisilicon/HiKey/Library/HiKeyLib/HiKeyLib.inf | 54 +++ .../Hisilicon/HiKey/Library/HiKeyLib/HiKeyMem.c | 210 +++++++++ 10 files changed, 1505 insertions(+)
+STATIC struct HiKeyReservedMemory {
- EFI_PHYSICAL_ADDRESS Offset;
- EFI_PHYSICAL_ADDRESS Size;
+} HiKeyReservedMemoryBuffer [] = {
- { 0x05E00000, 0x00100000 }, // MCU
- { 0x05F01000, 0x00001000 }, // ADB REBOOT "REASON"
- { 0x06DFF000, 0x00001000 }, // MAILBOX
- { 0x0740F000, 0x00001000 }, // MAILBOX
- { 0x21F00000, 0x00100000 }, // PSTORE/RAMOOPS
- { 0x3E000000, 0x02000000 } // TEE OS
+};
Why are these spread out like this? Can't you use an adjacent set of reserved regions?
Oh. These are not defined by me. Some are defined by firmware, and others are defined by other guys. If I change anything, it'll break the existing system.
Best Regards Haojian