April 2018 - Linux-kselftest-mirror

by Randy Dunlap

Hi, I was having trouble with the use of the gcc -no-pie option in tools/testing/selftests/x86: (option not supported) CFLAGS := -O2 -g -std=gnu99 -pthread -Wall -no-pie so I looked for an archive of linux-kselftest(a)vger.kernel.org. http://vger.kernel.org/vger-lists.html lists all mailing lists and (some of) their archives, but none for linux-kselftest. Anyway, I checked www.spinics.net for an archive and there it was. (1) Is it OK to ask DaveM to list http://www.spinics.net/lists/linux-kselftest/ at http://vger.kernel.org/vger-lists.html#linux-kselftest ? (2) for this patch: http://www.spinics.net/lists/linux-kselftest/msg03136.html [PATCH] selftests/x86: Detect -no-pie availability Acked-by: Randy Dunlap <rdunlap(a)infradead.org> Tested-by: Randy Dunlap <rdunlap(a)infradead.org> What is the status of this patch? thanks, -- ~Randy -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

6 years, 7 months

4
5
0 0

[PATCH] kselftests: fix grammar and non-ASCII space

by Randy Dunlap

From: Randy Dunlap <rdunlap(a)infradead.org> This is a small cleanup to kselftest.rst: - Fix some language typos in the usage instructions. - Change one non-ASCII space to an ASCII space. Signed-off-by: Randy Dunlap <rdunlap(a)infradead.org> --- Documentation/dev-tools/kselftest.rst | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) --- linux-next-20180426.orig/Documentation/dev-tools/kselftest.rst +++ linux-next-20180426/Documentation/dev-tools/kselftest.rst @@ -9,7 +9,7 @@ and booting a kernel. On some systems, hot-plug tests could hang forever waiting for cpu and memory to be ready to be offlined. A special hot-plug target is created -to run full range of hot-plug tests. In default mode, hot-plug tests run +to run the full range of hot-plug tests. In default mode, hot-plug tests run in safe mode with a limited scope. In limited mode, cpu-hotplug test is run on a single cpu as opposed to all hotplug capable cpus, and memory hotplug test is run on 2% of hotplug capable memory instead of 10%. @@ -89,9 +89,9 @@ Note that some tests will require root p Install selftests ================= -You can use kselftest_install.sh tool installs selftests in default -location which is tools/testing/selftests/kselftest or a user specified -location. +You can use the kselftest_install.sh tool to install selftests in the +default location, which is tools/testing/selftests/kselftest, or in a +user specified location. To install selftests in default location:: @@ -109,7 +109,7 @@ Running installed selftests Kselftest install as well as the Kselftest tarball provide a script named "run_kselftest.sh" to run the tests. -You can simply do the following to run the installed Kselftests.Â Please +You can simply do the following to run the installed Kselftests. Please note some tests will require root privileges:: $ cd kselftest @@ -139,7 +139,7 @@ Contributing new tests (details) default. TEST_CUSTOM_PROGS should be used by tests that require custom build - rule and prevent common build rule use. + rules and prevent common build rule use. TEST_PROGS are for test shell scripts. Please ensure shell script has its exec bit set. Otherwise, lib.mk run_tests will generate a warning. -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

6 years, 7 months

1
0
0 0

[PATCH] doc: dev-tools: kselftest.rst: update contributing new tests

by Anders Roxell

Add a description that the kernel headers should be used as far as it is possible and then the system headers. Signed-off-by: Anders Roxell <anders.roxell(a)linaro.org> --- Documentation/dev-tools/kselftest.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/dev-tools/kselftest.rst b/Documentation/dev-tools/kselftest.rst index e80850eefe13..27f08d6ba91c 100644 --- a/Documentation/dev-tools/kselftest.rst +++ b/Documentation/dev-tools/kselftest.rst @@ -151,6 +151,9 @@ Contributing new tests (details) TEST_FILES, TEST_GEN_FILES mean it is the file which is used by test. + * First use the headers inside the kernel, and then the system headers. The + internal headers should be the primary focus to be able to find regressions. + Test Harness ============ -- 2.11.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

6 years, 7 months

3
4
0 0

[PATCH 4.17-rc2] selftests: Fix lib.mk run_tests target shell script

by Mathieu Desnoyers

Within run_tests target, the whole script needs to be executed within the same shell and not as separate subshells, so the initial test_num variable set to 0 is still present when executing "test_num=`echo $$test_num+1 | bc`;". Demonstration of the issue (make run_tests): TAP version 13 (standard_in) 1: syntax error selftests: basic_test ======================================== ok 1.. selftests: basic_test [PASS] (standard_in) 1: syntax error selftests: basic_percpu_ops_test ======================================== ok 1.. selftests: basic_percpu_ops_test [PASS] (standard_in) 1: syntax error selftests: param_test ======================================== ok 1.. selftests: param_test [PASS] With fix applied: TAP version 13 selftests: basic_test ======================================== ok 1..1 selftests: basic_test [PASS] selftests: basic_percpu_ops_test ======================================== ok 1..2 selftests: basic_percpu_ops_test [PASS] selftests: param_test ======================================== ok 1..3 selftests: param_test [PASS] Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers(a)efficios.com> Fixes: 1f87c7c15d7 ("selftests: lib.mk: change RUN_TESTS to print messages in TAP13 format") CC: Shuah Khan <shuahkh(a)osg.samsung.com> CC: linux-kselftest(a)vger.kernel.org --- tools/testing/selftests/lib.mk | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk index 195e9d4739a9..c1b1a4dc6a96 100644 --- a/tools/testing/selftests/lib.mk +++ b/tools/testing/selftests/lib.mk @@ -20,10 +20,10 @@ all: $(TEST_GEN_PROGS) $(TEST_GEN_PROGS_EXTENDED) $(TEST_GEN_FILES) .ONESHELL: define RUN_TESTS - @export KSFT_TAP_LEVEL=`echo 1`; - @test_num=`echo 0`; - @echo "TAP version 13"; - @for TEST in $(1); do \ + @export KSFT_TAP_LEVEL=`echo 1`; \ + test_num=`echo 0`; \ + echo "TAP version 13"; \ + for TEST in $(1); do \ BASENAME_TEST=`basename $$TEST`; \ test_num=`echo $$test_num+1 | bc`; \ echo "selftests: $$BASENAME_TEST"; \ -- 2.11.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

6 years, 7 months

2
1
0 0

Re: [PATCH 1/1] selftests: Fix lib.mk run_tests target shell script

by Mathieu Desnoyers

----- On Nov 1, 2017, at 6:28 PM, Shuah Khan shuahkh(a)osg.samsung.com wrote: > On 11/01/2017 04:24 PM, Mathieu Desnoyers wrote: >> ----- On Nov 1, 2017, at 6:22 PM, Mathieu Desnoyers >> mathieu.desnoyers(a)efficios.com wrote: >> >>> ----- On Nov 1, 2017, at 5:33 PM, Shuah Khan shuahkh(a)osg.samsung.com wrote: >>> >>>> On 10/28/2017 07:46 AM, Mathieu Desnoyers wrote: >>>>> Within run_tests target, the whole script needs to be executed within >>>>> the same shell and not as separate subshells, so the initial test_num >>>>> variable set to 0 is still present when executing "test_num=`echo >>>>> $$test_num+1 | bc`;". >>>>> >>>>> Demonstration of the issue (make run_tests): >>>>> >>>>> TAP version 13 >>>>> (standard_in) 1: syntax error >>>>> selftests: basic_test >>>>> ======================================== >>>>> ok 1.. selftests: basic_test [PASS] >>>>> (standard_in) 1: syntax error >>>>> selftests: basic_percpu_ops_test >>>>> ======================================== >>>>> ok 1.. selftests: basic_percpu_ops_test [PASS] >>>>> (standard_in) 1: syntax error >>>>> selftests: param_test >>>>> ======================================== >>>>> ok 1.. selftests: param_test [PASS] >>>> >>>> Hi Mathieu, >>>> >>>> Odd. I don't see the error. I am curious if this specific to >>>> env. Can you reproduce this with one of the existing tests, >>>> kcmp or breakpoints >>> >>> Yes, it reproduces: >>> >>> cd tools/testing/selftests/kcmp >>> make run_tests >>> gcc -I../../../../usr/include/ kcmp_test.c -o >>> /home/efficios/git/linux-rseq/tools/testing/selftests/kcmp/kcmp_test >>> TAP version 13 >>> (standard_in) 1: syntax error >>> selftests: kcmp_test >>> ======================================== >>> ok 1.. selftests: kcmp_test [PASS] >>> >>> cd tools/testing/selftests/breakpoints >>> make run_tests >>> gcc step_after_suspend_test.c -o >>> /home/efficios/git/linux-rseq/tools/testing/selftests/breakpoints/step_after_suspend_test >>> gcc breakpoint_test.c -o >>> /home/efficios/git/linux-rseq/tools/testing/selftests/breakpoints/breakpoint_test >>> TAP version 13 >>> (standard_in) 1: syntax error >>> selftests: step_after_suspend_test >>> ======================================== >>> not ok 1.. selftests: step_after_suspend_test [FAIL] >>> (standard_in) 1: syntax error >>> selftests: breakpoint_test >>> ======================================== >>> ok 1.. selftests: breakpoint_test [PASS] >>> >> >> The version of "make" on that machine is: >> >> make --version >> GNU Make 3.81 >> Copyright (C) 2006 Free Software Foundation, Inc. >> This is free software; see the source for copying conditions. >> There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A >> PARTICULAR PURPOSE. >> >> This program built for x86_64-pc-linux-gnu >> >> (if it helps reproducing) >> > > Yup that's it. I have > > GNU Make 4.1 > Built for x86_64-pc-linux-gnu > Copyright (C) 1988-2014 Free Software Foundation, Inc. > License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html> > This is free software: you are free to change and redistribute it. > There is NO WARRANTY, to the extent permitted by law. > > I will test with your patch and see what happens in my env. Hi, I still see the problem with v4.17-rc2. Did you have time to consider merging my fix ? Thanks, Mathieu > > thanks, > -- Shuah -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

6 years, 7 months

2
4
0 0

[PATCH] selftests: net: add in_netns.sh TEST_GEN_PROGS_EXTENDED

by Anders Roxell

Script in_netns.sh is a utility function and not its own test so it shouldn't be part of the TEST_PROGS. The in_netns.sh get used by run_afpackettests. To install in_netns.sh without being added to the main run_kselftest.sh script use the TEST_GEN_PROGS_EXTENDED variable. Fixes: 5ff9c1a3dd92 ("selftests: net: add in_netns.sh to TEST_PROGS") Signed-off-by: Anders Roxell <anders.roxell(a)linaro.org> --- tools/testing/selftests/net/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile index c3761c35f542..4a8cfe8071a7 100644 --- a/tools/testing/selftests/net/Makefile +++ b/tools/testing/selftests/net/Makefile @@ -5,7 +5,8 @@ CFLAGS = -Wall -Wl,--no-as-needed -O2 -g CFLAGS += -I../../../../usr/include/ TEST_PROGS := run_netsocktests run_afpackettests test_bpf.sh netdevice.sh rtnetlink.sh -TEST_PROGS += fib_tests.sh fib-onlink-tests.sh in_netns.sh pmtu.sh +TEST_PROGS += fib_tests.sh fib-onlink-tests.sh pmtu.sh +TEST_GEN_PROGS_EXTENDED := in_netns.sh TEST_GEN_FILES = socket TEST_GEN_FILES += psock_fanout psock_tpacket msg_zerocopy TEST_GEN_FILES += tcp_mmap -- 2.11.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

6 years, 7 months

2
3
0 0

possible BUG: selftest about raw_skew failed

by Jeffrin Thalakkottoor

hello, failure of a test in selftest:timers selftests: raw_skew ======================================== WARNING: ADJ_OFFSET in progress, this will cause inaccurate results Estimating clock drift: 17.910(est) 16.820(act) [FAILED] Bail out! Pass 0 Fail 0 Xfail 0 Xpass 0 Skip 0 Error 0 1..0 not ok 1..7 selftests: raw_skew [FAIL] To reproduce : make -C tools/testing/selftests/timers/ run_tests Linux debian 4.17.0-rc1+ #3 SMP Sat Apr 21 03:41:44 IST 2018 x86_64 GNU/Linux GNU Make 4.2.1 Binutils 2.30 Util-linux 2.31.1 Mount 2.31.1 Linux C Library 2.27 Dynamic linker (ldd) 2.27 readlink: missing operand Try 'readlink --help' for more information. Procps 3.3.14 Kbd 2.0.4 Console-tools 2.0.4 Sh-utils 8.28 Udev 238 -- software engineer rajagiri school of engineering and technology -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

6 years, 7 months

4
5
0 0

selftests: pstore_tests failed

by Naresh Kamboju

pstore_tests failed on x86_64 device. This test pass at your end ? If yes, what are pre-requirements ? Linux kernel version: 4.17.0-rc1 + ./pstore_tests === Pstore unit tests (pstore_tests) === UUID=ffa28670-e941-478a-a3c0-2fdad1df8195 Checking pstore backend is registered ... ok backend=(null) cmdline=root=/dev/nfs rw nfsroot=10.66.16.116: /var/lib/lava/dispatcher/tmp/198332/extract-nfsrootfs-yqsi5ya0,tcp,hard,intr backend=ramoops ramoops.mem_address=0x30000000 ramoops.mem_size=0x10000 ip=dhcp console=ttyS0,115200n8 lava_mac={LAVA_MAC} Checking pstore console is registered ... FAIL Checking /dev/pmsg0 exists ... FAIL Writing unique string to /dev/pmsg0 ... FAIL Following config enabled, CONFIG_EFI_VARS_PSTORE=y CONFIG_PSTORE=y CONFIG_PSTORE_DEFLATE_COMPRESS=y ONFIG_PSTORE_COMPRESS=y CONFIG_PSTORE_DEFLATE_COMPRESS_DEFAULT=y CONFIG_PSTORE_COMPRESS_DEFAULT="deflate" CONFIG_PSTORE_CONSOLE=y CONFIG_PSTORE_PMSG=y CONFIG_PSTORE_RAM=m Please suggest a way to get this working. Complete boot log and test details link, https://lkft.validation.linaro.org/scheduler/job/198332#L230 -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

6 years, 7 months

2
1
0 0

[PATCH v5 0/2] sparc64: Add privileged ADI driver

by Tom Hromatka

ADI is a feature supported on SPARC M7 and newer processors to allow hardware to catch rogue accesses to memory. ADI is supported for data fetches only and not instruction fetches. An app can enable ADI on its data pages, set version tags on them and use versioned addresses to access the data pages. Upper bits of the address contain the version tag. On M7 processors, upper four bits (bits 63-60) contain the version tag. If a rogue app attempts to access ADI enabled data pages, its access is blocked and processor generates an exception. Please see Documentation/sparc/adi.txt for further details. This patchset implements a char driver to read/write ADI versions from privileged user space processes. Intended consumers are makedumpfile and crash. v5: * Fixed MODULE_LICENSE() for adi.c v4: * Fixed messed up subject lines. v3: * Really fixed the copyright headers to use SPDX GPL v2. Really. v2: * Simplified copyright headers * Completely reworked sparc64 selftests Makefiles. Used the android selftests Makefiles as an example * Added run.sh and drivers_test.sh to the sparc64 selftest directory. Used bpf/test_kmod.sh and the android selftests as examples * Minor cleanups in the selftest adi-test.c * Added calls to ksft_test_*() in the adi-test.c Tom Hromatka (2): char: sparc64: Add privileged ADI driver selftests: sparc64: char: Selftest for privileged ADI driver drivers/char/Kconfig | 12 + drivers/char/Makefile | 1 + drivers/char/adi.c | 240 +++++++ tools/testing/selftests/Makefile | 1 + tools/testing/selftests/sparc64/Makefile | 46 ++ tools/testing/selftests/sparc64/drivers/.gitignore | 1 + tools/testing/selftests/sparc64/drivers/Makefile | 15 + tools/testing/selftests/sparc64/drivers/adi-test.c | 721 +++++++++++++++++++++ .../selftests/sparc64/drivers/drivers_test.sh | 30 + tools/testing/selftests/sparc64/run.sh | 3 + 10 files changed, 1070 insertions(+) create mode 100644 drivers/char/adi.c create mode 100644 tools/testing/selftests/sparc64/Makefile create mode 100644 tools/testing/selftests/sparc64/drivers/.gitignore create mode 100644 tools/testing/selftests/sparc64/drivers/Makefile create mode 100644 tools/testing/selftests/sparc64/drivers/adi-test.c create mode 100755 tools/testing/selftests/sparc64/drivers/drivers_test.sh create mode 100755 tools/testing/selftests/sparc64/run.sh -- 2.15.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

6 years, 7 months

3
6
0 0

Re: [PATCH] selftests:firmware: fixes a call to a wrong function name

by Kees Cook

On Mon, Apr 23, 2018 at 7:10 AM, Jeffrin Jose T <ahiliation(a)yahoo.co.in> wrote: > This is a patch to the tools/testing/selftests/firmware/fw_run_tests.sh > file which fixes a bug which calls to a wrong function name,which in turn > blocks the execution of certain tests. > > Signed-off-by: Jeffrin Jose T <jeffrin(a)rajagiritech.edu.in> > > --- > tools/testing/selftests/firmware/fw_run_tests.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/firmware/fw_run_tests.sh b/tools/testing/selftests/firmware/fw_run_tests.sh > index 06d638e9dc62..cffdd4eb0a57 100755 > --- a/tools/testing/selftests/firmware/fw_run_tests.sh > +++ b/tools/testing/selftests/firmware/fw_run_tests.sh > @@ -66,5 +66,5 @@ if [ -f $FW_FORCE_SYSFS_FALLBACK ]; then > run_test_config_0003 > else > echo "Running basic kernel configuration, working with your config" > - run_test > + run_tests > fi I find it confusing that run_tests() uses $1 and $2 but later ignores them unless -f $FW_FORCE_SYSFS_FALLBACK, which is checked at both the top level and in proc_set_*_fallback()... I'd expected the test to happen only in run_tests() and have it removed from from proc_set_*_fallback(). Regardless, the above patch is correct to run the tests. :) Acked-by: Kees Cook <keescook(a)chromium.org> -Kees -- Kees Cook Pixel Security -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

6 years, 8 months

3
2
0 0

2024

2023

2022

2021

2020

2019

2018

2017

Linux-kselftest-mirror April 2018