April 2020 - Linux-kselftest-mirror

selftests/bpf: test_maps: libbpf: Error loading .BTF into kernel: -22. Failed to load SK_SKB verdict prog

by Paolo Pisati

test_maps fails consistently on x86-64 5.4.y (5.4.31 and defconfig + tools/testing/selftests/bpf/config in this case) and dumps this output: ~/linux/tools/testing/selftests/bpf$ sudo ./test_maps libbpf: Error loading BTF: Invalid argument(22) libbpf: magic: 0xeb9f version: 1 flags: 0x0 hdr_len: 24 type_off: 0 type_len: 780 str_off: 780 str_len: 854 btf_total_size: 1658 [1] PTR (anon) type_id=2 [2] STRUCT __sk_buff size=176 vlen=31 len type_id=3 bits_offset=0 pkt_type type_id=3 bits_offset=32 mark type_id=3 bits_offset=64 queue_mapping type_id=3 bits_offset=96 protocol type_id=3 bits_offset=128 vlan_present type_id=3 bits_offset=160 vlan_tci type_id=3 bits_offset=192 vlan_proto type_id=3 bits_offset=224 priority type_id=3 bits_offset=256 ingress_ifindex type_id=3 bits_offset=288 ifindex type_id=3 bits_offset=320 tc_index type_id=3 bits_offset=352 cb type_id=5 bits_offset=384 hash type_id=3 bits_offset=544 tc_classid type_id=3 bits_offset=576 data type_id=3 bits_offset=608 data_end type_id=3 bits_offset=640 napi_id type_id=3 bits_offset=672 family type_id=3 bits_offset=704 remote_ip4 type_id=3 bits_offset=736 local_ip4 type_id=3 bits_offset=768 remote_ip6 type_id=7 bits_offset=800 local_ip6 type_id=7 bits_offset=928 remote_port type_id=3 bits_offset=1056 local_port type_id=3 bits_offset=1088 data_meta type_id=3 bits_offset=1120 (anon) type_id=8 bits_offset=1152 tstamp type_id=10 bits_offset=1216 wire_len type_id=3 bits_offset=1280 gso_segs type_id=3 bits_offset=1312 (anon) type_id=12 bits_offset=1344 [3] TYPEDEF __u32 type_id=4 [4] INT unsigned int size=4 bits_offset=0 nr_bits=32 encoding=(none) [5] ARRAY (anon) type_id=3 index_type_id=6 nr_elems=5 [6] INT __ARRAY_SIZE_TYPE__ size=4 bits_offset=0 nr_bits=32 encoding=(none) [7] ARRAY (anon) type_id=3 index_type_id=6 nr_elems=4 [8] UNION (anon) size=8 vlen=1 flow_keys type_id=9 bits_offset=0 [9] PTR (anon) type_id=23 [10] TYPEDEF __u64 type_id=11 [11] INT long long unsigned int size=8 bits_offset=0 nr_bits=64 encoding=(none) [12] UNION (anon) size=8 vlen=1 sk type_id=13 bits_offset=0 [13] PTR (anon) type_id=24 [14] FUNC_PROTO (anon) return=15 args=(1 skb) [15] INT int size=4 bits_offset=0 nr_bits=32 encoding=SIGNED [16] FUNC bpf_prog1 type_id=14 vlen != 0 libbpf: Error loading .BTF into kernel: -22. libbpf: Error loading BTF: Invalid argument(22) libbpf: magic: 0xeb9f version: 1 flags: 0x0 hdr_len: 24 type_off: 0 type_len: 440 str_off: 440 str_len: 564 btf_total_size: 1028 [1] PTR (anon) type_id=2 [2] STRUCT sk_msg_md size=72 vlen=10 (anon) type_id=3 bits_offset=0 (anon) type_id=5 bits_offset=64 family type_id=6 bits_offset=128 remote_ip4 type_id=6 bits_offset=160 local_ip4 type_id=6 bits_offset=192 remote_ip6 type_id=8 bits_offset=224 local_ip6 type_id=8 bits_offset=352 remote_port type_id=6 bits_offset=480 local_port type_id=6 bits_offset=512 size type_id=6 bits_offset=544 [3] UNION (anon) size=8 vlen=1 data type_id=4 bits_offset=0 [4] PTR (anon) type_id=0 [5] UNION (anon) size=8 vlen=1 data_end type_id=4 bits_offset=0 [6] TYPEDEF __u32 type_id=7 [7] INT unsigned int size=4 bits_offset=0 nr_bits=32 encoding=(none) [8] ARRAY (anon) type_id=6 index_type_id=9 nr_elems=4 [9] INT __ARRAY_SIZE_TYPE__ size=4 bits_offset=0 nr_bits=32 encoding=(none) [10] FUNC_PROTO (anon) return=11 args=(1 msg) [11] INT int size=4 bits_offset=0 nr_bits=32 encoding=SIGNED [12] FUNC bpf_prog1 type_id=10 vlen != 0 libbpf: Error loading .BTF into kernel: -22. libbpf: Error loading BTF: Invalid argument(22) libbpf: magic: 0xeb9f version: 1 flags: 0x0 hdr_len: 24 type_off: 0 type_len: 1300 str_off: 1300 str_len: 907 btf_total_size: 2231 [1] STRUCT (anon) size=32 vlen=4 type type_id=2 bits_offset=0 max_entries type_id=6 bits_offset=64 key_size type_id=8 bits_offset=128 value_size type_id=8 bits_offset=192 [2] PTR (anon) type_id=4 [3] INT int size=4 bits_offset=0 nr_bits=32 encoding=SIGNED [4] ARRAY (anon) type_id=3 index_type_id=5 nr_elems=15 [5] INT __ARRAY_SIZE_TYPE__ size=4 bits_offset=0 nr_bits=32 encoding=(none) [6] PTR (anon) type_id=7 [7] ARRAY (anon) type_id=3 index_type_id=5 nr_elems=20 [8] PTR (anon) type_id=9 [9] ARRAY (anon) type_id=3 index_type_id=5 nr_elems=4 [10] VAR sock_map_rx type_id=1 linkage=1 [11] STRUCT (anon) size=32 vlen=4 type type_id=2 bits_offset=0 max_entries type_id=6 bits_offset=64 key_size type_id=8 bits_offset=128 value_size type_id=8 bits_offset=192 [12] VAR sock_map_tx type_id=11 linkage=1 [13] STRUCT (anon) size=32 vlen=4 type type_id=2 bits_offset=0 max_entries type_id=6 bits_offset=64 key_size type_id=8 bits_offset=128 value_size type_id=8 bits_offset=192 [14] VAR sock_map_msg type_id=13 linkage=1 [15] STRUCT (anon) size=32 vlen=4 type type_id=16 bits_offset=0 max_entries type_id=6 bits_offset=64 key type_id=18 bits_offset=128 value type_id=18 bits_offset=192 [16] PTR (anon) type_id=17 [17] ARRAY (anon) type_id=3 index_type_id=5 nr_elems=2 [18] PTR (anon) type_id=3 [19] VAR sock_map_break type_id=15 linkage=1 [20] PTR (anon) type_id=21 [21] STRUCT __sk_buff size=176 vlen=31 len type_id=22 bits_offset=0 pkt_type type_id=22 bits_offset=32 mark type_id=22 bits_offset=64 queue_mapping type_id=22 bits_offset=96 protocol type_id=22 bits_offset=128 vlan_present type_id=22 bits_offset=160 vlan_tci type_id=22 bits_offset=192 vlan_proto type_id=22 bits_offset=224 priority type_id=22 bits_offset=256 ingress_ifindex type_id=22 bits_offset=288 ifindex type_id=22 bits_offset=320 tc_index type_id=22 bits_offset=352 cb type_id=24 bits_offset=384 hash type_id=22 bits_offset=544 tc_classid type_id=22 bits_offset=576 data type_id=22 bits_offset=608 data_end type_id=22 bits_offset=640 napi_id type_id=22 bits_offset=672 family type_id=22 bits_offset=704 remote_ip4 type_id=22 bits_offset=736 local_ip4 type_id=22 bits_offset=768 remote_ip6 type_id=25 bits_offset=800 local_ip6 type_id=25 bits_offset=928 remote_port type_id=22 bits_offset=1056 local_port type_id=22 bits_offset=1088 data_meta type_id=22 bits_offset=1120 (anon) type_id=26 bits_offset=1152 tstamp type_id=28 bits_offset=1216 wire_len type_id=22 bits_offset=1280 gso_segs type_id=22 bits_offset=1312 (anon) type_id=30 bits_offset=1344 [22] TYPEDEF __u32 type_id=23 [23] INT unsigned int size=4 bits_offset=0 nr_bits=32 encoding=(none) [24] ARRAY (anon) type_id=22 index_type_id=5 nr_elems=5 [25] ARRAY (anon) type_id=22 index_type_id=5 nr_elems=4 [26] UNION (anon) size=8 vlen=1 flow_keys type_id=27 bits_offset=0 [27] PTR (anon) type_id=41 [28] TYPEDEF __u64 type_id=29 [29] INT long long unsigned int size=8 bits_offset=0 nr_bits=64 encoding=(none) [30] UNION (anon) size=8 vlen=1 sk type_id=31 bits_offset=0 [31] PTR (anon) type_id=42 [32] FUNC_PROTO (anon) return=3 args=(20 skb) [33] FUNC bpf_prog2 type_id=32 vlen != 0 libbpf: Error loading .BTF into kernel: -22. Failed to load SK_SKB verdict prog ~/linux/tools/testing/selftests/bpf$ find . -name sockmap_\*prog.o ./sockmap_verdict_prog.o ./sockmap_tcp_msg_prog.o ./alu32/sockmap_verdict_prog.o ./alu32/sockmap_tcp_msg_prog.o ./alu32/sockmap_parse_prog.o ./sockmap_parse_prog.o $ dpkg -l | grep clang ii clang 1:10.0-50~exp1 amd64 C, C++ and Objective-C compiler (LLVM based) ii clang-10 1:10.0.0-2ubuntu2 amd64 C, C++ and Objective-C compiler ii libclang-common-10-dev 1:10.0.0-2ubuntu2 amd64 Clang library - Common development package ii libclang-cpp10 1:10.0.0-2ubuntu2 amd64 C++ interface to the Clang library ii libclang1-10 1:10.0.0-2ubuntu2 amd64 C interface to the Clang library Full log of "TARGETS=bpf run_tests" is available here: https://paste.ubuntu.com/p/MTkWD63Zgc/ -- bye, p.

5 years

2
1
0 0

[PATCH] Revert "Kernel selftests: tpm2: check for tpm support"

by Jarkko Sakkinen

This reverts commit b32694cd0724d4ceca2c62cc7c3d3a8d1ffa11fc. The original comment was neither reviewed nor tested. Thus, this the *only* possible action to take. Cc: Nikita Sobolev <Nikita.Sobolev(a)synopsys.com> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen(a)linux.intel.com> --- tools/testing/selftests/tpm2/test_smoke.sh | 13 ++----------- tools/testing/selftests/tpm2/test_space.sh | 9 +-------- 2 files changed, 3 insertions(+), 19 deletions(-) diff --git a/tools/testing/selftests/tpm2/test_smoke.sh b/tools/testing/selftests/tpm2/test_smoke.sh index b630c7b5950a..8155c2ea7ccb 100755 --- a/tools/testing/selftests/tpm2/test_smoke.sh +++ b/tools/testing/selftests/tpm2/test_smoke.sh @@ -1,17 +1,8 @@ #!/bin/bash # SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) -self.flags = flags -# Kselftest framework requirement - SKIP code is 4. -ksft_skip=4 - - -if [ -f /dev/tpm0 ] ; then - python -m unittest -v tpm2_tests.SmokeTest - python -m unittest -v tpm2_tests.AsyncTest -else - exit $ksft_skip -fi +python -m unittest -v tpm2_tests.SmokeTest +python -m unittest -v tpm2_tests.AsyncTest CLEAR_CMD=$(which tpm2_clear) if [ -n $CLEAR_CMD ]; then diff --git a/tools/testing/selftests/tpm2/test_space.sh b/tools/testing/selftests/tpm2/test_space.sh index 180b469c53b4..a6f5e346635e 100755 --- a/tools/testing/selftests/tpm2/test_space.sh +++ b/tools/testing/selftests/tpm2/test_space.sh @@ -1,11 +1,4 @@ #!/bin/bash # SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) -# Kselftest framework requirement - SKIP code is 4. -ksft_skip=4 - -if [ -f /dev/tpmrm0 ] ; then - python -m unittest -v tpm2_tests.SpaceTest -else - exit $ksft_skip -fi +python -m unittest -v tpm2_tests.SpaceTest -- 2.25.1

5 years

2
5
0 0

[PATCH 0/1] selftests: kvm: Overlapped memory regions test

by Wainer dos Santos Moschetta

This introduces a test case to check memory slots with overlapped regions on the guest address cannot be added. The cases checked are described in the block comment upon test_overlap_memory_regions() (see the patch 01). I didn't see the need to calcute the addresses on compile/run-time, so I just left them hard-coded (remember: aligned 1M to work on s390x). It works on x86_64, aarch64, and s390x. The patch is based on queue branch. Ah, I did some cosmetic changes on test_add_max_memory_regions() too. If it is not OK to be in a single patch...let me know. Wainer dos Santos Moschetta (1): selftests: kvm: Add overlapped memory regions test .../selftests/kvm/set_memory_region_test.c | 75 ++++++++++++++++++- 1 file changed, 74 insertions(+), 1 deletion(-) -- 2.17.2

5 years

3
3
0 0

[PATCH AUTOSEL 5.5 04/66] Kernel selftests: tpm2: check for tpm support

by Sasha Levin

From: Nikita Sobolev <Nikita.Sobolev(a)synopsys.com> [ Upstream commit b32694cd0724d4ceca2c62cc7c3d3a8d1ffa11fc ] tpm2 tests set fails if there is no /dev/tpm0 and /dev/tpmrm0 supported. Check if these files exist before run and mark test as skipped in case of absence. Signed-off-by: Nikita Sobolev <Nikita.Sobolev(a)synopsys.com> Signed-off-by: Shuah Khan <skhan(a)linuxfoundation.org> Signed-off-by: Sasha Levin <sashal(a)kernel.org> --- tools/testing/selftests/tpm2/test_smoke.sh | 13 +++++++++++-- tools/testing/selftests/tpm2/test_space.sh | 9 ++++++++- 2 files changed, 19 insertions(+), 3 deletions(-) diff --git a/tools/testing/selftests/tpm2/test_smoke.sh b/tools/testing/selftests/tpm2/test_smoke.sh index 8155c2ea7ccbb..b630c7b5950a9 100755 --- a/tools/testing/selftests/tpm2/test_smoke.sh +++ b/tools/testing/selftests/tpm2/test_smoke.sh @@ -1,8 +1,17 @@ #!/bin/bash # SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) +self.flags = flags -python -m unittest -v tpm2_tests.SmokeTest -python -m unittest -v tpm2_tests.AsyncTest +# Kselftest framework requirement - SKIP code is 4. +ksft_skip=4 + + +if [ -f /dev/tpm0 ] ; then + python -m unittest -v tpm2_tests.SmokeTest + python -m unittest -v tpm2_tests.AsyncTest +else + exit $ksft_skip +fi CLEAR_CMD=$(which tpm2_clear) if [ -n $CLEAR_CMD ]; then diff --git a/tools/testing/selftests/tpm2/test_space.sh b/tools/testing/selftests/tpm2/test_space.sh index a6f5e346635e5..180b469c53b47 100755 --- a/tools/testing/selftests/tpm2/test_space.sh +++ b/tools/testing/selftests/tpm2/test_space.sh @@ -1,4 +1,11 @@ #!/bin/bash # SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) -python -m unittest -v tpm2_tests.SpaceTest +# Kselftest framework requirement - SKIP code is 4. +ksft_skip=4 + +if [ -f /dev/tpmrm0 ] ; then + python -m unittest -v tpm2_tests.SpaceTest +else + exit $ksft_skip +fi -- 2.20.1

5 years

3
2
0 0

[PATCH v16 00/10] Landlock LSM

by Mickaël Salaün

Hi, This new patch series brings some improvements while simplifying the code, fixes some bugs and adds more tests: Use a bitfield of layers to properly manage superset and subset of access rights, whatever their order in the stack of layers [1]. Allow to open pipes and similar special files through /proc/self/fd, as well as internal filesystems such as nsfs through /proc/self/ns, because disconnected path cannot be evaluated. Such special filesystems could be handled with a future evolution. For the sake of simplicity, forbid reparenting when linking or renaming to protect against possible privilege escalation. This could happen by changing the hierarchy of a file or directory in relation to an enforced access policy (from the set of layers). This will be relaxed in the future with more complex code. Rename the unlink and rmdir access rights to a more generic ones: remove_dir and remove_file. Indeed it makes sense to also use them for the action of renaming a file or a directory, which may lead to the removal of the source file or directory. Replace the link_to, rename_from and rename_to access rights with remove_file, remove_dir and make_* . Add multiple tests to check semantic, and improve test coverage for security/landlock to 94.1% of lines (best possible with deterministic user space tests). Add current limitations to documentation: file renaming and linking, OverlayFS and special filesystems (e.g. nsfs). The previously identified memory accounting limitation can already be solved with the (kernel) Memory Resource Controller from cgroup. The SLOC count is 1267 for security/landlock/ and 1643 for tools/testing/selftest/landlock/ . The compiled documentation is available here: https://landlock.io/linux-doc/landlock-v16/security/landlock/index.html This series can be applied on top of v5.7-rc1. This can be tested with CONFIG_SECURITY_LANDLOCK and CONFIG_SAMPLE_LANDLOCK. This patch series can be found in a Git repository here: https://github.com/landlock-lsm/linux/commits/landlock-v16 I would really appreciate constructive comments on this patch series. # Landlock LSM The goal of Landlock is to enable to restrict ambient rights (e.g. global filesystem access) for a set of processes. Because Landlock is a stackable LSM [2], it makes possible to create safe security sandboxes as new security layers in addition to the existing system-wide access-controls. This kind of sandbox is expected to help mitigate the security impact of bugs or unexpected/malicious behaviors in user-space applications. Landlock empowers any process, including unprivileged ones, to securely restrict themselves. Landlock is inspired by seccomp-bpf but instead of filtering syscalls and their raw arguments, a Landlock rule can restrict the use of kernel objects like file hierarchies, according to the kernel semantic. Landlock also takes inspiration from other OS sandbox mechanisms: XNU Sandbox, FreeBSD Capsicum or OpenBSD Pledge/Unveil. Previous version: https://lore.kernel.org/lkml/20200326202731.693608-1-mic@digikod.net/ [1] https://lore.kernel.org/lkml/e07fe473-1801-01cc-12ae-b3167f95250e@digikod.n… [2] https://lore.kernel.org/lkml/50db058a-7dde-441b-a7f9-f6837fe8b69f@schaufler… Regards, Mickaël Salaün (10): landlock: Add object management landlock: Add ruleset and domain management landlock: Set up the security framework and manage credentials landlock: Add ptrace restrictions fs,landlock: Support filesystem access-control landlock: Add syscall implementation arch: Wire up landlock() syscall selftests/landlock: Add initial tests samples/landlock: Add a sandbox manager example landlock: Add user and kernel documentation Documentation/security/index.rst | 1 + Documentation/security/landlock/index.rst | 18 + Documentation/security/landlock/kernel.rst | 69 + Documentation/security/landlock/user.rst | 268 +++ MAINTAINERS | 12 + arch/alpha/kernel/syscalls/syscall.tbl | 1 + arch/arm/tools/syscall.tbl | 1 + arch/arm64/include/asm/unistd.h | 2 +- arch/arm64/include/asm/unistd32.h | 2 + arch/ia64/kernel/syscalls/syscall.tbl | 1 + arch/m68k/kernel/syscalls/syscall.tbl | 1 + arch/microblaze/kernel/syscalls/syscall.tbl | 1 + arch/mips/kernel/syscalls/syscall_n32.tbl | 1 + arch/mips/kernel/syscalls/syscall_n64.tbl | 1 + arch/mips/kernel/syscalls/syscall_o32.tbl | 1 + arch/parisc/kernel/syscalls/syscall.tbl | 1 + arch/powerpc/kernel/syscalls/syscall.tbl | 1 + arch/s390/kernel/syscalls/syscall.tbl | 1 + arch/sh/kernel/syscalls/syscall.tbl | 1 + arch/sparc/kernel/syscalls/syscall.tbl | 1 + arch/x86/entry/syscalls/syscall_32.tbl | 1 + arch/x86/entry/syscalls/syscall_64.tbl | 1 + arch/xtensa/kernel/syscalls/syscall.tbl | 1 + fs/super.c | 2 + include/linux/fs.h | 5 + include/linux/landlock.h | 22 + include/linux/syscalls.h | 3 + include/uapi/asm-generic/unistd.h | 4 +- include/uapi/linux/landlock.h | 296 +++ kernel/sys_ni.c | 3 + samples/Kconfig | 7 + samples/Makefile | 1 + samples/landlock/.gitignore | 1 + samples/landlock/Makefile | 15 + samples/landlock/sandboxer.c | 228 +++ security/Kconfig | 11 +- security/Makefile | 2 + security/landlock/Kconfig | 18 + security/landlock/Makefile | 4 + security/landlock/common.h | 20 + security/landlock/cred.c | 46 + security/landlock/cred.h | 58 + security/landlock/fs.c | 601 ++++++ security/landlock/fs.h | 42 + security/landlock/object.c | 66 + security/landlock/object.h | 91 + security/landlock/ptrace.c | 120 ++ security/landlock/ptrace.h | 14 + security/landlock/ruleset.c | 344 ++++ security/landlock/ruleset.h | 161 ++ security/landlock/setup.c | 39 + security/landlock/setup.h | 18 + security/landlock/syscall.c | 501 +++++ tools/testing/selftests/Makefile | 1 + tools/testing/selftests/landlock/.gitignore | 4 + tools/testing/selftests/landlock/Makefile | 29 + tools/testing/selftests/landlock/common.h | 42 + tools/testing/selftests/landlock/config | 5 + tools/testing/selftests/landlock/test_base.c | 156 ++ tools/testing/selftests/landlock/test_fs.c | 1696 +++++++++++++++++ .../testing/selftests/landlock/test_ptrace.c | 291 +++ tools/testing/selftests/landlock/true.c | 5 + 62 files changed, 5353 insertions(+), 7 deletions(-) create mode 100644 Documentation/security/landlock/index.rst create mode 100644 Documentation/security/landlock/kernel.rst create mode 100644 Documentation/security/landlock/user.rst create mode 100644 include/linux/landlock.h create mode 100644 include/uapi/linux/landlock.h create mode 100644 samples/landlock/.gitignore create mode 100644 samples/landlock/Makefile create mode 100644 samples/landlock/sandboxer.c create mode 100644 security/landlock/Kconfig create mode 100644 security/landlock/Makefile create mode 100644 security/landlock/common.h create mode 100644 security/landlock/cred.c create mode 100644 security/landlock/cred.h create mode 100644 security/landlock/fs.c create mode 100644 security/landlock/fs.h create mode 100644 security/landlock/object.c create mode 100644 security/landlock/object.h create mode 100644 security/landlock/ptrace.c create mode 100644 security/landlock/ptrace.h create mode 100644 security/landlock/ruleset.c create mode 100644 security/landlock/ruleset.h create mode 100644 security/landlock/setup.c create mode 100644 security/landlock/setup.h create mode 100644 security/landlock/syscall.c create mode 100644 tools/testing/selftests/landlock/.gitignore create mode 100644 tools/testing/selftests/landlock/Makefile create mode 100644 tools/testing/selftests/landlock/common.h create mode 100644 tools/testing/selftests/landlock/config create mode 100644 tools/testing/selftests/landlock/test_base.c create mode 100644 tools/testing/selftests/landlock/test_fs.c create mode 100644 tools/testing/selftests/landlock/test_ptrace.c create mode 100644 tools/testing/selftests/landlock/true.c -- 2.26.1

5 years

1
10
0 0

[PATCH v5 0/4] KUnit-KASAN Integration

by David Gow

This patchset contains everything needed to integrate KASAN and KUnit. KUnit will be able to: (1) Fail tests when an unexpected KASAN error occurs (2) Pass tests when an expected KASAN error occurs Convert KASAN tests to KUnit with the exception of copy_user_test because KUnit is unable to test those. Add documentation on how to run the KASAN tests with KUnit and what to expect when running these tests. Depends on "[PATCH v3 kunit-next 0/2] kunit: extend kunit resources API" patchset [1] Changes from v4: - KASAN no longer will panic on errors if both panic_on_warn and kasan_multishot are enabled. - As a result, the KASAN tests will no-longer disable panic_on_warn. - This also means panic_on_warn no-longer needs to be exported. - The use of temporary "kasan_data" variables has been cleaned up somewhat. - A potential refcount/resource leak should multiple KASAN errors appear during an assertion was fixed. - Some wording changes to the KASAN test Kconfig entries. Changes from v3: - KUNIT_SET_KASAN_DATA and KUNIT_DO_EXPECT_KASAN_FAIL have been combined and included in KUNIT_DO_EXPECT_KASAN_FAIL() instead. - Reordered logic in kasan_update_kunit_status() in report.c to be easier to read. - Added comment to not use the name "kasan_data" for any kunit tests outside of KUNIT_EXPECT_KASAN_FAIL(). Changes since v2: - Due to Alan's changes in [1], KUnit can be built as a module. - The name of the tests that could not be run with KUnit has been changed to be more generic: test_kasan_module. - Documentation on how to run the new KASAN tests and what to expect when running them has been added. - Some variables and functions are now static. - Now save/restore panic_on_warn in a similar way to kasan_multi_shot and renamed the init/exit functions to be more generic to accommodate. - Due to [2] in kasan_strings, kasan_memchr, and kasan_memcmp will fail if CONFIG_AMD_MEM_ENCRYPT is enabled so return early and print message explaining this circumstance. - Changed preprocessor checks to C checks where applicable. Changes since v1: - Make use of Alan Maguire's suggestion to use his patch that allows static resources for integration instead of adding a new attribute to the kunit struct - All KUNIT_EXPECT_KASAN_FAIL statements are local to each test - The definition of KUNIT_EXPECT_KASAN_FAIL is local to the test_kasan.c file since it seems this is the only place this will be used. - Integration relies on KUnit being builtin - copy_user_test has been separated into its own file since KUnit is unable to test these. This can be run as a module just as before, using CONFIG_TEST_KASAN_USER - The addition to the current task has been separated into its own patch as this is a significant enough change to be on its own. [1] https://lore.kernel.org/linux-kselftest/1585313122-26441-1-git-send-email-a… [2] https://bugzilla.kernel.org/show_bug.cgi?id=206337 Patricia Alfonso (4): Add KUnit Struct to Current Task KUnit: KASAN Integration KASAN: Port KASAN Tests to KUnit KASAN: Testing Documentation Documentation/dev-tools/kasan.rst | 70 ++++ include/kunit/test.h | 5 + include/linux/kasan.h | 6 + include/linux/sched.h | 4 + lib/Kconfig.kasan | 18 +- lib/Makefile | 3 +- lib/kunit/test.c | 13 +- lib/test_kasan.c | 668 +++++++++++++----------------- lib/test_kasan_module.c | 76 ++++ mm/kasan/report.c | 34 +- 10 files changed, 504 insertions(+), 393 deletions(-) create mode 100644 lib/test_kasan_module.c -- 2.26.0.110.g2183baf09c-goog

5 years

2
9
0 0

[PATCH] test_firmware: remove unnecessary test_fw_mutex in test_dev_config_show_xxx

by Scott Branden

Remove unnecessary use of test_fw_mutex in test_dev_config_show_xxx functions that show simple bool, int, and u8. Signed-off-by: Scott Branden <scott.branden(a)broadcom.com> --- lib/test_firmware.c | 26 +++----------------------- 1 file changed, 3 insertions(+), 23 deletions(-) diff --git a/lib/test_firmware.c b/lib/test_firmware.c index 0c7fbcf07ac5..9fee2b93a8d1 100644 --- a/lib/test_firmware.c +++ b/lib/test_firmware.c @@ -310,27 +310,13 @@ static int test_dev_config_update_bool(const char *buf, size_t size, return ret; } -static ssize_t -test_dev_config_show_bool(char *buf, - bool config) +static ssize_t test_dev_config_show_bool(char *buf, bool val) { - bool val; - - mutex_lock(&test_fw_mutex); - val = config; - mutex_unlock(&test_fw_mutex); - return snprintf(buf, PAGE_SIZE, "%d\n", val); } -static ssize_t test_dev_config_show_int(char *buf, int cfg) +static ssize_t test_dev_config_show_int(char *buf, int val) { - int val; - - mutex_lock(&test_fw_mutex); - val = cfg; - mutex_unlock(&test_fw_mutex); - return snprintf(buf, PAGE_SIZE, "%d\n", val); } @@ -354,14 +340,8 @@ static int test_dev_config_update_u8(const char *buf, size_t size, u8 *cfg) return size; } -static ssize_t test_dev_config_show_u8(char *buf, u8 cfg) +static ssize_t test_dev_config_show_u8(char *buf, u8 val) { - u8 val; - - mutex_lock(&test_fw_mutex); - val = cfg; - mutex_unlock(&test_fw_mutex); - return snprintf(buf, PAGE_SIZE, "%u\n", val); } -- 2.17.1

5 years

3
4
0 0

[PATCH] hugetlb_cgroup: remove unused variable 'i'

by Ralph Campbell

Compiling tests in tools/testing/selftests/vm/ results in a C compiler warning: write_to_hugetlbfs.c: In function ‘main’: write_to_hugetlbfs.c:77:16: warning: unused variable ‘i’ 77 | unsigned long i; Delete the unused variable. Fixes: 29750f71a9b4 ("hugetlb_cgroup: add hugetlb_cgroup reservation tests") Signed-off-by: Ralph Campbell <rcampbell(a)nvidia.com> --- tools/testing/selftests/vm/write_to_hugetlbfs.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tools/testing/selftests/vm/write_to_hugetlbfs.c b/tools/testing/selftests/vm/write_to_hugetlbfs.c index 110bc4e4015d..6a2caba19ee1 100644 --- a/tools/testing/selftests/vm/write_to_hugetlbfs.c +++ b/tools/testing/selftests/vm/write_to_hugetlbfs.c @@ -74,8 +74,6 @@ int main(int argc, char **argv) int write = 0; int reserve = 1; - unsigned long i; - if (signal(SIGINT, sig_handler) == SIG_ERR) err(1, "\ncan't catch SIGINT\n"); -- 2.25.2

5 years

2
1
0 0

[PATCH v8 0/3] mm/hmm/test: add self tests for HMM

by Ralph Campbell

This series adds basic self tests for HMM and are intended for Jason Gunthorpe's rdma tree which has a number of HMM patches applied. Changes v7 -> v8: Rebased to Jason's rdma/hmm tree, plus Jason's 6 patch series "Small hmm_range_fault() cleanups". Applied a number of changes from Jason's comments. Changes v6 -> v7: Rebased to linux-5.6.0-rc6 Reverted back to just using mmu_interval_notifier_insert() and making this series only introduce HMM self tests. Changes v5 -> v6: Rebased to linux-5.5.0-rc6 Refactored mmu interval notifier patches Converted nouveau to use the new mmu interval notifier API Changes v4 -> v5: Added mmu interval notifier insert/remove/update callable from the invalidate() callback Updated HMM tests to use the new core interval notifier API Changes v1 -> v4: https://lore.kernel.org/linux-mm/20191104222141.5173-1-rcampbell@nvidia.com Ralph Campbell (3): mm/hmm/test: add selftest driver for HMM mm/hmm/test: add selftests for HMM MAINTAINERS: add HMM selftests MAINTAINERS | 3 + include/uapi/linux/test_hmm.h | 59 ++ lib/Kconfig.debug | 12 + lib/Makefile | 1 + lib/test_hmm.c | 1177 +++++++++++++++++++++ tools/testing/selftests/vm/.gitignore | 1 + tools/testing/selftests/vm/Makefile | 3 + tools/testing/selftests/vm/config | 2 + tools/testing/selftests/vm/hmm-tests.c | 1353 ++++++++++++++++++++++++ tools/testing/selftests/vm/run_vmtests | 16 + tools/testing/selftests/vm/test_hmm.sh | 97 ++ 11 files changed, 2724 insertions(+) create mode 100644 include/uapi/linux/test_hmm.h create mode 100644 lib/test_hmm.c create mode 100644 tools/testing/selftests/vm/hmm-tests.c create mode 100755 tools/testing/selftests/vm/test_hmm.sh -- 2.20.1

5 years

4
16
0 0

[PATCH v8 kunit-next 0/4] kunit: add debugfs representation to show results

by Alan Maguire

When kunit tests are run on native (i.e. non-UML) environments, the results of test execution are often intermixed with dmesg output. This patch series attempts to solve this by providing a debugfs representation of the results of the last test run, available as /sys/kernel/debug/kunit/<testsuite>/results Changes since v7: - renamed KUNIT_INDENT[2] to KUNIT_SUBTEST_INDENT, KUNIT_SUBSUBTEST_INDENT and added more description to their definitions to clarify why they are defined as they are (Shuah) - defined KUNIT_SUBSUBTEST_INDENT directly as 8 spaces to avoid checkpatch error (Shuah) Changes since v6: - fixed regexp parsing in kunit_parser.py to ensure test results are read successfully with 4-space indentation (Brendan, patch 3) Changes since v5: - replaced undefined behaviour use of snprintf(buf, ..., buf) in kunit_log() with a function to append string to existing log (Frank, patch 1) - added clarification on log size limitations to documentation (Frank, patch 4) Changes since v4: - added suite-level log expectations to kunit log test (Brendan, patch 2) - added log expectations (of it being NULL) for case where CONFIG_KUNIT_DEBUGFS=n to kunit log test (patch 2) - added patch 3 which replaces subtest tab indentation with 4 space indentation as per TAP 14 spec (Frank, patch 3) Changes since v3: - added CONFIG_KUNIT_DEBUGFS to support conditional compilation of debugfs representation, including string logging (Frank, patch 1) - removed unneeded NULL check for test_case in kunit_suite_for_each_test_case() (Frank, patch 1) - added kunit log test to verify logging multiple strings works (Frank, patch 2) - rephrased description of results file (Frank, patch 3) Changes since v2: - updated kunit_status2str() to kunit_status_to_string() and made it static inline in include/kunit/test.h (Brendan) - added log string to struct kunit_suite and kunit_case, with log pointer in struct kunit pointing at the case log. This allows us to collect kunit_[err|info|warning]() messages at the same time as we printk() them. This solves for the most part the sharing of log messages between test execution and debugfs since we just print the suite log (which contains the test suite preamble) and the individual test logs. The only exception is the suite-level status, which we cannot store in the suite log as it would mean we'd print the suite and its status prior to the suite's results. (Brendan, patch 1) - dropped debugfs-based kunit run patch for now so as not to cause problems with tests currently under development (Brendan) - fixed doc issues with code block (Brendan, patch 3) Changes since v1: - trimmed unneeded include files in lib/kunit/debugfs.c (Greg) - renamed global debugfs functions to be prefixed with kunit_ (Greg) - removed error checking for debugfs operations (Greg) Alan Maguire (4): kunit: add debugfs /sys/kernel/debug/kunit/<suite>/results display kunit: add log test kunit: subtests should be indented 4 spaces according to TAP kunit: update documentation to describe debugfs representation Documentation/dev-tools/kunit/usage.rst | 14 +++ include/kunit/test.h | 63 ++++++++++++-- lib/kunit/Kconfig | 8 ++ lib/kunit/Makefile | 4 + lib/kunit/assert.c | 79 ++++++++--------- lib/kunit/debugfs.c | 116 +++++++++++++++++++++++++ lib/kunit/debugfs.h | 30 +++++++ lib/kunit/kunit-test.c | 44 +++++++++- lib/kunit/test.c | 148 +++++++++++++++++++++++++------- tools/testing/kunit/kunit_parser.py | 10 +-- 10 files changed, 430 insertions(+), 86 deletions(-) create mode 100644 lib/kunit/debugfs.c create mode 100644 lib/kunit/debugfs.h -- 1.8.3.1

5 years

4
10
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-kselftest-mirror April 2020