May 2022 - Linux-kselftest-mirror

[PATCH v1] selftests/kselftest: Make failed tests exit with 1

by Mickaël Salaün

To check that tests are passing we must parse the kselftest runner output. It is much more convenient to check the return value of the runner instead: 0 is OK, and 1 implies one or more errors. This has an impact on the kselftest's gen_tar bundle and the run_tests make target. Backporting this change would be useful to consistently test older kernels as well. Cc: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> Cc: SeongJae Park <sjpark(a)amazon.de> Cc: Shuah Khan <shuah(a)kernel.org> Cc: stable(a)vger.kernel.org # 303f8e2d0200: selftests/kselftest/runner/run_one(): allow running non-executable files Signed-off-by: Mickaël Salaün <mic(a)digikod.net> Link: https://lore.kernel.org/r/20220527162417.2646998-1-mic@digikod.net --- tools/testing/selftests/kselftest/runner.sh | 36 +++++++++++++-------- tools/testing/selftests/run_kselftest.sh | 4 ++- 2 files changed, 26 insertions(+), 14 deletions(-) diff --git a/tools/testing/selftests/kselftest/runner.sh b/tools/testing/selftests/kselftest/runner.sh index 294619ade49f..f6488a53a78c 100644 --- a/tools/testing/selftests/kselftest/runner.sh +++ b/tools/testing/selftests/kselftest/runner.sh @@ -46,6 +46,8 @@ run_one() DIR="$1" TEST="$2" NUM="$3" + local rc=1 + local ret=1 BASENAME_TEST=$(basename $TEST) @@ -107,29 +109,36 @@ run_one() cmd="$interpreter ./$BASENAME_TEST" else echo "not ok $test_num $TEST_HDR_MSG" - return + return 1 fi fi cd `dirname $TEST` > /dev/null - ((((( tap_timeout "$cmd" 2>&1; echo $? >&3) | + if (((( tap_timeout "$cmd" 2>&1; echo $? >&3) | tap_prefix >&4) 3>&1) | - (read xs; exit $xs)) 4>>"$logfile" && - echo "ok $test_num $TEST_HDR_MSG") || - (rc=$?; \ - if [ $rc -eq $skip_rc ]; then \ - echo "ok $test_num $TEST_HDR_MSG # SKIP" - elif [ $rc -eq $timeout_rc ]; then \ - echo "#" - echo "not ok $test_num $TEST_HDR_MSG # TIMEOUT $kselftest_timeout seconds" + (read xs; exit $xs)) 4>>"$logfile"; then + echo "ok $test_num $TEST_HDR_MSG" + ret=0 else - echo "not ok $test_num $TEST_HDR_MSG # exit=$rc" - fi) + rc=$? + if [ $rc -eq $skip_rc ]; then + echo "ok $test_num $TEST_HDR_MSG # SKIP" + ret=0 + elif [ $rc -eq $timeout_rc ]; then + echo "#" + echo "not ok $test_num $TEST_HDR_MSG # TIMEOUT $kselftest_timeout seconds" + else + echo "not ok $test_num $TEST_HDR_MSG # exit=$rc" + fi + fi cd - >/dev/null fi + return $ret } run_many() { + local ret=0 + echo "TAP version 13" DIR="${PWD#${BASE_DIR}/}" test_num=0 @@ -142,6 +151,7 @@ run_many() logfile="/tmp/$BASENAME_TEST" cat /dev/null > "$logfile" fi - run_one "$DIR" "$TEST" "$test_num" + run_one "$DIR" "$TEST" "$test_num" || ret=1 done + return $ret } diff --git a/tools/testing/selftests/run_kselftest.sh b/tools/testing/selftests/run_kselftest.sh index 97165a83df63..6164314f837e 100755 --- a/tools/testing/selftests/run_kselftest.sh +++ b/tools/testing/selftests/run_kselftest.sh @@ -85,9 +85,11 @@ if [ -n "$TESTS" ]; then available="$(echo "$valid" | sed -e 's/ /\n/g')" fi +ret=0 collections=$(echo "$available" | cut -d: -f1 | uniq) for collection in $collections ; do [ -w /dev/kmsg ] && echo "kselftest: Running tests in $collection" >> /dev/kmsg tests=$(echo "$available" | grep "^$collection:" | cut -d: -f2) - ($dryrun cd "$collection" && $dryrun run_many $tests) + ($dryrun cd "$collection" && $dryrun run_many $tests) || ret=1 done +exit $ret base-commit: 7e284070abe53d448517b80493863595af4ab5f0 -- 2.36.0

2 years, 2 months

1
0
0 0

Greetings From Ukraine.

by Kostiantyn Chichkov

Good Morning, We are Kostiantyn Chychkov and Maryna Chudnovska from Ukraine, we need your service, we have gone through your profile and we will like to work with you on an important service that needs urgent attention due to the ongoing war in our country. Kindly acknowledge this inquiry as soon as possible for a detailed discussion about the service. Thank you. Yours expectantly, Kostiantyn Chichkov & Ms. Maryna Chudnovska, From Ukraine.

2 years, 2 months

1
0
0 0

[PATCH v3 0/3] fat: add support for the renameat2 RENAME_EXCHANGE flag

by Javier Martinez Canillas

Hello, This series add support for the renameat2 system call RENAME_EXCHANGE flag (which allows to atomically replace two paths) to the vfat filesystem code. There are many use cases for this, but we are particularly interested in making possible for vfat filesystems to be part of OSTree [0] deployments. Currently OSTree relies on symbolic links to make the deployment updates an atomic transactional operation. But RENAME_EXCHANGE could be used [1] to achieve a similar level of robustness when using a vfat filesystem. Patch #1 is just a preparatory patch to introduce the RENAME_EXCHANGE support in patch #2 and finally patch #3 adds some kselftests to test it. This is a v3 that addresses issues pointed out in the second version posted: https://lkml.org/lkml/2022/5/24/137 [0]: https://github.com/ostreedev/ostree [1]: https://github.com/ostreedev/ostree/issues/1649 Changes in v3: - Add a .gitignore for the rename_exchange binary (Muhammad Usama Anjum). - Include $(KHDR_INCLUDES) instead of hardcoding a relative path in Makefile (Muhammad Usama Anjum). Changes in v2: - Only update the new_dir inode version and timestamps if != old_dir (Alex Larsson). - Add some helper functions to avoid duplicating code (OGAWA Hirofumi). - Use braces for multi-lines blocks even if are one statement (OGAWA Hirofumi). - Mention in commit message that the operation is as transactional as possible but within the vfat limitations of not having a journal (Colin Walters). - Call sync to flush the page cache before checking the file contents (Alex Larsson). - Drop RFC prefix since the patches already got some review. Javier Martinez Canillas (3): fat: add a vfat_rename2() and make existing .rename callback a helper fat: add renameat2 RENAME_EXCHANGE flag support selftests/filesystems: add a vfat RENAME_EXCHANGE test MAINTAINERS | 1 + fs/fat/namei_vfat.c | 193 +++++++++++++++++- tools/testing/selftests/Makefile | 1 + .../selftests/filesystems/fat/.gitignore | 2 + .../selftests/filesystems/fat/Makefile | 7 + .../testing/selftests/filesystems/fat/config | 2 + .../filesystems/fat/rename_exchange.c | 37 ++++ .../filesystems/fat/run_fat_tests.sh | 82 ++++++++ 8 files changed, 318 insertions(+), 7 deletions(-) create mode 100644 tools/testing/selftests/filesystems/fat/.gitignore create mode 100644 tools/testing/selftests/filesystems/fat/Makefile create mode 100644 tools/testing/selftests/filesystems/fat/config create mode 100644 tools/testing/selftests/filesystems/fat/rename_exchange.c create mode 100755 tools/testing/selftests/filesystems/fat/run_fat_tests.sh -- 2.36.1

2 years, 2 months

2
2
0 0

[REGRESSION] lkft kselftest for next-20220525

by lkft＠linaro.org

## Build * kernel: 5.18.0 * git: ['', 'https://gitlab.com/Linaro/lkft/mirrors/next/linux-next'] * git branch: master * git commit: 8cb8311e95e3bb58bd84d6350365f14a718faa6d * git describe: next-20220525 * test details: https://qa-reports.linaro.org/lkft/linux-next-master/build/next-20220525 ## Test Regressions (compared to next-20220524) * qemu_arm, kselftest-pidfd - pidfd.pidfd_poll_test ## Metric Regressions (compared to next-20220524) No metric regressions found. Reported-by: Linux Kernel Functional Testing <lkft(a)linaro.org> ## Test Fixes (compared to next-20220524) * qemu_arm, kselftest-seccomp - seccomp.seccomp_benchmark - seccomp.seccomp_bpf.TSYNC.siblings_fail_prctl - seccomp.seccomp_bpf.TSYNC.two_siblings_with_one_divergence - seccomp.seccomp_bpf.TSYNC.two_siblings_with_one_divergence_no_tid_in_err ## Metric Fixes (compared to next-20220524) No metric fixes found. ## Test result summary total: 385, pass: 166, fail: 91, skip: 128, xfail: 0 ## Build Summary ## Test suites summary * kselftest-android * kselftest-breakpoints * kselftest-capabilities * kselftest-cgroup * kselftest-clone3 * kselftest-core * kselftest-cpu-hotplug * kselftest-cpufreq * kselftest-drivers * kselftest-efivarfs * kselftest-filesystems * kselftest-firmware * kselftest-fpu * kselftest-gpio * kselftest-ipc * kselftest-ir * kselftest-kcmp * kselftest-kvm * kselftest-lib * kselftest-membarrier * kselftest-openat2 * kselftest-pid_namespace * kselftest-pidfd * kselftest-proc * kselftest-pstore * kselftest-rseq * kselftest-rtc * kselftest-seccomp * kselftest-sigaltstack * kselftest-size * kselftest-splice * kselftest-static_keys * kselftest-sync * kselftest-sysctl * kselftest-timens * kselftest-timers * kselftest-tmpfs * kselftest-tpm2 * kselftest-user * kselftest-vm -- Linaro LKFT https://lkft.linaro.org

2 years, 2 months

1
0
0 0

[PATCH v2] selftests/net: enable lo.accept_local in psock_snd test

by Yun Lu

From: luyun <luyun(a)kylinos.cn> The psock_snd test sends and recieves packets over loopback, and the test results depend on parameter settings: Set rp_filter=0, or set rp_filter=1 and accept_local=1 so that the test will pass. Otherwise, this test will fail with Resource temporarily unavailable: sudo ./psock_snd.sh dgram tx: 128 rx: 142 ./psock_snd: recv: Resource temporarily unavailable For most distro kernel releases(like Ubuntu or Centos), the parameter rp_filter is enabled by default, so it's necessary to enable the parameter lo.accept_local in psock_snd test. And this test runs inside a netns, changing a sysctl is fine. v2: add detailed description. Suggested-by: Willem de Bruijn <willemdebruijn.kernel(a)gmail.com> Signed-off-by: luyun <luyun(a)kylinos.cn> Reviewed-by: Jackie Liu <liuyun01(a)kylinos.cn> --- tools/testing/selftests/net/psock_snd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/testing/selftests/net/psock_snd.c b/tools/testing/selftests/net/psock_snd.c index 7d15e10a9fb6..edf1e6f80d41 100644 --- a/tools/testing/selftests/net/psock_snd.c +++ b/tools/testing/selftests/net/psock_snd.c @@ -389,6 +389,8 @@ int main(int argc, char **argv) error(1, errno, "ip link set mtu"); if (system("ip addr add dev lo 172.17.0.1/24")) error(1, errno, "ip addr add"); + if (system("sysctl -w net.ipv4.conf.lo.accept_local=1")) + error(1, errno, "sysctl lo.accept_local"); run_test(); -- 2.25.1 No virus found Checked by Hillstone Network AntiVirus

2 years, 2 months

4
3
0 0

Bitte kontaktaufnahme Erforderlich !!! Please Contact Required !!!

by Deterin Falcao

Guten Tag, Ich habe mich nur gefragt, ob Sie meine vorherige E-Mail bekommen haben ? Ich habe versucht, Sie per E-Mail zu erreichen. Kommen Sie bitte schnell zu mir zurück, es ist sehr wichtig. Danke Falcao Deterin falcaodeterin(a)gmail.com ---------------------------------- Good Afternoon, I was just wondering if you got my Previous E-mail have ? I tried to reach you by E-mail. Please come back to me quickly, it is very Important. Thanks Falcao Deterin falcaodeterin(a)gmail.com

2 years, 2 months

1
0
0 0

Re: [GIT PULL] KUnit update for Linux 5.19-rc1

by pr-tracker-bot＠kernel.org

The pull request you sent on Mon, 23 May 2022 12:21:27 -0600: > git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest tags/linux-kselftest-kunit-5.19-rc1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/64e34b50d7aeee7082287ec39f9d34d4e60f3a04 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html

2 years, 2 months

1
0
0 0

[GIT PULL] Kselftest update for Linux 5.19-rc1

by Shuah Khan

Hi Linus, Please pull the following Kselftest update for Linux 5.19-rc1 This Kselftest update for Linux 5.19-rc1 consists of several fixes, cleanups, and enhancements to tests: - adds mips support for kprobe args string and syntax tests - updates to resctrl test to use kselftest framework - fixes, cleanups, and enhancements to tests diff is attached. thanks, -- Shuah ---------------------------------------------------------------- The following changes since commit b2d229d4ddb17db541098b83524d901257e93845: Linux 5.18-rc3 (2022-04-17 13:57:31 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest tags/linux-kselftest-next-5.19-rc1 for you to fetch changes up to 15477b31db104bc795dd1acccb3e9b89465fff01: kselftests/ir : Improve readability of modprobe error message (2022-05-16 13:34:19 -0600) ---------------------------------------------------------------- linux-kselftest-next-5.19-rc1 This Kselftest update for Linux 5.19-rc1 consists of several fixes, cleanups, and enhancements to tests: - adds mips support for kprobe args string and syntax tests - updates to resctrl test to use kselftest framework - fixes, cleanups, and enhancements to tests ---------------------------------------------------------------- Colin Ian King (1): selftests/resctrl: Fix null pointer dereference on open failed Gautam Menghani (1): kselftests/ir : Improve readability of modprobe error message Geliang Tang (1): selftests: mqueue: drop duplicate min definition Karthik Alapati (1): selftests/binderfs: Improve message to provide more info Reinette Chatre (4): selftests: Provide local define of __cpuid_count() selftests/vm/pkeys: Use provided __cpuid_count() macro selftests/x86/amx: Use provided __cpuid_count() macro selftests/x86/corrupt_xstate_header: Use provided __cpuid_count() macro Shaopeng Tan (8): selftests/resctrl: Extend CPU vendor detection selftests/resctrl: Print a message if the result of MBM&CMT tests is failed on Intel CPU selftests/resctrl: Kill child process before parent process terminates if SIGTERM is received selftests/resctrl: Change the default limited time to 120 seconds selftests/resctrl: Fix resctrl_tests' return code to work with selftest framework selftests/resctrl: Make resctrl_tests run using kselftest framework selftests/resctrl: Update README about using kselftest framework to build/run resctrl_tests selftests/resctrl: Add missing SPDX license to Makefile Yuanchu Xie (1): selftests/damon: add damon to selftests root Makefile Ze Zhang (2): selftests/ftrace: add mips support for kprobe args string tests selftests/ftrace: add mips support for kprobe args syntax tests tools/testing/selftests/Makefile | 2 + .../selftests/filesystems/binderfs/binderfs_test.c | 3 +- .../ftrace/test.d/kprobe/kprobe_args_string.tc | 3 ++ .../ftrace/test.d/kprobe/kprobe_args_syntax.tc | 4 ++ tools/testing/selftests/ir/ir_loopback.sh | 2 +- tools/testing/selftests/kselftest.h | 15 +++++++ tools/testing/selftests/mqueue/mq_perf_tests.c | 4 +- tools/testing/selftests/resctrl/Makefile | 19 +++------ tools/testing/selftests/resctrl/README | 39 +++++++++++++---- tools/testing/selftests/resctrl/cat_test.c | 2 +- tools/testing/selftests/resctrl/fill_buf.c | 4 +- tools/testing/selftests/resctrl/resctrl.h | 5 ++- tools/testing/selftests/resctrl/resctrl_tests.c | 49 +++++++++++++++------- tools/testing/selftests/resctrl/resctrl_val.c | 1 + tools/testing/selftests/resctrl/resctrlfs.c | 2 +- tools/testing/selftests/resctrl/settings | 3 ++ tools/testing/selftests/vm/pkey-x86.h | 21 +--------- tools/testing/selftests/x86/amx.c | 24 ++++------- .../testing/selftests/x86/corrupt_xstate_header.c | 16 +------ 19 files changed, 124 insertions(+), 94 deletions(-) create mode 100644 tools/testing/selftests/resctrl/settings ----------------------------------------------------------------

2 years, 2 months

2
1
0 0

[RFC PATCH 0/4] kunit: more assertion reworking

by Daniel Latypov

This is a follow up to these three series: https://lore.kernel.org/all/20220113165931.451305-1-dlatypov@google.com/ https://lore.kernel.org/all/20220118223506.1701553-1-dlatypov@google.com/ https://lore.kernel.org/all/20220125210011.3817742-1-dlatypov@google.com/ The two goals of those series were a) reduce the size of struct kunit_assert and friends. (struct kunit_assert went from 48 => 8 bytes on UML.) b) simplify the internal code, mostly by deleting macros This series goes further a) sizeof(struct kunit_assert) = 0 now b) e.g. we delete another class of macros (KUNIT_INIT_*_ASSERT_STRUCT) Note: this does change the function signature of kunit_do_failed_assertion, so we'd need to update the rust wrapper in https://github.com/Rust-for-Linux/linux/blob/rust/rust/kernel/kunit.rs But otherwise, I don't think this series changes anything on the rust-side. Daniel Latypov (4): rfc: kunit: remove format func from struct kunit_assert, get it to 0 bytes rfc: kunit: rename base KUNIT_ASSERTION macro to _KUNIT_FAILED rfc: kunit: eliminate KUNIT_INIT_*_ASSERT_STRUCT macros kunit: delcare kunit_assert structs as const include/kunit/assert.h | 74 ++----------------------- include/kunit/test.h | 123 ++++++++++++++++++++++------------------- lib/kunit/test.c | 7 ++- 3 files changed, 76 insertions(+), 128 deletions(-) base-commit: e7eaffce47b7db72b077630dbe836f0c4132496d -- 2.36.1.124.g0e6072fb45-goog

2 years, 2 months

2
6
0 0

[PATCH v3 0/5] memcontrol selftests fixups

by Michal Koutný

Hello. I'm just flushing the patches to make memcontrol selftests check the events behavior we had consensus about (test_memcg_low fails). (test_memcg_reclaim, test_memcg_swap_max fail for me now but it's present even before the refactoring.) The two bigger changes are: - adjustment of the protected values to make tests succeed with the given tolerance, - both test_memcg_low and test_memcg_min check protection of memory in populated cgroups (actually as per Documentation/admin-guide/cgroup-v2.rst memory.min should not apply to empty cgroups, which is not the case currently. Therefore I unified tests with the populated case in order to to bring more broken tests). Thanks, Michal Changes from v2 (https://lore.kernel.org/r/20220518161859.21565-2-mkoutny@suse.com/) - rebased on mm-stable 02e34fff195d3a5f67cbb553795dc109a37d1dcf - collected acked-bys - proper Fixes: tag Changes from v1 (https://lore.kernel.org/r/20220513171811.730-1-mkoutny@suse.com/) - fixed mis-rebase in compilation fix patch, - added review, ack tags from v1, - applied feedback from v1 (Octave script in git tree), - added one more patch extracting common parts, - rebased on mm-stable bbe832b9db2e. Michal Koutný (5): selftests: memcg: Fix compilation selftests: memcg: Expect no low events in unprotected sibling selftests: memcg: Adjust expected reclaim values of protected cgroups selftests: memcg: Remove protection from top level memcg selftests: memcg: Factor out common parts of memory.{low,min} tests MAINTAINERS | 1 + .../selftests/cgroup/memcg_protection.m | 89 +++++++ .../selftests/cgroup/test_memcontrol.c | 247 +++++------------- 3 files changed, 152 insertions(+), 185 deletions(-) create mode 100644 tools/testing/selftests/cgroup/memcg_protection.m -- 2.35.3

2 years, 2 months

2
7
0 0

2024

2023

2022

2021

2020

2019

2018

2017

Linux-kselftest-mirror May 2022