July 2022 - Linux-kselftest-mirror

[PATCH] KVM: selftests: fix bit test in is_steal_time_supported()

by Dan Carpenter

The KVM_FEATURE_STEAL_TIME (5) define is the BIT() value so we need to do shift for this to work correctly. Fixes: 998016048221 ("KVM: selftests: Convert steal_time away from VCPU_ID") Signed-off-by: Dan Carpenter <dan.carpenter(a)oracle.com> --- tools/testing/selftests/kvm/steal_time.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/kvm/steal_time.c b/tools/testing/selftests/kvm/steal_time.c index d122f1e05cdd..b89f0cfa2dc3 100644 --- a/tools/testing/selftests/kvm/steal_time.c +++ b/tools/testing/selftests/kvm/steal_time.c @@ -62,7 +62,7 @@ static bool is_steal_time_supported(struct kvm_vcpu *vcpu) { struct kvm_cpuid_entry2 *cpuid = kvm_get_supported_cpuid_entry(KVM_CPUID_FEATURES); - return cpuid && (cpuid->eax & KVM_FEATURE_STEAL_TIME); + return cpuid && (cpuid->eax & (1 << KVM_FEATURE_STEAL_TIME)); } static void steal_time_init(struct kvm_vcpu *vcpu, uint32_t i) -- 2.35.1

1 year, 10 months

2
1
0 0

[bug report] kselftest/arm64: Add utilities and a test to validate mte memory

by Dan Carpenter

Hello Amit Daniel Kachhap, The patch e9b60476bea0: "kselftest/arm64: Add utilities and a test to validate mte memory" from Oct 2, 2020, leads to the following Smatch static checker warning: ./tools/testing/selftests/arm64/mte/mte_common_util.c:336 mte_default_setup() warn: bitwise AND condition is false here ./tools/testing/selftests/arm64/mte/mte_common_util.c 316 int mte_default_setup(void) 317 { 318 unsigned long hwcaps2 = getauxval(AT_HWCAP2); 319 unsigned long en = 0; 320 int ret; 321 322 if (!(hwcaps2 & HWCAP2_MTE)) { 323 ksft_print_msg("SKIP: MTE features unavailable\n"); 324 return KSFT_SKIP; 325 } 326 /* Get current mte mode */ 327 ret = prctl(PR_GET_TAGGED_ADDR_CTRL, en, 0, 0, 0); 328 if (ret < 0) { 329 ksft_print_msg("FAIL:prctl PR_GET_TAGGED_ADDR_CTRL with error =%d\n", ret); 330 return KSFT_FAIL; 331 } 332 if (ret & PR_MTE_TCF_SYNC) 333 mte_cur_mode = MTE_SYNC_ERR; 334 else if (ret & PR_MTE_TCF_ASYNC) 335 mte_cur_mode = MTE_ASYNC_ERR; --> 336 else if (ret & PR_MTE_TCF_NONE) It looks like the intent was to make PR_MTE_TCF_NONE into an ifdef configurable thing but that never happened? 337 mte_cur_mode = MTE_NONE_ERR; 338 339 mte_cur_pstate_tco = mte_get_pstate_tco(); 340 /* Disable PSTATE.TCO */ 341 mte_disable_pstate_tco(); 342 return 0; 343 } regards, dan carpenter

1 year, 10 months

2
1
0 0

[PATCH] ksefltest: pidfd: Fix wait_states: Test terminated by timeout

by lizhijian＠fujitsu.com

0Day/LKP observed that the kselftest blocks forever since one of the pidfd_wait doesn't terminate in 1 of 30 runs. After digging into the source, we found that it blocks at: ASSERT_EQ(sys_waitid(P_PIDFD, pidfd, &info, WCONTINUED, NULL), 0); wait_states has below testing flow: CHILD PARENT ---------------+-------------- 1 STOP itself 2 WAIT for CHILD STOPPED 3 SIGNAL CHILD to CONT 4 CONT 5 STOP itself 5' WAIT for CHILD CONT 6 WAIT for CHILD STOPPED The problem is that the kernel cannot ensure the order of 5 and 5', once 5's goes first, the test will fail. we can reproduce it by: $ while true; do make run_tests -C pidfd; done Introduce a blocking read in child process to make sure the parent can check its WCONTINUED. CC: Philip Li <philip.li(a)intel.com> Reported-by: kernel test robot <lkp(a)intel.com> Signed-off-by: Li Zhijian <lizhijian(a)fujitsu.com> --- I have almost forgotten this patch since the former version post over 6 months ago. This time I just do a rebase and update the comments. V2: rewrite with pipe to avoid usleep --- tools/testing/selftests/pidfd/pidfd_wait.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/tools/testing/selftests/pidfd/pidfd_wait.c b/tools/testing/selftests/pidfd/pidfd_wait.c index 070c1c876df1..3f7bc6517dea 100644 --- a/tools/testing/selftests/pidfd/pidfd_wait.c +++ b/tools/testing/selftests/pidfd/pidfd_wait.c @@ -95,20 +95,27 @@ TEST(wait_states) .flags = CLONE_PIDFD | CLONE_PARENT_SETTID, .exit_signal = SIGCHLD, }; + int ret, pfd[2]; pid_t pid; siginfo_t info = { .si_signo = 0, }; + ASSERT_EQ(pipe(pfd), 0); pid = sys_clone3(&args); ASSERT_GE(pid, 0); if (pid == 0) { + char buf[2]; + close(pfd[1]); kill(getpid(), SIGSTOP); + ASSERT_EQ(read(pfd[0], buf, 1), 1); + close(pfd[0]); kill(getpid(), SIGSTOP); exit(EXIT_SUCCESS); } + close(pfd[0]); ASSERT_EQ(sys_waitid(P_PIDFD, pidfd, &info, WSTOPPED, NULL), 0); ASSERT_EQ(info.si_signo, SIGCHLD); ASSERT_EQ(info.si_code, CLD_STOPPED); @@ -117,6 +124,8 @@ TEST(wait_states) ASSERT_EQ(sys_pidfd_send_signal(pidfd, SIGCONT, NULL, 0), 0); ASSERT_EQ(sys_waitid(P_PIDFD, pidfd, &info, WCONTINUED, NULL), 0); + ASSERT_EQ(write(pfd[1], "C", 1), 1); + close(pfd[1]); ASSERT_EQ(info.si_signo, SIGCHLD); ASSERT_EQ(info.si_code, CLD_CONTINUED); ASSERT_EQ(info.si_pid, parent_tid); -- 2.36.0

1 year, 10 months

2
2
0 0

[PATCH] selftests:Unneeded semicolon

by Xin Gao

Unneeded semicolon Signed-off-by: Xin Gao <gaoxin(a)cdjrlc.com> --- tools/testing/selftests/timers/nsleep-lat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/timers/nsleep-lat.c b/tools/testing/selftests/timers/nsleep-lat.c index eb3e79ed7b4a..a7ca9825e106 100644 --- a/tools/testing/selftests/timers/nsleep-lat.c +++ b/tools/testing/selftests/timers/nsleep-lat.c @@ -72,7 +72,7 @@ char *clockstring(int clockid) return "CLOCK_BOOTTIME_ALARM"; case CLOCK_TAI: return "CLOCK_TAI"; - }; + } return "UNKNOWN_CLOCKID"; } -- 2.30.2

1 year, 10 months

1
0
0 0

[PATCH] selftests:Unneeded semicolon

by Xin Gao

Unneeded semicolon Signed-off-by: Xin Gao <gaoxin(a)cdjrlc.com> --- tools/testing/selftests/timers/nanosleep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/timers/nanosleep.c b/tools/testing/selftests/timers/nanosleep.c index 71b5441c2fd9..433a09676aeb 100644 --- a/tools/testing/selftests/timers/nanosleep.c +++ b/tools/testing/selftests/timers/nanosleep.c @@ -72,7 +72,7 @@ char *clockstring(int clockid) return "CLOCK_BOOTTIME_ALARM"; case CLOCK_TAI: return "CLOCK_TAI"; - }; + } return "UNKNOWN_CLOCKID"; } -- 2.30.2

1 year, 10 months

1
0
0 0

[PATCH v3] KVM: selftests: Fix target thread to be migrated in rseq_test

by Gavin Shan

In rseq_test, there are two threads, which are vCPU thread and migration worker separately. Unfortunately, the test has the wrong PID passed to sched_setaffinity() in the migration worker. It forces migration on the migration worker because zeroed PID represents the calling thread, which is the migration worker itself. It means the vCPU thread is never enforced to migration and it can migrate at any time, which eventually leads to failure as the following logs show. host# uname -r 5.19.0-rc6-gavin+ host# # cat /proc/cpuinfo | grep processor | tail -n 1 processor : 223 host# pwd /home/gavin/sandbox/linux.main/tools/testing/selftests/kvm host# for i in `seq 1 100`; do \ echo "--------> $i"; ./rseq_test; done --------> 1 --------> 2 --------> 3 --------> 4 --------> 5 --------> 6 ==== Test Assertion Failure ==== rseq_test.c:265: rseq_cpu == cpu pid=3925 tid=3925 errno=4 - Interrupted system call 1 0x0000000000401963: main at rseq_test.c:265 (discriminator 2) 2 0x0000ffffb044affb: ?? ??:0 3 0x0000ffffb044b0c7: ?? ??:0 4 0x0000000000401a6f: _start at ??:? rseq CPU = 4, sched CPU = 27 Fix the issue by passing correct parameter, TID of the vCPU thread, to sched_setaffinity() in the migration worker. Fixes: 61e52f1630f5 ("KVM: selftests: Add a test for KVM_RUN+rseq to detect task migration bugs") Signed-off-by: Gavin Shan <gshan(a)redhat.com> Reviewed-by: Oliver Upton <oliver.upton(a)linux.dev> --- v3: Improved changelog (Oliver Upon) --- tools/testing/selftests/kvm/rseq_test.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/kvm/rseq_test.c b/tools/testing/selftests/kvm/rseq_test.c index 4158da0da2bb..c83ac7b467f8 100644 --- a/tools/testing/selftests/kvm/rseq_test.c +++ b/tools/testing/selftests/kvm/rseq_test.c @@ -38,6 +38,7 @@ static __thread volatile struct rseq __rseq = { */ #define NR_TASK_MIGRATIONS 100000 +static pid_t rseq_tid; static pthread_t migration_thread; static cpu_set_t possible_mask; static int min_cpu, max_cpu; @@ -106,7 +107,8 @@ static void *migration_worker(void *ign) * stable, i.e. while changing affinity is in-progress. */ smp_wmb(); - r = sched_setaffinity(0, sizeof(allowed_mask), &allowed_mask); + r = sched_setaffinity(rseq_tid, sizeof(allowed_mask), + &allowed_mask); TEST_ASSERT(!r, "sched_setaffinity failed, errno = %d (%s)", errno, strerror(errno)); smp_wmb(); @@ -231,6 +233,7 @@ int main(int argc, char *argv[]) vm = vm_create_default(VCPU_ID, 0, guest_code); ucall_init(vm, NULL); + rseq_tid = gettid(); pthread_create(&migration_thread, NULL, migration_worker, 0); for (i = 0; !done; i++) { -- 2.23.0

1 year, 10 months

2
2
0 0

[PATCH] tools: Change the division operator to a right shift operator

by Lv qian

Change the division operator to a right shift operator,Reduced assembly code. Signed-off-by: Lv qian <lvqian(a)nfschina.com> --- tools/testing/selftests/size/get_size.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/size/get_size.c b/tools/testing/selftests/size/get_size.c index 2980b1a63366..b1e34408f8c6 100644 --- a/tools/testing/selftests/size/get_size.c +++ b/tools/testing/selftests/size/get_size.c @@ -73,7 +73,7 @@ static int print_k_value(const char *s, unsigned long num, unsigned long units) print(s); temp = num; - temp = (temp * units)/1024; + temp = (temp * units)>>10; num = temp; ccode = print_num(num); print("\n"); -- 2.18.2

1 year, 10 months

1
0
0 0

[PATCH v2] KVM: selftests: Fix target thread to be migrated in rseq_test

by Gavin Shan

In rseq_test, there are two threads, which are thread group leader and migration worker. The migration worker relies on sched_setaffinity() to force migration on the thread group leader. Unfortunately, we have wrong parameter (0) passed to sched_getaffinity(). It's actually forcing migration on the migration worker instead of the thread group leader. It also means migration can happen on the thread group leader at any time, which eventually leads to failure as the following logs show. host# uname -r 5.19.0-rc6-gavin+ host# # cat /proc/cpuinfo | grep processor | tail -n 1 processor : 223 host# pwd /home/gavin/sandbox/linux.main/tools/testing/selftests/kvm host# for i in `seq 1 100`; \ do echo "--------> $i"; ./rseq_test; done --------> 1 --------> 2 --------> 3 --------> 4 --------> 5 --------> 6 ==== Test Assertion Failure ==== rseq_test.c:265: rseq_cpu == cpu pid=3925 tid=3925 errno=4 - Interrupted system call 1 0x0000000000401963: main at rseq_test.c:265 (discriminator 2) 2 0x0000ffffb044affb: ?? ??:0 3 0x0000ffffb044b0c7: ?? ??:0 4 0x0000000000401a6f: _start at ??:? rseq CPU = 4, sched CPU = 27 This fixes the issue by passing correct parameter, tid of the group thread leader, to sched_setaffinity(). Fixes: 61e52f1630f5 ("KVM: selftests: Add a test for KVM_RUN+rseq to detect task migration bugs") Signed-off-by: Gavin Shan <gshan(a)redhat.com> --- tools/testing/selftests/kvm/rseq_test.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/kvm/rseq_test.c b/tools/testing/selftests/kvm/rseq_test.c index 4158da0da2bb..c83ac7b467f8 100644 --- a/tools/testing/selftests/kvm/rseq_test.c +++ b/tools/testing/selftests/kvm/rseq_test.c @@ -38,6 +38,7 @@ static __thread volatile struct rseq __rseq = { */ #define NR_TASK_MIGRATIONS 100000 +static pid_t rseq_tid; static pthread_t migration_thread; static cpu_set_t possible_mask; static int min_cpu, max_cpu; @@ -106,7 +107,8 @@ static void *migration_worker(void *ign) * stable, i.e. while changing affinity is in-progress. */ smp_wmb(); - r = sched_setaffinity(0, sizeof(allowed_mask), &allowed_mask); + r = sched_setaffinity(rseq_tid, sizeof(allowed_mask), + &allowed_mask); TEST_ASSERT(!r, "sched_setaffinity failed, errno = %d (%s)", errno, strerror(errno)); smp_wmb(); @@ -231,6 +233,7 @@ int main(int argc, char *argv[]) vm = vm_create_default(VCPU_ID, 0, guest_code); ucall_init(vm, NULL); + rseq_tid = gettid(); pthread_create(&migration_thread, NULL, migration_worker, 0); for (i = 0; !done; i++) { -- 2.23.0

1 year, 10 months

2
3
0 0

Hi Dear,

by Lily William

Hi Dear, My name is Dr Lily William from the United States.I am a French and American nationality (dual) living in the U.S and sometimes in France for Work Purpose. I hope you consider my friend request. I will share some of my pics and more details about myself when I get your response. Thanks With love Lily

1 year, 10 months

1
0
0 0

Re: linux-next: Tree for Jul 18 (ne_misc_dev.c)

by Randy Dunlap

On 7/18/22 04:02, Stephen Rothwell wrote: > Hi all, > > Changes since 20220715: > on x86_64: vmlinux.o: in function `ne_misc_dev_test_merge_phys_contig_memory_regions': ne_misc_dev.c:(.text+0x88eae7): undefined reference to `kunit_kmalloc_array' ld: ne_misc_dev.c:(.text+0x88eafd): undefined reference to `kunit_unary_assert_format' ld: ne_misc_dev.c:(.text+0x88eb25): undefined reference to `kunit_do_failed_assertion' ld: ne_misc_dev.c:(.text+0x88ec0c): undefined reference to `kunit_binary_assert_format' ld: ne_misc_dev.c:(.text+0x88ec3c): undefined reference to `kunit_do_failed_assertion' ld: ne_misc_dev.c:(.text+0x88ec58): undefined reference to `kunit_binary_assert_format' ld: ne_misc_dev.c:(.text+0x88ec88): undefined reference to `kunit_do_failed_assertion' ld: ne_misc_dev.c:(.text+0x88ecc2): undefined reference to `kunit_binary_assert_format' ld: ne_misc_dev.c:(.text+0x88ecf2): undefined reference to `kunit_do_failed_assertion' ld: ne_misc_dev.c:(.text+0x88ed19): undefined reference to `kunit_binary_assert_format' ld: ne_misc_dev.c:(.text+0x88ed49): undefined reference to `kunit_do_failed_assertion' ld: ne_misc_dev.c:(.text+0x88ed7e): undefined reference to `kunit_kfree' Full randconfig file is attached. -- ~Randy

1 year, 10 months

1
0
0 0

2024

2023

2022

2021

2020

2019

2018

2017

Linux-kselftest-mirror July 2022