July 2023 - Linux-kselftest-mirror

[PATCH v2 0/9] kunit: Add test attributes API

by Rae Moar

Hello everyone, This patch series adds a test attributes framework to KUnit. There has been interest in filtering out "slow" KUnit tests. Most notably, a new config, CONFIG_MEMCPY_SLOW_KUNIT_TEST, has been added to exclude a particularly slow memcpy test (https://lore.kernel.org/all/20230118200653.give.574-kees@kernel.org/). This attributes framework can be used to save and access test associated data, including whether a test is slow. These attributes are reportable (via KTAP and command line output) and are also filterable. This framework is designed to allow for the addition of other attributes in the future. These attributes could include whether the test can be run concurrently, test file path, etc. To try out the framework I suggest running: "./tools/testing/kunit/kunit.py run --filter speed!=slow" This patch series was originally sent out as an RFC. Here is a link to the RFC v2: https://lore.kernel.org/all/20230707210947.1208717-1-rmoar@google.com/ Thanks! Rae Rae Moar (9): kunit: Add test attributes API structure kunit: Add speed attribute kunit: Add module attribute kunit: Add ability to filter attributes kunit: tool: Add command line interface to filter and report attributes kunit: memcpy: Mark tests as slow using test attributes kunit: time: Mark test as slow using test attributes kunit: add tests for filtering attributes kunit: Add documentation of KUnit test attributes .../dev-tools/kunit/running_tips.rst | 166 +++++++ include/kunit/attributes.h | 50 +++ include/kunit/test.h | 70 ++- kernel/time/time_test.c | 2 +- lib/Kconfig.debug | 3 + lib/kunit/Makefile | 3 +- lib/kunit/attributes.c | 418 ++++++++++++++++++ lib/kunit/executor.c | 115 ++++- lib/kunit/executor_test.c | 128 +++++- lib/kunit/kunit-example-test.c | 9 + lib/kunit/test.c | 27 +- lib/memcpy_kunit.c | 8 +- tools/testing/kunit/kunit.py | 70 ++- tools/testing/kunit/kunit_kernel.py | 8 +- tools/testing/kunit/kunit_parser.py | 11 +- tools/testing/kunit/kunit_tool_test.py | 39 +- 16 files changed, 1051 insertions(+), 76 deletions(-) create mode 100644 include/kunit/attributes.h create mode 100644 lib/kunit/attributes.c base-commit: 64bd4641310c41a1ecf07c13c67bc0ed61045dfd -- 2.41.0.487.g6d72f3e995-goog

1 year, 1 month

2
15
0 0

[PATCH v3 0/8] selftests/mm fixes for arm64

by Ryan Roberts

Hi All, This is v3 of my series to clean up mm selftests so that they run correctly on arm64. See [1] for full explanation. Only patch 6 has changed vs v2. The rest are the same and already carry reviewed/acked-bys. So I'm hoping I can get the final patch reviewed and this series is hopefully then good enough to merge? Changes Since v2 [2] -------------------- - Patch 6: Change approach to cleaning up child processes; Use "parent death signal", as suggested by David. - Added Reviewed-by/Acked-by tags: thanks to David, Mark and Peter! Changes Since v1 [1] -------------------- - Patch 1: Explicitly set line buffer mode in ksft_print_header() - Dropped v1 patch 2 (set execute permissions): Andrew has taken this into his branch separately. - Patch 2: Don't compile `soft-dirty` suite for arm64 instead of skipping it at runtime. - Patch 2: Declare fewer tests and skip all of test_softdirty() if soft-dirty is not supported, rather than conditionally marking each check as skipped. - Added Reviewed-by tags: thanks DavidH! - Patch 8: Clarified commit message. [1] https://lore.kernel.org/linux-mm/20230713135440.3651409-1-ryan.roberts@arm.… [2] https://lore.kernel.org/linux-mm/20230717103152.202078-1-ryan.roberts@arm.c… Thanks, Ryan Ryan Roberts (8): selftests: Line buffer test program's stdout selftests/mm: Skip soft-dirty tests on arm64 selftests/mm: Enable mrelease_test for arm64 selftests/mm: Fix thuge-gen test bugs selftests/mm: va_high_addr_switch should skip unsupported arm64 configs selftests/mm: Make migration test robust to failure selftests/mm: Optionally pass duration to transhuge-stress selftests/mm: Run all tests from run_vmtests.sh tools/testing/selftests/kselftest.h | 9 ++ tools/testing/selftests/kselftest/runner.sh | 7 +- tools/testing/selftests/mm/Makefile | 82 ++++++++++--------- tools/testing/selftests/mm/madv_populate.c | 26 +++++- tools/testing/selftests/mm/migration.c | 12 ++- tools/testing/selftests/mm/mrelease_test.c | 1 + tools/testing/selftests/mm/run_vmtests.sh | 28 ++++++- tools/testing/selftests/mm/settings | 2 +- tools/testing/selftests/mm/thuge-gen.c | 4 +- tools/testing/selftests/mm/transhuge-stress.c | 12 ++- .../selftests/mm/va_high_addr_switch.c | 2 +- 11 files changed, 132 insertions(+), 53 deletions(-) -- 2.25.1

1 year, 1 month

4
13
0 0

[PATCH] selftests/bpf: fix build errors if CONFIG_NF_CONNTRACK_MARK not set.

by Mahmoud Maatuq

'mark' member in 'struct nf_conn' is conditionally defined by CONFIG_NF_CONNTRACK_MARK so any reference to it should follow the same. $ make -C tools/testing/selftests/bpf progs/test_bpf_nf.c:219:12: error: no member named 'mark' in 'struct nf_conn' if (ct->mark == 42) { ~~ ^ progs/test_bpf_nf.c:220:9: error: no member named 'mark' in 'struct nf_conn' ct->mark++; ~~ ^ progs/test_bpf_nf.c:221:34: error: no member named 'mark' in 'struct nf_conn' test_exist_lookup_mark = ct->mark; Signed-off-by: Mahmoud Maatuq <mahmoudmatook.mm(a)gmail.com> --- .../testing/selftests/bpf/progs/test_bpf_nf.c | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/tools/testing/selftests/bpf/progs/test_bpf_nf.c b/tools/testing/selftests/bpf/progs/test_bpf_nf.c index 77ad8adf68da..0b285de8b7e7 100644 --- a/tools/testing/selftests/bpf/progs/test_bpf_nf.c +++ b/tools/testing/selftests/bpf/progs/test_bpf_nf.c @@ -157,7 +157,10 @@ nf_ct_test(struct nf_conn *(*lookup_fn)(void *, struct bpf_sock_tuple *, u32, struct nf_conn *ct_ins; bpf_ct_set_timeout(ct, 10000); - ct->mark = 77; + #if defined(CONFIG_NF_CONNTRACK_MARK) + ct->mark = 77; + #endif + /* snat */ saddr.ip = bpf_get_prandom_u32(); @@ -188,7 +191,9 @@ nf_ct_test(struct nf_conn *(*lookup_fn)(void *, struct bpf_sock_tuple *, u32, bpf_ct_change_timeout(ct_lk, 10000); test_delta_timeout = ct_lk->timeout - bpf_jiffies64(); test_delta_timeout /= CONFIG_HZ; - test_insert_lookup_mark = ct_lk->mark; + #if defined(CONFIG_NF_CONNTRACK_MARK) + test_insert_lookup_mark = ct_lk->mark; + #endif bpf_ct_change_status(ct_lk, IPS_CONFIRMED | IPS_SEEN_REPLY); test_status = ct_lk->status; @@ -210,10 +215,12 @@ nf_ct_test(struct nf_conn *(*lookup_fn)(void *, struct bpf_sock_tuple *, u32, sizeof(opts_def)); if (ct) { test_exist_lookup = 0; - if (ct->mark == 42) { - ct->mark++; - test_exist_lookup_mark = ct->mark; - } + #if defined(CONFIG_NF_CONNTRACK_MARK) + if (ct->mark == 42) { + ct->mark++; + test_exist_lookup_mark = ct->mark; + } + #endif bpf_ct_release(ct); } else { test_exist_lookup = opts_def.error; -- 2.34.1

1 year, 1 month

2
1
0 0

[PATCH v2 00/35] arm64/gcs: Provide support for GCS in userspace

by Mark Brown

The arm64 Guarded Control Stack (GCS) feature provides support for hardware protected stacks of return addresses, intended to provide hardening against return oriented programming (ROP) attacks and to make it easier to gather call stacks for applications such as profiling. When GCS is active a secondary stack called the Guarded Control Stack is maintained, protected with a memory attribute which means that it can only be written with specific GCS operations. When a BL is executed the value stored in LR is also pushed onto the GCS, and when a RET is executed the top of the GCS is popped and compared to LR with a fault being raised if the values do not match. GCS operations may only be performed on GCS pages, a data abort is generated if they are not. This series implements support for use of GCS by userspace, along with support for use of GCS within KVM guests. It does not enable use of GCS by either EL1 or EL2. Executables are started without GCS and must use a prctl() to enable it, it is expected that this will be done very early in application execution by the dynamic linker or other startup code. x86 has an equivalent feature called shadow stacks, this series depends on the x86 patches for generic memory management support for the new guarded/shadow stack page type and shares APIs as much as possible. As there has been extensive discussion with the wider community around the ABI for shadow stacks I have as far as practical kept implementation decisions close to those for x86, anticipating that review would lead to similar conclusions in the absence of strong reasoning for divergence. The main divergence I am concious of is that x86 allows shadow stack to be enabled and disabled repeatedly, freeing the shadow stack for the thread whenever disabled, while this implementation keeps the GCS allocated after disable but refuses to reenable it. This is to avoid races with things actively walking the GCS during a disable, we do anticipate that some systems will wish to disable GCS at runtime but are not aware of any demand for subsequently reenabling it. x86 uses an arch_prctl() to manage enable and disable, since only x86 and S/390 use arch_prctl() a generic prctl() was proposed[1] as part of a patch set for the equivalent RISC-V zisslpcfi feature which I initially adopted fairly directly but following review feedback has been reviewed quite a bit. There is an open issue with support for CRIU, on x86 this required the ability to set the GCS mode via ptrace. This series supports configuring mode bits other than enable/disable via ptrace but it needs to be confirmed if this is sufficient. There's a few bits where I'm not convinced with where I've placed things, in particular the GCS write operation is in the GCS header not in uaccess.h, I wasn't sure what was clearest there and am probably too close to the code to have a clear opinion. The reporting of GCS in /proc/PID/smaps is also a bit awkward. The series depends on the x86 shadow stack support: https://lore.kernel.org/lkml/20230227222957.24501-1-rick.p.edgecombe@intel.… I've rebased this onto v6.5-rc3 but not included it in the series in order to avoid confusion with Rick's work and cut down the size of the series, you can see the branch at: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/misc.git arm64-gcs [1] https://lore.kernel.org/lkml/20230213045351.3945824-1-debug@rivosinc.com/ Signed-off-by: Mark Brown <broonie(a)kernel.org> --- Changes in v2: - Rebase onto v6.5-rc3. - Rework prctl() interface to allow each bit to be locked independently. - map_shadow_stack() now places the cap token based on the size requested by the caller not the actual space allocated. - Mode changes other than enable via ptrace are now supported. - Expand test coverage. - Various smaller fixes and adjustments. - Link to v1: https://lore.kernel.org/r/20230716-arm64-gcs-v1-0-bf567f93bba6@kernel.org --- Mark Brown (35): prctl: arch-agnostic prctl for shadow stack arm64: Document boot requirements for Guarded Control Stacks arm64/gcs: Document the ABI for Guarded Control Stacks arm64/sysreg: Add new system registers for GCS arm64/sysreg: Add definitions for architected GCS caps arm64/gcs: Add manual encodings of GCS instructions arm64/gcs: Provide copy_to_user_gcs() arm64/cpufeature: Runtime detection of Guarded Control Stack (GCS) arm64/mm: Allocate PIE slots for EL0 guarded control stack mm: Define VM_SHADOW_STACK for arm64 when we support GCS arm64/mm: Map pages for guarded control stack KVM: arm64: Manage GCS registers for guests arm64/el2_setup: Allow GCS usage at EL0 and EL1 arm64/idreg: Add overrride for GCS arm64/hwcap: Add hwcap for GCS arm64/traps: Handle GCS exceptions arm64/mm: Handle GCS data aborts arm64/gcs: Context switch GCS registers for EL0 arm64/gcs: Allocate a new GCS for threads with GCS enabled arm64/gcs: Implement shadow stack prctl() interface arm64/mm: Implement map_shadow_stack() arm64/signal: Set up and restore the GCS context for signal handlers arm64/signal: Expose GCS state in signal frames arm64/ptrace: Expose GCS via ptrace and core files arm64: Add Kconfig for Guarded Control Stack (GCS) kselftest/arm64: Verify the GCS hwcap kselftest/arm64: Add GCS as a detected feature in the signal tests kselftest/arm64: Add framework support for GCS to signal handling tests kselftest/arm64: Allow signals tests to specify an expected si_code kselftest/arm64: Always run signals tests with GCS enabled kselftest/arm64: Add very basic GCS test program kselftest/arm64: Add a GCS test program built with the system libc kselftest/arm64: Add test coverage for GCS mode locking selftests/arm64: Add GCS signal tests kselftest/arm64: Enable GCS for the FP stress tests Documentation/admin-guide/kernel-parameters.txt | 3 + Documentation/arch/arm64/booting.rst | 22 ++ Documentation/arch/arm64/elf_hwcaps.rst | 3 + Documentation/arch/arm64/gcs.rst | 225 +++++++++++++ Documentation/arch/arm64/index.rst | 1 + Documentation/filesystems/proc.rst | 2 +- arch/arm64/Kconfig | 19 ++ arch/arm64/include/asm/cpufeature.h | 6 + arch/arm64/include/asm/el2_setup.h | 17 + arch/arm64/include/asm/esr.h | 28 +- arch/arm64/include/asm/exception.h | 2 + arch/arm64/include/asm/gcs.h | 106 ++++++ arch/arm64/include/asm/hwcap.h | 1 + arch/arm64/include/asm/kvm_host.h | 12 + arch/arm64/include/asm/pgtable-prot.h | 14 +- arch/arm64/include/asm/processor.h | 7 + arch/arm64/include/asm/sysreg.h | 20 ++ arch/arm64/include/asm/uaccess.h | 42 +++ arch/arm64/include/uapi/asm/hwcap.h | 1 + arch/arm64/include/uapi/asm/ptrace.h | 8 + arch/arm64/include/uapi/asm/sigcontext.h | 9 + arch/arm64/kernel/cpufeature.c | 19 ++ arch/arm64/kernel/cpuinfo.c | 1 + arch/arm64/kernel/entry-common.c | 23 ++ arch/arm64/kernel/idreg-override.c | 2 + arch/arm64/kernel/process.c | 78 +++++ arch/arm64/kernel/ptrace.c | 59 ++++ arch/arm64/kernel/signal.c | 237 ++++++++++++- arch/arm64/kernel/traps.c | 11 + arch/arm64/kvm/hyp/include/hyp/sysreg-sr.h | 17 + arch/arm64/kvm/sys_regs.c | 22 ++ arch/arm64/mm/Makefile | 1 + arch/arm64/mm/fault.c | 78 ++++- arch/arm64/mm/gcs.c | 226 +++++++++++++ arch/arm64/mm/mmap.c | 17 +- arch/arm64/tools/cpucaps | 1 + arch/arm64/tools/sysreg | 55 +++ fs/proc/task_mmu.c | 3 + include/linux/mm.h | 16 +- include/linux/syscalls.h | 1 + include/uapi/asm-generic/unistd.h | 5 +- include/uapi/linux/elf.h | 1 + include/uapi/linux/prctl.h | 22 ++ kernel/sys.c | 30 ++ kernel/sys_ni.c | 1 + tools/testing/selftests/arm64/Makefile | 2 +- tools/testing/selftests/arm64/abi/hwcap.c | 19 ++ tools/testing/selftests/arm64/fp/assembler.h | 15 + tools/testing/selftests/arm64/fp/fpsimd-test.S | 2 + tools/testing/selftests/arm64/fp/sve-test.S | 2 + tools/testing/selftests/arm64/fp/za-test.S | 2 + tools/testing/selftests/arm64/fp/zt-test.S | 2 + tools/testing/selftests/arm64/gcs/.gitignore | 3 + tools/testing/selftests/arm64/gcs/Makefile | 19 ++ tools/testing/selftests/arm64/gcs/basic-gcs.c | 351 +++++++++++++++++++ tools/testing/selftests/arm64/gcs/gcs-locking.c | 200 +++++++++++ tools/testing/selftests/arm64/gcs/gcs-util.h | 87 +++++ tools/testing/selftests/arm64/gcs/libc-gcs.c | 372 +++++++++++++++++++++ tools/testing/selftests/arm64/signal/.gitignore | 1 + .../testing/selftests/arm64/signal/test_signals.c | 17 +- .../testing/selftests/arm64/signal/test_signals.h | 6 + .../selftests/arm64/signal/test_signals_utils.c | 32 +- .../selftests/arm64/signal/test_signals_utils.h | 39 +++ .../arm64/signal/testcases/gcs_exception_fault.c | 59 ++++ .../selftests/arm64/signal/testcases/gcs_frame.c | 78 +++++ .../arm64/signal/testcases/gcs_write_fault.c | 67 ++++ .../selftests/arm64/signal/testcases/testcases.c | 7 + .../selftests/arm64/signal/testcases/testcases.h | 1 + 68 files changed, 2825 insertions(+), 32 deletions(-) --- base-commit: b8f2cc1100d85456f9a48243328b33ab0ce5caff change-id: 20230303-arm64-gcs-e311ab0d8729 Best regards, -- Mark Brown <broonie(a)kernel.org>

1 year, 1 month

1
35
0 0

[PROBLEM] seltests: net/forwarding/sch_ets.sh [HANG]

by Mirsad Todorovac

Hi, Using the same config for 6.5-rc2 on Ubuntu 22.04 LTS and 22.10, the execution stop at the exact same line on both boxes (os I reckon it is more than an accident): # selftests: net/forwarding: sch_ets.sh # TEST: ping vlan 10 [ OK ] # TEST: ping vlan 11 [ OK ] # TEST: ping vlan 12 [ OK ] # Running in priomap mode # Testing ets bands 3 strict 3, streams 0 1 # TEST: band 0 [ OK ] # INFO: Expected ratio >95% Measured ratio 100.00 # TEST: band 1 [ OK ] # INFO: Expected ratio <5% Measured ratio 0 # Testing ets bands 3 strict 3, streams 1 2 # TEST: band 1 [ OK ] # INFO: Expected ratio >95% Measured ratio 100.00 # TEST: band 2 [ OK ] # INFO: Expected ratio <5% Measured ratio 0 # Testing ets bands 4 strict 1 quanta 5000 2500 1500, streams 0 1 # TEST: band 0 [ OK ] # INFO: Expected ratio >95% Measured ratio 100.00 # TEST: band 1 [ OK ] # INFO: Expected ratio <5% Measured ratio 0 # Testing ets bands 4 strict 1 quanta 5000 2500 1500, streams 1 2 # TEST: bands 1:2 [ OK ] # INFO: Expected ratio 2.00 Measured ratio 1.99 # Testing ets bands 3 quanta 3300 3300 3300, streams 0 1 2 # TEST: bands 0:1 [ OK ] # INFO: Expected ratio 1.00 Measured ratio .99 # TEST: bands 0:2 [ OK ] # INFO: Expected ratio 1.00 Measured ratio 1.00 # Testing ets bands 3 quanta 5000 3500 1500, streams 0 1 2 # TEST: bands 0:1 [ OK ] # INFO: Expected ratio 1.42 Measured ratio 1.42 # TEST: bands 0:2 [ OK ] # INFO: Expected ratio 3.33 Measured ratio 3.33 # Testing ets bands 3 quanta 5000 8000 1500, streams 0 1 2 # TEST: bands 0:1 [ OK ] # INFO: Expected ratio 1.60 Measured ratio 1.59 # TEST: bands 0:2 [ OK ] # INFO: Expected ratio 3.33 Measured ratio 3.33 # Testing ets bands 2 quanta 5000 2500, streams 0 1 # TEST: bands 0:1 [ OK ] # INFO: Expected ratio 2.00 Measured ratio 1.99 # Running in classifier mode # Testing ets bands 3 strict 3, streams 0 1 # TEST: band 0 [ OK ] # INFO: Expected ratio >95% Measured ratio 100.00 # TEST: band 1 [ OK ] # INFO: Expected ratio <5% Measured ratio 0 # Testing ets bands 3 strict 3, streams 1 2 # TEST: band 1 [ OK ] # INFO: Expected ratio >95% Measured ratio 100.00 # TEST: band 2 [ OK ] # INFO: Expected ratio <5% Measured ratio 0 # Testing ets bands 4 strict 1 quanta 5000 2500 1500, streams 0 1 I tried to run 'set -x' enabled version standalone, but that one finished correctly (?). It could be something previous scripts left, but right now I don't have a clue. I can attempt to rerun all tests with sch_ets.sh bash 'set -x' enabled later today. Best regards, Mirsad Todorovac

1 year, 1 month

2
7
0 0

Re: [PATCH 6.1 000/223] 6.1.40-rc1 review

by Naresh Kamboju

On Sat, 22 Jul 2023 at 00:47, Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> wrote: > > This is the start of the stable review cycle for the 6.1.40 release. > There are 223 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses should be made by Sun, 23 Jul 2023 16:04:33 +0000. > Anything received after that time might be too late. > > The whole patch series can be found in one patch at: > https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.40-rc1… > or in the git tree and branch at: > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y > and the diffstat can be found below. > > thanks, > > greg k-h Results from Linaro’s test farm. No regressions on arm64, arm, x86_64, and i386. Tested-by: Linux Kernel Functional Testing <lkft(a)linaro.org> NOTES: These are not kernel regressions as per the review, Following kselfest build regressions noticed on stable-rc 6.1 and 6.4 The selftests sources are from stable tree 6.4.y branch and version 6.4.4 selftest build errors: --------------------- 1) aarch64-linux-gnu-gcc -Wall -O2 -Wno-unused-function -D_GNU_SOURCE -pthread proc-empty-vm.c -o kselftest/proc/proc-empty-vm proc-empty-vm.c: In function 'main': proc-empty-vm.c:350:2: error: #error "implement 'unmap everything'" 350 | #error "implement 'unmap everything'" | ^~~~~ make[3]: *** [../lib.mk:147: kselftest/proc/proc-empty-vm] Error 1 2) make[3]: Entering directory 'tools/testing/selftests/tc-testing' /bin/sh: 1: llc: not found clang -I. -I/include/uapi -Wno-compare-distinct-pointer-types \ -O2 -target bpf -emit-llvm -c action.c -o - | \ llc -march=bpf -mcpu=probe -filetype=obj -o kselftest/tc-testing/action.o /bin/sh: 1: clang: not found /bin/sh: 3: llc: not found make[3]: *** [Makefile:26: kselftest/tc-testing/action.o] Error 127 ## Build * kernel: 6.1.40-rc1 * git: https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc * git branch: linux-6.1.y * git commit: e54fe15e179b2cc0f0587e2ef1549295ae7bc3be * git describe: v6.1.39-224-ge54fe15e179b * test details: https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-6.1.y/build/v6.1.3… ## Test Regressions (compared to v6.1.39) * bcm2711-rpi-4-b, kselftest-proc - shardfile-proc * bcm2711-rpi-4-b, kselftest-tc-testing - shardfile-tc-testing * dragonboard-410c, kselftest-proc - shardfile-proc * dragonboard-410c, kselftest-tc-testing - shardfile-tc-testing * juno-r2, kselftest-proc - shardfile-proc * juno-r2, kselftest-tc-testing - shardfile-tc-testing ## Metric Regressions (compared to v6.1.39) ## Test Fixes (compared to v6.1.39) ## Metric Fixes (compared to v6.1.39) ## Test result summary total: 149107, pass: 126633, fail: 2237, skip: 20065, xfail: 172 ## Build Summary * arc: 5 total, 5 passed, 0 failed * arm: 151 total, 150 passed, 1 failed * arm64: 57 total, 56 passed, 1 failed * i386: 41 total, 38 passed, 3 failed * mips: 30 total, 28 passed, 2 failed * parisc: 4 total, 4 passed, 0 failed * powerpc: 38 total, 36 passed, 2 failed * riscv: 16 total, 15 passed, 1 failed * s390: 16 total, 16 passed, 0 failed * sh: 14 total, 12 passed, 2 failed * sparc: 8 total, 8 passed, 0 failed * x86_64: 46 total, 46 passed, 0 failed ## Test suites summary * boot * kselftest-android * kselftest-arm64 * kselftest-breakpoints * kselftest-capabilities * kselftest-cgroup * kselftest-clone3 * kselftest-core * kselftest-cpu-hotplug * kselftest-cpufreq * kselftest-drivers-dma-buf * kselftest-efivarfs * kselftest-exec * kselftest-filesystems * kselftest-filesystems-binderfs * kselftest-filesytems-epoll * kselftest-firmware * kselftest-fpu * kselftest-ftrace * kselftest-futex * kselftest-gpio * kselftest-intel_pstate * kselftest-ipc * kselftest-ir * kselftest-kcmp * kselftest-kexec * kselftest-kvm * kselftest-lib * kselftest-membarrier * kselftest-memfd * kselftest-memory-hotplug * kselftest-mincore * kselftest-mount * kselftest-mqueue * kselftest-net * kselftest-net-forwarding * kselftest-net-mptcp * kselftest-netfilter * kselftest-nsfs * kselftest-openat2 * kselftest-pid_namespace * kselftest-pidfd * kselftest-proc * kselftest-pstore * kselftest-ptrace * kselftest-rseq * kselftest-rtc * kselftest-seccomp * kselftest-sigaltstack * kselftest-size * kselftest-splice * kselftest-static_keys * kselftest-sync * kselftest-sysctl * kselftest-tc-testing * kselftest-timens * kselftest-tmpfs * kselftest-tpm2 * kselftest-user_events * kselftest-vDSO * kselftest-watchdog * kselftest-x86 * kunit * kvm-unit-tests * libgpiod * libhugetlbfs * log-parser-boot * log-parser-test * ltp-cap_bounds * ltp-commands * ltp-containers * ltp-controllers * ltp-cpuhotplug * ltp-crypto * ltp-cve * ltp-dio * ltp-fcntl-locktests * ltp-filecaps * ltp-fs * ltp-fs_bind * ltp-fs_perms_simple * ltp-fsx * ltp-hugetlb * ltp-io * ltp-ipc * ltp-math * ltp-mm * ltp-nptl * ltp-pty * ltp-sched * ltp-securebits * ltp-smoke * ltp-syscalls * ltp-tracing * network-basic-tests * perf * rcutorture * v4l2-compliance -- Linaro LKFT https://lkft.linaro.org

1 year, 1 month

1
0
0 0

[PATCH v5] selftests: rtc: Fixes rtctest error handling.

by Atul Kumar Pant

Adds a check to verify if the rtc device file is valid or not and prints a useful error message if the file is not accessible. Signed-off-by: Atul Kumar Pant <atulpant.linux(a)gmail.com> Acked-by: Alexandre Belloni <alexandre.belloni(a)bootlin.com> --- changes since v4: Updated the commit message. changes since v3: Added Linux-kselftest and Linux-kernel mailing lists. changes since v2: Changed error message when rtc file does not exist. changes since v1: Removed check for uid=0 If rtc file is invalid, then exit the test. tools/testing/selftests/rtc/rtctest.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/rtc/rtctest.c b/tools/testing/selftests/rtc/rtctest.c index 63ce02d1d5cc..630fef735c7e 100644 --- a/tools/testing/selftests/rtc/rtctest.c +++ b/tools/testing/selftests/rtc/rtctest.c @@ -17,6 +17,7 @@ #include <unistd.h> #include "../kselftest_harness.h" +#include "../kselftest.h" #define NUM_UIE 3 #define ALARM_DELTA 3 @@ -419,6 +420,8 @@ __constructor_order_last(void) int main(int argc, char **argv) { + int ret = -1; + switch (argc) { case 2: rtc_file = argv[1]; @@ -430,5 +433,11 @@ int main(int argc, char **argv) return 1; } - return test_harness_run(argc, argv); + // Run the test if rtc_file is valid + if (access(rtc_file, F_OK) == 0) + ret = test_harness_run(argc, argv); + else + ksft_exit_fail_msg("[ERROR]: Cannot access rtc file %s - Exiting\n", rtc_file); + + return ret; } -- 2.25.1

1 year, 1 month

1
0
0 0

[PATCH v1 0/9] kunit: Add test attributes API

by Rae Moar

Hello everyone, This patch series adds a test attributes framework to KUnit. There has been interest in filtering out "slow" KUnit tests. Most notably, a new config, CONFIG_MEMCPY_SLOW_KUNIT_TEST, has been added to exclude a particularly slow memcpy test (https://lore.kernel.org/all/20230118200653.give.574-kees@kernel.org/). This attributes framework can be used to save and access test associated data, including whether a test is slow. These attributes are reportable (via KTAP and command line output) and are also filterable. This framework is designed to allow for the addition of other attributes in the future. These attributes could include whether the test can be run concurrently, test file path, etc. To try out the framework I suggest running: "./tools/testing/kunit/kunit.py run --filter speed!=slow" This patch series was originally sent out as an RFC. Here is a link to the RFC v2: https://lore.kernel.org/all/20230707210947.1208717-1-rmoar@google.com/ Thanks! Rae Rae Moar (9): kunit: Add test attributes API structure kunit: Add speed attribute kunit: Add module attribute kunit: Add ability to filter attributes kunit: tool: Add command line interface to filter and report attributes kunit: memcpy: Mark tests as slow using test attributes kunit: time: Mark test as slow using test attributes kunit: add tests for filtering attributes kunit: Add documentation of KUnit test attributes .../dev-tools/kunit/running_tips.rst | 166 +++++++ include/kunit/attributes.h | 50 +++ include/kunit/test.h | 70 ++- kernel/time/time_test.c | 2 +- lib/Kconfig.debug | 3 + lib/kunit/Makefile | 3 +- lib/kunit/attributes.c | 421 ++++++++++++++++++ lib/kunit/executor.c | 115 ++++- lib/kunit/executor_test.c | 128 +++++- lib/kunit/kunit-example-test.c | 9 + lib/kunit/test.c | 27 +- lib/memcpy_kunit.c | 8 +- tools/testing/kunit/kunit.py | 70 ++- tools/testing/kunit/kunit_kernel.py | 8 +- tools/testing/kunit/kunit_parser.py | 11 +- tools/testing/kunit/kunit_tool_test.py | 39 +- 16 files changed, 1054 insertions(+), 76 deletions(-) create mode 100644 include/kunit/attributes.h create mode 100644 lib/kunit/attributes.c base-commit: 64bd4641310c41a1ecf07c13c67bc0ed61045dfd -- 2.41.0.255.g8b1d071c50-goog

1 year, 1 month

2
11
0 0

[BUG] sefltests: forwarding: gre_custom_multipath_hash.sh: [FAIL] and syntax errors

by Mirsad Todorovac

Hi, It's me again. Don't throw things at me, but it is the same old vanilla torvalds tree kernel 6.5-rc2 kselftest run, and after applying the patches I ran into the new problems: I have been free to add the timeout SIGTERM trap to the test, and this is the only change, save for the Ido's lib.sh patch (for filling the veth NETIFS array in default execution case). Here is the command output: # selftests: net/forwarding: gre_custom_multipath_hash.sh # TEST: ping [ OK ] # TEST: ping6 [ OK ] # INFO: Running IPv4 overlay custom multipath hash tests # TEST: Multipath hash field: Inner source IP (balanced) [ OK ] # INFO: Packets sent on path1 / path2: 6760 / 5859 # TEST: Multipath hash field: Inner source IP (unbalanced) [ OK ] # INFO: Packets sent on path1 / path2: 2 / 12603 # TEST: Multipath hash field: Inner destination IP (balanced) [ OK ] # INFO: Packets sent on path1 / path2: 5850 / 6750 # TEST: Multipath hash field: Inner destination IP (unbalanced) [ OK ] # INFO: Packets sent on path1 / path2: 12602 / 1 # TEST: Multipath hash field: Inner source port (balanced) [ OK ] # INFO: Packets sent on path1 / path2: 16411 / 16364 # TEST: Multipath hash field: Inner source port (unbalanced) [ OK ] # INFO: Packets sent on path1 / path2: 32773 / 3 # TEST: Multipath hash field: Inner destination port (balanced) [ OK ] # INFO: Packets sent on path1 / path2: 16410 / 16362 # TEST: Multipath hash field: Inner destination port (unbalanced) [ OK ] # INFO: Packets sent on path1 / path2: 32770 / 0 # INFO: Running IPv6 overlay custom multipath hash tests # TEST: Multipath hash field: Inner source IP (balanced) [ OK ] # INFO: Packets sent on path1 / path2: 6150 / 6452 # TEST: Multipath hash field: Inner source IP (unbalanced) [ OK ] # INFO: Packets sent on path1 / path2: 0 / 12600 # jq: error (at <stdin>:1): Cannot iterate over null (null) # jq: error (at <stdin>:1): Cannot iterate over null (null) # TEST: Multipath hash field: Inner destination IP (balanced) [FAIL] # Expected traffic to be balanced, but it is not # INFO: Packets sent on path1 / path2: -129763 / -77050 # jq: error (at <stdin>:1): Cannot iterate over null (null) # jq: error (at <stdin>:1): Cannot iterate over null (null) # Invalid VRF name # jq: error (at <stdin>:1): Cannot iterate over null (null) # jq: error (at <stdin>:1): Cannot iterate over null (null) # Runtime error (func=(main), adr=3): Divide by zero # (standard_in) 1: syntax error # TEST: Multipath hash field: Inner destination IP (unbalanced) [ OK ] # INFO: Packets sent on path1 / path2: 0 / 0 # jq: error (at <stdin>:1): Cannot iterate over null (null) # jq: error (at <stdin>:1): Cannot iterate over null (null) # jq: error (at <stdin>:1): Cannot iterate over null (null) # jq: error (at <stdin>:1): Cannot iterate over null (null) # Runtime error (func=(main), adr=3): Divide by zero # (standard_in) 1: syntax error # TEST: Multipath hash field: Inner flowlabel (balanced) [FAIL] # Expected traffic to be balanced, but it is not # INFO: Packets sent on path1 / path2: 0 / 0 # jq: error (at <stdin>:1): Cannot iterate over null (null) # jq: error (at <stdin>:1): Cannot iterate over null (null) # Invalid VRF name # jq: error (at <stdin>:1): Cannot iterate over null (null) # jq: error (at <stdin>:1): Cannot iterate over null (null) # Runtime error (func=(main), adr=3): Divide by zero # (standard_in) 1: syntax error # TEST: Multipath hash field: Inner flowlabel (unbalanced) [ OK ] # INFO: Packets sent on path1 / path2: 0 / 0 # jq: error (at <stdin>:1): Cannot iterate over null (null) # jq: error (at <stdin>:1): Cannot iterate over null (null) # Invalid VRF name # jq: error (at <stdin>:1): Cannot iterate over null (null) # jq: error (at <stdin>:1): Cannot iterate over null (null) # Runtime error (func=(main), adr=3): Divide by zero # (standard_in) 1: syntax error # TEST: Multipath hash field: Inner source port (balanced) [FAIL] # Expected traffic to be balanced, but it is not # INFO: Packets sent on path1 / path2: 0 / 0 # jq: error (at <stdin>:1): Cannot iterate over null (null) # jq: error (at <stdin>:1): Cannot iterate over null (null) # Invalid VRF name # jq: error (at <stdin>:1): Cannot iterate over null (null) # jq: error (at <stdin>:1): Cannot iterate over null (null) # Runtime error (func=(main), adr=3): Divide by zero # (standard_in) 1: syntax error # TEST: Multipath hash field: Inner source port (unbalanced) [ OK ] # INFO: Packets sent on path1 / path2: 0 / 0 # jq: error (at <stdin>:1): Cannot iterate over null (null) # jq: error (at <stdin>:1): Cannot iterate over null (null) # Invalid VRF name # jq: error (at <stdin>:1): Cannot iterate over null (null) # jq: error (at <stdin>:1): Cannot iterate over null (null) # Runtime error (func=(main), adr=3): Divide by zero # (standard_in) 1: syntax error # TEST: Multipath hash field: Inner destination port (balanced) [FAIL] # Expected traffic to be balanced, but it is not # INFO: Packets sent on path1 / path2: 0 / 0 # jq: error (at <stdin>:1): Cannot iterate over null (null) # jq: error (at <stdin>:1): Cannot iterate over null (null) # Invalid VRF name # jq: error (at <stdin>:1): Cannot iterate over null (null) # jq: error (at <stdin>:1): Cannot iterate over null (null) # Runtime error (func=(main), adr=3): Divide by zero # (standard_in) 1: syntax error # TEST: Multipath hash field: Inner destination port (unbalanced) [ OK ] # INFO: Packets sent on path1 / path2: 0 / 0 # Error: argument "vveth9" is wrong: Invalid VRF # # Error: argument "vveth9" is wrong: Invalid VRF # # RTNETLINK answers: Cannot assign requested address # RTNETLINK answers: Cannot assign requested address # RTNETLINK answers: No such process # RTNETLINK answers: No such process # Cannot find device "vveth9" # Error: argument "vveth8" is wrong: Invalid VRF # # Error: argument "vveth8" is wrong: Invalid VRF # # Error: argument "vveth8" is wrong: Invalid VRF # # Cannot find device "g2" # Cannot find device "g2" # Cannot find device "g2" # Cannot find device "g2" # RTNETLINK answers: Cannot assign requested address # RTNETLINK answers: Cannot assign requested address # RTNETLINK answers: Cannot assign requested address # RTNETLINK answers: No such process # RTNETLINK answers: No such process # Cannot find device "vveth8" # Error: Invalid handle. # Error: argument "vveth6" is wrong: Invalid VRF # # Error: argument "vveth6" is wrong: Invalid VRF # # Cannot find device "veth5.222" # Cannot find device "veth5.111" # RTNETLINK answers: Cannot assign requested address # RTNETLINK answers: No such process # RTNETLINK answers: No such process # Cannot find device "vveth6" # Error: argument "vveth3" is wrong: Invalid VRF # # Error: argument "vveth3" is wrong: Invalid VRF # # Cannot find device "veth4.222" # Cannot find device "veth4.111" # RTNETLINK answers: Cannot assign requested address # RTNETLINK answers: No such process # RTNETLINK answers: No such process # Cannot find device "vveth3" # Error: argument "vveth1" is wrong: Invalid VRF # # Error: argument "vveth1" is wrong: Invalid VRF # # Error: argument "vveth1" is wrong: Invalid VRF # # Cannot find device "g1" # Cannot find device "g1" # Cannot find device "g1" # Cannot find device "g1" # RTNETLINK answers: Cannot assign requested address # RTNETLINK answers: Cannot assign requested address # RTNETLINK answers: Cannot assign requested address # RTNETLINK answers: No such process # RTNETLINK answers: No such process # Cannot find device "vveth1" # Error: argument "vveth0" is wrong: Invalid VRF # # Error: argument "vveth0" is wrong: Invalid VRF # # RTNETLINK answers: Cannot assign requested address # RTNETLINK answers: Cannot assign requested address # RTNETLINK answers: No such process # RTNETLINK answers: No such process # Cannot find device "vveth0" # RTNETLINK answers: File exists # RTNETLINK answers: No such file or directory # RTNETLINK answers: File exists # RTNETLINK answers: No such file or directory # not ok 18 selftests: net/forwarding: gre_custom_multipath_hash.sh # TIMEOUT 240 seconds Those things like RTNETLINK errors probably mess up things beyond what cleanup does, so the reproducer might not be that easy to devise. I have tried to reduce the complexity by adding: trap cleanup INT TERM EXIT to the tests that timed out. Kind regards, Mirsad

1 year, 2 months

1
0
0 0

[PROBLEM] selftests: net/forwarding/*.sh: 'Command line is not complete. Try option "help"'

by Mirsad Todorovac

Hi, There seems to be a problem with net/forwarding line of 6.5-rc2 kselftests, vanilla Torvalds tree, commit fdf0eaf11452, on Ubuntu 22.04 LTS Jammy Jellyfish. (Confirmed on Ubuntu 22.10 Kinetic Kudu.) Tests fail with error message: Command line is not complete. Try option "help" Failed to create netif The script # tools/testing/seltests/net/forwarding/bridge_igmp.sh bash `set -x` ends with an error: ++ create_netif_veth ++ local i ++ (( i = 1 )) ++ (( i <= NUM_NETIFS )) ++ local j=2 ++ ip link show dev ++ [[ 255 -ne 0 ]] ++ ip link add type veth peer name Command line is not complete. Try option "help" ++ [[ 255 -ne 0 ]] ++ echo 'Failed to create netif' Failed to create netif ++ exit 1 The problem seems to be linked with this piece of code of "lib.sh": create_netif_veth() { local i for ((i = 1; i <= NUM_NETIFS; ++i)); do local j=$((i+1)) ip link show dev ${NETIFS[p$i]} &> /dev/null if [[ $? -ne 0 ]]; then ip link add ${NETIFS[p$i]} type veth \ peer name ${NETIFS[p$j]} if [[ $? -ne 0 ]]; then echo "Failed to create netif" exit 1 fi fi i=$j done } Somehow, ${NETIFS[p$i]} is evaluated to an empty string? However, I can't seem to see what is the expected result. The problem was confirmed in the backlogs of 6.5-rc1 and 6.4 kselftests. It is possible that I'm doing something terribly wrong, but it is basically the default kselftest suite on a rather minimal Ubuntu. Please find attached the bash output from `set -x`. Version of iproute2 is: ii iproute2 5.15.0-1ubuntu2 amd64 networking and traffic control tools Hope this helps. Best regards, Mirsad Todorovac

1 year, 2 months

3
7
0 0

2024

2023

2022

2021

2020

2019

2018

2017

Linux-kselftest-mirror July 2023