August 2023 - Linux-kselftest-mirror

selftests: net/af_unix test_unix_oob [FAILED]

by Mirsad Todorovac

Hi all, In the kernel 6.5-rc5 build on Ubuntu 22.04 LTS (jammy jellyfish) on a Ryzen 7950 assembled box, vanilla torvalds tree kernel, the test test_unix_oob unexpectedly fails: # selftests: net/af_unix: test_unix_oob # Test 2 failed, sigurg 23 len 63 OOB % It is this code: /* Test 2: * Verify that the first OOB is over written by * the 2nd one and the first OOB is returned as * part of the read, and sigurg is received. */ wait_for_data(pfd, POLLIN | POLLPRI); len = 0; while (len < 70) len = recv(pfd, buf, 1024, MSG_PEEK); len = read_data(pfd, buf, 1024); read_oob(pfd, &oob); if (!signal_recvd || len != 127 || oob != '#') { fprintf(stderr, "Test 2 failed, sigurg %d len %d OOB %c\n", signal_recvd, len, oob); die(1); } In 6.5-rc4, this test was OK, so it might mean we have a regression? marvin@defiant:~/linux/kernel/linux_torvalds$ grep test_unix_oob ../kselftest-6.5-rc4-1.log /net/af_unix/test_unix_oob # selftests: net/af_unix: test_unix_oob ok 2 selftests: net/af_unix: test_unix_oob marvin@defiant:~/linux/kernel/linux_torvalds$ Hope this helps. NOTE: the kernel is vanilla torvalds tree, only "dirty" because the selftests were modified. Kind regards, Mirsad Todorovac

1 year, 4 months

2
5
0 0

[PATCH 1/2] asm-generic: current: Don't include thread-info.h if building asm

by David Gow

asm/current.h is included by some assembly files (either directly, or indirectly). This works on some architectures (such as x86), as their implementation of current.h is careful to not include any C, but the asm-generic version includes linux/thread-info.h unconditionally, which leads to errors when either C code or non-asm-compatible preprocessor directives are included. Just wrap the contents behind an #ifndef __ASSEMBLY__ to avoid any C code making its way in. Signed-off-by: David Gow <davidgow(a)google.com> --- This is requrired for patch #2 here, as UML uses this asm-generic header, but works with x86 assembly files which are expecting the x86 current.h, which is assembly-friendly. --- include/asm-generic/current.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/asm-generic/current.h b/include/asm-generic/current.h index 3a2e224b9fa0..9c2aeecbd05a 100644 --- a/include/asm-generic/current.h +++ b/include/asm-generic/current.h @@ -2,9 +2,11 @@ #ifndef __ASM_GENERIC_CURRENT_H #define __ASM_GENERIC_CURRENT_H +#ifndef __ASSEMBLY__ #include <linux/thread_info.h> #define get_current() (current_thread_info()->task) #define current get_current() +#endif #endif /* __ASM_GENERIC_CURRENT_H */ -- 2.41.0.255.g8b1d071c50-goog

1 year, 4 months

3
3
0 0

[PATCH v2] selftests/tpm2: tpm2-parse-error.py

by Jarkko Sakkinen

Add a script to quickly parse any TPM error code. This can be useful, e.g. when parsing klog output when TPM fails in an internal kernel operation. Example transcript: $ python3 tpm2-parse-error.py 0x1C4 TPM_RC_VALUE: rc=0x000001c4 Signed-off-by: Jarkko Sakkinen <jarkko(a)kernel.org> --- v2: Makefile: s/tpm2-parse-error/tpm2-parse-error.py/ --- tools/testing/selftests/tpm2/Makefile | 2 +- .../testing/selftests/tpm2/tpm2-parse-error.py | 17 +++++++++++++++++ 2 files changed, 18 insertions(+), 1 deletion(-) create mode 100644 tools/testing/selftests/tpm2/tpm2-parse-error.py diff --git a/tools/testing/selftests/tpm2/Makefile b/tools/testing/selftests/tpm2/Makefile index a9bf9459fb25..dbff77612785 100644 --- a/tools/testing/selftests/tpm2/Makefile +++ b/tools/testing/selftests/tpm2/Makefile @@ -2,4 +2,4 @@ include ../lib.mk TEST_PROGS := test_smoke.sh test_space.sh test_async.sh -TEST_PROGS_EXTENDED := tpm2.py tpm2_tests.py +TEST_PROGS_EXTENDED := tpm2.py tpm2_tests.py tpm2-parse-error.py diff --git a/tools/testing/selftests/tpm2/tpm2-parse-error.py b/tools/testing/selftests/tpm2/tpm2-parse-error.py new file mode 100644 index 000000000000..8eed72681af1 --- /dev/null +++ b/tools/testing/selftests/tpm2/tpm2-parse-error.py @@ -0,0 +1,17 @@ +#!/usr/bin/env python3 +# SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) + +from argparse import ArgumentParser +from argparse import FileType +import os +import sys +import tpm2 + +def main(): + parser = ArgumentParser(description='Parse a TPM error code') + parser.add_argument('rc', type=(lambda x: int(x, 0))) + args = parser.parse_args() + print(str(tpm2.ProtocolError(None, args.rc))) + +if __name__ == '__main__': + main() -- 2.39.2

1 year, 4 months

1
0
0 0

[PATCH] selftests/tpm2: tpm2-parse-error.py

by Jarkko Sakkinen

Add a script to quickly parse any TPM error code. This can be useful, e.g. when parsing klog output when TPM fails in an internal kernel operation. Example transcript: $ python3 tpm2-parse-error.py 0x1C4 TPM_RC_VALUE: rc=0x000001c4 Signed-off-by: Jarkko Sakkinen <jarkko(a)kernel.org> --- tools/testing/selftests/tpm2/Makefile | 2 +- .../testing/selftests/tpm2/tpm2-parse-error.py | 17 +++++++++++++++++ 2 files changed, 18 insertions(+), 1 deletion(-) create mode 100644 tools/testing/selftests/tpm2/tpm2-parse-error.py diff --git a/tools/testing/selftests/tpm2/Makefile b/tools/testing/selftests/tpm2/Makefile index a9bf9459fb25..b2c0504bcca6 100644 --- a/tools/testing/selftests/tpm2/Makefile +++ b/tools/testing/selftests/tpm2/Makefile @@ -2,4 +2,4 @@ include ../lib.mk TEST_PROGS := test_smoke.sh test_space.sh test_async.sh -TEST_PROGS_EXTENDED := tpm2.py tpm2_tests.py +TEST_PROGS_EXTENDED := tpm2.py tpm2_tests.py tpm2-parse-error diff --git a/tools/testing/selftests/tpm2/tpm2-parse-error.py b/tools/testing/selftests/tpm2/tpm2-parse-error.py new file mode 100644 index 000000000000..8eed72681af1 --- /dev/null +++ b/tools/testing/selftests/tpm2/tpm2-parse-error.py @@ -0,0 +1,17 @@ +#!/usr/bin/env python3 +# SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) + +from argparse import ArgumentParser +from argparse import FileType +import os +import sys +import tpm2 + +def main(): + parser = ArgumentParser(description='Parse a TPM error code') + parser.add_argument('rc', type=(lambda x: int(x, 0))) + args = parser.parse_args() + print(str(tpm2.ProtocolError(None, args.rc))) + +if __name__ == '__main__': + main() -- 2.39.2

1 year, 4 months

1
0
0 0

[PATCH] selftests/tpm2: tpm2-parse-error.py

by Jarkko Sakkinen

Add a script to quickly parse any TPM error code. This can be useful, e.g. when parsing klog output when TPM fails in an internal kernel operation. Example transcript: $ python3 tpm2-parse-error.py 0x1C4 TPM_RC_VALUE: rc=0x000001c4 Signed-off-by: Jarkko Sakkinen <jarkko(a)kernel.org> --- tools/testing/selftests/tpm2/Makefile | 2 +- .../testing/selftests/tpm2/tpm2-parse-error.py | 17 +++++++++++++++++ 2 files changed, 18 insertions(+), 1 deletion(-) create mode 100644 tools/testing/selftests/tpm2/tpm2-parse-error.py diff --git a/tools/testing/selftests/tpm2/Makefile b/tools/testing/selftests/tpm2/Makefile index a9bf9459fb25..b2c0504bcca6 100644 --- a/tools/testing/selftests/tpm2/Makefile +++ b/tools/testing/selftests/tpm2/Makefile @@ -2,4 +2,4 @@ include ../lib.mk TEST_PROGS := test_smoke.sh test_space.sh test_async.sh -TEST_PROGS_EXTENDED := tpm2.py tpm2_tests.py +TEST_PROGS_EXTENDED := tpm2.py tpm2_tests.py tpm2-parse-error diff --git a/tools/testing/selftests/tpm2/tpm2-parse-error.py b/tools/testing/selftests/tpm2/tpm2-parse-error.py new file mode 100644 index 000000000000..8eed72681af1 --- /dev/null +++ b/tools/testing/selftests/tpm2/tpm2-parse-error.py @@ -0,0 +1,17 @@ +#!/usr/bin/env python3 +# SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) + +from argparse import ArgumentParser +from argparse import FileType +import os +import sys +import tpm2 + +def main(): + parser = ArgumentParser(description='Parse a TPM error code') + parser.add_argument('rc', type=(lambda x: int(x, 0))) + args = parser.parse_args() + print(str(tpm2.ProtocolError(None, args.rc))) + +if __name__ == '__main__': + main() -- 2.39.2

1 year, 4 months

1
0
0 0

Greetings from Ukraine,

by Mr.Razum Khailo

Greetings from Ukraine, Mr. Razumkov Mykhailo, an entrepreneur businessman from Odessa Ukraine. Within a year plus some months now, more than 8.2 million people around the cities of my country Ukraine have been evacuated to a safe location and out of the country, most especially children with their parents, nursing mothers and pregnant women, and those who have been seriously wounded and need urgent medical attention. I was among those that were able to evacuate to our neighbouring countries and I’m now in the refugee camp of Ter Apel Groningen in the Netherlands. I need a foreign partner to enable me to transport my investment capital and then relocate with my family, honestly i wish I will discuss more and get along. I need a partner because my investment capital is in my international account. I’m interested in buying properties, houses, building real estates, my capital for investment is ($30 Million USD) . The financial institutions in my country Ukraine are all shot down due to the crisis of this war on Ukraine soil by the Russian forces. Meanwhile, if there is any profitable investment that you have so much experience in your country, then we can join together as partners since I’m a foreigner. I came across your e-mail contact through private search while in need of your assistance and I decided to contact you directly to ask you if you know any lucrative business investment in your country i can invest my money since my country Ukraine security and economic independent has lost to the greatest lower level, and our culture has lost including our happiness has been taken away from us. Our country has been on fire for more than a year now. If you are capable of handling this business partnership, contact me for more details, I will appreciate it if you can contact me immediately. You may as well tell me a little more about yourself. Contact me urgently to enable us to proceed with the business. I will be waiting for your response. My sincere apologies for the inconvenience. Thank you! Mr. Razumkov Mykhailo.

1 year, 4 months

1
0
0 0

[RFC PATCH bpf-next 0/2] bpf, x64: Fix tailcall infinite loop bug

by Leon Hwang

From commit ebf7d1f508a73871 ("bpf, x64: rework pro/epilogue and tailcall handling in JIT"), the tailcall on x64 works better than before. From commit e411901c0b775a3a ("bpf: allow for tailcalls in BPF subprograms for x64 JIT"), tailcall is able to run in BPF subprograms on x64. From commit 5b92a28aae4dd0f8 ("bpf: Support attaching tracing BPF program to other BPF programs"), BPF program is able to trace other BPF programs. How about combining them all together? 1. FENTRY/FEXIT on a BPF subprogram. 2. A tailcall runs in the BPF subprogram. 3. The tailcall calls itself. As a result, a tailcall infinite loop comes up. And the loop would halt the machine. As we know, in tail call context, the tail_call_cnt propagates by stack and RAX register between BPF subprograms. So do it in FENTRY/FEXIT trampolines. How did I discover the bug? From commit 7f6e4312e15a5c37 ("bpf: Limit caller's stack depth 256 for subprogs with tailcalls"), the total stack size limits to around 8KiB. Then, I write some bpf progs to validate the stack consuming, that are tailcalls running in bpf2bpf and FENTRY/FEXIT tracing on bpf2bpf[1]. At that time, accidently, I made a tailcall loop. And then the loop halted my VM. Without the loop, the bpf progs would consume over 8KiB stack size. But the _stack-overflow_ did not halt my VM. With bpf_printk(), I confirmed that the tailcall count limit did not work expectedly. Next, read the code and fix it. Finally, unfortunately, I only fix it on x64 but other arches. As a result, CI tests failed because this bug hasn't been fixed on s390x. Some helps are requested. [1]: https://github.com/Asphaltt/learn-by-example/tree/main/ebpf/tailcall-stacko… Leon Hwang (2): bpf, x64: Fix tailcall infinite loop bug selftests/bpf: Add testcases for tailcall infinite loop bug fixing arch/x86/net/bpf_jit_comp.c | 23 ++- include/linux/bpf.h | 6 + kernel/bpf/trampoline.c | 5 +- kernel/bpf/verifier.c | 9 +- .../selftests/bpf/prog_tests/tailcalls.c | 194 +++++++++++++++++- .../bpf/progs/tailcall_bpf2bpf_fentry.c | 18 ++ .../bpf/progs/tailcall_bpf2bpf_fexit.c | 18 ++ 7 files changed, 264 insertions(+), 9 deletions(-) create mode 100644 tools/testing/selftests/bpf/progs/tailcall_bpf2bpf_fentry.c create mode 100644 tools/testing/selftests/bpf/progs/tailcall_bpf2bpf_fexit.c base-commit: 9930e4af4b509bcf6f060b09b16884f26102d110 -- 2.41.0

1 year, 4 months

3
9
0 0

[RFC PATCH 00/11] New KVM ioctl to link a gmem inode to a new gmem file

by Ackerley Tng

Hello, This patchset builds upon the code at https://lore.kernel.org/lkml/20230718234512.1690985-1-seanjc@google.com/T/. This code is available at https://github.com/googleprodkernel/linux-cc/tree/kvm-gmem-link-migrate-rfc…. In guest_mem v11, a split file/inode model was proposed, where memslot bindings belong to the file and pages belong to the inode. This model lends itself well to having different VMs use separate files pointing to the same inode. This RFC proposes an ioctl, KVM_LINK_GUEST_MEMFD, that takes a VM and a gmem fd, and returns another gmem fd referencing a different file and associated with VM. This RFC also includes an update to KVM_CAP_VM_MOVE_ENC_CONTEXT_FROM to migrate memory context (slot->arch.lpage_info and kvm->mem_attr_array) from source to destination vm, intra-host. Intended usage of the two ioctls: 1. Source VM’s fd is passed to destination VM via unix sockets 2. Destination VM uses new ioctl KVM_LINK_GUEST_MEMFD to link source VM’s fd to a new fd. 3. Destination VM will pass new fds to KVM_SET_USER_MEMORY_REGION, which will bind the new file, pointing to the same inode that the source VM’s file points to, to memslots 4. Use KVM_CAP_VM_MOVE_ENC_CONTEXT_FROM to move kvm->mem_attr_array and slot->arch.lpage_info to the destination VM. 5. Run the destination VM as per normal Some other approaches considered were: + Using the linkat() syscall, but that requires a mount/directory for a source fd to be linked to + Using the dup() syscall, but that only duplicates the fd, and both fds point to the same file --- Ackerley Tng (11): KVM: guest_mem: Refactor out kvm_gmem_alloc_file() KVM: guest_mem: Add ioctl KVM_LINK_GUEST_MEMFD KVM: selftests: Add tests for KVM_LINK_GUEST_MEMFD ioctl KVM: selftests: Test transferring private memory to another VM KVM: x86: Refactor sev's flag migration_in_progress to kvm struct KVM: x86: Refactor common code out of sev.c KVM: x86: Refactor common migration preparation code out of sev_vm_move_enc_context_from KVM: x86: Let moving encryption context be configurable KVM: x86: Handle moving of memory context for intra-host migration KVM: selftests: Generalize migration functions from sev_migrate_tests.c KVM: selftests: Add tests for migration of private mem arch/x86/include/asm/kvm_host.h | 4 +- arch/x86/kvm/svm/sev.c | 85 ++----- arch/x86/kvm/svm/svm.h | 3 +- arch/x86/kvm/x86.c | 221 +++++++++++++++++- arch/x86/kvm/x86.h | 6 + include/linux/kvm_host.h | 18 ++ include/uapi/linux/kvm.h | 8 + tools/testing/selftests/kvm/Makefile | 1 + .../testing/selftests/kvm/guest_memfd_test.c | 42 ++++ .../selftests/kvm/include/kvm_util_base.h | 31 +++ .../kvm/x86_64/private_mem_migrate_tests.c | 93 ++++++++ .../selftests/kvm/x86_64/sev_migrate_tests.c | 48 ++-- virt/kvm/guest_mem.c | 151 ++++++++++-- virt/kvm/kvm_main.c | 10 + virt/kvm/kvm_mm.h | 7 + 15 files changed, 596 insertions(+), 132 deletions(-) create mode 100644 tools/testing/selftests/kvm/x86_64/private_mem_migrate_tests.c -- 2.41.0.640.ga95def55d0-goog

1 year, 4 months

3
14
0 0

[PATCH v2] selftests/tdx: Add .gitignore

by Anh Tuan Phan

Add .gitignore to ignore tools/testing/selftests/tdx/tdx_guest_test. It uses the same filter from tools/testing/selftests/kvm/.gitignore. Signed-off-by: Anh Tuan Phan <tuananhlfc(a)gmail.com> --- Change from v1: - Use the same filter from tools/testing/selftests/kvm/.gitignore --- tools/testing/selftests/tdx/.gitignore | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 tools/testing/selftests/tdx/.gitignore diff --git a/tools/testing/selftests/tdx/.gitignore b/tools/testing/selftests/tdx/.gitignore new file mode 100644 index 000000000000..6d9381d60172 --- /dev/null +++ b/tools/testing/selftests/tdx/.gitignore @@ -0,0 +1,7 @@ +# SPDX-License-Identifier: GPL-2.0-only +* +!/**/ +!*.c +!*.h +!*.S +!*.sh -- 2.34.1

1 year, 4 months

1
0
0 0

[PATCH] kselftest/arm64: Fix hwcaps selftest build

by Mark Brown

The hwcaps selftest currently relies on the assembler being able to assemble the crc32w instruction but this is not in the base v8.0 so is not accepted by the standard GCC configurations used by many distributions. Switch to manually encoding to fix the build. Fixes: 09d2e95a04ad ("kselftest/arm64: add crc32 feature to hwcap test") Signed-off-by: Mark Brown <broonie(a)kernel.org> --- tools/testing/selftests/arm64/abi/hwcap.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/arm64/abi/hwcap.c b/tools/testing/selftests/arm64/abi/hwcap.c index 112b6a219382..3b26a3660292 100644 --- a/tools/testing/selftests/arm64/abi/hwcap.c +++ b/tools/testing/selftests/arm64/abi/hwcap.c @@ -42,7 +42,8 @@ static void atomics_sigill(void) static void crc32_sigill(void) { - asm volatile("crc32w w0, w0, w1"); + /* CRC32W W0, W0, W1 */ + asm volatile(".inst 0x1ac14800" : : : ); } static void cssc_sigill(void) --- base-commit: 358b763ee64b11f45287c286e1f6145729ed49ab change-id: 20230816-arm64-fix-crc32-build-9d4c94f2e60e Best regards, -- Mark Brown <broonie(a)kernel.org>

1 year, 4 months

2
1
0 0

2024

2023

2022

2021

2020

2019

2018

2017

Linux-kselftest-mirror August 2023