- Linux-kselftest-mirror - lists.linaro.org

[PATCH] lib: kunit: add bitfield test conversion to KUnit

by Vitor Massaru Iha

This adds the conversion of the runtime tests of test_bitfield, from `lib/test_bitfield.c` to KUnit tests. Please apply this commit first (linux-kselftest/kunit-fixes): 3f37d14b8a3152441f36b6bc74000996679f0998 kunit: kunit_config: Fix parsing of CONFIG options with space Code Style Documentation: [0] Signed-off-by: Vitor Massaru Iha <vitor(a)massaru.org> Link: [0] https://lore.kernel.org/linux-kselftest/20200620054944.167330-1-davidgow@go… --- lib/Kconfig.debug | 23 ++++-- lib/Makefile | 2 +- lib/{test_bitfield.c => bitfield_kunit.c} | 92 ++++++++++------------- 3 files changed, 57 insertions(+), 60 deletions(-) rename lib/{test_bitfield.c => bitfield_kunit.c} (66%) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 9ad9210d70a1..16c5574bf103 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -1986,13 +1986,6 @@ config TEST_BITMAP If unsure, say N. -config TEST_BITFIELD - tristate "Test bitfield functions at runtime" - help - Enable this option to test the bitfield functions at boot. - - If unsure, say N. - config TEST_UUID tristate "Test functions located in the uuid module at runtime" @@ -2142,6 +2135,22 @@ config TEST_SYSCTL If unsure, say N. +config BITFIELD_KUNIT + tristate "KUnit test bitfield functions at runtime" + depends on KUNIT + help + Enable this option to test the bitfield functions at boot. + + KUnit tests run during boot and output the results to the debug log + in TAP format (http://testanything.org/). Only useful for kernel devs + running the KUnit test harness, and not intended for inclusion into a + production build. + + For more information on KUnit and unit tests in general please refer + to the KUnit documentation in Documentation/dev-tools/kunit/. + + If unsure, say N. + config SYSCTL_KUNIT_TEST tristate "KUnit test for sysctl" if !KUNIT_ALL_TESTS depends on KUNIT diff --git a/lib/Makefile b/lib/Makefile index b1c42c10073b..56019c34f5ed 100644 --- a/lib/Makefile +++ b/lib/Makefile @@ -84,7 +84,6 @@ obj-$(CONFIG_TEST_STATIC_KEYS) += test_static_key_base.o obj-$(CONFIG_TEST_PRINTF) += test_printf.o obj-$(CONFIG_TEST_BITMAP) += test_bitmap.o obj-$(CONFIG_TEST_STRSCPY) += test_strscpy.o -obj-$(CONFIG_TEST_BITFIELD) += test_bitfield.o obj-$(CONFIG_TEST_UUID) += test_uuid.o obj-$(CONFIG_TEST_XARRAY) += test_xarray.o obj-$(CONFIG_TEST_PARMAN) += test_parman.o @@ -316,5 +315,6 @@ obj-$(CONFIG_GENERIC_LIB_UCMPDI2) += ucmpdi2.o obj-$(CONFIG_OBJAGG) += objagg.o # KUnit tests +obj-$(CONFIG_BITFIELD_KUNIT) += bitfield_kunit.o obj-$(CONFIG_LIST_KUNIT_TEST) += list-test.o obj-$(CONFIG_LINEAR_RANGES_TEST) += test_linear_ranges.o diff --git a/lib/test_bitfield.c b/lib/bitfield_kunit.c similarity index 66% rename from lib/test_bitfield.c rename to lib/bitfield_kunit.c index 5b8f4108662d..d63a2be5aff8 100644 --- a/lib/test_bitfield.c +++ b/lib/bitfield_kunit.c @@ -5,8 +5,7 @@ #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt -#include <linux/kernel.h> -#include <linux/module.h> +#include <kunit/test.h> #include <linux/bitfield.h> #define CHECK_ENC_GET_U(tp, v, field, res) do { \ @@ -14,13 +13,11 @@ u##tp _res; \ \ _res = u##tp##_encode_bits(v, field); \ - if (_res != res) { \ - pr_warn("u" #tp "_encode_bits(" #v ", " #field ") is 0x%llx != " #res "\n",\ - (u64)_res); \ - return -EINVAL; \ - } \ - if (u##tp##_get_bits(_res, field) != v) \ - return -EINVAL; \ + KUNIT_ASSERT_FALSE_MSG(context, _res != res, \ + "u" #tp "_encode_bits(" #v ", " #field ") is 0x%llx != " #res "\n", \ + (u64)_res); \ + KUNIT_ASSERT_FALSE(context, \ + u##tp##_get_bits(_res, field) != v); \ } \ } while (0) @@ -29,14 +26,13 @@ __le##tp _res; \ \ _res = le##tp##_encode_bits(v, field); \ - if (_res != cpu_to_le##tp(res)) { \ - pr_warn("le" #tp "_encode_bits(" #v ", " #field ") is 0x%llx != 0x%llx\n",\ - (u64)le##tp##_to_cpu(_res), \ - (u64)(res)); \ - return -EINVAL; \ - } \ - if (le##tp##_get_bits(_res, field) != v) \ - return -EINVAL; \ + KUNIT_ASSERT_FALSE_MSG(context, \ + _res != cpu_to_le##tp(res), \ + "le" #tp "_encode_bits(" #v ", " #field ") is 0x%llx != 0x%llx",\ + (u64)le##tp##_to_cpu(_res), \ + (u64)(res)); \ + KUNIT_ASSERT_FALSE(context, \ + le##tp##_get_bits(_res, field) != v);\ } \ } while (0) @@ -45,14 +41,13 @@ __be##tp _res; \ \ _res = be##tp##_encode_bits(v, field); \ - if (_res != cpu_to_be##tp(res)) { \ - pr_warn("be" #tp "_encode_bits(" #v ", " #field ") is 0x%llx != 0x%llx\n",\ - (u64)be##tp##_to_cpu(_res), \ - (u64)(res)); \ - return -EINVAL; \ - } \ - if (be##tp##_get_bits(_res, field) != v) \ - return -EINVAL; \ + KUNIT_ASSERT_FALSE_MSG(context, \ + _res != cpu_to_be##tp(res), \ + "be" #tp "_encode_bits(" #v ", " #field ") is 0x%llx != 0x%llx", \ + (u64)be##tp##_to_cpu(_res), \ + (u64)(res)); \ + KUNIT_ASSERT_FALSE(context, \ + be##tp##_get_bits(_res, field) != v);\ } \ } while (0) @@ -62,7 +57,7 @@ CHECK_ENC_GET_BE(tp, v, field, res); \ } while (0) -static int test_constants(void) +static void __init test_bitfields_constants(struct kunit *context) { /* * NOTE @@ -95,19 +90,17 @@ static int test_constants(void) CHECK_ENC_GET(64, 7, 0x00f0000000000000ull, 0x0070000000000000ull); CHECK_ENC_GET(64, 14, 0x0f00000000000000ull, 0x0e00000000000000ull); CHECK_ENC_GET(64, 15, 0xf000000000000000ull, 0xf000000000000000ull); - - return 0; } #define CHECK(tp, mask) do { \ u64 v; \ \ for (v = 0; v < 1 << hweight32(mask); v++) \ - if (tp##_encode_bits(v, mask) != v << __ffs64(mask)) \ - return -EINVAL; \ + KUNIT_ASSERT_FALSE(context, \ + tp##_encode_bits(v, mask) != v << __ffs64(mask));\ } while (0) -static int test_variables(void) +static void __init test_bitfields_variables(struct kunit *context) { CHECK(u8, 0x0f); CHECK(u8, 0xf0); @@ -130,39 +123,34 @@ static int test_variables(void) CHECK(u64, 0x000000007f000000ull); CHECK(u64, 0x0000000018000000ull); CHECK(u64, 0x0000001f8000000ull); - - return 0; } -static int __init test_bitfields(void) -{ - int ret = test_constants(); - - if (ret) { - pr_warn("constant tests failed!\n"); - return ret; - } - - ret = test_variables(); - if (ret) { - pr_warn("variable tests failed!\n"); - return ret; - } -#ifdef TEST_BITFIELD_COMPILE +static void __init test_bitfields_compile(struct kunit *context) +{ /* these should fail compilation */ CHECK_ENC_GET(16, 16, 0x0f00, 0x1000); u32_encode_bits(7, 0x06000000); /* this should at least give a warning */ u16_encode_bits(0, 0x60000); +} + +static struct kunit_case __refdata bitfields_test_cases[] = { + KUNIT_CASE(test_bitfields_constants), + KUNIT_CASE(test_bitfields_variables), +#ifdef TEST_BITFIELD_COMPILE + KUNIT_CASE(test_bitfields_compile), #endif + {} +}; - pr_info("tests passed\n"); +static struct kunit_suite bitfields_test_suite = { + .name = "bitfields", + .test_cases = bitfields_test_cases, +}; - return 0; -} -module_init(test_bitfields) +kunit_test_suites(&bitfields_test_suite); MODULE_AUTHOR("Johannes Berg <johannes(a)sipsolutions.net>"); MODULE_LICENSE("GPL"); base-commit: d43c7fb05765152d4d4a39a8ef957c4ea14d8847 -- 2.26.2

4 years, 8 months

3
3
0 0

[tip: core/rcu] rcutorture: Cleanup PREEMPT_COUNT leftovers

by tip-bot2 for Thomas Gleixner

The following commit has been merged into the core/rcu branch of tip: Commit-ID: 27405ee98aee7a25bbca59b0aba04f33b6acc561 Gitweb: https://git.kernel.org/tip/27405ee98aee7a25bbca59b0aba04f33b6acc561 Author: Thomas Gleixner <tglx(a)linutronix.de> AuthorDate: Mon, 14 Sep 2020 19:37:36 +02:00 Committer: Paul E. McKenney <paulmck(a)kernel.org> CommitterDate: Thu, 01 Oct 2020 09:05:16 -07:00 rcutorture: Cleanup PREEMPT_COUNT leftovers CONFIG_PREEMPT_COUNT is now unconditionally enabled and will be removed. Cleanup the leftovers before doing so. Signed-off-by: Thomas Gleixner <tglx(a)linutronix.de> Cc: "Paul E. McKenney" <paulmck(a)kernel.org> Cc: Josh Triplett <josh(a)joshtriplett.org> Cc: Steven Rostedt <rostedt(a)goodmis.org> Cc: Mathieu Desnoyers <mathieu.desnoyers(a)efficios.com> Cc: Lai Jiangshan <jiangshanlai(a)gmail.com> Cc: Shuah Khan <shuah(a)kernel.org> Cc: rcu(a)vger.kernel.org Cc: linux-kselftest(a)vger.kernel.org Signed-off-by: Paul E. McKenney <paulmck(a)kernel.org> --- tools/testing/selftests/rcutorture/configs/rcu/SRCU-t | 1 - tools/testing/selftests/rcutorture/configs/rcu/SRCU-u | 1 - tools/testing/selftests/rcutorture/configs/rcu/TINY01 | 1 - tools/testing/selftests/rcutorture/doc/TINY_RCU.txt | 5 ++--- tools/testing/selftests/rcutorture/doc/TREE_RCU-kconfig.txt | 1 - tools/testing/selftests/rcutorture/formal/srcu-cbmc/src/config.h | 1 - 6 files changed, 2 insertions(+), 8 deletions(-) diff --git a/tools/testing/selftests/rcutorture/configs/rcu/SRCU-t b/tools/testing/selftests/rcutorture/configs/rcu/SRCU-t index 6c78022..553cf65 100644 --- a/tools/testing/selftests/rcutorture/configs/rcu/SRCU-t +++ b/tools/testing/selftests/rcutorture/configs/rcu/SRCU-t @@ -7,4 +7,3 @@ CONFIG_RCU_TRACE=n CONFIG_DEBUG_LOCK_ALLOC=n CONFIG_DEBUG_OBJECTS_RCU_HEAD=n CONFIG_DEBUG_ATOMIC_SLEEP=y -#CHECK#CONFIG_PREEMPT_COUNT=y diff --git a/tools/testing/selftests/rcutorture/configs/rcu/SRCU-u b/tools/testing/selftests/rcutorture/configs/rcu/SRCU-u index c15ada8..99563da 100644 --- a/tools/testing/selftests/rcutorture/configs/rcu/SRCU-u +++ b/tools/testing/selftests/rcutorture/configs/rcu/SRCU-u @@ -7,4 +7,3 @@ CONFIG_RCU_TRACE=n CONFIG_DEBUG_LOCK_ALLOC=y CONFIG_PROVE_LOCKING=y CONFIG_DEBUG_OBJECTS_RCU_HEAD=n -CONFIG_PREEMPT_COUNT=n diff --git a/tools/testing/selftests/rcutorture/configs/rcu/TINY01 b/tools/testing/selftests/rcutorture/configs/rcu/TINY01 index 6db705e..9b22b8e 100644 --- a/tools/testing/selftests/rcutorture/configs/rcu/TINY01 +++ b/tools/testing/selftests/rcutorture/configs/rcu/TINY01 @@ -10,4 +10,3 @@ CONFIG_RCU_TRACE=n #CHECK#CONFIG_RCU_STALL_COMMON=n CONFIG_DEBUG_LOCK_ALLOC=n CONFIG_DEBUG_OBJECTS_RCU_HEAD=n -CONFIG_PREEMPT_COUNT=n diff --git a/tools/testing/selftests/rcutorture/doc/TINY_RCU.txt b/tools/testing/selftests/rcutorture/doc/TINY_RCU.txt index a75b169..d30cedf 100644 --- a/tools/testing/selftests/rcutorture/doc/TINY_RCU.txt +++ b/tools/testing/selftests/rcutorture/doc/TINY_RCU.txt @@ -3,11 +3,10 @@ This document gives a brief rationale for the TINY_RCU test cases. Kconfig Parameters: -CONFIG_DEBUG_LOCK_ALLOC -- Do all three and none of the three. -CONFIG_PREEMPT_COUNT +CONFIG_DEBUG_LOCK_ALLOC -- Do both and none of the two. CONFIG_RCU_TRACE -The theory here is that randconfig testing will hit the other six possible +The theory here is that randconfig testing will hit the other two possible combinations of these parameters. diff --git a/tools/testing/selftests/rcutorture/doc/TREE_RCU-kconfig.txt b/tools/testing/selftests/rcutorture/doc/TREE_RCU-kconfig.txt index 1b96d68..cfdd48f 100644 --- a/tools/testing/selftests/rcutorture/doc/TREE_RCU-kconfig.txt +++ b/tools/testing/selftests/rcutorture/doc/TREE_RCU-kconfig.txt @@ -43,7 +43,6 @@ CONFIG_64BIT Used only to check CONFIG_RCU_FANOUT value, inspection suffices. -CONFIG_PREEMPT_COUNT CONFIG_PREEMPT_RCU Redundant with CONFIG_PREEMPT, ignore. diff --git a/tools/testing/selftests/rcutorture/formal/srcu-cbmc/src/config.h b/tools/testing/selftests/rcutorture/formal/srcu-cbmc/src/config.h index 283d710..d0d485d 100644 --- a/tools/testing/selftests/rcutorture/formal/srcu-cbmc/src/config.h +++ b/tools/testing/selftests/rcutorture/formal/srcu-cbmc/src/config.h @@ -8,7 +8,6 @@ #undef CONFIG_HOTPLUG_CPU #undef CONFIG_MODULES #undef CONFIG_NO_HZ_FULL_SYSIDLE -#undef CONFIG_PREEMPT_COUNT #undef CONFIG_PREEMPT_RCU #undef CONFIG_PROVE_RCU #undef CONFIG_RCU_NOCB_CPU

4 years, 9 months

1
0
0 0

selftests: pidfd: pidfd_wait hangs on linux next kernel on all devices

by Naresh Kamboju

selftests: pidfd: pidfd_wait hangs on linux next kernel on x86_64, i386 and arm64 Juno-r2 These devices are using NFS mounted rootfs. I have tested pidfd testcases independently and all test PASS. The Hang or exit from test run noticed when run by run_kselftest.sh pidfd_wait.c:208:wait_nonblock:Expected sys_waitid(P_PIDFD, pidfd, &info, WSTOPPED, NULL) (-1) == 0 (0) wait_nonblock: Test terminated by assertion metadata: git branch: master git repo: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git git commit: e64997027d5f171148687e58b78c8b3c869a6158 git describe: next-20200922 make_kernelversion: 5.9.0-rc6 kernel-config: http://snapshots.linaro.org/openembedded/lkft/lkft/sumo/intel-core2-32/lkft… Reported-by: Naresh Kamboju <naresh.kamboju(a)linaro.org> Test output log: --------------------- [ 1385.104983] audit: type=1701 audit(1600804535.960:87865): auid=4294967295 uid=0 gid=0 ses=4294967295 subj=kernel pid=31268 comm=\"pidfd_wait\" exe=\"/opt/kselftests/default-in-kernel/pidfd/pidfd_wait\" sig=6 res=1 # selftests: pidfd: pidfd_wait # TAP version 13 # 1..3 # # Starting 3 tests from 1 test cases. # # RUN global.wait_simple ... # # OK global.wait_simple # ok 1 global.wait_simple # # RUN global.wait_states ... # # OK global.wait_states # ok 2 global.wait_states # # RUN global.wait_nonblock ... # # pidfd_wait.c:208:wait_nonblock:Expected sys_waitid(P_PIDFD, pidfd, &info, WSTOPPED, NULL) (-1) == 0 (0) # # wait_nonblock: Test terminated by assertion # # FAIL global.wait_nonblock # not ok 3 global.wait_nonblock # # FAILED: 2 / 3 tests passed. # # Totals: pass:2 fail:1 xfail:0 xpass:0 skip:0 error:0 Marking unfinished test run as failed ref: https://lkft.validation.linaro.org/scheduler/job/1782129#L11737 https://lkft.validation.linaro.org/scheduler/job/1782130#L12735 https://lkft.validation.linaro.org/scheduler/job/1782138#L14178 -- Linaro LKFT https://lkft.linaro.org

4 years, 9 months

2
5
0 0

[PATCH net-next] selftests: mptcp: interpret \n as a new line

by Matthieu Baerts

In case of errors, this message was printed: (...) balanced bwidth with unbalanced delay 5233 max 5005 [ fail ] client exit code 0, server 0 \nnetns ns3-0-EwnkPH socket stat for 10003: (...) Obviously, the idea was to add a new line before the socket stat and not print "\nnetns". The commit 8b974778f998 ("selftests: mptcp: interpret \n as a new line") is very similar to this one. But the modification in simult_flows.sh was missed because this commit above was done in parallel to one here below. Fixes: 1a418cb8e888 ("mptcp: simult flow self-tests") Signed-off-by: Matthieu Baerts <matthieu.baerts(a)tessares.net> --- tools/testing/selftests/net/mptcp/simult_flows.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/net/mptcp/simult_flows.sh b/tools/testing/selftests/net/mptcp/simult_flows.sh index 0d88225daa02..2f649b431456 100755 --- a/tools/testing/selftests/net/mptcp/simult_flows.sh +++ b/tools/testing/selftests/net/mptcp/simult_flows.sh @@ -200,9 +200,9 @@ do_transfer() echo " [ fail ]" echo "client exit code $retc, server $rets" 1>&2 - echo "\nnetns ${ns3} socket stat for $port:" 1>&2 + echo -e "\nnetns ${ns3} socket stat for $port:" 1>&2 ip netns exec ${ns3} ss -nita 1>&2 -o "sport = :$port" - echo "\nnetns ${ns1} socket stat for $port:" 1>&2 + echo -e "\nnetns ${ns1} socket stat for $port:" 1>&2 ip netns exec ${ns1} ss -nita 1>&2 -o "dport = :$port" ls -l $sin $cout ls -l $cin $sout -- 2.27.0

4 years, 9 months

3
2
0 0

[PATCH v2] selftests/tls: Add {} to avoid static checker warning

by Kees Cook

This silences a static checker warning due to the unusual macro construction of EXPECT_*() by adding explicit {}s around the enclosing while loop. Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com> Fixes: 7f657d5bf507 ("selftests: tls: add selftests for TLS sockets") Signed-off-by: Kees Cook <keescook(a)chromium.org> --- v2: rebase to v5.9-rc2; oops, I lost this patch and just found it again v1: https://lore.kernel.org/lkml/20190108214159.GA33292@beast/ --- tools/testing/selftests/net/tls.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/net/tls.c b/tools/testing/selftests/net/tls.c index b599f1fa99b5..44984741bd41 100644 --- a/tools/testing/selftests/net/tls.c +++ b/tools/testing/selftests/net/tls.c @@ -387,8 +387,9 @@ TEST_F(tls, sendmsg_large) EXPECT_EQ(sendmsg(self->cfd, &msg, 0), send_len); } - while (recvs++ < sends) + while (recvs++ < sends) { EXPECT_NE(recv(self->fd, mem, send_len, 0), -1); + } free(mem); } -- 2.25.1

4 years, 9 months

1
0
0 0

[PATCH v2 00/11] Introduce Simple atomic counters

by Shuah Khan

This patch series is a result of discussion at the refcount_t BOF the Linux Plumbers Conference. In this discussion, we identified a need for looking closely and investigating atomic_t usages in the kernel when it is used strictly as a counter without it controlling object lifetimes and state changes. There are a number of atomic_t usages in the kernel where atomic_t api is used strictly for counting and not for managing object lifetime. In some cases, atomic_t might not even be needed. The purpose of these counters is to clearly differentiate atomic_t counters from atomic_t usages that guard object lifetimes, hence prone to overflow and underflow errors. It allows tools that scan for underflow and overflow on atomic_t usages to detect overflow and underflows to scan just the cases that are prone to errors. Simple atomic counters api provides interfaces for simple atomic counters that just count, and don't guard resource lifetimes. Counter will wrap around to 0 when it overflows and should not be used to guard resource lifetimes, device usage and open counts that control state changes, and pm states. Using counter_atomic* to guard lifetimes could lead to use-after free when it overflows and undefined behavior when used to manage state changes and device usage/open states. This patch series introduces Simple atomic counters. Counter atomic ops leverage atomic_t and provide a sub-set of atomic_t ops. In addition this patch series converts a few drivers to use the new api. The following criteria is used for select variables for conversion: 1. Variable doesn't guard object lifetimes, manage state changes e.g: device usage counts, device open counts, and pm states. 2. Variable is used for stats and counters. 3. The conversion doesn't change the overflow behavior. Changes since Patch v1 -- Thanks for reviews and reviewed-by, and Acked-by tags. Updated the patches with the tags. -- Addressed Kees's and Joel's comments: 1. Removed dec_return interfaces (Patch 1/11) 2. Removed counter_simple interfaces to be added later with changes to drivers that use them (if any) (Patch 1/11) 3. Comment and Changelogs updates to Patch 2/11 Kees, if this series is good, would you like to take this through your tree or would you like to take this through mine? Changes since RFC: -- Thanks for reviews and reviewed-by, and Acked-by tags. Updated the patches with the tags. -- Addressed Kees's comments: 1. Non-atomic counters renamed to counter_simple32 and counter_simple64 to clearly indicate size. 2. Added warning for counter_simple* usage and it should be used only when there is no need for atomicity. 3. Renamed counter_atomic to counter_atomic32 to clearly indicate size. 4. Renamed counter_atomic_long to counter_atomic64 and it now uses atomic64_t ops and indicates size. 5. Test updated for the API renames. 6. Added helper functions for test results printing 7. Verified that the test module compiles in kunit env. and test module can be loaded to run the test. 8. Updated Documentation to reflect the intent to make the API restricted so it can never be used to guard object lifetimes and state management. I left _return ops for now, inc_return is necessary for now as per the discussion we had on this topic. -- Updated driver patches with API name changes. -- We discussed if binder counters can be non-atomic. For now I left them the same as the RFC patch - using counter_atomic32 -- Unrelated to this patch series: The patch series review uncovered improvements could be made to test_async_driver_probe and vmw_vmci/vmci_guest. I will track these for fixing later. Shuah Khan (11): counters: Introduce counter_atomic* counters selftests:lib:test_counters: add new test for counters drivers/base: convert deferred_trigger_count and probe_count to counter_atomic32 drivers/base/devcoredump: convert devcd_count to counter_atomic32 drivers/acpi: convert seqno counter_atomic32 drivers/acpi/apei: convert seqno counter_atomic32 drivers/android/binder: convert stats, transaction_log to counter_atomic32 drivers/base/test/test_async_driver_probe: convert to use counter_atomic32 drivers/char/ipmi: convert stats to use counter_atomic32 drivers/misc/vmw_vmci: convert num guest devices counter to counter_atomic32 drivers/edac: convert pci counters to counter_atomic32 Documentation/core-api/counters.rst | 103 +++++++++++ MAINTAINERS | 8 + drivers/acpi/acpi_extlog.c | 5 +- drivers/acpi/apei/ghes.c | 5 +- drivers/android/binder.c | 41 ++--- drivers/android/binder_internal.h | 3 +- drivers/base/dd.c | 19 +- drivers/base/devcoredump.c | 5 +- drivers/base/test/test_async_driver_probe.c | 23 +-- drivers/char/ipmi/ipmi_msghandler.c | 9 +- drivers/char/ipmi/ipmi_si_intf.c | 9 +- drivers/edac/edac_pci.h | 5 +- drivers/edac/edac_pci_sysfs.c | 28 +-- drivers/misc/vmw_vmci/vmci_guest.c | 9 +- include/linux/counters.h | 173 +++++++++++++++++++ lib/Kconfig | 10 ++ lib/Makefile | 1 + lib/test_counters.c | 157 +++++++++++++++++ tools/testing/selftests/lib/Makefile | 1 + tools/testing/selftests/lib/config | 1 + tools/testing/selftests/lib/test_counters.sh | 5 + 21 files changed, 546 insertions(+), 74 deletions(-) create mode 100644 Documentation/core-api/counters.rst create mode 100644 include/linux/counters.h create mode 100644 lib/test_counters.c create mode 100755 tools/testing/selftests/lib/test_counters.sh -- 2.25.1

4 years, 9 months

2
3
0 0

[REGRESSION] kselftest: next-20201006

by LKFT

## Kernel * kernel: 5.9.0-rc8 * git repo: ['https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git', 'https://gitlab.com/Linaro/lkft/mirrors/next/linux-next'] * git branch: master * git commit: a804ab086e9de200e2e70600996db7fc14c91959 * git describe: next-20201006 * Test details: https://qa-reports.linaro.org/lkft/linux-next-master/build/next-20201006 ## Regressions (compared to build next-20201002) x86: kselftest-vsyscall-mode-none: * rtc.rtctest kselftest: * net.mptcp.mptcp_connect.sh * rtc.rtctest i386: kselftest: * rtc.rtctest ## Fixes (compared to build next-20201002) x86: kselftest-vsyscall-mode-native: * net.mptcp.mptcp_connect.sh * rtc.rtctest kselftest-vsyscall-mode-none: * proc.read * tc-testing.tdc.sh i386: kselftest: * pidfd.pidfd_test ## Summary ### i386, kselftest * total: 676 * pass: 410 * fail: 215 * skip: 51 * xfail: 0 ### juno-r2, kselftest * total: 653 * pass: 404 * fail: 199 * skip: 50 * xfail: 0 ### x86, kselftest * total: 670 * pass: 436 * fail: 189 * skip: 45 * xfail: 0 ### x86, kselftest-vsyscall-mode-native * total: 671 * pass: 439 * fail: 187 * skip: 45 * xfail: 0 ### x86, kselftest-vsyscall-mode-none * total: 670 * pass: 437 * fail: 188 * skip: 45 * xfail: 0 ## Environments * dragonboard-410c * hi6220-hikey * i386 * juno-r2 * juno-r2-compat * juno-r2-kasan * nxp-ls2088 * qemu_arm * qemu_arm64 * qemu_i386 * qemu_x86_64 * x15 * x86 * x86-kasan ## Suites * kselftest * kselftest-vsyscall-mode-native * kselftest-vsyscall-mode-none ## Failures ### i386, kselftest * bpf.test_verifier * bpf.test_maps * bpf.test_progs * bpf.test_dev_cgroup * bpf.test_tcpbpf_user * bpf.get_cgroup_id_user * bpf.test_socket_cookie * bpf.test_netcnt * bpf.test_tcpnotify_user * bpf.test_sysctl * bpf.test_progs-no_alu32 * bpf.test_xdp_redirect.sh * bpf.test_xdp_meta.sh * bpf.test_sock_addr.sh * bpf.test_tunnel.sh * bpf.test_lwt_seg6local.sh * bpf.test_skb_cgroup_id.sh * bpf.test_flow_dissector.sh * bpf.test_xdp_vlan_mode_generic.sh * bpf.test_xdp_vlan_mode_native.sh * bpf.test_lwt_ip_encap.sh * bpf.test_tcp_check_syncookie.sh * bpf.test_tc_tunnel.sh * bpf.test_tc_edt.sh * bpf.test_xdping.sh * bpf.test_bpftool.sh * cgroup.test_memcontrol * cgroup.test_kmem * cgroup.test_core * cgroup.test_freezer * clone3.clone3_clear_sighand * clone3.clone3_cap_checkpoint_restore * core.close_range_test * filesystems.binderfs.binderfs_test * firmware.fw_run_tests.sh * ftrace.ftracetest * intel_pstate.run.sh * kvm.cr4_cpuid_sync_test * kvm.evmcs_test * kvm.hyperv_cpuid * kvm.mmio_warning_test * kvm.platform_info_test * kvm.set_sregs_test * kvm.smm_test * kvm.state_test * kvm.vmx_preemption_timer_test * kvm.svm_vmcall_test * kvm.sync_regs_test * kvm.vmx_close_while_nested_test * kvm.vmx_dirty_log_test * kvm.vmx_set_nested_state_test * kvm.vmx_tsc_adjust_test * kvm.xss_msr_test * kvm.debug_regs * kvm.clear_dirty_log_test * kvm.demand_paging_test * kvm.dirty_log_test * kvm.kvm_create_max_vcpus * kvm.set_memory_region_test * kvm.steal_time * lkdtm.BUG.sh * lkdtm.WARNING.sh * lkdtm.WARNING_MESSAGE.sh * lkdtm.EXCEPTION.sh * lkdtm.CORRUPT_LIST_ADD.sh * lkdtm.CORRUPT_LIST_DEL.sh * lkdtm.STACK_GUARD_PAGE_LEADING.sh * lkdtm.STACK_GUARD_PAGE_TRAILING.sh * lkdtm.UNSET_SMEP.sh * lkdtm.DOUBLE_FAULT.sh * lkdtm.CORRUPT_PAC.sh * lkdtm.UNALIGNED_LOAD_STORE_WRITE.sh * lkdtm.READ_AFTER_FREE.sh * lkdtm.READ_BUDDY_AFTER_FREE.sh * lkdtm.SLAB_FREE_DOUBLE.sh * lkdtm.SLAB_FREE_CROSS.sh * lkdtm.SLAB_FREE_PAGE.sh * lkdtm.EXEC_DATA.sh * lkdtm.EXEC_STACK.sh * lkdtm.EXEC_KMALLOC.sh * lkdtm.EXEC_VMALLOC.sh * lkdtm.EXEC_RODATA.sh * lkdtm.EXEC_USERSPACE.sh * lkdtm.EXEC_NULL.sh * lkdtm.ACCESS_USERSPACE.sh * lkdtm.ACCESS_NULL.sh * lkdtm.WRITE_RO.sh * lkdtm.WRITE_RO_AFTER_INIT.sh * lkdtm.WRITE_KERN.sh * lkdtm.REFCOUNT_INC_OVERFLOW.sh * lkdtm.REFCOUNT_ADD_OVERFLOW.sh * lkdtm.REFCOUNT_INC_NOT_ZERO_OVERFLOW.sh * lkdtm.REFCOUNT_ADD_NOT_ZERO_OVERFLOW.sh * lkdtm.REFCOUNT_DEC_ZERO.sh * lkdtm.REFCOUNT_DEC_NEGATIVE.sh * lkdtm.REFCOUNT_DEC_AND_TEST_NEGATIVE.sh * lkdtm.REFCOUNT_SUB_AND_TEST_NEGATIVE.sh * lkdtm.REFCOUNT_INC_ZERO.sh * lkdtm.REFCOUNT_ADD_ZERO.sh * lkdtm.REFCOUNT_INC_SATURATED.sh * lkdtm.REFCOUNT_DEC_SATURATED.sh * lkdtm.REFCOUNT_ADD_SATURATED.sh * lkdtm.REFCOUNT_INC_NOT_ZERO_SATURATED.sh * lkdtm.REFCOUNT_ADD_NOT_ZERO_SATURATED.sh * lkdtm.REFCOUNT_DEC_AND_TEST_SATURATED.sh * lkdtm.REFCOUNT_SUB_AND_TEST_SATURATED.sh * lkdtm.USERCOPY_HEAP_SIZE_TO.sh * lkdtm.USERCOPY_HEAP_SIZE_FROM.sh * lkdtm.USERCOPY_HEAP_WHITELIST_TO.sh * lkdtm.USERCOPY_HEAP_WHITELIST_FROM.sh * lkdtm.USERCOPY_STACK_FRAME_TO.sh * lkdtm.USERCOPY_STACK_FRAME_FROM.sh * lkdtm.USERCOPY_STACK_BEYOND.sh * lkdtm.USERCOPY_KERNEL.sh * lkdtm.STACKLEAK_ERASING.sh * lkdtm.CFI_FORWARD_PROTO.sh * mincore.mincore_selftest.global.check_file_mmap * mincore.mincore_selftest * mqueue.mq_perf_tests * net.run_netsocktests * net.fib_tests.sh * net.fib-onlink-tests.sh * net.pmtu.sh * net.udpgso_bench.sh * net.psock_snd.sh * net.udpgro_bench.sh * net.test_vxlan_under_vrf.sh * net.l2tp.sh * net.traceroute.sh * net.altnames.sh * net.icmp_redirect.sh * net.txtimestamp.sh * net.vrf-xfrm-tests.sh * net.devlink_port_split.py * net.forwarding.bridge_igmp.sh * net.forwarding.bridge_port_isolation.sh * net.forwarding.bridge_sticky_fdb.sh * net.forwarding.bridge_vlan_aware.sh * net.forwarding.bridge_vlan_unaware.sh * net.forwarding.ethtool.sh * net.forwarding.gre_inner_v4_multipath.sh * net.forwarding.gre_inner_v6_multipath.sh * net.forwarding.gre_multipath.sh * net.forwarding.ip6gre_inner_v4_multipath.sh * net.forwarding.ip6gre_inner_v6_multipath.sh * net.forwarding.ipip_flat_gre_key.sh * net.forwarding.ipip_flat_gre_keys.sh * net.forwarding.ipip_flat_gre.sh * net.forwarding.ipip_hier_gre_key.sh * net.forwarding.ipip_hier_gre_keys.sh * net.forwarding.ipip_hier_gre.sh * net.forwarding.loopback.sh * net.forwarding.mirror_gre_bound.sh * net.forwarding.mirror_gre_bridge_1d.sh * net.forwarding.mirror_gre_bridge_1d_vlan.sh * net.forwarding.mirror_gre_bridge_1q_lag.sh * net.forwarding.mirror_gre_bridge_1q.sh * net.forwarding.mirror_gre_changes.sh * net.forwarding.mirror_gre_flower.sh * net.forwarding.mirror_gre_lag_lacp.sh * net.forwarding.mirror_gre_neigh.sh * net.forwarding.mirror_gre_nh.sh * net.forwarding.mirror_gre.sh * net.forwarding.mirror_gre_vlan_bridge_1q.sh * net.forwarding.mirror_gre_vlan.sh * net.forwarding.mirror_vlan.sh * net.forwarding.router_bridge.sh * net.forwarding.router_bridge_vlan.sh * net.forwarding.router_broadcast.sh * net.forwarding.router_mpath_nh.sh * net.forwarding.router_multicast.sh * net.forwarding.router_multipath.sh * net.forwarding.router.sh * net.forwarding.router_vid_1.sh * net.forwarding.sch_ets.sh * net.forwarding.sch_tbf_ets.sh * net.forwarding.sch_tbf_prio.sh * net.forwarding.sch_tbf_root.sh * net.forwarding.tc_actions.sh * net.forwarding.tc_chains.sh * net.forwarding.tc_flower_router.sh * net.forwarding.tc_flower.sh * net.forwarding.tc_shblocks.sh * net.forwarding.tc_vlan_modify.sh * net.forwarding.vxlan_asymmetric.sh * net.forwarding.vxlan_bridge_1d_port_8472.sh * net.forwarding.vxlan_bridge_1d.sh * net.forwarding.vxlan_bridge_1q_port_8472.sh * net.forwarding.vxlan_bridge_1q.sh * net.forwarding.vxlan_symmetric.sh * net.mptcp.simult_flows.sh * netfilter.nft_concat_range.sh * netfilter.nft_queue.sh * pidfd.pidfd_open_test * pidfd.pidfd_poll_test * proc.proc-self-syscall * proc.proc-fsconfig-hidepid * pstore.pstore_tests * ptrace.vmaccess.global.attach * ptrace.vmaccess * openat2.openat2_test * openat2.resolve_test * openat2.rename_attack_test * rseq.param_test * rseq.param_test_benchmark * rseq.param_test_compare_twice * rseq.run_param_test.sh * rtc.rtctest * seccomp.seccomp_bpf.global.user_notification_filter_empty * seccomp.seccomp_bpf.global.user_notification_filter_empty_threaded * seccomp.seccomp_bpf.global.user_notification_addfd * seccomp.seccomp_bpf * seccomp.seccomp_benchmark * splice.short_splice_read.sh * vm.run_vmtests.sh ### juno-r2, kselftest * bpf.test_verifier * bpf.test_tag * bpf.test_maps * bpf.test_lpm_map * bpf.test_progs * bpf.test_dev_cgroup * bpf.test_tcpbpf_user * bpf.get_cgroup_id_user * bpf.test_socket_cookie * bpf.test_netcnt * bpf.test_tcpnotify_user * bpf.test_sysctl * bpf.test_progs-no_alu32 * bpf.test_xdp_redirect.sh * bpf.test_xdp_meta.sh * bpf.test_sock_addr.sh * bpf.test_tunnel.sh * bpf.test_lwt_seg6local.sh * bpf.test_skb_cgroup_id.sh * bpf.test_flow_dissector.sh * bpf.test_xdp_vlan_mode_generic.sh * bpf.test_xdp_vlan_mode_native.sh * bpf.test_lwt_ip_encap.sh * bpf.test_tcp_check_syncookie.sh * bpf.test_tc_tunnel.sh * bpf.test_tc_edt.sh * bpf.test_xdping.sh * bpf.test_bpftool.sh * cgroup.test_memcontrol * cgroup.test_kmem * cgroup.test_core * cgroup.test_freezer * clone3.clone3_cap_checkpoint_restore * core.close_range_test * cpufreq.main.sh * filesystems.binderfs.binderfs_test * firmware.fw_run_tests.sh * ftrace.ftracetest * lkdtm.BUG.sh * lkdtm.WARNING.sh * lkdtm.WARNING_MESSAGE.sh * lkdtm.EXCEPTION.sh * lkdtm.CORRUPT_LIST_ADD.sh * lkdtm.CORRUPT_LIST_DEL.sh * lkdtm.STACK_GUARD_PAGE_LEADING.sh * lkdtm.STACK_GUARD_PAGE_TRAILING.sh * lkdtm.UNSET_SMEP.sh * lkdtm.CORRUPT_PAC.sh * lkdtm.UNALIGNED_LOAD_STORE_WRITE.sh * lkdtm.READ_AFTER_FREE.sh * lkdtm.READ_BUDDY_AFTER_FREE.sh * lkdtm.SLAB_FREE_DOUBLE.sh * lkdtm.SLAB_FREE_CROSS.sh * lkdtm.SLAB_FREE_PAGE.sh * lkdtm.EXEC_DATA.sh * lkdtm.EXEC_STACK.sh * lkdtm.EXEC_KMALLOC.sh * lkdtm.EXEC_VMALLOC.sh * lkdtm.EXEC_RODATA.sh * lkdtm.EXEC_USERSPACE.sh * lkdtm.EXEC_NULL.sh * lkdtm.ACCESS_USERSPACE.sh * lkdtm.ACCESS_NULL.sh * lkdtm.WRITE_RO.sh * lkdtm.WRITE_RO_AFTER_INIT.sh * lkdtm.WRITE_KERN.sh * lkdtm.REFCOUNT_INC_OVERFLOW.sh * lkdtm.REFCOUNT_ADD_OVERFLOW.sh * lkdtm.REFCOUNT_INC_NOT_ZERO_OVERFLOW.sh * lkdtm.REFCOUNT_ADD_NOT_ZERO_OVERFLOW.sh * lkdtm.REFCOUNT_DEC_ZERO.sh * lkdtm.REFCOUNT_DEC_NEGATIVE.sh * lkdtm.REFCOUNT_DEC_AND_TEST_NEGATIVE.sh * lkdtm.REFCOUNT_SUB_AND_TEST_NEGATIVE.sh * lkdtm.REFCOUNT_INC_ZERO.sh * lkdtm.REFCOUNT_ADD_ZERO.sh * lkdtm.REFCOUNT_INC_SATURATED.sh * lkdtm.REFCOUNT_DEC_SATURATED.sh * lkdtm.REFCOUNT_ADD_SATURATED.sh * lkdtm.REFCOUNT_INC_NOT_ZERO_SATURATED.sh * lkdtm.REFCOUNT_ADD_NOT_ZERO_SATURATED.sh * lkdtm.REFCOUNT_DEC_AND_TEST_SATURATED.sh * lkdtm.REFCOUNT_SUB_AND_TEST_SATURATED.sh * lkdtm.USERCOPY_HEAP_SIZE_TO.sh * lkdtm.USERCOPY_HEAP_SIZE_FROM.sh * lkdtm.USERCOPY_HEAP_WHITELIST_TO.sh * lkdtm.USERCOPY_HEAP_WHITELIST_FROM.sh * lkdtm.USERCOPY_STACK_FRAME_TO.sh * lkdtm.USERCOPY_STACK_FRAME_FROM.sh * lkdtm.USERCOPY_STACK_BEYOND.sh * lkdtm.USERCOPY_KERNEL.sh * lkdtm.STACKLEAK_ERASING.sh * lkdtm.CFI_FORWARD_PROTO.sh * memory-hotplug.mem-on-off-test.sh * mincore.mincore_selftest.global.check_file_mmap * mincore.mincore_selftest * net.run_netsocktests * net.fib_tests.sh * net.fib-onlink-tests.sh * net.pmtu.sh * net.udpgso_bench.sh * net.fib_rule_tests.sh * net.psock_snd.sh * net.udpgro_bench.sh * net.udpgro.sh * net.test_vxlan_under_vrf.sh * net.tcp_fastopen_backup_key.sh * net.l2tp.sh * net.fib_nexthops.sh * net.altnames.sh * net.icmp_redirect.sh * net.txtimestamp.sh * net.vrf-xfrm-tests.sh * net.devlink_port_split.py * net.forwarding.bridge_igmp.sh * net.forwarding.bridge_port_isolation.sh * net.forwarding.bridge_sticky_fdb.sh * net.forwarding.bridge_vlan_aware.sh * net.forwarding.bridge_vlan_unaware.sh * net.forwarding.ethtool.sh * net.forwarding.gre_inner_v4_multipath.sh * net.forwarding.gre_inner_v6_multipath.sh * net.forwarding.gre_multipath.sh * net.forwarding.ip6gre_inner_v4_multipath.sh * net.forwarding.ip6gre_inner_v6_multipath.sh * net.forwarding.ipip_flat_gre_key.sh * net.forwarding.ipip_flat_gre_keys.sh * net.forwarding.ipip_flat_gre.sh * net.forwarding.ipip_hier_gre_key.sh * net.forwarding.ipip_hier_gre_keys.sh * net.forwarding.ipip_hier_gre.sh * net.forwarding.loopback.sh * net.forwarding.mirror_gre_bound.sh * net.forwarding.mirror_gre_bridge_1d.sh * net.forwarding.mirror_gre_bridge_1d_vlan.sh * net.forwarding.mirror_gre_bridge_1q_lag.sh * net.forwarding.mirror_gre_bridge_1q.sh * net.forwarding.mirror_gre_changes.sh * net.forwarding.mirror_gre_flower.sh * net.forwarding.mirror_gre_lag_lacp.sh * net.forwarding.mirror_gre_neigh.sh * net.forwarding.mirror_gre_nh.sh * net.forwarding.mirror_gre.sh * net.forwarding.mirror_gre_vlan_bridge_1q.sh * net.forwarding.mirror_gre_vlan.sh * net.forwarding.mirror_vlan.sh * net.forwarding.router_bridge.sh * net.forwarding.router_bridge_vlan.sh * net.forwarding.router_broadcast.sh * net.forwarding.router_mpath_nh.sh * net.forwarding.router_multicast.sh * net.forwarding.router_multipath.sh * net.forwarding.router.sh * net.forwarding.router_vid_1.sh * net.forwarding.sch_ets.sh * net.forwarding.sch_tbf_ets.sh * net.forwarding.sch_tbf_prio.sh * net.forwarding.sch_tbf_root.sh * net.forwarding.tc_actions.sh * net.forwarding.tc_chains.sh * net.forwarding.tc_flower_router.sh * net.forwarding.tc_flower.sh * net.forwarding.tc_shblocks.sh * net.forwarding.tc_vlan_modify.sh * net.forwarding.vxlan_asymmetric.sh * net.forwarding.vxlan_bridge_1d_port_8472.sh * net.forwarding.vxlan_bridge_1d.sh * net.forwarding.vxlan_bridge_1q_port_8472.sh * net.forwarding.vxlan_bridge_1q.sh * net.forwarding.vxlan_symmetric.sh * net.mptcp.simult_flows.sh * netfilter.nft_nat.sh * netfilter.conntrack_icmp_related.sh * netfilter.nft_concat_range.sh * netfilter.nft_queue.sh * pidfd.pidfd_test * pidfd.pidfd_fdinfo_test * pidfd.pidfd_open_test * pidfd.pidfd_poll_test * proc.proc-fsconfig-hidepid * pstore.pstore_tests * ptrace.vmaccess.global.attach * ptrace.vmaccess * openat2.openat2_test * openat2.resolve_test * openat2.rename_attack_test * rseq.param_test * rseq.param_test_benchmark * rseq.param_test_compare_twice * rtc.rtctest * seccomp.seccomp_bpf.global.user_notification_filter_empty * seccomp.seccomp_bpf.global.user_notification_filter_empty_threaded * seccomp.seccomp_bpf.global.user_notification_addfd * seccomp.seccomp_bpf * seccomp.seccomp_benchmark * splice.short_splice_read.sh * sysctl.sysctl.sh * tc-testing.tdc.sh * vm.run_vmtests.sh ### x86, kselftest * bpf.test_verifier * bpf.test_maps * bpf.test_progs * bpf.test_dev_cgroup * bpf.test_tcpbpf_user * bpf.get_cgroup_id_user * bpf.test_socket_cookie * bpf.test_netcnt * bpf.test_tcpnotify_user * bpf.test_sysctl * bpf.test_progs-no_alu32 * bpf.test_xdp_redirect.sh * bpf.test_xdp_meta.sh * bpf.test_sock_addr.sh * bpf.test_tunnel.sh * bpf.test_lwt_seg6local.sh * bpf.test_skb_cgroup_id.sh * bpf.test_flow_dissector.sh * bpf.test_xdp_vlan_mode_generic.sh * bpf.test_xdp_vlan_mode_native.sh * bpf.test_lwt_ip_encap.sh * bpf.test_tcp_check_syncookie.sh * bpf.test_tc_tunnel.sh * bpf.test_tc_edt.sh * bpf.test_xdping.sh * bpf.test_bpftool.sh * cgroup.test_memcontrol * cgroup.test_kmem * cgroup.test_core * cgroup.test_freezer * clone3.clone3_cap_checkpoint_restore * core.close_range_test * filesystems.binderfs.binderfs_test * firmware.fw_run_tests.sh * ftrace.ftracetest * intel_pstate.run.sh * lkdtm.BUG.sh * lkdtm.WARNING.sh * lkdtm.WARNING_MESSAGE.sh * lkdtm.EXCEPTION.sh * lkdtm.CORRUPT_LIST_ADD.sh * lkdtm.CORRUPT_LIST_DEL.sh * lkdtm.STACK_GUARD_PAGE_LEADING.sh * lkdtm.STACK_GUARD_PAGE_TRAILING.sh * lkdtm.UNSET_SMEP.sh * lkdtm.CORRUPT_PAC.sh * lkdtm.UNALIGNED_LOAD_STORE_WRITE.sh * lkdtm.READ_AFTER_FREE.sh * lkdtm.READ_BUDDY_AFTER_FREE.sh * lkdtm.SLAB_FREE_DOUBLE.sh * lkdtm.SLAB_FREE_CROSS.sh * lkdtm.SLAB_FREE_PAGE.sh * lkdtm.EXEC_DATA.sh * lkdtm.EXEC_STACK.sh * lkdtm.EXEC_KMALLOC.sh * lkdtm.EXEC_VMALLOC.sh * lkdtm.EXEC_RODATA.sh * lkdtm.EXEC_USERSPACE.sh * lkdtm.EXEC_NULL.sh * lkdtm.ACCESS_USERSPACE.sh * lkdtm.ACCESS_NULL.sh * lkdtm.WRITE_RO.sh * lkdtm.WRITE_RO_AFTER_INIT.sh * lkdtm.WRITE_KERN.sh * lkdtm.REFCOUNT_INC_OVERFLOW.sh * lkdtm.REFCOUNT_ADD_OVERFLOW.sh * lkdtm.REFCOUNT_INC_NOT_ZERO_OVERFLOW.sh * lkdtm.REFCOUNT_ADD_NOT_ZERO_OVERFLOW.sh * lkdtm.REFCOUNT_DEC_ZERO.sh * lkdtm.REFCOUNT_DEC_NEGATIVE.sh * lkdtm.REFCOUNT_DEC_AND_TEST_NEGATIVE.sh * lkdtm.REFCOUNT_SUB_AND_TEST_NEGATIVE.sh * lkdtm.REFCOUNT_INC_ZERO.sh * lkdtm.REFCOUNT_ADD_ZERO.sh * lkdtm.REFCOUNT_INC_SATURATED.sh * lkdtm.REFCOUNT_DEC_SATURATED.sh * lkdtm.REFCOUNT_ADD_SATURATED.sh * lkdtm.REFCOUNT_INC_NOT_ZERO_SATURATED.sh * lkdtm.REFCOUNT_ADD_NOT_ZERO_SATURATED.sh * lkdtm.REFCOUNT_DEC_AND_TEST_SATURATED.sh * lkdtm.REFCOUNT_SUB_AND_TEST_SATURATED.sh * lkdtm.USERCOPY_HEAP_SIZE_TO.sh * lkdtm.USERCOPY_HEAP_SIZE_FROM.sh * lkdtm.USERCOPY_HEAP_WHITELIST_TO.sh * lkdtm.USERCOPY_HEAP_WHITELIST_FROM.sh * lkdtm.USERCOPY_STACK_FRAME_TO.sh * lkdtm.USERCOPY_STACK_FRAME_FROM.sh * lkdtm.USERCOPY_STACK_BEYOND.sh * lkdtm.USERCOPY_KERNEL.sh * lkdtm.STACKLEAK_ERASING.sh * lkdtm.CFI_FORWARD_PROTO.sh * mincore.mincore_selftest.global.check_file_mmap * mincore.mincore_selftest * mqueue.mq_perf_tests * net.run_netsocktests * net.xfrm_policy.sh * net.fib_tests.sh * net.fib-onlink-tests.sh * net.pmtu.sh * net.udpgso_bench.sh * net.psock_snd.sh * net.udpgro_bench.sh * net.udpgro.sh * net.test_vxlan_under_vrf.sh * net.l2tp.sh * net.traceroute.sh * net.altnames.sh * net.icmp_redirect.sh * net.txtimestamp.sh * net.vrf-xfrm-tests.sh * net.devlink_port_split.py * net.forwarding.bridge_igmp.sh * net.forwarding.bridge_port_isolation.sh * net.forwarding.bridge_sticky_fdb.sh * net.forwarding.bridge_vlan_aware.sh * net.forwarding.bridge_vlan_unaware.sh * net.forwarding.ethtool.sh * net.forwarding.gre_inner_v4_multipath.sh * net.forwarding.gre_inner_v6_multipath.sh * net.forwarding.gre_multipath.sh * net.forwarding.ip6gre_inner_v4_multipath.sh * net.forwarding.ip6gre_inner_v6_multipath.sh * net.forwarding.ipip_flat_gre_key.sh * net.forwarding.ipip_flat_gre_keys.sh * net.forwarding.ipip_flat_gre.sh * net.forwarding.ipip_hier_gre_key.sh * net.forwarding.ipip_hier_gre_keys.sh * net.forwarding.ipip_hier_gre.sh * net.forwarding.loopback.sh * net.forwarding.mirror_gre_bound.sh * net.forwarding.mirror_gre_bridge_1d.sh * net.forwarding.mirror_gre_bridge_1d_vlan.sh * net.forwarding.mirror_gre_bridge_1q_lag.sh * net.forwarding.mirror_gre_bridge_1q.sh * net.forwarding.mirror_gre_changes.sh * net.forwarding.mirror_gre_flower.sh * net.forwarding.mirror_gre_lag_lacp.sh * net.forwarding.mirror_gre_neigh.sh * net.forwarding.mirror_gre_nh.sh * net.forwarding.mirror_gre.sh * net.forwarding.mirror_gre_vlan_bridge_1q.sh * net.forwarding.mirror_gre_vlan.sh * net.forwarding.mirror_vlan.sh * net.forwarding.router_bridge.sh * net.forwarding.router_bridge_vlan.sh * net.forwarding.router_broadcast.sh * net.forwarding.router_mpath_nh.sh * net.forwarding.router_multicast.sh * net.forwarding.router_multipath.sh * net.forwarding.router.sh * net.forwarding.router_vid_1.sh * net.forwarding.sch_ets.sh * net.forwarding.sch_tbf_ets.sh * net.forwarding.sch_tbf_prio.sh * net.forwarding.sch_tbf_root.sh * net.forwarding.tc_actions.sh * net.forwarding.tc_chains.sh * net.forwarding.tc_flower_router.sh * net.forwarding.tc_flower.sh * net.forwarding.tc_shblocks.sh * net.forwarding.tc_vlan_modify.sh * net.forwarding.vxlan_asymmetric.sh * net.forwarding.vxlan_bridge_1d_port_8472.sh * net.forwarding.vxlan_bridge_1d.sh * net.forwarding.vxlan_bridge_1q_port_8472.sh * net.forwarding.vxlan_bridge_1q.sh * net.forwarding.vxlan_symmetric.sh * net.mptcp.mptcp_connect.sh * net.mptcp.simult_flows.sh * netfilter.nft_concat_range.sh * netfilter.nft_queue.sh * pidfd.pidfd_open_test * pidfd.pidfd_poll_test * proc.proc-fsconfig-hidepid * pstore.pstore_tests * ptrace.vmaccess.global.attach * ptrace.vmaccess * openat2.openat2_test * openat2.resolve_test * openat2.rename_attack_test * rtc.rtctest * seccomp.seccomp_bpf.global.user_notification_filter_empty * seccomp.seccomp_bpf.global.user_notification_filter_empty_threaded * seccomp.seccomp_bpf.global.user_notification_addfd * seccomp.seccomp_bpf * seccomp.seccomp_benchmark * splice.short_splice_read.sh * vm.run_vmtests.sh * x86.syscall_numbering_64 ### x86, kselftest-vsyscall-mode-native * bpf.test_verifier * bpf.test_maps * bpf.test_progs * bpf.test_dev_cgroup * bpf.test_tcpbpf_user * bpf.get_cgroup_id_user * bpf.test_socket_cookie * bpf.test_netcnt * bpf.test_tcpnotify_user * bpf.test_sysctl * bpf.test_progs-no_alu32 * bpf.test_xdp_redirect.sh * bpf.test_xdp_meta.sh * bpf.test_sock_addr.sh * bpf.test_tunnel.sh * bpf.test_lwt_seg6local.sh * bpf.test_skb_cgroup_id.sh * bpf.test_flow_dissector.sh * bpf.test_xdp_vlan_mode_generic.sh * bpf.test_xdp_vlan_mode_native.sh * bpf.test_lwt_ip_encap.sh * bpf.test_tcp_check_syncookie.sh * bpf.test_tc_tunnel.sh * bpf.test_tc_edt.sh * bpf.test_xdping.sh * bpf.test_bpftool.sh * cgroup.test_memcontrol * cgroup.test_kmem * cgroup.test_core * cgroup.test_freezer * clone3.clone3_cap_checkpoint_restore * core.close_range_test * filesystems.binderfs.binderfs_test * firmware.fw_run_tests.sh * ftrace.ftracetest * intel_pstate.run.sh * lkdtm.BUG.sh * lkdtm.WARNING.sh * lkdtm.WARNING_MESSAGE.sh * lkdtm.EXCEPTION.sh * lkdtm.CORRUPT_LIST_ADD.sh * lkdtm.CORRUPT_LIST_DEL.sh * lkdtm.STACK_GUARD_PAGE_LEADING.sh * lkdtm.STACK_GUARD_PAGE_TRAILING.sh * lkdtm.UNSET_SMEP.sh * lkdtm.CORRUPT_PAC.sh * lkdtm.UNALIGNED_LOAD_STORE_WRITE.sh * lkdtm.READ_AFTER_FREE.sh * lkdtm.READ_BUDDY_AFTER_FREE.sh * lkdtm.SLAB_FREE_DOUBLE.sh * lkdtm.SLAB_FREE_CROSS.sh * lkdtm.SLAB_FREE_PAGE.sh * lkdtm.EXEC_DATA.sh * lkdtm.EXEC_STACK.sh * lkdtm.EXEC_KMALLOC.sh * lkdtm.EXEC_VMALLOC.sh * lkdtm.EXEC_RODATA.sh * lkdtm.EXEC_USERSPACE.sh * lkdtm.EXEC_NULL.sh * lkdtm.ACCESS_USERSPACE.sh * lkdtm.ACCESS_NULL.sh * lkdtm.WRITE_RO.sh * lkdtm.WRITE_RO_AFTER_INIT.sh * lkdtm.WRITE_KERN.sh * lkdtm.REFCOUNT_INC_OVERFLOW.sh * lkdtm.REFCOUNT_ADD_OVERFLOW.sh * lkdtm.REFCOUNT_INC_NOT_ZERO_OVERFLOW.sh * lkdtm.REFCOUNT_ADD_NOT_ZERO_OVERFLOW.sh * lkdtm.REFCOUNT_DEC_ZERO.sh * lkdtm.REFCOUNT_DEC_NEGATIVE.sh * lkdtm.REFCOUNT_DEC_AND_TEST_NEGATIVE.sh * lkdtm.REFCOUNT_SUB_AND_TEST_NEGATIVE.sh * lkdtm.REFCOUNT_INC_ZERO.sh * lkdtm.REFCOUNT_ADD_ZERO.sh * lkdtm.REFCOUNT_INC_SATURATED.sh * lkdtm.REFCOUNT_DEC_SATURATED.sh * lkdtm.REFCOUNT_ADD_SATURATED.sh * lkdtm.REFCOUNT_INC_NOT_ZERO_SATURATED.sh * lkdtm.REFCOUNT_ADD_NOT_ZERO_SATURATED.sh * lkdtm.REFCOUNT_DEC_AND_TEST_SATURATED.sh * lkdtm.REFCOUNT_SUB_AND_TEST_SATURATED.sh * lkdtm.USERCOPY_HEAP_SIZE_TO.sh * lkdtm.USERCOPY_HEAP_SIZE_FROM.sh * lkdtm.USERCOPY_HEAP_WHITELIST_TO.sh * lkdtm.USERCOPY_HEAP_WHITELIST_FROM.sh * lkdtm.USERCOPY_STACK_FRAME_TO.sh * lkdtm.USERCOPY_STACK_FRAME_FROM.sh * lkdtm.USERCOPY_STACK_BEYOND.sh * lkdtm.USERCOPY_KERNEL.sh * lkdtm.STACKLEAK_ERASING.sh * lkdtm.CFI_FORWARD_PROTO.sh * mincore.mincore_selftest.global.check_file_mmap * mincore.mincore_selftest * mqueue.mq_perf_tests * net.run_netsocktests * net.xfrm_policy.sh * net.fib_tests.sh * net.fib-onlink-tests.sh * net.pmtu.sh * net.udpgso_bench.sh * net.psock_snd.sh * net.udpgro_bench.sh * net.udpgro.sh * net.test_vxlan_under_vrf.sh * net.l2tp.sh * net.traceroute.sh * net.altnames.sh * net.icmp_redirect.sh * net.txtimestamp.sh * net.vrf-xfrm-tests.sh * net.devlink_port_split.py * net.forwarding.bridge_igmp.sh * net.forwarding.bridge_port_isolation.sh * net.forwarding.bridge_sticky_fdb.sh * net.forwarding.bridge_vlan_aware.sh * net.forwarding.bridge_vlan_unaware.sh * net.forwarding.ethtool.sh * net.forwarding.gre_inner_v4_multipath.sh * net.forwarding.gre_inner_v6_multipath.sh * net.forwarding.gre_multipath.sh * net.forwarding.ip6gre_inner_v4_multipath.sh * net.forwarding.ip6gre_inner_v6_multipath.sh * net.forwarding.ipip_flat_gre_key.sh * net.forwarding.ipip_flat_gre_keys.sh * net.forwarding.ipip_flat_gre.sh * net.forwarding.ipip_hier_gre_key.sh * net.forwarding.ipip_hier_gre_keys.sh * net.forwarding.ipip_hier_gre.sh * net.forwarding.loopback.sh * net.forwarding.mirror_gre_bound.sh * net.forwarding.mirror_gre_bridge_1d.sh * net.forwarding.mirror_gre_bridge_1d_vlan.sh * net.forwarding.mirror_gre_bridge_1q_lag.sh * net.forwarding.mirror_gre_bridge_1q.sh * net.forwarding.mirror_gre_changes.sh * net.forwarding.mirror_gre_flower.sh * net.forwarding.mirror_gre_lag_lacp.sh * net.forwarding.mirror_gre_neigh.sh * net.forwarding.mirror_gre_nh.sh * net.forwarding.mirror_gre.sh * net.forwarding.mirror_gre_vlan_bridge_1q.sh * net.forwarding.mirror_gre_vlan.sh * net.forwarding.mirror_vlan.sh * net.forwarding.router_bridge.sh * net.forwarding.router_bridge_vlan.sh * net.forwarding.router_broadcast.sh * net.forwarding.router_mpath_nh.sh * net.forwarding.router_multicast.sh * net.forwarding.router_multipath.sh * net.forwarding.router.sh * net.forwarding.router_vid_1.sh * net.forwarding.sch_ets.sh * net.forwarding.sch_tbf_ets.sh * net.forwarding.sch_tbf_prio.sh * net.forwarding.sch_tbf_root.sh * net.forwarding.tc_actions.sh * net.forwarding.tc_chains.sh * net.forwarding.tc_flower_router.sh * net.forwarding.tc_flower.sh * net.forwarding.tc_shblocks.sh * net.forwarding.tc_vlan_modify.sh * net.forwarding.vxlan_asymmetric.sh * net.forwarding.vxlan_bridge_1d_port_8472.sh * net.forwarding.vxlan_bridge_1d.sh * net.forwarding.vxlan_bridge_1q_port_8472.sh * net.forwarding.vxlan_bridge_1q.sh * net.forwarding.vxlan_symmetric.sh * net.mptcp.simult_flows.sh * netfilter.nft_concat_range.sh * netfilter.nft_queue.sh * pidfd.pidfd_open_test * pidfd.pidfd_poll_test * proc.proc-fsconfig-hidepid * pstore.pstore_tests * ptrace.vmaccess.global.attach * ptrace.vmaccess * openat2.openat2_test * openat2.resolve_test * openat2.rename_attack_test * seccomp.seccomp_bpf.global.user_notification_filter_empty * seccomp.seccomp_bpf.global.user_notification_filter_empty_threaded * seccomp.seccomp_bpf.global.user_notification_addfd * seccomp.seccomp_bpf * seccomp.seccomp_benchmark * splice.short_splice_read.sh * vm.run_vmtests.sh * x86.syscall_numbering_64 ### x86, kselftest-vsyscall-mode-none * bpf.test_verifier * bpf.test_maps * bpf.test_progs * bpf.test_dev_cgroup * bpf.test_tcpbpf_user * bpf.get_cgroup_id_user * bpf.test_socket_cookie * bpf.test_netcnt * bpf.test_tcpnotify_user * bpf.test_sysctl * bpf.test_progs-no_alu32 * bpf.test_xdp_redirect.sh * bpf.test_xdp_meta.sh * bpf.test_sock_addr.sh * bpf.test_tunnel.sh * bpf.test_lwt_seg6local.sh * bpf.test_skb_cgroup_id.sh * bpf.test_flow_dissector.sh * bpf.test_xdp_vlan_mode_generic.sh * bpf.test_xdp_vlan_mode_native.sh * bpf.test_lwt_ip_encap.sh * bpf.test_tcp_check_syncookie.sh * bpf.test_tc_tunnel.sh * bpf.test_tc_edt.sh * bpf.test_xdping.sh * bpf.test_bpftool.sh * cgroup.test_memcontrol * cgroup.test_kmem * cgroup.test_core * cgroup.test_freezer * clone3.clone3_cap_checkpoint_restore * core.close_range_test * filesystems.binderfs.binderfs_test * firmware.fw_run_tests.sh * ftrace.ftracetest * intel_pstate.run.sh * lkdtm.BUG.sh * lkdtm.WARNING.sh * lkdtm.WARNING_MESSAGE.sh * lkdtm.EXCEPTION.sh * lkdtm.CORRUPT_LIST_ADD.sh * lkdtm.CORRUPT_LIST_DEL.sh * lkdtm.STACK_GUARD_PAGE_LEADING.sh * lkdtm.STACK_GUARD_PAGE_TRAILING.sh * lkdtm.UNSET_SMEP.sh * lkdtm.CORRUPT_PAC.sh * lkdtm.UNALIGNED_LOAD_STORE_WRITE.sh * lkdtm.READ_AFTER_FREE.sh * lkdtm.READ_BUDDY_AFTER_FREE.sh * lkdtm.SLAB_FREE_DOUBLE.sh * lkdtm.SLAB_FREE_CROSS.sh * lkdtm.SLAB_FREE_PAGE.sh * lkdtm.EXEC_DATA.sh * lkdtm.EXEC_STACK.sh * lkdtm.EXEC_KMALLOC.sh * lkdtm.EXEC_VMALLOC.sh * lkdtm.EXEC_RODATA.sh * lkdtm.EXEC_USERSPACE.sh * lkdtm.EXEC_NULL.sh * lkdtm.ACCESS_USERSPACE.sh * lkdtm.ACCESS_NULL.sh * lkdtm.WRITE_RO.sh * lkdtm.WRITE_RO_AFTER_INIT.sh * lkdtm.WRITE_KERN.sh * lkdtm.REFCOUNT_INC_OVERFLOW.sh * lkdtm.REFCOUNT_ADD_OVERFLOW.sh * lkdtm.REFCOUNT_INC_NOT_ZERO_OVERFLOW.sh * lkdtm.REFCOUNT_ADD_NOT_ZERO_OVERFLOW.sh * lkdtm.REFCOUNT_DEC_ZERO.sh * lkdtm.REFCOUNT_DEC_NEGATIVE.sh * lkdtm.REFCOUNT_DEC_AND_TEST_NEGATIVE.sh * lkdtm.REFCOUNT_SUB_AND_TEST_NEGATIVE.sh * lkdtm.REFCOUNT_INC_ZERO.sh * lkdtm.REFCOUNT_ADD_ZERO.sh * lkdtm.REFCOUNT_INC_SATURATED.sh * lkdtm.REFCOUNT_DEC_SATURATED.sh * lkdtm.REFCOUNT_ADD_SATURATED.sh * lkdtm.REFCOUNT_INC_NOT_ZERO_SATURATED.sh * lkdtm.REFCOUNT_ADD_NOT_ZERO_SATURATED.sh * lkdtm.REFCOUNT_DEC_AND_TEST_SATURATED.sh * lkdtm.REFCOUNT_SUB_AND_TEST_SATURATED.sh * lkdtm.USERCOPY_HEAP_SIZE_TO.sh * lkdtm.USERCOPY_HEAP_SIZE_FROM.sh * lkdtm.USERCOPY_HEAP_WHITELIST_TO.sh * lkdtm.USERCOPY_HEAP_WHITELIST_FROM.sh * lkdtm.USERCOPY_STACK_FRAME_TO.sh * lkdtm.USERCOPY_STACK_FRAME_FROM.sh * lkdtm.USERCOPY_STACK_BEYOND.sh * lkdtm.USERCOPY_KERNEL.sh * lkdtm.STACKLEAK_ERASING.sh * lkdtm.CFI_FORWARD_PROTO.sh * mincore.mincore_selftest.global.check_file_mmap * mincore.mincore_selftest * mqueue.mq_perf_tests * net.run_netsocktests * net.xfrm_policy.sh * net.fib_tests.sh * net.fib-onlink-tests.sh * net.pmtu.sh * net.udpgso_bench.sh * net.psock_snd.sh * net.udpgro_bench.sh * net.udpgro.sh * net.test_vxlan_under_vrf.sh * net.l2tp.sh * net.traceroute.sh * net.altnames.sh * net.icmp_redirect.sh * net.txtimestamp.sh * net.vrf-xfrm-tests.sh * net.devlink_port_split.py * net.forwarding.bridge_igmp.sh * net.forwarding.bridge_port_isolation.sh * net.forwarding.bridge_sticky_fdb.sh * net.forwarding.bridge_vlan_aware.sh * net.forwarding.bridge_vlan_unaware.sh * net.forwarding.ethtool.sh * net.forwarding.gre_inner_v4_multipath.sh * net.forwarding.gre_inner_v6_multipath.sh * net.forwarding.gre_multipath.sh * net.forwarding.ip6gre_inner_v4_multipath.sh * net.forwarding.ip6gre_inner_v6_multipath.sh * net.forwarding.ipip_flat_gre_key.sh * net.forwarding.ipip_flat_gre_keys.sh * net.forwarding.ipip_flat_gre.sh * net.forwarding.ipip_hier_gre_key.sh * net.forwarding.ipip_hier_gre_keys.sh * net.forwarding.ipip_hier_gre.sh * net.forwarding.loopback.sh * net.forwarding.mirror_gre_bound.sh * net.forwarding.mirror_gre_bridge_1d.sh * net.forwarding.mirror_gre_bridge_1d_vlan.sh * net.forwarding.mirror_gre_bridge_1q_lag.sh * net.forwarding.mirror_gre_bridge_1q.sh * net.forwarding.mirror_gre_changes.sh * net.forwarding.mirror_gre_flower.sh * net.forwarding.mirror_gre_lag_lacp.sh * net.forwarding.mirror_gre_neigh.sh * net.forwarding.mirror_gre_nh.sh * net.forwarding.mirror_gre.sh * net.forwarding.mirror_gre_vlan_bridge_1q.sh * net.forwarding.mirror_gre_vlan.sh * net.forwarding.mirror_vlan.sh * net.forwarding.router_bridge.sh * net.forwarding.router_bridge_vlan.sh * net.forwarding.router_broadcast.sh * net.forwarding.router_mpath_nh.sh * net.forwarding.router_multicast.sh * net.forwarding.router_multipath.sh * net.forwarding.router.sh * net.forwarding.router_vid_1.sh * net.forwarding.sch_ets.sh * net.forwarding.sch_tbf_ets.sh * net.forwarding.sch_tbf_prio.sh * net.forwarding.sch_tbf_root.sh * net.forwarding.tc_actions.sh * net.forwarding.tc_chains.sh * net.forwarding.tc_flower_router.sh * net.forwarding.tc_flower.sh * net.forwarding.tc_shblocks.sh * net.forwarding.tc_vlan_modify.sh * net.forwarding.vxlan_asymmetric.sh * net.forwarding.vxlan_bridge_1d_port_8472.sh * net.forwarding.vxlan_bridge_1d.sh * net.forwarding.vxlan_bridge_1q_port_8472.sh * net.forwarding.vxlan_bridge_1q.sh * net.forwarding.vxlan_symmetric.sh * net.mptcp.simult_flows.sh * netfilter.nft_concat_range.sh * netfilter.nft_queue.sh * pidfd.pidfd_open_test * pidfd.pidfd_poll_test * proc.proc-fsconfig-hidepid * pstore.pstore_tests * ptrace.vmaccess.global.attach * ptrace.vmaccess * openat2.openat2_test * openat2.resolve_test * openat2.rename_attack_test * rtc.rtctest * seccomp.seccomp_bpf.global.user_notification_filter_empty * seccomp.seccomp_bpf.global.user_notification_filter_empty_threaded * seccomp.seccomp_bpf.global.user_notification_addfd * seccomp.seccomp_bpf * seccomp.seccomp_benchmark * splice.short_splice_read.sh * vm.run_vmtests.sh * x86.syscall_numbering_64 ## Skips ### i386, kselftest * breakpoints.breakpoint_test * breakpoints.step_after_suspend_test * net.msg_zerocopy.sh * net.rtnetlink.sh * net.udpgro.sh * net.xfrm_policy.sh * netfilter.bridge_brouter.sh * netfilter.conntrack_icmp_related.sh * netfilter.nft_flowtable.sh * netfilter.nft_nat.sh * netfilter.nft_trans_stress.sh * pidfd.pidfd_wait * zram.zram.sh * bpf.test_xdp_veth.sh * bpf.test_bpftool_metadata.sh * cgroup.test_stress.sh * efivarfs.efivarfs.sh * fpu.run_test_fpu.sh * ir.ir_loopback.sh * kexec.test_kexec_load.sh * kexec.test_kexec_file_load.sh * livepatch.test-livepatch.sh * livepatch.test-callbacks.sh * livepatch.test-shadow-vars.sh * livepatch.test-state.sh * livepatch.test-ftrace.sh * lkdtm.PANIC.sh * lkdtm.LOOP.sh * lkdtm.EXHAUST_STACK.sh * lkdtm.CORRUPT_STACK.sh * lkdtm.CORRUPT_STACK_STRONG.sh * lkdtm.OVERWRITE_ALLOCATION.sh * lkdtm.WRITE_AFTER_FREE.sh * lkdtm.WRITE_BUDDY_AFTER_FREE.sh * lkdtm.SOFTLOCKUP.sh * lkdtm.HARDLOCKUP.sh * lkdtm.SPINLOCKUP.sh * lkdtm.HUNG_TASK.sh * lkdtm.REFCOUNT_TIMING.sh * lkdtm.ATOMIC_TIMING.sh * memory-hotplug.mem-on-off-test.sh * net.reuseport_bpf_numa * net.drop_monitor_tests.sh * net.mptcp.diag.sh * netfilter.ipvs.sh * netfilter.nft_conntrack_helper.sh * netfilter.nft_meta.sh * proc.proc-pid-vm * pstore.pstore_post_reboot_tests * tpm2.test_smoke.sh * tpm2.test_space.sh ### juno-r2, kselftest * mqueue.mq_perf_tests * breakpoints.breakpoint_test_arm64 * breakpoints.step_after_suspend_test * net.msg_zerocopy.sh * net.rtnetlink.sh * netfilter.bridge_brouter.sh * netfilter.nft_flowtable.sh * netfilter.nft_trans_stress.sh * pidfd.pidfd_wait * rseq.run_param_test.sh * zram.zram.sh * arm64.sve-ptrace * arm64.sve-probe-vls * bpf.test_xdp_veth.sh * bpf.test_bpftool_metadata.sh * cgroup.test_stress.sh * efivarfs.efivarfs.sh * fpu.run_test_fpu.sh * intel_pstate.run.sh * ir.ir_loopback.sh * livepatch.test-livepatch.sh * livepatch.test-callbacks.sh * livepatch.test-shadow-vars.sh * livepatch.test-state.sh * livepatch.test-ftrace.sh * lkdtm.PANIC.sh * lkdtm.LOOP.sh * lkdtm.EXHAUST_STACK.sh * lkdtm.CORRUPT_STACK.sh * lkdtm.CORRUPT_STACK_STRONG.sh * lkdtm.DOUBLE_FAULT.sh * lkdtm.OVERWRITE_ALLOCATION.sh * lkdtm.WRITE_AFTER_FREE.sh * lkdtm.WRITE_BUDDY_AFTER_FREE.sh * lkdtm.SOFTLOCKUP.sh * lkdtm.HARDLOCKUP.sh * lkdtm.SPINLOCKUP.sh * lkdtm.HUNG_TASK.sh * lkdtm.REFCOUNT_TIMING.sh * lkdtm.ATOMIC_TIMING.sh * net.xfrm_policy.sh * net.drop_monitor_tests.sh * net.mptcp.diag.sh * netfilter.ipvs.sh * netfilter.nft_conntrack_helper.sh * netfilter.nft_meta.sh * proc.proc-pid-vm * pstore.pstore_post_reboot_tests * tpm2.test_smoke.sh * tpm2.test_space.sh ### x86, kselftest * breakpoints.breakpoint_test * breakpoints.step_after_suspend_test * net.msg_zerocopy.sh * net.rtnetlink.sh * netfilter.bridge_brouter.sh * netfilter.conntrack_icmp_related.sh * netfilter.nft_flowtable.sh * netfilter.nft_nat.sh * netfilter.nft_trans_stress.sh * pidfd.pidfd_wait * proc.proc-pid-vm * zram.zram.sh * bpf.test_xdp_veth.sh * bpf.test_bpftool_metadata.sh * cgroup.test_stress.sh * efivarfs.efivarfs.sh * fpu.run_test_fpu.sh * ir.ir_loopback.sh * kexec.test_kexec_load.sh * kexec.test_kexec_file_load.sh * kvm.mmio_warning_test * kvm.svm_vmcall_test * lkdtm.PANIC.sh * lkdtm.LOOP.sh * lkdtm.EXHAUST_STACK.sh * lkdtm.CORRUPT_STACK.sh * lkdtm.CORRUPT_STACK_STRONG.sh * lkdtm.DOUBLE_FAULT.sh * lkdtm.OVERWRITE_ALLOCATION.sh * lkdtm.WRITE_AFTER_FREE.sh * lkdtm.WRITE_BUDDY_AFTER_FREE.sh * lkdtm.SOFTLOCKUP.sh * lkdtm.HARDLOCKUP.sh * lkdtm.SPINLOCKUP.sh * lkdtm.HUNG_TASK.sh * lkdtm.REFCOUNT_TIMING.sh * lkdtm.ATOMIC_TIMING.sh * net.drop_monitor_tests.sh * net.mptcp.diag.sh * netfilter.ipvs.sh * netfilter.nft_conntrack_helper.sh * netfilter.nft_meta.sh * pstore.pstore_post_reboot_tests * tpm2.test_smoke.sh * tpm2.test_space.sh ### x86, kselftest-vsyscall-mode-native * breakpoints.breakpoint_test * breakpoints.step_after_suspend_test * net.msg_zerocopy.sh * net.rtnetlink.sh * netfilter.bridge_brouter.sh * netfilter.conntrack_icmp_related.sh * netfilter.nft_flowtable.sh * netfilter.nft_nat.sh * netfilter.nft_trans_stress.sh * pidfd.pidfd_wait * proc.proc-pid-vm * zram.zram.sh * bpf.test_xdp_veth.sh * bpf.test_bpftool_metadata.sh * cgroup.test_stress.sh * efivarfs.efivarfs.sh * fpu.run_test_fpu.sh * ir.ir_loopback.sh * kexec.test_kexec_load.sh * kexec.test_kexec_file_load.sh * kvm.mmio_warning_test * kvm.svm_vmcall_test * lkdtm.PANIC.sh * lkdtm.LOOP.sh * lkdtm.EXHAUST_STACK.sh * lkdtm.CORRUPT_STACK.sh * lkdtm.CORRUPT_STACK_STRONG.sh * lkdtm.DOUBLE_FAULT.sh * lkdtm.OVERWRITE_ALLOCATION.sh * lkdtm.WRITE_AFTER_FREE.sh * lkdtm.WRITE_BUDDY_AFTER_FREE.sh * lkdtm.SOFTLOCKUP.sh * lkdtm.HARDLOCKUP.sh * lkdtm.SPINLOCKUP.sh * lkdtm.HUNG_TASK.sh * lkdtm.REFCOUNT_TIMING.sh * lkdtm.ATOMIC_TIMING.sh * net.drop_monitor_tests.sh * net.mptcp.diag.sh * netfilter.ipvs.sh * netfilter.nft_conntrack_helper.sh * netfilter.nft_meta.sh * pstore.pstore_post_reboot_tests * tpm2.test_smoke.sh * tpm2.test_space.sh ### x86, kselftest-vsyscall-mode-none * breakpoints.breakpoint_test * breakpoints.step_after_suspend_test * net.msg_zerocopy.sh * net.rtnetlink.sh * netfilter.bridge_brouter.sh * netfilter.conntrack_icmp_related.sh * netfilter.nft_flowtable.sh * netfilter.nft_nat.sh * netfilter.nft_trans_stress.sh * pidfd.pidfd_wait * proc.proc-pid-vm * zram.zram.sh * bpf.test_xdp_veth.sh * bpf.test_bpftool_metadata.sh * cgroup.test_stress.sh * efivarfs.efivarfs.sh * fpu.run_test_fpu.sh * ir.ir_loopback.sh * kexec.test_kexec_load.sh * kexec.test_kexec_file_load.sh * kvm.mmio_warning_test * kvm.svm_vmcall_test * lkdtm.PANIC.sh * lkdtm.LOOP.sh * lkdtm.EXHAUST_STACK.sh * lkdtm.CORRUPT_STACK.sh * lkdtm.CORRUPT_STACK_STRONG.sh * lkdtm.DOUBLE_FAULT.sh * lkdtm.OVERWRITE_ALLOCATION.sh * lkdtm.WRITE_AFTER_FREE.sh * lkdtm.WRITE_BUDDY_AFTER_FREE.sh * lkdtm.SOFTLOCKUP.sh * lkdtm.HARDLOCKUP.sh * lkdtm.SPINLOCKUP.sh * lkdtm.HUNG_TASK.sh * lkdtm.REFCOUNT_TIMING.sh * lkdtm.ATOMIC_TIMING.sh * net.drop_monitor_tests.sh * net.mptcp.diag.sh * netfilter.ipvs.sh * netfilter.nft_conntrack_helper.sh * netfilter.nft_meta.sh * pstore.pstore_post_reboot_tests * tpm2.test_smoke.sh * tpm2.test_space.sh -- Linaro LKFT https://lkft.linaro.org

4 years, 9 months

1
0
0 0

[PATCH] selftests/vm: 10x speedup for hmm-tests

by John Hubbard

This patch reduces the running time for hmm-tests from about 10+ seconds, to just under 1.0 second, for an approximately 10x speedup. That brings it in line with most of the other tests in selftests/vm, which mostly run in < 1 sec. This is done with a one-line change that simply reduces the number of iterations of several tests, from 256, to 10. Thanks to Ralph Campbell for suggesting changing NTIMES as a way to get the speedup. Suggested-by: Ralph Campbell <rcampbell(a)nvidia.com> Signed-off-by: John Hubbard <jhubbard(a)nvidia.com> --- This is based on mmotm. tools/testing/selftests/vm/hmm-tests.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/vm/hmm-tests.c b/tools/testing/selftests/vm/hmm-tests.c index 6b79723d7dc6..5d1ac691b9f4 100644 --- a/tools/testing/selftests/vm/hmm-tests.c +++ b/tools/testing/selftests/vm/hmm-tests.c @@ -49,7 +49,7 @@ struct hmm_buffer { #define TWOMEG (1 << 21) #define HMM_BUFFER_SIZE (1024 << 12) #define HMM_PATH_MAX 64 -#define NTIMES 256 +#define NTIMES 10 #define ALIGN(x, a) (((x) + (a - 1)) & (~((a) - 1))) -- 2.28.0

4 years, 9 months

2
3
0 0

[PATCH bpf-next v4 0/6] bpf: BTF support for ksyms

by Hao Luo

v3 -> v4: - Rebasing - Cast bpf_[per|this]_cpu_ptr's parameter to void __percpu * before passing into per_cpu_ptr. v2 -> v3: - Rename functions and variables in verifier for better readability. - Stick to logging message convention in libbpf. - Move bpf_per_cpu_ptr and bpf_this_cpu_ptr from trace-specific helper set to base helper set. - More specific test in ksyms_btf. - Fix return type cast in bpf_*_cpu_ptr. - Fix btf leak in ksyms_btf selftest. - Fix return error code for kallsyms_find(). v1 -> v2: - Move check_pseudo_btf_id from check_ld_imm() to replace_map_fd_with_map_ptr() and rename the latter. - Add bpf_this_cpu_ptr(). - Use bpf_core_types_are_compat() in libbpf.c for checking type compatibility. - Rewrite typed ksym extern type in BTF with int to save space. - Minor revision of bpf_per_cpu_ptr()'s comments. - Avoid using long in tests that use skeleton. - Refactored test_ksyms.c by moving kallsyms_find() to trace_helpers.c - Fold the patches that sync include/linux/uapi and tools/include/linux/uapi. rfc -> v1: - Encode VAR's btf_id for PSEUDO_BTF_ID. - More checks in verifier. Checking the btf_id passed as PSEUDO_BTF_ID is valid VAR, its name and type. - Checks in libbpf on type compatibility of ksyms. - Add bpf_per_cpu_ptr() to access kernel percpu vars. Introduced new ARG and RET types for this helper. This patch series extends the previously added __ksym externs with btf support. Right now the __ksym externs are treated as pure 64-bit scalar value. Libbpf replaces ld_imm64 insn of __ksym by its kernel address at load time. This patch series extend those externs with their btf info. Note that btf support for __ksym must come with the kernel btf that has VARs encoded to work properly. The corresponding chagnes in pahole is available at [1] (with a fix at [2] for gcc 4.9+). The first 3 patches in this series add support for general kernel global variables, which include verifier checking (01/06), libpf support (02/06) and selftests for getting typed ksym extern's kernel address (03/06). The next 3 patches extends that capability further by introducing helpers bpf_per_cpu_ptr() and bpf_this_cpu_ptr(), which allows accessing kernel percpu variables correctly (04/06 and 05/06). The tests of this feature were performed against pahole that is extended with [1] and [2]. For kernel BTF that does not have VARs encoded, the selftests will be skipped. [1] https://git.kernel.org/pub/scm/devel/pahole/pahole.git/commit/?id=f3d9054ba… [2] https://www.spinics.net/lists/dwarves/msg00451.html Hao Luo (6): bpf: Introduce pseudo_btf_id bpf/libbpf: BTF support for typed ksyms selftests/bpf: ksyms_btf to test typed ksyms bpf: Introduce bpf_per_cpu_ptr() bpf: Introducte bpf_this_cpu_ptr() bpf/selftests: Test for bpf_per_cpu_ptr() and bpf_this_cpu_ptr() include/linux/bpf.h | 6 + include/linux/bpf_verifier.h | 7 + include/linux/btf.h | 26 +++ include/uapi/linux/bpf.h | 67 +++++- kernel/bpf/btf.c | 25 --- kernel/bpf/helpers.c | 32 +++ kernel/bpf/verifier.c | 190 ++++++++++++++++-- kernel/trace/bpf_trace.c | 4 + tools/include/uapi/linux/bpf.h | 67 +++++- tools/lib/bpf/libbpf.c | 112 +++++++++-- .../testing/selftests/bpf/prog_tests/ksyms.c | 38 ++-- .../selftests/bpf/prog_tests/ksyms_btf.c | 88 ++++++++ .../selftests/bpf/progs/test_ksyms_btf.c | 55 +++++ tools/testing/selftests/bpf/trace_helpers.c | 27 +++ tools/testing/selftests/bpf/trace_helpers.h | 4 + 15 files changed, 653 insertions(+), 95 deletions(-) create mode 100644 tools/testing/selftests/bpf/prog_tests/ksyms_btf.c create mode 100644 tools/testing/selftests/bpf/progs/test_ksyms_btf.c -- 2.28.0.709.gb0816b6eb0-goog

4 years, 9 months

2
12
0 0

[PATCH v5 00/16] Introduce partial kernel_read_file() support

by Kees Cook

v5: - add more reviews (thank you!) - add "description" string to post_load_data API (mimi) - drop bug fix that got taken already v4: https://lore.kernel.org/lkml/20200729175845.1745471-1-keescook@chromium.org/ v3: https://lore.kernel.org/lkml/20200724213640.389191-1-keescook@chromium.org/ v2: lost to the ether v1: https://lore.kernel.org/lkml/20200717174309.1164575-1-keescook@chromium.org/ Hi, Here's my tree for adding partial read support in kernel_read_file(), which fixes a number of issues along the way. It's got Scott's firmware and IMA patches ported and everything tests cleanly for me (even with CONFIG_IMA_APPRAISE=y), and now appears to pass 0day. :) The intention is for this to go via Greg's tree since Scott's driver code will depend on it. Thanks, -Kees Kees Cook (12): fs/kernel_read_file: Remove FIRMWARE_PREALLOC_BUFFER enum fs/kernel_read_file: Remove FIRMWARE_EFI_EMBEDDED enum fs/kernel_read_file: Split into separate source file fs/kernel_read_file: Remove redundant size argument fs/kernel_read_file: Switch buffer size arg to size_t fs/kernel_read_file: Add file_size output argument LSM: Introduce kernel_post_load_data() hook firmware_loader: Use security_post_load_data() module: Call security_kernel_post_load_data() LSM: Add "contents" flag to kernel_read_file hook fs/kernel_file_read: Add "offset" arg for partial reads firmware: Store opt_flags in fw_priv Scott Branden (4): fs/kernel_read_file: Split into separate include file IMA: Add support for file reads without contents firmware: Add request_partial_firmware_into_buf() test_firmware: Test partial read support drivers/base/firmware_loader/fallback.c | 19 +- drivers/base/firmware_loader/fallback.h | 5 +- .../base/firmware_loader/fallback_platform.c | 12 +- drivers/base/firmware_loader/firmware.h | 7 +- drivers/base/firmware_loader/main.c | 135 ++++++++++--- fs/Makefile | 3 +- fs/exec.c | 132 +----------- fs/kernel_read_file.c | 189 ++++++++++++++++++ include/linux/firmware.h | 12 ++ include/linux/fs.h | 39 ---- include/linux/ima.h | 20 +- include/linux/kernel_read_file.h | 55 +++++ include/linux/lsm_hook_defs.h | 6 +- include/linux/lsm_hooks.h | 13 ++ include/linux/security.h | 21 +- kernel/kexec.c | 2 +- kernel/kexec_file.c | 19 +- kernel/module.c | 24 ++- lib/test_firmware.c | 154 ++++++++++++-- security/integrity/digsig.c | 8 +- security/integrity/ima/ima_fs.c | 10 +- security/integrity/ima/ima_main.c | 73 +++++-- security/integrity/ima/ima_policy.c | 1 + security/loadpin/loadpin.c | 17 +- security/security.c | 28 ++- security/selinux/hooks.c | 8 +- .../selftests/firmware/fw_filesystem.sh | 91 +++++++++ 27 files changed, 807 insertions(+), 296 deletions(-) create mode 100644 fs/kernel_read_file.c create mode 100644 include/linux/kernel_read_file.h -- 2.25.1

4 years, 9 months

2
20
0 0

[PATCH 00/11] Introduce Simple atomic and non-atomic counters

by Shuah Khan

This patch series is a result of discussion at the refcount_t BOF the Linux Plumbers Conference. In this discussion, we identified a need for looking closely and investigating atomic_t usages in the kernel when it is used strictly as a counter without it controlling object lifetimes and state changes. There are a number of atomic_t usages in the kernel where atomic_t api is used strictly for counting and not for managing object lifetime. In some cases, atomic_t might not even be needed. The purpose of these counters is twofold: 1. clearly differentiate atomic_t counters from atomic_t usages that guard object lifetimes, hence prone to overflow and underflow errors. It allows tools that scan for underflow and overflow on atomic_t usages to detect overflow and underflows to scan just the cases that are prone to errors. 2. provides non-atomic counters for cases where atomic isn't necessary. Simple atomic and non-atomic counters api provides interfaces for simple atomic and non-atomic counters that just count, and don't guard resource lifetimes. Counters will wrap around to 0 when it overflows and should not be used to guard resource lifetimes, device usage and open counts that control state changes, and pm states. Using counter_atomic to guard lifetimes could lead to use-after free when it overflows and undefined behavior when used to manage state changes and device usage/open states. This patch series introduces Simple atomic and non-atomic counters. Counter atomic ops leverage atomic_t and provide a sub-set of atomic_t ops. In addition this patch series converts a few drivers to use the new api. The following criteria is used for select variables for conversion: 1. Variable doesn't guard object lifetimes, manage state changes e.g: device usage counts, device open counts, and pm states. 2. Variable is used for stats and counters. 3. The conversion doesn't change the overflow behavior. Changes since RFC: -- Thanks for reviews and reviewed-by, and Acked-by tags. Updated the patches with the tags. -- Addressed Kees's comments: 1. Non-atomic counters renamed to counter_simple32 and counter_simple64 to clearly indicate size. 2. Added warning for counter_simple* usage and it should be used only when there is no need for atomicity. 3. Renamed counter_atomic to counter_atomic32 to clearly indicate size. 4. Renamed counter_atomic_long to counter_atomic64 and it now uses atomic64_t ops and indicates size. 5. Test updated for the API renames. 6. Added helper functions for test results printing 7. Verified that the test module compiles in kunit env. and test module can be loaded to run the test. 8. Updated Documentation to reflect the intent to make the API restricted so it can never be used to guard object lifetimes and state management. I left _return ops for now, inc_return is necessary for now as per the discussion we had on this topic. -- Updated driver patches with API name changes. -- We discussed if binder counters can be non-atomic. For now I left them the same as the RFC patch - using counter_atomic32 -- Unrelated to this patch series: The patch series review uncovered improvements could be made to test_async_driver_probe and vmw_vmci/vmci_guest. I will track these for fixing later. Shuah Khan (11): counters: Introduce counter_simple* and counter_atomic* counters selftests:lib:test_counters: add new test for counters drivers/base: convert deferred_trigger_count and probe_count to counter_atomic32 drivers/base/devcoredump: convert devcd_count to counter_atomic32 drivers/acpi: convert seqno counter_atomic32 drivers/acpi/apei: convert seqno counter_atomic32 drivers/android/binder: convert stats, transaction_log to counter_atomic32 drivers/base/test/test_async_driver_probe: convert to use counter_atomic32 drivers/char/ipmi: convert stats to use counter_atomic32 drivers/misc/vmw_vmci: convert num guest devices counter to counter_atomic32 drivers/edac: convert pci counters to counter_atomic32 Documentation/core-api/counters.rst | 174 +++++++++ MAINTAINERS | 8 + drivers/acpi/acpi_extlog.c | 5 +- drivers/acpi/apei/ghes.c | 5 +- drivers/android/binder.c | 41 +-- drivers/android/binder_internal.h | 3 +- drivers/base/dd.c | 19 +- drivers/base/devcoredump.c | 5 +- drivers/base/test/test_async_driver_probe.c | 23 +- drivers/char/ipmi/ipmi_msghandler.c | 9 +- drivers/char/ipmi/ipmi_si_intf.c | 9 +- drivers/edac/edac_pci.h | 5 +- drivers/edac/edac_pci_sysfs.c | 28 +- drivers/misc/vmw_vmci/vmci_guest.c | 9 +- include/linux/counters.h | 350 +++++++++++++++++++ lib/Kconfig | 10 + lib/Makefile | 1 + lib/test_counters.c | 276 +++++++++++++++ tools/testing/selftests/lib/Makefile | 1 + tools/testing/selftests/lib/config | 1 + tools/testing/selftests/lib/test_counters.sh | 5 + 21 files changed, 913 insertions(+), 74 deletions(-) create mode 100644 Documentation/core-api/counters.rst create mode 100644 include/linux/counters.h create mode 100644 lib/test_counters.c create mode 100755 tools/testing/selftests/lib/test_counters.sh -- 2.25.1

4 years, 9 months

3
15
0 0

[PATCH] selftests: splice: Adjust for handler fallback removal

by Kees Cook

Some pseudo-filesystems do not have an explicit splice fops since adding commit 36e2c7421f02 ("fs: don't allow splice read/write without explicit ops"), and now will reject attempts to use splice() in those filesystem paths. Reported-by: kernel test robot <rong.a.chen(a)intel.com> Link: https://lore.kernel.org/lkml/202009181443.C2179FB@keescook/ Fixes: 36e2c7421f02 ("fs: don't allow splice read/write without explicit ops") Signed-off-by: Kees Cook <keescook(a)chromium.org> --- .../selftests/splice/short_splice_read.sh | 119 ++++++++++++++---- 1 file changed, 98 insertions(+), 21 deletions(-) diff --git a/tools/testing/selftests/splice/short_splice_read.sh b/tools/testing/selftests/splice/short_splice_read.sh index 7810d3589d9a..22b6c8910b18 100755 --- a/tools/testing/selftests/splice/short_splice_read.sh +++ b/tools/testing/selftests/splice/short_splice_read.sh @@ -1,21 +1,87 @@ #!/bin/sh # SPDX-License-Identifier: GPL-2.0 +# +# Test for mishandling of splice() on pseudofilesystems, which should catch +# bugs like 11990a5bd7e5 ("module: Correctly truncate sysfs sections output") +# +# Since splice fallback was removed as part of the set_fs() rework, many of these +# tests expect to fail now. See https://lore.kernel.org/lkml/202009181443.C2179FB@keescook/ set -e +DIR=$(dirname "$0") + ret=0 +expect_success() +{ + title="$1" + shift + + echo "" >&2 + echo "$title ..." >&2 + + set +e + "$@" + rc=$? + set -e + + case "$rc" in + 0) + echo "ok: $title succeeded" >&2 + ;; + 1) + echo "FAIL: $title should work" >&2 + ret=$(( ret + 1 )) + ;; + *) + echo "FAIL: something else went wrong" >&2 + ret=$(( ret + 1 )) + ;; + esac +} + +expect_failure() +{ + title="$1" + shift + + echo "" >&2 + echo "$title ..." >&2 + + set +e + "$@" + rc=$? + set -e + + case "$rc" in + 0) + echo "FAIL: $title unexpectedly worked" >&2 + ret=$(( ret + 1 )) + ;; + 1) + echo "ok: $title correctly failed" >&2 + ;; + *) + echo "FAIL: something else went wrong" >&2 + ret=$(( ret + 1 )) + ;; + esac +} + do_splice() { filename="$1" bytes="$2" expected="$3" + report="$4" - out=$(./splice_read "$filename" "$bytes" | cat) + out=$("$DIR"/splice_read "$filename" "$bytes" | cat) if [ "$out" = "$expected" ] ; then - echo "ok: $filename $bytes" + echo " matched $report" >&2 + return 0 else - echo "FAIL: $filename $bytes" - ret=1 + echo " no match: '$out' vs $report" >&2 + return 1 fi } @@ -23,34 +89,45 @@ test_splice() { filename="$1" + echo " checking $filename ..." >&2 + full=$(cat "$filename") + rc=$? + if [ $rc -ne 0 ] ; then + return 2 + fi + two=$(echo "$full" | grep -m1 . | cut -c-2) # Make sure full splice has the same contents as a standard read. - do_splice "$filename" 4096 "$full" + echo " splicing 4096 bytes ..." >&2 + if ! do_splice "$filename" 4096 "$full" "full read" ; then + return 1 + fi # Make sure a partial splice see the first two characters. - do_splice "$filename" 2 "$two" + echo " splicing 2 bytes ..." >&2 + if ! do_splice "$filename" 2 "$two" "'$two'" ; then + return 1 + fi + + return 0 } -# proc_single_open(), seq_read() -test_splice /proc/$$/limits -# special open, seq_read() -test_splice /proc/$$/comm +### /proc/$pid/ has no splice interface; these should all fail. +expect_failure "proc_single_open(), seq_read() splice" test_splice /proc/$$/limits +expect_failure "special open(), seq_read() splice" test_splice /proc/$$/comm -# proc_handler, proc_dointvec_minmax -test_splice /proc/sys/fs/nr_open -# proc_handler, proc_dostring -test_splice /proc/sys/kernel/modprobe -# proc_handler, special read -test_splice /proc/sys/kernel/version +### /proc/sys/ has a splice interface; these should all succeed. +expect_success "proc_handler: proc_dointvec_minmax() splice" test_splice /proc/sys/fs/nr_open +expect_success "proc_handler: proc_dostring() splice" test_splice /proc/sys/kernel/modprobe +expect_success "proc_handler: special read splice" test_splice /proc/sys/kernel/version +### /sys/ has no splice interface; these should all fail. if ! [ -d /sys/module/test_module/sections ] ; then - modprobe test_module + expect_success "test_module kernel module load" modprobe test_module fi -# kernfs, attr -test_splice /sys/module/test_module/coresize -# kernfs, binattr -test_splice /sys/module/test_module/sections/.init.text +expect_failure "kernfs attr splice" test_splice /sys/module/test_module/coresize +expect_failure "kernfs binattr splice" test_splice /sys/module/test_module/sections/.init.text exit $ret -- 2.25.1

4 years, 9 months

1
0
0 0

[PATCH v2 0/6] kselftest: arm64/mte: Tests for user-space MTE

by Amit Daniel Kachhap

These patch series adds below kselftests to test the user-space support for the ARMv8.5 Memory Tagging Extension present in arm64 tree [1]. This patch series is based on Linux v5.9-rc3. 1) This test-case verifies that the memory allocated by kernel mmap interface can support tagged memory access. It first checks the presence of tags at address[56:59] and then proceeds with read and write. The pass criteria for this test is that tag fault exception should not happen. 2) This test-case crosses the valid memory to the invalid memory. In this memory area valid tags are not inserted so read and write should not pass. The pass criteria for this test is that tag fault exception should happen for all the illegal addresses. This test also verfies that PSTATE.TCO works properly. 3) This test-case verifies that the memory inherited by child process from parent process should have same tags copied. The pass criteria for this test is that tag fault exception should not happen. 4) This test checks different mmap flags with PROT_MTE memory protection. 5) This testcase checks that KSM should not merge pages containing different MTE tag values. However, if the tags are same then the pages may merge. This testcase uses the generic ksm sysfs interfaces to verify the MTE behaviour, so this testcase is not fullproof and may be impacted due to other load in the system. 6) Fifth test verifies that syscalls read/write etc works by considering that user pointer has valid/invalid allocation tags. Changes since v1 [2]: * Redefined MTE kernel header definitions to decouple kselftest compilations. * Removed gmi masking instructions in mte_insert_random_tag assembly function. This simplifies the tag inclusion mask test with only GCR mask register used. * Created a new mte_insert_random_tag function with gmi instruction. This is useful for the 6th test which reuses the original tag. * Now use /dev/shm/* to hold temporary files. * Updated the 6th test to handle the error properly in case of failure in accessing memory with invalid tag in kernel. * Code and comment clean-ups. Thanks, Amit Daniel [1]: https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/mte [2]: https://patchwork.kernel.org/patch/11747791/ Amit Daniel Kachhap (6): kselftest/arm64: Add utilities and a test to validate mte memory kselftest/arm64: Verify mte tag inclusion via prctl kselftest/arm64: Check forked child mte memory accessibility kselftest/arm64: Verify all different mmap MTE options kselftest/arm64: Verify KSM page merge for MTE pages kselftest/arm64: Check mte tagged user address in kernel tools/testing/selftests/arm64/Makefile | 2 +- tools/testing/selftests/arm64/mte/.gitignore | 6 + tools/testing/selftests/arm64/mte/Makefile | 29 ++ .../selftests/arm64/mte/check_buffer_fill.c | 475 ++++++++++++++++++ .../selftests/arm64/mte/check_child_memory.c | 195 +++++++ .../selftests/arm64/mte/check_ksm_options.c | 159 ++++++ .../selftests/arm64/mte/check_mmap_options.c | 262 ++++++++++ .../arm64/mte/check_tags_inclusion.c | 185 +++++++ .../selftests/arm64/mte/check_user_mem.c | 111 ++++ .../selftests/arm64/mte/mte_common_util.c | 341 +++++++++++++ .../selftests/arm64/mte/mte_common_util.h | 118 +++++ tools/testing/selftests/arm64/mte/mte_def.h | 60 +++ .../testing/selftests/arm64/mte/mte_helper.S | 128 +++++ 13 files changed, 2070 insertions(+), 1 deletion(-) create mode 100644 tools/testing/selftests/arm64/mte/.gitignore create mode 100644 tools/testing/selftests/arm64/mte/Makefile create mode 100644 tools/testing/selftests/arm64/mte/check_buffer_fill.c create mode 100644 tools/testing/selftests/arm64/mte/check_child_memory.c create mode 100644 tools/testing/selftests/arm64/mte/check_ksm_options.c create mode 100644 tools/testing/selftests/arm64/mte/check_mmap_options.c create mode 100644 tools/testing/selftests/arm64/mte/check_tags_inclusion.c create mode 100644 tools/testing/selftests/arm64/mte/check_user_mem.c create mode 100644 tools/testing/selftests/arm64/mte/mte_common_util.c create mode 100644 tools/testing/selftests/arm64/mte/mte_common_util.h create mode 100644 tools/testing/selftests/arm64/mte/mte_def.h create mode 100644 tools/testing/selftests/arm64/mte/mte_helper.S -- 2.17.1

4 years, 9 months

3
8
0 0

[PATCH v3 0/5] Speed up mremap on large regions

by Kalesh Singh

This version 3 of the mremap speed up patches previously posted at: v1 - https://lore.kernel.org/r/20200930222130.4175584-1-kaleshsingh@google.com v2 - https://lore.kernel.org/r/20201002162101.665549-1-kaleshsingh@google.com mremap time can be optimized by moving entries at the PMD/PUD level if the source and destination addresses are PMD/PUD-aligned and PMD/PUD-sized. Enable moving at the PMD and PUD levels on arm64 and x86. Other architectures where this type of move is supported and known to be safe can also opt-in to these optimizations by enabling HAVE_MOVE_PMD and HAVE_MOVE_PUD. Observed Performance Improvements for remapping a PUD-aligned 1GB-sized region on x86 and arm64: - HAVE_MOVE_PMD is already enabled on x86 : N/A - Enabling HAVE_MOVE_PUD on x86 : ~13x speed up - Enabling HAVE_MOVE_PMD on arm64 : ~ 8x speed up - Enabling HAVE_MOVE_PUD on arm64 : ~19x speed up Altogether, HAVE_MOVE_PMD and HAVE_MOVE_PUD give a total of ~150x speed up on arm64. Changes in v2: - Reduce mremap_test time by only validating a configurable threshold of the remapped region, as per John. - Use a random pattern for mremap validation. Provide pattern seed in test output, as per John. - Moved set_pud_at() to separate patch, per Kirill. - Use switch() instead of ifs in move_pgt_entry(), per Kirill. - Update commit message with description of Android garbage collector use case for HAVE_MOVE_PUD, as per Joel. - Fix build test error reported by kernel test robot in [1]. Changes in v3: - Make lines 80 cols or less where they don’t need to be longer, per John. - Removed unused PATTERN_SIZE in mremap_test - Added Reviewed-by tag for patch 1/5 (mremap kselftest patch). - Use switch() instead of ifs in get_extent(), per Kirill - Add BUILD_BUG() is get_extent() default case. - Move get_old_pud() and alloc_new_pud() out of #ifdef CONFIG_HAVE_MOVE_PUD, per Kirill. - Have get_old_pmd() and alloc_new_pmd() use get_old_pud() and alloc_old_pud(), per Kirill. - Replace #ifdef CONFIG_HAVE_MOVE_PMD / PUD in move_page_tables() with IS_ENABLED(CONFIG_HAVE_MOVE_PMD / PUD), per Kirill. - Fold Add set_pud_at() patch into patch 4/5, per Kirill. [1] https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org/thread/CKPGL4F… Kalesh Singh (5): kselftests: vm: Add mremap tests arm64: mremap speedup - Enable HAVE_MOVE_PMD mm: Speedup mremap on 1GB or larger regions arm64: mremap speedup - Enable HAVE_MOVE_PUD x86: mremap speedup - Enable HAVE_MOVE_PUD arch/Kconfig | 7 + arch/arm64/Kconfig | 2 + arch/arm64/include/asm/pgtable.h | 1 + arch/x86/Kconfig | 1 + mm/mremap.c | 230 ++++++++++++--- tools/testing/selftests/vm/.gitignore | 1 + tools/testing/selftests/vm/Makefile | 1 + tools/testing/selftests/vm/mremap_test.c | 344 +++++++++++++++++++++++ tools/testing/selftests/vm/run_vmtests | 11 + 9 files changed, 558 insertions(+), 40 deletions(-) create mode 100644 tools/testing/selftests/vm/mremap_test.c base-commit: 549738f15da0e5a00275977623be199fbbf7df50 -- 2.28.0.806.g8561365e88-goog

4 years, 9 months

1
5
0 0

[REGRESSION] kselftest: next-20201002

by LKFT

## Kernel * kernel: 5.9.0-rc7 * git repo: ['https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git', 'https://gitlab.com/Linaro/lkft/mirrors/next/linux-next'] * git branch: master * git commit: 2172e358cd1713c5b7c31361ac465edfe55e455c * git describe: next-20201002 * Test details: https://qa-reports.linaro.org/lkft/linux-next-master/build/next-20201002 ## Regressions (compared to build next-20201001) x86: kselftest-vsyscall-mode-native: * net.fib-onlink-tests.sh * net.mptcp.mptcp_connect.sh kselftest-vsyscall-mode-none: * proc.read juno-r2: kselftest: * rtc.rtctest ## Fixes (compared to build next-20201001) x86: kselftest-vsyscall-mode-native: * pidfd.pidfd_test * tc-testing.tdc.sh kselftest-vsyscall-mode-none: * kvm.vmx_preemption_timer_test * rtc.rtctest kselftest: * rtc.rtctest * tc-testing.tdc.sh ## Summary ### i386, kselftest * total: 677 * pass: 411 * fail: 215 * skip: 51 * xfail: 0 ### juno-r2, kselftest * total: 653 * pass: 404 * fail: 199 * skip: 50 * xfail: 0 ### x86, kselftest * total: 671 * pass: 439 * fail: 187 * skip: 45 * xfail: 0 ### x86, kselftest-vsyscall-mode-native * total: 670 * pass: 436 * fail: 189 * skip: 45 * xfail: 0 ### x86, kselftest-vsyscall-mode-none * total: 671 * pass: 437 * fail: 189 * skip: 45 * xfail: 0 ## Environments * dragonboard-410c * hi6220-hikey * i386 * juno-r2 * juno-r2-compat * juno-r2-kasan * nxp-ls2088 * qemu_arm * qemu_arm64 * qemu_i386 * qemu_x86_64 * x15 * x86 * x86-kasan ## Suites * kselftest * kselftest-vsyscall-mode-native * kselftest-vsyscall-mode-none ## Failures ### i386, kselftest * bpf.test_verifier * bpf.test_maps * bpf.test_progs * bpf.test_dev_cgroup * bpf.test_tcpbpf_user * bpf.get_cgroup_id_user * bpf.test_socket_cookie * bpf.test_netcnt * bpf.test_tcpnotify_user * bpf.test_sysctl * bpf.test_progs-no_alu32 * bpf.test_xdp_redirect.sh * bpf.test_xdp_meta.sh * bpf.test_sock_addr.sh * bpf.test_tunnel.sh * bpf.test_lwt_seg6local.sh * bpf.test_skb_cgroup_id.sh * bpf.test_flow_dissector.sh * bpf.test_xdp_vlan_mode_generic.sh * bpf.test_xdp_vlan_mode_native.sh * bpf.test_lwt_ip_encap.sh * bpf.test_tcp_check_syncookie.sh * bpf.test_tc_tunnel.sh * bpf.test_tc_edt.sh * bpf.test_xdping.sh * bpf.test_bpftool.sh * cgroup.test_memcontrol * cgroup.test_kmem * cgroup.test_core * cgroup.test_freezer * clone3.clone3_clear_sighand * clone3.clone3_cap_checkpoint_restore * core.close_range_test * filesystems.binderfs.binderfs_test * firmware.fw_run_tests.sh * ftrace.ftracetest * intel_pstate.run.sh * kvm.cr4_cpuid_sync_test * kvm.evmcs_test * kvm.hyperv_cpuid * kvm.mmio_warning_test * kvm.platform_info_test * kvm.set_sregs_test * kvm.smm_test * kvm.state_test * kvm.vmx_preemption_timer_test * kvm.svm_vmcall_test * kvm.sync_regs_test * kvm.vmx_close_while_nested_test * kvm.vmx_dirty_log_test * kvm.vmx_set_nested_state_test * kvm.vmx_tsc_adjust_test * kvm.xss_msr_test * kvm.debug_regs * kvm.clear_dirty_log_test * kvm.demand_paging_test * kvm.dirty_log_test * kvm.kvm_create_max_vcpus * kvm.set_memory_region_test * kvm.steal_time * lkdtm.BUG.sh * lkdtm.WARNING.sh * lkdtm.WARNING_MESSAGE.sh * lkdtm.EXCEPTION.sh * lkdtm.CORRUPT_LIST_ADD.sh * lkdtm.CORRUPT_LIST_DEL.sh * lkdtm.STACK_GUARD_PAGE_LEADING.sh * lkdtm.STACK_GUARD_PAGE_TRAILING.sh * lkdtm.UNSET_SMEP.sh * lkdtm.DOUBLE_FAULT.sh * lkdtm.CORRUPT_PAC.sh * lkdtm.UNALIGNED_LOAD_STORE_WRITE.sh * lkdtm.READ_AFTER_FREE.sh * lkdtm.READ_BUDDY_AFTER_FREE.sh * lkdtm.SLAB_FREE_DOUBLE.sh * lkdtm.SLAB_FREE_CROSS.sh * lkdtm.SLAB_FREE_PAGE.sh * lkdtm.EXEC_DATA.sh * lkdtm.EXEC_STACK.sh * lkdtm.EXEC_KMALLOC.sh * lkdtm.EXEC_VMALLOC.sh * lkdtm.EXEC_RODATA.sh * lkdtm.EXEC_USERSPACE.sh * lkdtm.EXEC_NULL.sh * lkdtm.ACCESS_USERSPACE.sh * lkdtm.ACCESS_NULL.sh * lkdtm.WRITE_RO.sh * lkdtm.WRITE_RO_AFTER_INIT.sh * lkdtm.WRITE_KERN.sh * lkdtm.REFCOUNT_INC_OVERFLOW.sh * lkdtm.REFCOUNT_ADD_OVERFLOW.sh * lkdtm.REFCOUNT_INC_NOT_ZERO_OVERFLOW.sh * lkdtm.REFCOUNT_ADD_NOT_ZERO_OVERFLOW.sh * lkdtm.REFCOUNT_DEC_ZERO.sh * lkdtm.REFCOUNT_DEC_NEGATIVE.sh * lkdtm.REFCOUNT_DEC_AND_TEST_NEGATIVE.sh * lkdtm.REFCOUNT_SUB_AND_TEST_NEGATIVE.sh * lkdtm.REFCOUNT_INC_ZERO.sh * lkdtm.REFCOUNT_ADD_ZERO.sh * lkdtm.REFCOUNT_INC_SATURATED.sh * lkdtm.REFCOUNT_DEC_SATURATED.sh * lkdtm.REFCOUNT_ADD_SATURATED.sh * lkdtm.REFCOUNT_INC_NOT_ZERO_SATURATED.sh * lkdtm.REFCOUNT_ADD_NOT_ZERO_SATURATED.sh * lkdtm.REFCOUNT_DEC_AND_TEST_SATURATED.sh * lkdtm.REFCOUNT_SUB_AND_TEST_SATURATED.sh * lkdtm.USERCOPY_HEAP_SIZE_TO.sh * lkdtm.USERCOPY_HEAP_SIZE_FROM.sh * lkdtm.USERCOPY_HEAP_WHITELIST_TO.sh * lkdtm.USERCOPY_HEAP_WHITELIST_FROM.sh * lkdtm.USERCOPY_STACK_FRAME_TO.sh * lkdtm.USERCOPY_STACK_FRAME_FROM.sh * lkdtm.USERCOPY_STACK_BEYOND.sh * lkdtm.USERCOPY_KERNEL.sh * lkdtm.STACKLEAK_ERASING.sh * lkdtm.CFI_FORWARD_PROTO.sh * mincore.mincore_selftest.global.check_file_mmap * mincore.mincore_selftest * mqueue.mq_perf_tests * net.run_netsocktests * net.fib_tests.sh * net.fib-onlink-tests.sh * net.pmtu.sh * net.udpgso_bench.sh * net.psock_snd.sh * net.udpgro_bench.sh * net.test_vxlan_under_vrf.sh * net.l2tp.sh * net.traceroute.sh * net.altnames.sh * net.icmp_redirect.sh * net.txtimestamp.sh * net.vrf-xfrm-tests.sh * net.devlink_port_split.py * net.forwarding.bridge_igmp.sh * net.forwarding.bridge_port_isolation.sh * net.forwarding.bridge_sticky_fdb.sh * net.forwarding.bridge_vlan_aware.sh * net.forwarding.bridge_vlan_unaware.sh * net.forwarding.ethtool.sh * net.forwarding.gre_inner_v4_multipath.sh * net.forwarding.gre_inner_v6_multipath.sh * net.forwarding.gre_multipath.sh * net.forwarding.ip6gre_inner_v4_multipath.sh * net.forwarding.ip6gre_inner_v6_multipath.sh * net.forwarding.ipip_flat_gre_key.sh * net.forwarding.ipip_flat_gre_keys.sh * net.forwarding.ipip_flat_gre.sh * net.forwarding.ipip_hier_gre_key.sh * net.forwarding.ipip_hier_gre_keys.sh * net.forwarding.ipip_hier_gre.sh * net.forwarding.loopback.sh * net.forwarding.mirror_gre_bound.sh * net.forwarding.mirror_gre_bridge_1d.sh * net.forwarding.mirror_gre_bridge_1d_vlan.sh * net.forwarding.mirror_gre_bridge_1q_lag.sh * net.forwarding.mirror_gre_bridge_1q.sh * net.forwarding.mirror_gre_changes.sh * net.forwarding.mirror_gre_flower.sh * net.forwarding.mirror_gre_lag_lacp.sh * net.forwarding.mirror_gre_neigh.sh * net.forwarding.mirror_gre_nh.sh * net.forwarding.mirror_gre.sh * net.forwarding.mirror_gre_vlan_bridge_1q.sh * net.forwarding.mirror_gre_vlan.sh * net.forwarding.mirror_vlan.sh * net.forwarding.router_bridge.sh * net.forwarding.router_bridge_vlan.sh * net.forwarding.router_broadcast.sh * net.forwarding.router_mpath_nh.sh * net.forwarding.router_multicast.sh * net.forwarding.router_multipath.sh * net.forwarding.router.sh * net.forwarding.router_vid_1.sh * net.forwarding.sch_ets.sh * net.forwarding.sch_tbf_ets.sh * net.forwarding.sch_tbf_prio.sh * net.forwarding.sch_tbf_root.sh * net.forwarding.tc_actions.sh * net.forwarding.tc_chains.sh * net.forwarding.tc_flower_router.sh * net.forwarding.tc_flower.sh * net.forwarding.tc_shblocks.sh * net.forwarding.tc_vlan_modify.sh * net.forwarding.vxlan_asymmetric.sh * net.forwarding.vxlan_bridge_1d_port_8472.sh * net.forwarding.vxlan_bridge_1d.sh * net.forwarding.vxlan_bridge_1q_port_8472.sh * net.forwarding.vxlan_bridge_1q.sh * net.forwarding.vxlan_symmetric.sh * net.mptcp.simult_flows.sh * netfilter.nft_concat_range.sh * netfilter.nft_queue.sh * pidfd.pidfd_test * pidfd.pidfd_open_test * pidfd.pidfd_poll_test * proc.proc-self-syscall * proc.proc-fsconfig-hidepid * pstore.pstore_tests * ptrace.vmaccess.global.attach * ptrace.vmaccess * openat2.openat2_test * openat2.resolve_test * openat2.rename_attack_test * rseq.param_test * rseq.param_test_benchmark * rseq.param_test_compare_twice * rseq.run_param_test.sh * seccomp.seccomp_bpf.global.user_notification_filter_empty * seccomp.seccomp_bpf.global.user_notification_filter_empty_threaded * seccomp.seccomp_bpf.global.user_notification_addfd * seccomp.seccomp_bpf * seccomp.seccomp_benchmark * splice.short_splice_read.sh * vm.run_vmtests.sh ### juno-r2, kselftest * bpf.test_verifier * bpf.test_tag * bpf.test_maps * bpf.test_lpm_map * bpf.test_progs * bpf.test_dev_cgroup * bpf.test_tcpbpf_user * bpf.get_cgroup_id_user * bpf.test_socket_cookie * bpf.test_netcnt * bpf.test_tcpnotify_user * bpf.test_sysctl * bpf.test_progs-no_alu32 * bpf.test_xdp_redirect.sh * bpf.test_xdp_meta.sh * bpf.test_sock_addr.sh * bpf.test_tunnel.sh * bpf.test_lwt_seg6local.sh * bpf.test_skb_cgroup_id.sh * bpf.test_flow_dissector.sh * bpf.test_xdp_vlan_mode_generic.sh * bpf.test_xdp_vlan_mode_native.sh * bpf.test_lwt_ip_encap.sh * bpf.test_tcp_check_syncookie.sh * bpf.test_tc_tunnel.sh * bpf.test_tc_edt.sh * bpf.test_xdping.sh * bpf.test_bpftool.sh * cgroup.test_memcontrol * cgroup.test_kmem * cgroup.test_core * cgroup.test_freezer * clone3.clone3_cap_checkpoint_restore * core.close_range_test * cpufreq.main.sh * filesystems.binderfs.binderfs_test * firmware.fw_run_tests.sh * ftrace.ftracetest * lkdtm.BUG.sh * lkdtm.WARNING.sh * lkdtm.WARNING_MESSAGE.sh * lkdtm.EXCEPTION.sh * lkdtm.CORRUPT_LIST_ADD.sh * lkdtm.CORRUPT_LIST_DEL.sh * lkdtm.STACK_GUARD_PAGE_LEADING.sh * lkdtm.STACK_GUARD_PAGE_TRAILING.sh * lkdtm.UNSET_SMEP.sh * lkdtm.CORRUPT_PAC.sh * lkdtm.UNALIGNED_LOAD_STORE_WRITE.sh * lkdtm.READ_AFTER_FREE.sh * lkdtm.READ_BUDDY_AFTER_FREE.sh * lkdtm.SLAB_FREE_DOUBLE.sh * lkdtm.SLAB_FREE_CROSS.sh * lkdtm.SLAB_FREE_PAGE.sh * lkdtm.EXEC_DATA.sh * lkdtm.EXEC_STACK.sh * lkdtm.EXEC_KMALLOC.sh * lkdtm.EXEC_VMALLOC.sh * lkdtm.EXEC_RODATA.sh * lkdtm.EXEC_USERSPACE.sh * lkdtm.EXEC_NULL.sh * lkdtm.ACCESS_USERSPACE.sh * lkdtm.ACCESS_NULL.sh * lkdtm.WRITE_RO.sh * lkdtm.WRITE_RO_AFTER_INIT.sh * lkdtm.WRITE_KERN.sh * lkdtm.REFCOUNT_INC_OVERFLOW.sh * lkdtm.REFCOUNT_ADD_OVERFLOW.sh * lkdtm.REFCOUNT_INC_NOT_ZERO_OVERFLOW.sh * lkdtm.REFCOUNT_ADD_NOT_ZERO_OVERFLOW.sh * lkdtm.REFCOUNT_DEC_ZERO.sh * lkdtm.REFCOUNT_DEC_NEGATIVE.sh * lkdtm.REFCOUNT_DEC_AND_TEST_NEGATIVE.sh * lkdtm.REFCOUNT_SUB_AND_TEST_NEGATIVE.sh * lkdtm.REFCOUNT_INC_ZERO.sh * lkdtm.REFCOUNT_ADD_ZERO.sh * lkdtm.REFCOUNT_INC_SATURATED.sh * lkdtm.REFCOUNT_DEC_SATURATED.sh * lkdtm.REFCOUNT_ADD_SATURATED.sh * lkdtm.REFCOUNT_INC_NOT_ZERO_SATURATED.sh * lkdtm.REFCOUNT_ADD_NOT_ZERO_SATURATED.sh * lkdtm.REFCOUNT_DEC_AND_TEST_SATURATED.sh * lkdtm.REFCOUNT_SUB_AND_TEST_SATURATED.sh * lkdtm.USERCOPY_HEAP_SIZE_TO.sh * lkdtm.USERCOPY_HEAP_SIZE_FROM.sh * lkdtm.USERCOPY_HEAP_WHITELIST_TO.sh * lkdtm.USERCOPY_HEAP_WHITELIST_FROM.sh * lkdtm.USERCOPY_STACK_FRAME_TO.sh * lkdtm.USERCOPY_STACK_FRAME_FROM.sh * lkdtm.USERCOPY_STACK_BEYOND.sh * lkdtm.USERCOPY_KERNEL.sh * lkdtm.STACKLEAK_ERASING.sh * lkdtm.CFI_FORWARD_PROTO.sh * memory-hotplug.mem-on-off-test.sh * mincore.mincore_selftest.global.check_file_mmap * mincore.mincore_selftest * net.run_netsocktests * net.fib_tests.sh * net.fib-onlink-tests.sh * net.pmtu.sh * net.udpgso_bench.sh * net.fib_rule_tests.sh * net.psock_snd.sh * net.udpgro_bench.sh * net.udpgro.sh * net.test_vxlan_under_vrf.sh * net.tcp_fastopen_backup_key.sh * net.l2tp.sh * net.fib_nexthops.sh * net.altnames.sh * net.icmp_redirect.sh * net.txtimestamp.sh * net.vrf-xfrm-tests.sh * net.devlink_port_split.py * net.forwarding.bridge_igmp.sh * net.forwarding.bridge_port_isolation.sh * net.forwarding.bridge_sticky_fdb.sh * net.forwarding.bridge_vlan_aware.sh * net.forwarding.bridge_vlan_unaware.sh * net.forwarding.ethtool.sh * net.forwarding.gre_inner_v4_multipath.sh * net.forwarding.gre_inner_v6_multipath.sh * net.forwarding.gre_multipath.sh * net.forwarding.ip6gre_inner_v4_multipath.sh * net.forwarding.ip6gre_inner_v6_multipath.sh * net.forwarding.ipip_flat_gre_key.sh * net.forwarding.ipip_flat_gre_keys.sh * net.forwarding.ipip_flat_gre.sh * net.forwarding.ipip_hier_gre_key.sh * net.forwarding.ipip_hier_gre_keys.sh * net.forwarding.ipip_hier_gre.sh * net.forwarding.loopback.sh * net.forwarding.mirror_gre_bound.sh * net.forwarding.mirror_gre_bridge_1d.sh * net.forwarding.mirror_gre_bridge_1d_vlan.sh * net.forwarding.mirror_gre_bridge_1q_lag.sh * net.forwarding.mirror_gre_bridge_1q.sh * net.forwarding.mirror_gre_changes.sh * net.forwarding.mirror_gre_flower.sh * net.forwarding.mirror_gre_lag_lacp.sh * net.forwarding.mirror_gre_neigh.sh * net.forwarding.mirror_gre_nh.sh * net.forwarding.mirror_gre.sh * net.forwarding.mirror_gre_vlan_bridge_1q.sh * net.forwarding.mirror_gre_vlan.sh * net.forwarding.mirror_vlan.sh * net.forwarding.router_bridge.sh * net.forwarding.router_bridge_vlan.sh * net.forwarding.router_broadcast.sh * net.forwarding.router_mpath_nh.sh * net.forwarding.router_multicast.sh * net.forwarding.router_multipath.sh * net.forwarding.router.sh * net.forwarding.router_vid_1.sh * net.forwarding.sch_ets.sh * net.forwarding.sch_tbf_ets.sh * net.forwarding.sch_tbf_prio.sh * net.forwarding.sch_tbf_root.sh * net.forwarding.tc_actions.sh * net.forwarding.tc_chains.sh * net.forwarding.tc_flower_router.sh * net.forwarding.tc_flower.sh * net.forwarding.tc_shblocks.sh * net.forwarding.tc_vlan_modify.sh * net.forwarding.vxlan_asymmetric.sh * net.forwarding.vxlan_bridge_1d_port_8472.sh * net.forwarding.vxlan_bridge_1d.sh * net.forwarding.vxlan_bridge_1q_port_8472.sh * net.forwarding.vxlan_bridge_1q.sh * net.forwarding.vxlan_symmetric.sh * net.mptcp.simult_flows.sh * netfilter.nft_nat.sh * netfilter.conntrack_icmp_related.sh * netfilter.nft_concat_range.sh * netfilter.nft_queue.sh * pidfd.pidfd_test * pidfd.pidfd_fdinfo_test * pidfd.pidfd_open_test * pidfd.pidfd_poll_test * proc.proc-fsconfig-hidepid * pstore.pstore_tests * ptrace.vmaccess.global.attach * ptrace.vmaccess * openat2.openat2_test * openat2.resolve_test * openat2.rename_attack_test * rseq.param_test * rseq.param_test_benchmark * rseq.param_test_compare_twice * rtc.rtctest * seccomp.seccomp_bpf.global.user_notification_filter_empty * seccomp.seccomp_bpf.global.user_notification_filter_empty_threaded * seccomp.seccomp_bpf.global.user_notification_addfd * seccomp.seccomp_bpf * seccomp.seccomp_benchmark * splice.short_splice_read.sh * sysctl.sysctl.sh * tc-testing.tdc.sh * vm.run_vmtests.sh ### x86, kselftest * bpf.test_verifier * bpf.test_maps * bpf.test_progs * bpf.test_dev_cgroup * bpf.test_tcpbpf_user * bpf.get_cgroup_id_user * bpf.test_socket_cookie * bpf.test_netcnt * bpf.test_tcpnotify_user * bpf.test_sysctl * bpf.test_progs-no_alu32 * bpf.test_xdp_redirect.sh * bpf.test_xdp_meta.sh * bpf.test_sock_addr.sh * bpf.test_tunnel.sh * bpf.test_lwt_seg6local.sh * bpf.test_skb_cgroup_id.sh * bpf.test_flow_dissector.sh * bpf.test_xdp_vlan_mode_generic.sh * bpf.test_xdp_vlan_mode_native.sh * bpf.test_lwt_ip_encap.sh * bpf.test_tcp_check_syncookie.sh * bpf.test_tc_tunnel.sh * bpf.test_tc_edt.sh * bpf.test_xdping.sh * bpf.test_bpftool.sh * cgroup.test_memcontrol * cgroup.test_kmem * cgroup.test_core * cgroup.test_freezer * clone3.clone3_cap_checkpoint_restore * core.close_range_test * filesystems.binderfs.binderfs_test * firmware.fw_run_tests.sh * ftrace.ftracetest * intel_pstate.run.sh * lkdtm.BUG.sh * lkdtm.WARNING.sh * lkdtm.WARNING_MESSAGE.sh * lkdtm.EXCEPTION.sh * lkdtm.CORRUPT_LIST_ADD.sh * lkdtm.CORRUPT_LIST_DEL.sh * lkdtm.STACK_GUARD_PAGE_LEADING.sh * lkdtm.STACK_GUARD_PAGE_TRAILING.sh * lkdtm.UNSET_SMEP.sh * lkdtm.CORRUPT_PAC.sh * lkdtm.UNALIGNED_LOAD_STORE_WRITE.sh * lkdtm.READ_AFTER_FREE.sh * lkdtm.READ_BUDDY_AFTER_FREE.sh * lkdtm.SLAB_FREE_DOUBLE.sh * lkdtm.SLAB_FREE_CROSS.sh * lkdtm.SLAB_FREE_PAGE.sh * lkdtm.EXEC_DATA.sh * lkdtm.EXEC_STACK.sh * lkdtm.EXEC_KMALLOC.sh * lkdtm.EXEC_VMALLOC.sh * lkdtm.EXEC_RODATA.sh * lkdtm.EXEC_USERSPACE.sh * lkdtm.EXEC_NULL.sh * lkdtm.ACCESS_USERSPACE.sh * lkdtm.ACCESS_NULL.sh * lkdtm.WRITE_RO.sh * lkdtm.WRITE_RO_AFTER_INIT.sh * lkdtm.WRITE_KERN.sh * lkdtm.REFCOUNT_INC_OVERFLOW.sh * lkdtm.REFCOUNT_ADD_OVERFLOW.sh * lkdtm.REFCOUNT_INC_NOT_ZERO_OVERFLOW.sh * lkdtm.REFCOUNT_ADD_NOT_ZERO_OVERFLOW.sh * lkdtm.REFCOUNT_DEC_ZERO.sh * lkdtm.REFCOUNT_DEC_NEGATIVE.sh * lkdtm.REFCOUNT_DEC_AND_TEST_NEGATIVE.sh * lkdtm.REFCOUNT_SUB_AND_TEST_NEGATIVE.sh * lkdtm.REFCOUNT_INC_ZERO.sh * lkdtm.REFCOUNT_ADD_ZERO.sh * lkdtm.REFCOUNT_INC_SATURATED.sh * lkdtm.REFCOUNT_DEC_SATURATED.sh * lkdtm.REFCOUNT_ADD_SATURATED.sh * lkdtm.REFCOUNT_INC_NOT_ZERO_SATURATED.sh * lkdtm.REFCOUNT_ADD_NOT_ZERO_SATURATED.sh * lkdtm.REFCOUNT_DEC_AND_TEST_SATURATED.sh * lkdtm.REFCOUNT_SUB_AND_TEST_SATURATED.sh * lkdtm.USERCOPY_HEAP_SIZE_TO.sh * lkdtm.USERCOPY_HEAP_SIZE_FROM.sh * lkdtm.USERCOPY_HEAP_WHITELIST_TO.sh * lkdtm.USERCOPY_HEAP_WHITELIST_FROM.sh * lkdtm.USERCOPY_STACK_FRAME_TO.sh * lkdtm.USERCOPY_STACK_FRAME_FROM.sh * lkdtm.USERCOPY_STACK_BEYOND.sh * lkdtm.USERCOPY_KERNEL.sh * lkdtm.STACKLEAK_ERASING.sh * lkdtm.CFI_FORWARD_PROTO.sh * mincore.mincore_selftest.global.check_file_mmap * mincore.mincore_selftest * mqueue.mq_perf_tests * net.run_netsocktests * net.xfrm_policy.sh * net.fib_tests.sh * net.fib-onlink-tests.sh * net.pmtu.sh * net.udpgso_bench.sh * net.psock_snd.sh * net.udpgro_bench.sh * net.udpgro.sh * net.test_vxlan_under_vrf.sh * net.l2tp.sh * net.traceroute.sh * net.altnames.sh * net.icmp_redirect.sh * net.txtimestamp.sh * net.vrf-xfrm-tests.sh * net.devlink_port_split.py * net.forwarding.bridge_igmp.sh * net.forwarding.bridge_port_isolation.sh * net.forwarding.bridge_sticky_fdb.sh * net.forwarding.bridge_vlan_aware.sh * net.forwarding.bridge_vlan_unaware.sh * net.forwarding.ethtool.sh * net.forwarding.gre_inner_v4_multipath.sh * net.forwarding.gre_inner_v6_multipath.sh * net.forwarding.gre_multipath.sh * net.forwarding.ip6gre_inner_v4_multipath.sh * net.forwarding.ip6gre_inner_v6_multipath.sh * net.forwarding.ipip_flat_gre_key.sh * net.forwarding.ipip_flat_gre_keys.sh * net.forwarding.ipip_flat_gre.sh * net.forwarding.ipip_hier_gre_key.sh * net.forwarding.ipip_hier_gre_keys.sh * net.forwarding.ipip_hier_gre.sh * net.forwarding.loopback.sh * net.forwarding.mirror_gre_bound.sh * net.forwarding.mirror_gre_bridge_1d.sh * net.forwarding.mirror_gre_bridge_1d_vlan.sh * net.forwarding.mirror_gre_bridge_1q_lag.sh * net.forwarding.mirror_gre_bridge_1q.sh * net.forwarding.mirror_gre_changes.sh * net.forwarding.mirror_gre_flower.sh * net.forwarding.mirror_gre_lag_lacp.sh * net.forwarding.mirror_gre_neigh.sh * net.forwarding.mirror_gre_nh.sh * net.forwarding.mirror_gre.sh * net.forwarding.mirror_gre_vlan_bridge_1q.sh * net.forwarding.mirror_gre_vlan.sh * net.forwarding.mirror_vlan.sh * net.forwarding.router_bridge.sh * net.forwarding.router_bridge_vlan.sh * net.forwarding.router_broadcast.sh * net.forwarding.router_mpath_nh.sh * net.forwarding.router_multicast.sh * net.forwarding.router_multipath.sh * net.forwarding.router.sh * net.forwarding.router_vid_1.sh * net.forwarding.sch_ets.sh * net.forwarding.sch_tbf_ets.sh * net.forwarding.sch_tbf_prio.sh * net.forwarding.sch_tbf_root.sh * net.forwarding.tc_actions.sh * net.forwarding.tc_chains.sh * net.forwarding.tc_flower_router.sh * net.forwarding.tc_flower.sh * net.forwarding.tc_shblocks.sh * net.forwarding.tc_vlan_modify.sh * net.forwarding.vxlan_asymmetric.sh * net.forwarding.vxlan_bridge_1d_port_8472.sh * net.forwarding.vxlan_bridge_1d.sh * net.forwarding.vxlan_bridge_1q_port_8472.sh * net.forwarding.vxlan_bridge_1q.sh * net.forwarding.vxlan_symmetric.sh * net.mptcp.simult_flows.sh * netfilter.nft_concat_range.sh * netfilter.nft_queue.sh * pidfd.pidfd_open_test * pidfd.pidfd_poll_test * proc.proc-fsconfig-hidepid * pstore.pstore_tests * ptrace.vmaccess.global.attach * ptrace.vmaccess * openat2.openat2_test * openat2.resolve_test * openat2.rename_attack_test * seccomp.seccomp_bpf.global.user_notification_filter_empty * seccomp.seccomp_bpf.global.user_notification_filter_empty_threaded * seccomp.seccomp_bpf.global.user_notification_addfd * seccomp.seccomp_bpf * seccomp.seccomp_benchmark * splice.short_splice_read.sh * vm.run_vmtests.sh * x86.syscall_numbering_64 ### x86, kselftest-vsyscall-mode-native * bpf.test_verifier * bpf.test_maps * bpf.test_progs * bpf.test_dev_cgroup * bpf.test_tcpbpf_user * bpf.get_cgroup_id_user * bpf.test_socket_cookie * bpf.test_netcnt * bpf.test_tcpnotify_user * bpf.test_sysctl * bpf.test_progs-no_alu32 * bpf.test_xdp_redirect.sh * bpf.test_xdp_meta.sh * bpf.test_sock_addr.sh * bpf.test_tunnel.sh * bpf.test_lwt_seg6local.sh * bpf.test_skb_cgroup_id.sh * bpf.test_flow_dissector.sh * bpf.test_xdp_vlan_mode_generic.sh * bpf.test_xdp_vlan_mode_native.sh * bpf.test_lwt_ip_encap.sh * bpf.test_tcp_check_syncookie.sh * bpf.test_tc_tunnel.sh * bpf.test_tc_edt.sh * bpf.test_xdping.sh * bpf.test_bpftool.sh * cgroup.test_memcontrol * cgroup.test_kmem * cgroup.test_core * cgroup.test_freezer * clone3.clone3_cap_checkpoint_restore * core.close_range_test * filesystems.binderfs.binderfs_test * firmware.fw_run_tests.sh * ftrace.ftracetest * intel_pstate.run.sh * lkdtm.BUG.sh * lkdtm.WARNING.sh * lkdtm.WARNING_MESSAGE.sh * lkdtm.EXCEPTION.sh * lkdtm.CORRUPT_LIST_ADD.sh * lkdtm.CORRUPT_LIST_DEL.sh * lkdtm.STACK_GUARD_PAGE_LEADING.sh * lkdtm.STACK_GUARD_PAGE_TRAILING.sh * lkdtm.UNSET_SMEP.sh * lkdtm.CORRUPT_PAC.sh * lkdtm.UNALIGNED_LOAD_STORE_WRITE.sh * lkdtm.READ_AFTER_FREE.sh * lkdtm.READ_BUDDY_AFTER_FREE.sh * lkdtm.SLAB_FREE_DOUBLE.sh * lkdtm.SLAB_FREE_CROSS.sh * lkdtm.SLAB_FREE_PAGE.sh * lkdtm.EXEC_DATA.sh * lkdtm.EXEC_STACK.sh * lkdtm.EXEC_KMALLOC.sh * lkdtm.EXEC_VMALLOC.sh * lkdtm.EXEC_RODATA.sh * lkdtm.EXEC_USERSPACE.sh * lkdtm.EXEC_NULL.sh * lkdtm.ACCESS_USERSPACE.sh * lkdtm.ACCESS_NULL.sh * lkdtm.WRITE_RO.sh * lkdtm.WRITE_RO_AFTER_INIT.sh * lkdtm.WRITE_KERN.sh * lkdtm.REFCOUNT_INC_OVERFLOW.sh * lkdtm.REFCOUNT_ADD_OVERFLOW.sh * lkdtm.REFCOUNT_INC_NOT_ZERO_OVERFLOW.sh * lkdtm.REFCOUNT_ADD_NOT_ZERO_OVERFLOW.sh * lkdtm.REFCOUNT_DEC_ZERO.sh * lkdtm.REFCOUNT_DEC_NEGATIVE.sh * lkdtm.REFCOUNT_DEC_AND_TEST_NEGATIVE.sh * lkdtm.REFCOUNT_SUB_AND_TEST_NEGATIVE.sh * lkdtm.REFCOUNT_INC_ZERO.sh * lkdtm.REFCOUNT_ADD_ZERO.sh * lkdtm.REFCOUNT_INC_SATURATED.sh * lkdtm.REFCOUNT_DEC_SATURATED.sh * lkdtm.REFCOUNT_ADD_SATURATED.sh * lkdtm.REFCOUNT_INC_NOT_ZERO_SATURATED.sh * lkdtm.REFCOUNT_ADD_NOT_ZERO_SATURATED.sh * lkdtm.REFCOUNT_DEC_AND_TEST_SATURATED.sh * lkdtm.REFCOUNT_SUB_AND_TEST_SATURATED.sh * lkdtm.USERCOPY_HEAP_SIZE_TO.sh * lkdtm.USERCOPY_HEAP_SIZE_FROM.sh * lkdtm.USERCOPY_HEAP_WHITELIST_TO.sh * lkdtm.USERCOPY_HEAP_WHITELIST_FROM.sh * lkdtm.USERCOPY_STACK_FRAME_TO.sh * lkdtm.USERCOPY_STACK_FRAME_FROM.sh * lkdtm.USERCOPY_STACK_BEYOND.sh * lkdtm.USERCOPY_KERNEL.sh * lkdtm.STACKLEAK_ERASING.sh * lkdtm.CFI_FORWARD_PROTO.sh * mincore.mincore_selftest.global.check_file_mmap * mincore.mincore_selftest * mqueue.mq_perf_tests * net.run_netsocktests * net.xfrm_policy.sh * net.fib_tests.sh * net.fib-onlink-tests.sh * net.pmtu.sh * net.udpgso_bench.sh * net.psock_snd.sh * net.udpgro_bench.sh * net.udpgro.sh * net.test_vxlan_under_vrf.sh * net.l2tp.sh * net.traceroute.sh * net.altnames.sh * net.icmp_redirect.sh * net.txtimestamp.sh * net.vrf-xfrm-tests.sh * net.devlink_port_split.py * net.forwarding.bridge_igmp.sh * net.forwarding.bridge_port_isolation.sh * net.forwarding.bridge_sticky_fdb.sh * net.forwarding.bridge_vlan_aware.sh * net.forwarding.bridge_vlan_unaware.sh * net.forwarding.ethtool.sh * net.forwarding.gre_inner_v4_multipath.sh * net.forwarding.gre_inner_v6_multipath.sh * net.forwarding.gre_multipath.sh * net.forwarding.ip6gre_inner_v4_multipath.sh * net.forwarding.ip6gre_inner_v6_multipath.sh * net.forwarding.ipip_flat_gre_key.sh * net.forwarding.ipip_flat_gre_keys.sh * net.forwarding.ipip_flat_gre.sh * net.forwarding.ipip_hier_gre_key.sh * net.forwarding.ipip_hier_gre_keys.sh * net.forwarding.ipip_hier_gre.sh * net.forwarding.loopback.sh * net.forwarding.mirror_gre_bound.sh * net.forwarding.mirror_gre_bridge_1d.sh * net.forwarding.mirror_gre_bridge_1d_vlan.sh * net.forwarding.mirror_gre_bridge_1q_lag.sh * net.forwarding.mirror_gre_bridge_1q.sh * net.forwarding.mirror_gre_changes.sh * net.forwarding.mirror_gre_flower.sh * net.forwarding.mirror_gre_lag_lacp.sh * net.forwarding.mirror_gre_neigh.sh * net.forwarding.mirror_gre_nh.sh * net.forwarding.mirror_gre.sh * net.forwarding.mirror_gre_vlan_bridge_1q.sh * net.forwarding.mirror_gre_vlan.sh * net.forwarding.mirror_vlan.sh * net.forwarding.router_bridge.sh * net.forwarding.router_bridge_vlan.sh * net.forwarding.router_broadcast.sh * net.forwarding.router_mpath_nh.sh * net.forwarding.router_multicast.sh * net.forwarding.router_multipath.sh * net.forwarding.router.sh * net.forwarding.router_vid_1.sh * net.forwarding.sch_ets.sh * net.forwarding.sch_tbf_ets.sh * net.forwarding.sch_tbf_prio.sh * net.forwarding.sch_tbf_root.sh * net.forwarding.tc_actions.sh * net.forwarding.tc_chains.sh * net.forwarding.tc_flower_router.sh * net.forwarding.tc_flower.sh * net.forwarding.tc_shblocks.sh * net.forwarding.tc_vlan_modify.sh * net.forwarding.vxlan_asymmetric.sh * net.forwarding.vxlan_bridge_1d_port_8472.sh * net.forwarding.vxlan_bridge_1d.sh * net.forwarding.vxlan_bridge_1q_port_8472.sh * net.forwarding.vxlan_bridge_1q.sh * net.forwarding.vxlan_symmetric.sh * net.mptcp.mptcp_connect.sh * net.mptcp.simult_flows.sh * netfilter.nft_concat_range.sh * netfilter.nft_queue.sh * pidfd.pidfd_open_test * pidfd.pidfd_poll_test * proc.proc-fsconfig-hidepid * pstore.pstore_tests * ptrace.vmaccess.global.attach * ptrace.vmaccess * openat2.openat2_test * openat2.resolve_test * openat2.rename_attack_test * rtc.rtctest * seccomp.seccomp_bpf.global.user_notification_filter_empty * seccomp.seccomp_bpf.global.user_notification_filter_empty_threaded * seccomp.seccomp_bpf.global.user_notification_addfd * seccomp.seccomp_bpf * seccomp.seccomp_benchmark * splice.short_splice_read.sh * vm.run_vmtests.sh * x86.syscall_numbering_64 ### x86, kselftest-vsyscall-mode-none * bpf.test_verifier * bpf.test_maps * bpf.test_progs * bpf.test_dev_cgroup * bpf.test_tcpbpf_user * bpf.get_cgroup_id_user * bpf.test_socket_cookie * bpf.test_netcnt * bpf.test_tcpnotify_user * bpf.test_sysctl * bpf.test_progs-no_alu32 * bpf.test_xdp_redirect.sh * bpf.test_xdp_meta.sh * bpf.test_sock_addr.sh * bpf.test_tunnel.sh * bpf.test_lwt_seg6local.sh * bpf.test_skb_cgroup_id.sh * bpf.test_flow_dissector.sh * bpf.test_xdp_vlan_mode_generic.sh * bpf.test_xdp_vlan_mode_native.sh * bpf.test_lwt_ip_encap.sh * bpf.test_tcp_check_syncookie.sh * bpf.test_tc_tunnel.sh * bpf.test_tc_edt.sh * bpf.test_xdping.sh * bpf.test_bpftool.sh * cgroup.test_memcontrol * cgroup.test_kmem * cgroup.test_core * cgroup.test_freezer * clone3.clone3_cap_checkpoint_restore * core.close_range_test * filesystems.binderfs.binderfs_test * firmware.fw_run_tests.sh * ftrace.ftracetest * intel_pstate.run.sh * lkdtm.BUG.sh * lkdtm.WARNING.sh * lkdtm.WARNING_MESSAGE.sh * lkdtm.EXCEPTION.sh * lkdtm.CORRUPT_LIST_ADD.sh * lkdtm.CORRUPT_LIST_DEL.sh * lkdtm.STACK_GUARD_PAGE_LEADING.sh * lkdtm.STACK_GUARD_PAGE_TRAILING.sh * lkdtm.UNSET_SMEP.sh * lkdtm.CORRUPT_PAC.sh * lkdtm.UNALIGNED_LOAD_STORE_WRITE.sh * lkdtm.READ_AFTER_FREE.sh * lkdtm.READ_BUDDY_AFTER_FREE.sh * lkdtm.SLAB_FREE_DOUBLE.sh * lkdtm.SLAB_FREE_CROSS.sh * lkdtm.SLAB_FREE_PAGE.sh * lkdtm.EXEC_DATA.sh * lkdtm.EXEC_STACK.sh * lkdtm.EXEC_KMALLOC.sh * lkdtm.EXEC_VMALLOC.sh * lkdtm.EXEC_RODATA.sh * lkdtm.EXEC_USERSPACE.sh * lkdtm.EXEC_NULL.sh * lkdtm.ACCESS_USERSPACE.sh * lkdtm.ACCESS_NULL.sh * lkdtm.WRITE_RO.sh * lkdtm.WRITE_RO_AFTER_INIT.sh * lkdtm.WRITE_KERN.sh * lkdtm.REFCOUNT_INC_OVERFLOW.sh * lkdtm.REFCOUNT_ADD_OVERFLOW.sh * lkdtm.REFCOUNT_INC_NOT_ZERO_OVERFLOW.sh * lkdtm.REFCOUNT_ADD_NOT_ZERO_OVERFLOW.sh * lkdtm.REFCOUNT_DEC_ZERO.sh * lkdtm.REFCOUNT_DEC_NEGATIVE.sh * lkdtm.REFCOUNT_DEC_AND_TEST_NEGATIVE.sh * lkdtm.REFCOUNT_SUB_AND_TEST_NEGATIVE.sh * lkdtm.REFCOUNT_INC_ZERO.sh * lkdtm.REFCOUNT_ADD_ZERO.sh * lkdtm.REFCOUNT_INC_SATURATED.sh * lkdtm.REFCOUNT_DEC_SATURATED.sh * lkdtm.REFCOUNT_ADD_SATURATED.sh * lkdtm.REFCOUNT_INC_NOT_ZERO_SATURATED.sh * lkdtm.REFCOUNT_ADD_NOT_ZERO_SATURATED.sh * lkdtm.REFCOUNT_DEC_AND_TEST_SATURATED.sh * lkdtm.REFCOUNT_SUB_AND_TEST_SATURATED.sh * lkdtm.USERCOPY_HEAP_SIZE_TO.sh * lkdtm.USERCOPY_HEAP_SIZE_FROM.sh * lkdtm.USERCOPY_HEAP_WHITELIST_TO.sh * lkdtm.USERCOPY_HEAP_WHITELIST_FROM.sh * lkdtm.USERCOPY_STACK_FRAME_TO.sh * lkdtm.USERCOPY_STACK_FRAME_FROM.sh * lkdtm.USERCOPY_STACK_BEYOND.sh * lkdtm.USERCOPY_KERNEL.sh * lkdtm.STACKLEAK_ERASING.sh * lkdtm.CFI_FORWARD_PROTO.sh * mincore.mincore_selftest.global.check_file_mmap * mincore.mincore_selftest * mqueue.mq_perf_tests * net.run_netsocktests * net.xfrm_policy.sh * net.fib_tests.sh * net.fib-onlink-tests.sh * net.pmtu.sh * net.udpgso_bench.sh * net.psock_snd.sh * net.udpgro_bench.sh * net.udpgro.sh * net.test_vxlan_under_vrf.sh * net.l2tp.sh * net.traceroute.sh * net.altnames.sh * net.icmp_redirect.sh * net.txtimestamp.sh * net.vrf-xfrm-tests.sh * net.devlink_port_split.py * net.forwarding.bridge_igmp.sh * net.forwarding.bridge_port_isolation.sh * net.forwarding.bridge_sticky_fdb.sh * net.forwarding.bridge_vlan_aware.sh * net.forwarding.bridge_vlan_unaware.sh * net.forwarding.ethtool.sh * net.forwarding.gre_inner_v4_multipath.sh * net.forwarding.gre_inner_v6_multipath.sh * net.forwarding.gre_multipath.sh * net.forwarding.ip6gre_inner_v4_multipath.sh * net.forwarding.ip6gre_inner_v6_multipath.sh * net.forwarding.ipip_flat_gre_key.sh * net.forwarding.ipip_flat_gre_keys.sh * net.forwarding.ipip_flat_gre.sh * net.forwarding.ipip_hier_gre_key.sh * net.forwarding.ipip_hier_gre_keys.sh * net.forwarding.ipip_hier_gre.sh * net.forwarding.loopback.sh * net.forwarding.mirror_gre_bound.sh * net.forwarding.mirror_gre_bridge_1d.sh * net.forwarding.mirror_gre_bridge_1d_vlan.sh * net.forwarding.mirror_gre_bridge_1q_lag.sh * net.forwarding.mirror_gre_bridge_1q.sh * net.forwarding.mirror_gre_changes.sh * net.forwarding.mirror_gre_flower.sh * net.forwarding.mirror_gre_lag_lacp.sh * net.forwarding.mirror_gre_neigh.sh * net.forwarding.mirror_gre_nh.sh * net.forwarding.mirror_gre.sh * net.forwarding.mirror_gre_vlan_bridge_1q.sh * net.forwarding.mirror_gre_vlan.sh * net.forwarding.mirror_vlan.sh * net.forwarding.router_bridge.sh * net.forwarding.router_bridge_vlan.sh * net.forwarding.router_broadcast.sh * net.forwarding.router_mpath_nh.sh * net.forwarding.router_multicast.sh * net.forwarding.router_multipath.sh * net.forwarding.router.sh * net.forwarding.router_vid_1.sh * net.forwarding.sch_ets.sh * net.forwarding.sch_tbf_ets.sh * net.forwarding.sch_tbf_prio.sh * net.forwarding.sch_tbf_root.sh * net.forwarding.tc_actions.sh * net.forwarding.tc_chains.sh * net.forwarding.tc_flower_router.sh * net.forwarding.tc_flower.sh * net.forwarding.tc_shblocks.sh * net.forwarding.tc_vlan_modify.sh * net.forwarding.vxlan_asymmetric.sh * net.forwarding.vxlan_bridge_1d_port_8472.sh * net.forwarding.vxlan_bridge_1d.sh * net.forwarding.vxlan_bridge_1q_port_8472.sh * net.forwarding.vxlan_bridge_1q.sh * net.forwarding.vxlan_symmetric.sh * net.mptcp.simult_flows.sh * netfilter.nft_concat_range.sh * netfilter.nft_queue.sh * pidfd.pidfd_open_test * pidfd.pidfd_poll_test * proc.read * proc.proc-fsconfig-hidepid * pstore.pstore_tests * ptrace.vmaccess.global.attach * ptrace.vmaccess * openat2.openat2_test * openat2.resolve_test * openat2.rename_attack_test * seccomp.seccomp_bpf.global.user_notification_filter_empty * seccomp.seccomp_bpf.global.user_notification_filter_empty_threaded * seccomp.seccomp_bpf.global.user_notification_addfd * seccomp.seccomp_bpf * seccomp.seccomp_benchmark * splice.short_splice_read.sh * tc-testing.tdc.sh * vm.run_vmtests.sh * x86.syscall_numbering_64 ## Skips ### i386, kselftest * breakpoints.breakpoint_test * breakpoints.step_after_suspend_test * net.msg_zerocopy.sh * net.rtnetlink.sh * net.udpgro.sh * net.xfrm_policy.sh * netfilter.bridge_brouter.sh * netfilter.conntrack_icmp_related.sh * netfilter.nft_flowtable.sh * netfilter.nft_nat.sh * netfilter.nft_trans_stress.sh * pidfd.pidfd_wait * zram.zram.sh * bpf.test_xdp_veth.sh * bpf.test_bpftool_metadata.sh * cgroup.test_stress.sh * efivarfs.efivarfs.sh * fpu.run_test_fpu.sh * ir.ir_loopback.sh * kexec.test_kexec_load.sh * kexec.test_kexec_file_load.sh * livepatch.test-livepatch.sh * livepatch.test-callbacks.sh * livepatch.test-shadow-vars.sh * livepatch.test-state.sh * livepatch.test-ftrace.sh * lkdtm.PANIC.sh * lkdtm.LOOP.sh * lkdtm.EXHAUST_STACK.sh * lkdtm.CORRUPT_STACK.sh * lkdtm.CORRUPT_STACK_STRONG.sh * lkdtm.OVERWRITE_ALLOCATION.sh * lkdtm.WRITE_AFTER_FREE.sh * lkdtm.WRITE_BUDDY_AFTER_FREE.sh * lkdtm.SOFTLOCKUP.sh * lkdtm.HARDLOCKUP.sh * lkdtm.SPINLOCKUP.sh * lkdtm.HUNG_TASK.sh * lkdtm.REFCOUNT_TIMING.sh * lkdtm.ATOMIC_TIMING.sh * memory-hotplug.mem-on-off-test.sh * net.reuseport_bpf_numa * net.drop_monitor_tests.sh * net.mptcp.diag.sh * netfilter.ipvs.sh * netfilter.nft_conntrack_helper.sh * netfilter.nft_meta.sh * proc.proc-pid-vm * pstore.pstore_post_reboot_tests * tpm2.test_smoke.sh * tpm2.test_space.sh ### juno-r2, kselftest * mqueue.mq_perf_tests * breakpoints.breakpoint_test_arm64 * breakpoints.step_after_suspend_test * net.msg_zerocopy.sh * net.rtnetlink.sh * netfilter.bridge_brouter.sh * netfilter.nft_flowtable.sh * netfilter.nft_trans_stress.sh * pidfd.pidfd_wait * rseq.run_param_test.sh * zram.zram.sh * arm64.sve-ptrace * arm64.sve-probe-vls * bpf.test_xdp_veth.sh * bpf.test_bpftool_metadata.sh * cgroup.test_stress.sh * efivarfs.efivarfs.sh * fpu.run_test_fpu.sh * intel_pstate.run.sh * ir.ir_loopback.sh * livepatch.test-livepatch.sh * livepatch.test-callbacks.sh * livepatch.test-shadow-vars.sh * livepatch.test-state.sh * livepatch.test-ftrace.sh * lkdtm.PANIC.sh * lkdtm.LOOP.sh * lkdtm.EXHAUST_STACK.sh * lkdtm.CORRUPT_STACK.sh * lkdtm.CORRUPT_STACK_STRONG.sh * lkdtm.DOUBLE_FAULT.sh * lkdtm.OVERWRITE_ALLOCATION.sh * lkdtm.WRITE_AFTER_FREE.sh * lkdtm.WRITE_BUDDY_AFTER_FREE.sh * lkdtm.SOFTLOCKUP.sh * lkdtm.HARDLOCKUP.sh * lkdtm.SPINLOCKUP.sh * lkdtm.HUNG_TASK.sh * lkdtm.REFCOUNT_TIMING.sh * lkdtm.ATOMIC_TIMING.sh * net.xfrm_policy.sh * net.drop_monitor_tests.sh * net.mptcp.diag.sh * netfilter.ipvs.sh * netfilter.nft_conntrack_helper.sh * netfilter.nft_meta.sh * proc.proc-pid-vm * pstore.pstore_post_reboot_tests * tpm2.test_smoke.sh * tpm2.test_space.sh ### x86, kselftest * breakpoints.breakpoint_test * breakpoints.step_after_suspend_test * net.msg_zerocopy.sh * net.rtnetlink.sh * netfilter.bridge_brouter.sh * netfilter.conntrack_icmp_related.sh * netfilter.nft_flowtable.sh * netfilter.nft_nat.sh * netfilter.nft_trans_stress.sh * pidfd.pidfd_wait * proc.proc-pid-vm * zram.zram.sh * bpf.test_xdp_veth.sh * bpf.test_bpftool_metadata.sh * cgroup.test_stress.sh * efivarfs.efivarfs.sh * fpu.run_test_fpu.sh * ir.ir_loopback.sh * kexec.test_kexec_load.sh * kexec.test_kexec_file_load.sh * kvm.mmio_warning_test * kvm.svm_vmcall_test * lkdtm.PANIC.sh * lkdtm.LOOP.sh * lkdtm.EXHAUST_STACK.sh * lkdtm.CORRUPT_STACK.sh * lkdtm.CORRUPT_STACK_STRONG.sh * lkdtm.DOUBLE_FAULT.sh * lkdtm.OVERWRITE_ALLOCATION.sh * lkdtm.WRITE_AFTER_FREE.sh * lkdtm.WRITE_BUDDY_AFTER_FREE.sh * lkdtm.SOFTLOCKUP.sh * lkdtm.HARDLOCKUP.sh * lkdtm.SPINLOCKUP.sh * lkdtm.HUNG_TASK.sh * lkdtm.REFCOUNT_TIMING.sh * lkdtm.ATOMIC_TIMING.sh * net.drop_monitor_tests.sh * net.mptcp.diag.sh * netfilter.ipvs.sh * netfilter.nft_conntrack_helper.sh * netfilter.nft_meta.sh * pstore.pstore_post_reboot_tests * tpm2.test_smoke.sh * tpm2.test_space.sh ### x86, kselftest-vsyscall-mode-native * breakpoints.breakpoint_test * breakpoints.step_after_suspend_test * net.msg_zerocopy.sh * net.rtnetlink.sh * netfilter.bridge_brouter.sh * netfilter.conntrack_icmp_related.sh * netfilter.nft_flowtable.sh * netfilter.nft_nat.sh * netfilter.nft_trans_stress.sh * pidfd.pidfd_wait * proc.proc-pid-vm * zram.zram.sh * bpf.test_xdp_veth.sh * bpf.test_bpftool_metadata.sh * cgroup.test_stress.sh * efivarfs.efivarfs.sh * fpu.run_test_fpu.sh * ir.ir_loopback.sh * kexec.test_kexec_load.sh * kexec.test_kexec_file_load.sh * kvm.mmio_warning_test * kvm.svm_vmcall_test * lkdtm.PANIC.sh * lkdtm.LOOP.sh * lkdtm.EXHAUST_STACK.sh * lkdtm.CORRUPT_STACK.sh * lkdtm.CORRUPT_STACK_STRONG.sh * lkdtm.DOUBLE_FAULT.sh * lkdtm.OVERWRITE_ALLOCATION.sh * lkdtm.WRITE_AFTER_FREE.sh * lkdtm.WRITE_BUDDY_AFTER_FREE.sh * lkdtm.SOFTLOCKUP.sh * lkdtm.HARDLOCKUP.sh * lkdtm.SPINLOCKUP.sh * lkdtm.HUNG_TASK.sh * lkdtm.REFCOUNT_TIMING.sh * lkdtm.ATOMIC_TIMING.sh * net.drop_monitor_tests.sh * net.mptcp.diag.sh * netfilter.ipvs.sh * netfilter.nft_conntrack_helper.sh * netfilter.nft_meta.sh * pstore.pstore_post_reboot_tests * tpm2.test_smoke.sh * tpm2.test_space.sh ### x86, kselftest-vsyscall-mode-none * breakpoints.breakpoint_test * breakpoints.step_after_suspend_test * net.msg_zerocopy.sh * net.rtnetlink.sh * netfilter.bridge_brouter.sh * netfilter.conntrack_icmp_related.sh * netfilter.nft_flowtable.sh * netfilter.nft_nat.sh * netfilter.nft_trans_stress.sh * pidfd.pidfd_wait * proc.proc-pid-vm * zram.zram.sh * bpf.test_xdp_veth.sh * bpf.test_bpftool_metadata.sh * cgroup.test_stress.sh * efivarfs.efivarfs.sh * fpu.run_test_fpu.sh * ir.ir_loopback.sh * kexec.test_kexec_load.sh * kexec.test_kexec_file_load.sh * kvm.mmio_warning_test * kvm.svm_vmcall_test * lkdtm.PANIC.sh * lkdtm.LOOP.sh * lkdtm.EXHAUST_STACK.sh * lkdtm.CORRUPT_STACK.sh * lkdtm.CORRUPT_STACK_STRONG.sh * lkdtm.DOUBLE_FAULT.sh * lkdtm.OVERWRITE_ALLOCATION.sh * lkdtm.WRITE_AFTER_FREE.sh * lkdtm.WRITE_BUDDY_AFTER_FREE.sh * lkdtm.SOFTLOCKUP.sh * lkdtm.HARDLOCKUP.sh * lkdtm.SPINLOCKUP.sh * lkdtm.HUNG_TASK.sh * lkdtm.REFCOUNT_TIMING.sh * lkdtm.ATOMIC_TIMING.sh * net.drop_monitor_tests.sh * net.mptcp.diag.sh * netfilter.ipvs.sh * netfilter.nft_conntrack_helper.sh * netfilter.nft_meta.sh * pstore.pstore_post_reboot_tests * tpm2.test_smoke.sh * tpm2.test_space.sh -- Linaro LKFT https://lkft.linaro.org

4 years, 9 months

1
0
0 0

[RFC v5 0/1] Selftest for cpuidle latency measurement

by Pratik Rajesh Sampat

v4: https://lkml.org/lkml/2020/9/2/356 v4-->v5 Based on comments from Artem Bityutskiy, evaluation of timer based wakeup latencies may not be a fruitful measurement especially on the x86 platform which has the capability to pre-arm a CPU when a timer is set. Hence, including only the IPI based tests for latency measurement to acheive expected behaviour across platforms. kernel module + bash selftest approach which presents lower deviations and higher accuracy: https://lkml.org/lkml/2020/7/21/567 --- The patch series introduces a mechanism to measure wakeup latency for IPI based interrupts. The motivation behind this series is to find significant deviations behind advertised latency values To achieve this in the userspace, IPI latencies are calculated by sending information through pipes and inducing a wakeup. To account for delays from kernel-userspace interactions baseline observations are taken on a 100% busy CPU and subsequent obervations must be considered relative to that. One downside of the userspace approach in contrast to the kernel implementation is that the run to run variance can turn out to be high in the order of ms; which is the scope of the experiments at times. Another downside of the userspace approach is that it takes much longer to run and hence a command-line option quick and full are added to make sure quick 1 CPU tests can be carried out when needed and otherwise it can carry out a full system comprehensive test. Usage --- ./cpuidle --mode <full / quick / num_cpus> --output <output location> full: runs on all CPUS quick: run on a random CPU num_cpus: Limit the number of CPUS to run on Sample output snippet --------------------- --IPI Latency Test--- SRC_CPU DEST_CPU IPI_Latency(ns) ... 0 5 256178 0 6 478161 0 7 285445 0 8 273553 Expected IPI latency(ns): 100000 Observed Average IPI latency(ns): 248334 Pratik Rajesh Sampat (1): selftests/cpuidle: Add support for cpuidle latency measurement tools/testing/selftests/Makefile | 1 + tools/testing/selftests/cpuidle/Makefile | 7 + tools/testing/selftests/cpuidle/cpuidle.c | 479 ++++++++++++++++++++++ tools/testing/selftests/cpuidle/settings | 1 + 4 files changed, 488 insertions(+) create mode 100644 tools/testing/selftests/cpuidle/Makefile create mode 100644 tools/testing/selftests/cpuidle/cpuidle.c create mode 100644 tools/testing/selftests/cpuidle/settings -- 2.26.2

4 years, 9 months

1
1
0 0

[PATCH v2 0/8] selftests/vm: gup_test, hmm-tests, assorted improvements

by John Hubbard

Changes since v1: * check_config.sh now invokes the compiler via the Makefile's ($CC), thanks to Jason Gunthorpe for calling that out. * Removed a misleading sentence from patch #6, as identified by Ira Weiny. * Removed a forward-looking sentence, about using -lpthread in gup_test.c soon, from the commit message in patch #4, since I'm not yet sure if my local pthread-based stress tests are actually worthwhile or not. Original cover letter, still accurate at this point: This is based on the latest mmotm. Summary: This series provides two main things, and a number of smaller supporting goodies. The two main points are: 1) Add a new sub-test to gup_test, which in turn is a renamed version of gup_benchmark. This sub-test allows nicer testing of dump_pages(), at least on user-space pages. For quite a while, I was doing a quick hack to gup_test.c whenever I wanted to try out changes to dump_page(). Then Matthew Wilcox asked me what I meant when I said "I used my dump_page() unit test", and I realized that it might be nice to check in a polished up version of that. Details about how it works and how to use it are in the commit description for patch #6. 2) Fixes a limitation of hmm-tests: these tests are incredibly useful, but only if people actually build and run them. And it turns out that libhugetlbfs is a little too effective at throwing a wrench in the works, there. So I've added a little configuration check that removes just two of the 21 hmm-tests, if libhugetlbfs is not available. Further details in the commit description of patch #8. Other smaller things that this series does: a) Remove code duplication by creating gup_test.h. b) Clear up the sub-test organization, and their invocation within run_vmtests.sh. c) Other minor assorted improvements. John Hubbard (8): mm/gup_benchmark: rename to mm/gup_test selftests/vm: use a common gup_test.h selftests/vm: rename run_vmtests --> run_vmtests.sh selftests/vm: minor cleanup: Makefile and gup_test.c selftests/vm: only some gup_test items are really benchmarks selftests/vm: gup_test: introduce the dump_pages() sub-test selftests/vm: run_vmtest.sh: update and clean up gup_test invocation selftests/vm: hmm-tests: remove the libhugetlbfs dependency Documentation/core-api/pin_user_pages.rst | 6 +- arch/s390/configs/debug_defconfig | 2 +- arch/s390/configs/defconfig | 2 +- mm/Kconfig | 21 +- mm/Makefile | 2 +- mm/{gup_benchmark.c => gup_test.c} | 109 ++++++---- mm/gup_test.h | 32 +++ tools/testing/selftests/vm/.gitignore | 3 +- tools/testing/selftests/vm/Makefile | 38 +++- tools/testing/selftests/vm/check_config.sh | 31 +++ tools/testing/selftests/vm/config | 2 +- tools/testing/selftests/vm/gup_benchmark.c | 137 ------------- tools/testing/selftests/vm/gup_test.c | 188 ++++++++++++++++++ tools/testing/selftests/vm/hmm-tests.c | 10 +- .../vm/{run_vmtests => run_vmtest.sh} | 24 ++- 15 files changed, 404 insertions(+), 203 deletions(-) rename mm/{gup_benchmark.c => gup_test.c} (59%) create mode 100644 mm/gup_test.h create mode 100755 tools/testing/selftests/vm/check_config.sh delete mode 100644 tools/testing/selftests/vm/gup_benchmark.c create mode 100644 tools/testing/selftests/vm/gup_test.c rename tools/testing/selftests/vm/{run_vmtests => run_vmtest.sh} (91%) -- 2.28.0

4 years, 9 months

2
10
0 0

Re: [PATCH v2 1/6] kselftests: vm: Add mremap tests

by Kalesh Singh

On Sat, Oct 3, 2020 at 3:13 AM John Hubbard <jhubbard(a)nvidia.com> wrote: > > On 10/2/20 9:20 AM, Kalesh Singh wrote: > > Test mremap on regions of various sizes and alignments and validate > > data after remapping. Also provide total time for remapping > > the region which is useful for performance comparison of the mremap > > optimizations that move pages at the PMD/PUD levels if HAVE_MOVE_PMD > > and/or HAVE_MOVE_PUD are enabled. > > > > Signed-off-by: Kalesh Singh <kaleshsingh(a)google.com> > > --- > > Changes in v2: > > - Reduce test time by only validating a certain threshold of the > > remapped region (4MB by default). The -t flag can be used to > > set a custom threshold in MB or no threshold by passing 0. (-t0). > > mremap time is not provided in stdout for only partially validated > > regions. This time is only applicable for comparison if the entire > > mapped region was faulted in. > > - Use a random pattern for validating the remapped region. The -p > > flag can be used to run the tests with a specified seed for the > > random pattern. > > - Print test configs (threshold_mb and pattern_seed) to stdout. > > - Remove MAKE_SIMPLE_TEST macro. > > - Define named flags instead of 0 / 1. > > - Add comments for destination address' align_mask and offset. > > Thanks for making those changes. This all looks much nicer, both in the > code and on the screen. Now it's easy to see which code generates which > output, and the tests are readable. The new comments are also helpful. > > I ran it locally and it came in at 0.6 sec, so that looks good. > > A remaining nit: there are lots of > 80 col lines here. Only those lines > that contain printf output strings really need to be extra-long. The > others can all be easily made to fit. Thanks for the review John. I can fix the lines that don't need to be >80 col. FWIW checkpatch now allows 100 col lines: https://lore.kernel.org/r/9c360bfa43580ce7726dd3d9d247f1216a690ef0.camel@pe… > > ... > > + > > +#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0])) > > +#define MIN(X, Y) ((X) < (Y) ? (X) : (Y)) > > > Not really a comment on this patch, but: at least two other test suites > in selftests/ have had to recreate MIN() or min(), and probably a few > other common things as well. It would be nice to gather up some of these > common things into one of the shared header files in selftests/. > > I'm certainly not saying that this patchset has that responsibility, > though. Just pointing it out in case someone has a moment to clean up a > few here and there. Thanks for pointing this out. I'll leave it as a task for a separate patch if time permits or no one gets around to it before :-) > > I'll assume that any changes to make things fit within 80 cols are > trivial, so you can add: > > Reviewed-by: John Hubbard <jhubbard(a)nvidia.com> > > thanks, > -- > John Hubbard > NVIDIA > > > + > > +struct config { > > + unsigned long long src_alignment; > > + unsigned long long dest_alignment; > > + unsigned long long region_size; > > + int overlapping; > > +}; > > + > > +struct test { > > + const char *name; > > + struct config config; > > + int expect_failure; > > +}; > > + > > +enum { > > + _1KB = 1ULL << 10, /* 1KB -> not page aligned */ > > + _4KB = 4ULL << 10, > > + _8KB = 8ULL << 10, > > + _1MB = 1ULL << 20, > > + _2MB = 2ULL << 20, > > + _4MB = 4ULL << 20, > > + _1GB = 1ULL << 30, > > + _2GB = 2ULL << 30, > > + PTE = _4KB, > > + PMD = _2MB, > > + PUD = _1GB, > > +}; > > + > > +#define MAKE_TEST(source_align, destination_align, size, \ > > + overlaps, should_fail, test_name) \ > > +{ \ > > + .name = test_name, \ > > + .config = { \ > > + .src_alignment = source_align, \ > > + .dest_alignment = destination_align, \ > > + .region_size = size, \ > > + .overlapping = overlaps, \ > > + }, \ > > + .expect_failure = should_fail \ > > +} > > + > > +/* > > + * Returns the start address of the mapping on success, else returns > > + * NULL on failure. > > + */ > > +static void *get_source_mapping(struct config c) > > +{ > > + unsigned long long addr = 0ULL; > > + void *src_addr = NULL; > > +retry: > > + addr += c.src_alignment; > > + src_addr = mmap((void *) addr, c.region_size, PROT_READ | PROT_WRITE, > > + MAP_FIXED | MAP_ANONYMOUS | MAP_SHARED, -1, 0); > > + if (src_addr == MAP_FAILED) { > > + if (errno == EPERM) > > + goto retry; > > + goto error; > > + } > > + /* > > + * Check that the address is aligned to the specified alignment. Addresses > > + * which have alignments that are multiples of that specified are not considered > > + * valid. For instance, 1GB address is 2MB-aligned, however it will not be > > + * considered valid for a requested alignment of 2MB. This is done to > > + * reduce coincidental alignment in the tests. > > + */ > > + if (((unsigned long long) src_addr & (c.src_alignment - 1)) || > > + !((unsigned long long) src_addr & c.src_alignment)) > > + goto retry; > > + > > + if (!src_addr) > > + goto error; > > + > > + return src_addr; > > +error: > > + ksft_print_msg("Failed to map source region: %s\n", > > + strerror(errno)); > > + return NULL; > > +} > > + > > +/* Returns the time taken for the remap on success else returns -1. */ > > +static long long remap_region(struct config c, unsigned int threshold_mb, > > + char pattern_seed) > > +{ > > + void *addr, *src_addr, *dest_addr; > > + unsigned long long i; > > + struct timespec t_start = {0, 0}, t_end = {0, 0}; > > + long long start_ns, end_ns, align_mask, ret, offset; > > + unsigned long long threshold; > > + > > + if (threshold_mb == VALIDATION_NO_THRESHOLD) > > + threshold = c.region_size; > > + else > > + threshold = MIN(threshold_mb * _1MB, c.region_size); > > + > > + src_addr = get_source_mapping(c); > > + if (!src_addr) { > > + ret = -1; > > + goto out; > > + } > > + > > + /* Set byte pattern */ > > + srand(pattern_seed); > > + for (i = 0; i < threshold; i++) > > + memset((char *) src_addr + i, (char) rand(), 1); > > + > > + /* Mask to zero out lower bits of address for alignment */ > > + align_mask = ~(c.dest_alignment - 1); > > + /* Offset of destination address from the end of the source region */ > > + offset = (c.overlapping) ? -c.dest_alignment : c.dest_alignment; > > + addr = (void *) (((unsigned long long) src_addr + c.region_size + offset) > > + & align_mask); > > + > > + /* See comment in get_source_mapping() */ > > + if (!((unsigned long long) addr & c.dest_alignment)) > > + addr = (void *) ((unsigned long long) addr | c.dest_alignment); > > + > > + clock_gettime(CLOCK_MONOTONIC, &t_start); > > + dest_addr = mremap(src_addr, c.region_size, c.region_size, > > + MREMAP_MAYMOVE|MREMAP_FIXED, (char *) addr); > > + clock_gettime(CLOCK_MONOTONIC, &t_end); > > + > > + if (dest_addr == MAP_FAILED) { > > + ksft_print_msg("mremap failed: %s\n", strerror(errno)); > > + ret = -1; > > + goto clean_up_src; > > + } > > + > > + /* Verify byte pattern after remapping */ > > + srand(pattern_seed); > > + for (i = 0; i < threshold; i++) { > > + char c = (char) rand(); > > + > > + if (((char *) dest_addr)[i] != c) { > > + ksft_print_msg("Data after remap doesn't match at offset %d\n", > > + i); > > + ksft_print_msg("Expected: %#x\t Got: %#x\n", c & 0xff, > > + ((char *) dest_addr)[i] & 0xff); > > + ret = -1; > > + goto clean_up_dest; > > + } > > + } > > + > > + start_ns = t_start.tv_sec * NS_PER_SEC + t_start.tv_nsec; > > + end_ns = t_end.tv_sec * NS_PER_SEC + t_end.tv_nsec; > > + ret = end_ns - start_ns; > > + > > +/* > > + * Since the destination address is specified using MREMAP_FIXED, subsequent mremap will unmap any > > + * previous mapping at the address range specified by dest_addr and region_size. This significantly > > + * affects the remap time of subsequent tests. So we clean up mappings after each test. > > + */ > > +clean_up_dest: > > + munmap(dest_addr, c.region_size); > > +clean_up_src: > > + munmap(src_addr, c.region_size); > > +out: > > + return ret; > > +} > > + > > +static void run_mremap_test_case(struct test test_case, int *failures, unsigned int threshold_mb, > > + unsigned int pattern_seed) > > +{ > > + long long remap_time = remap_region(test_case.config, threshold_mb, pattern_seed); > > + > > + if (remap_time < 0) { > > + if (test_case.expect_failure) > > + ksft_test_result_pass("%s\n\tExpected mremap failure\n", test_case.name); > > + else { > > + ksft_test_result_fail("%s\n", test_case.name); > > + *failures += 1; > > + } > > + } else { > > + /* Comparing mremap time is only applicable if entire region was faulted in */ > > + if (threshold_mb == VALIDATION_NO_THRESHOLD || > > + test_case.config.region_size <= threshold_mb * _1MB) > > + ksft_test_result_pass("%s\n\tmremap time: %12lldns\n", > > + test_case.name, remap_time); > > + else > > + ksft_test_result_pass("%s\n", test_case.name); > > + } > > +} > > + > > +static void usage(const char *cmd) > > +{ > > + fprintf(stderr, > > + "Usage: %s [[-t <threshold_mb>] [-p <pattern_seed>]]\n" > > + "-t\t only validate threshold_mb of the remapped region\n" > > + " \t if 0 is supplied no threshold is used; all tests\n" > > + " \t are run and remapped regions validated fully.\n" > > + " \t The default threshold used is 4MB.\n" > > + "-p\t provide a seed to generate the random pattern for\n" > > + " \t validating the remapped region.\n", cmd); > > +} > > + > > +static int parse_args(int argc, char **argv, unsigned int *threshold_mb, > > + unsigned int *pattern_seed) > > +{ > > + const char *optstr = "t:p:"; > > + int opt; > > + > > + while ((opt = getopt(argc, argv, optstr)) != -1) { > > + switch (opt) { > > + case 't': > > + *threshold_mb = atoi(optarg); > > + break; > > + case 'p': > > + *pattern_seed = atoi(optarg); > > + break; > > + default: > > + usage(argv[0]); > > + return -1; > > + } > > + } > > + > > + if (optind < argc) { > > + usage(argv[0]); > > + return -1; > > + } > > + > > + return 0; > > +} > > + > > +int main(int argc, char **argv) > > +{ > > + int failures = 0; > > + int i, run_perf_tests; > > + unsigned int threshold_mb = VALIDATION_DEFAULT_THRESHOLD; > > + unsigned int pattern_seed; > > + time_t t; > > + > > + pattern_seed = (unsigned int) time(&t); > > + > > + if (parse_args(argc, argv, &threshold_mb, &pattern_seed) < 0) > > + exit(EXIT_FAILURE); > > + > > + ksft_print_msg("Test configs:\n\tthreshold_mb=%u\n\tpattern_seed=%u\n\n", > > + threshold_mb, pattern_seed); > > + > > + struct test test_cases[] = { > > + /* Expected mremap failures */ > > + MAKE_TEST(_4KB, _4KB, _4KB, OVERLAPPING, EXPECT_FAILURE, > > + "mremap - Source and Destination Regions Overlapping"), > > + MAKE_TEST(_4KB, _1KB, _4KB, NON_OVERLAPPING, EXPECT_FAILURE, > > + "mremap - Destination Address Misaligned (1KB-aligned)"), > > + MAKE_TEST(_1KB, _4KB, _4KB, NON_OVERLAPPING, EXPECT_FAILURE, > > + "mremap - Source Address Misaligned (1KB-aligned)"), > > + > > + /* Src addr PTE aligned */ > > + MAKE_TEST(PTE, PTE, _8KB, NON_OVERLAPPING, EXPECT_SUCCESS, > > + "8KB mremap - Source PTE-aligned, Destination PTE-aligned"), > > + > > + /* Src addr 1MB aligned */ > > + MAKE_TEST(_1MB, PTE, _2MB, NON_OVERLAPPING, EXPECT_SUCCESS, > > + "2MB mremap - Source 1MB-aligned, Destination PTE-aligned"), > > + MAKE_TEST(_1MB, _1MB, _2MB, NON_OVERLAPPING, EXPECT_SUCCESS, > > + "2MB mremap - Source 1MB-aligned, Destination 1MB-aligned"), > > + > > + /* Src addr PMD aligned */ > > + MAKE_TEST(PMD, PTE, _4MB, NON_OVERLAPPING, EXPECT_SUCCESS, > > + "4MB mremap - Source PMD-aligned, Destination PTE-aligned"), > > + MAKE_TEST(PMD, _1MB, _4MB, NON_OVERLAPPING, EXPECT_SUCCESS, > > + "4MB mremap - Source PMD-aligned, Destination 1MB-aligned"), > > + MAKE_TEST(PMD, PMD, _4MB, NON_OVERLAPPING, EXPECT_SUCCESS, > > + "4MB mremap - Source PMD-aligned, Destination PMD-aligned"), > > + > > + /* Src addr PUD aligned */ > > + MAKE_TEST(PUD, PTE, _2GB, NON_OVERLAPPING, EXPECT_SUCCESS, > > + "2GB mremap - Source PUD-aligned, Destination PTE-aligned"), > > + MAKE_TEST(PUD, _1MB, _2GB, NON_OVERLAPPING, EXPECT_SUCCESS, > > + "2GB mremap - Source PUD-aligned, Destination 1MB-aligned"), > > + MAKE_TEST(PUD, PMD, _2GB, NON_OVERLAPPING, EXPECT_SUCCESS, > > + "2GB mremap - Source PUD-aligned, Destination PMD-aligned"), > > + MAKE_TEST(PUD, PUD, _2GB, NON_OVERLAPPING, EXPECT_SUCCESS, > > + "2GB mremap - Source PUD-aligned, Destination PUD-aligned"), > > + }; > > + > > + struct test perf_test_cases[] = { > > + /* mremap 1GB region - Page table level aligned time comparison */ > > + MAKE_TEST(PTE, PTE, _1GB, NON_OVERLAPPING, EXPECT_SUCCESS, > > + "1GB mremap - Source PTE-aligned, Destination PTE-aligned"), > > + MAKE_TEST(PMD, PMD, _1GB, NON_OVERLAPPING, EXPECT_SUCCESS, > > + "1GB mremap - Source PMD-aligned, Destination PMD-aligned"), > > + MAKE_TEST(PUD, PUD, _1GB, NON_OVERLAPPING, EXPECT_SUCCESS, > > + "1GB mremap - Source PUD-aligned, Destination PUD-aligned"), > > + }; > > + > > + run_perf_tests = (threshold_mb == VALIDATION_NO_THRESHOLD) || > > + (threshold_mb * _1MB >= _1GB); > > + > > + ksft_set_plan(ARRAY_SIZE(test_cases) + (run_perf_tests ? > > + ARRAY_SIZE(perf_test_cases) : 0)); > > + > > + for (i = 0; i < ARRAY_SIZE(test_cases); i++) > > + run_mremap_test_case(test_cases[i], &failures, threshold_mb, pattern_seed); > > + > > + if (run_perf_tests) { > > + ksft_print_msg("\n%s\n", > > + "mremap HAVE_MOVE_PMD/PUD optimization time comparison for 1GB region:"); > > + for (i = 0; i < ARRAY_SIZE(perf_test_cases); i++) > > + run_mremap_test_case(perf_test_cases[i], &failures, threshold_mb, > > + pattern_seed); > > + } > > + > > + if (failures > 0) > > + ksft_exit_fail(); > > + else > > + ksft_exit_pass(); > > +} > > diff --git a/tools/testing/selftests/vm/run_vmtests b/tools/testing/selftests/vm/run_vmtests > > index a3f4f30f0a2e..d578ad831813 100755 > > --- a/tools/testing/selftests/vm/run_vmtests > > +++ b/tools/testing/selftests/vm/run_vmtests > > @@ -241,6 +241,17 @@ else > > echo "[PASS]" > > fi > > > > +echo "-------------------" > > +echo "running mremap_test" > > +echo "-------------------" > > +./mremap_test > > +if [ $? -ne 0 ]; then > > + echo "[FAIL]" > > + exitcode=1 > > +else > > + echo "[PASS]" > > +fi > > + > > echo "-----------------" > > echo "running thuge-gen" > > echo "-----------------" > > > > -- > To unsubscribe from this group and stop receiving emails from it, send an email to kernel-team+unsubscribe(a)android.com. >

4 years, 9 months

1
0
0 0

[PATCH v2 0/6] Speed up mremap on large regions

by Kalesh Singh

This version 2 of the mremap speed up patches previously posted at: https://lore.kernel.org/r/20200930222130.4175584-1-kaleshsingh@google.com mremap time can be optimized by moving entries at the PMD/PUD level if the source and destination addresses are PMD/PUD-aligned and PMD/PUD-sized. Enable moving at the PMD and PUD levels on arm64 and x86. Other architectures where this type of move is supported and known to be safe can also opt-in to these optimizations by enabling HAVE_MOVE_PMD and HAVE_MOVE_PUD. Observed Performance Improvements for remapping a PUD-aligned 1GB-sized region on x86 and arm64: - HAVE_MOVE_PMD is already enabled on x86 : N/A - Enabling HAVE_MOVE_PUD on x86 : ~13x speed up - Enabling HAVE_MOVE_PMD on arm64 : ~ 8x speed up - Enabling HAVE_MOVE_PUD on arm64 : ~19x speed up Altogether, HAVE_MOVE_PMD and HAVE_MOVE_PUD give a total of ~150x speed up on arm64. Changes in v2: - Reduce mremap_test time by only validating a configurable threshold of the remapped region, as per John. - Use a random pattern for mremap validation. Provide pattern seed in test output, as per John. - Moved set_pud_at() to separate patch, per Kirill. - Use switch() instead of ifs in move_pgt_entry(), per Kirill. - Update commit message with description of Android garbage collector use case for HAVE_MOVE_PUD, as per Joel. - Fix build test error reported by kernel test robot in [1]. [1] https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org/thread/CKPGL4F… Kalesh Singh (6): kselftests: vm: Add mremap tests arm64: mremap speedup - Enable HAVE_MOVE_PMD mm: Speedup mremap on 1GB or larger regions arm64: Add set_pud_at() functions arm64: mremap speedup - Enable HAVE_MOVE_PUD x86: mremap speedup - Enable HAVE_MOVE_PUD arch/Kconfig | 7 + arch/arm64/Kconfig | 2 + arch/arm64/include/asm/pgtable.h | 1 + arch/x86/Kconfig | 1 + mm/mremap.c | 220 +++++++++++++-- tools/testing/selftests/vm/.gitignore | 1 + tools/testing/selftests/vm/Makefile | 1 + tools/testing/selftests/vm/mremap_test.c | 333 +++++++++++++++++++++++ tools/testing/selftests/vm/run_vmtests | 11 + 9 files changed, 547 insertions(+), 30 deletions(-) create mode 100644 tools/testing/selftests/vm/mremap_test.c base-commit: 472e5b056f000a778abb41f1e443de58eb259783 -- 2.28.0.806.g8561365e88-goog

4 years, 9 months

2
11
0 0

[PATCH 0/1] selftests/vm: 8x compaction_test speedup

by John Hubbard

Hi, Maybe this should really be an RFC, given that I don't fully understand why the compaction_test.c program was mmap'ing 1 MB at a time. So apologies in advance if I've mucked up something important, but if so, maybe we can still find a way to get this fixed up to something better. Anyway: there are 20+ tests in tools/testing/selftests/vm/. The entire running time for these (via run_vmtest.sh) is about 56 seconds, of which over half is due to just one test: compaction_test, which takes 27 sec! (A runner-up is HMM, at 11 sec, so it's up for a look next.) The other tests mostly take a few ms, and a few take 1.0 sec. This drops the compaction_test run time from 27, to 3.3 sec. Enjoy. :) thanks, John Hubbard NVIDIA John Hubbard (1): selftests/vm: 8x compaction_test speedup tools/testing/selftests/vm/compaction_test.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) -- 2.28.0

4 years, 9 months

3
3
0 0

[PATCH] selftests/ftrace: check for do_sys_openat2 in user-memory test

by Colin King

From: Colin Ian King <colin.king(a)canonical.com> More recent libc implementations are now using openat/openat2 system calls so also add do_sys_openat2 to the tracing so that the test passes on these systems because do_sys_open may not be called. Signed-off-by: Colin Ian King <colin.king(a)canonical.com> --- .../testing/selftests/ftrace/test.d/kprobe/kprobe_args_user.tc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_user.tc b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_user.tc index a30a9c07290d..cf1b4c3e9e6b 100644 --- a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_user.tc +++ b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_user.tc @@ -9,6 +9,8 @@ grep -A10 "fetcharg:" README | grep -q '\[u\]<offset>' || exit_unsupported :;: "user-memory access syntax and ustring working on user memory";: echo 'p:myevent do_sys_open path=+0($arg2):ustring path2=+u0($arg2):string' \ > kprobe_events +echo 'p:myevent2 do_sys_openat2 path=+0($arg2):ustring path2=+u0($arg2):string' \ + > kprobe_events grep myevent kprobe_events | \ grep -q 'path=+0($arg2):ustring path2=+u0($arg2):string' -- 2.27.0

4 years, 9 months

4
6
0 0

[PATCH bpf-next v2 2/4] selftests: bpf: Add helper to compare socket cookies

by Lorenz Bauer

We compare socket cookies to ensure that insertion into a sockmap worked. Pull this out into a helper function for use in other tests. Signed-off-by: Lorenz Bauer <lmb(a)cloudflare.com> --- .../selftests/bpf/prog_tests/sockmap_basic.c | 50 +++++++++++++------ 1 file changed, 36 insertions(+), 14 deletions(-) diff --git a/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c b/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c index 4b7a527e7e82..67d3301bdf81 100644 --- a/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c +++ b/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c @@ -50,6 +50,37 @@ static int connected_socket_v4(void) return -1; } +static void compare_cookies(struct bpf_map *src, struct bpf_map *dst) +{ + __u32 i, max_entries = bpf_map__max_entries(src); + int err, duration, src_fd, dst_fd; + + src_fd = bpf_map__fd(src); + dst_fd = bpf_map__fd(dst); + + for (i = 0; i < max_entries; i++) { + __u64 src_cookie, dst_cookie; + + err = bpf_map_lookup_elem(src_fd, &i, &src_cookie); + if (err && errno == ENOENT) { + err = bpf_map_lookup_elem(dst_fd, &i, &dst_cookie); + CHECK(!err, "map_lookup_elem(dst)", "element %u not deleted\n", i); + CHECK(err && errno != ENOENT, "map_lookup_elem(dst)", "%s\n", + strerror(errno)); + continue; + } + if (CHECK(err, "lookup_elem(src)", "%s\n", strerror(errno))) + continue; + + err = bpf_map_lookup_elem(dst_fd, &i, &dst_cookie); + if (CHECK(err, "lookup_elem(dst)", "%s\n", strerror(errno))) + continue; + + CHECK(dst_cookie != src_cookie, "cookie mismatch", + "%llu != %llu (pos %u)\n", dst_cookie, src_cookie, i); + } +} + /* Create a map, populate it with one socket, and free the map. */ static void test_sockmap_create_update_free(enum bpf_map_type map_type) { @@ -109,9 +140,9 @@ static void test_skmsg_helpers(enum bpf_map_type map_type) static void test_sockmap_update(enum bpf_map_type map_type) { struct bpf_prog_test_run_attr tattr; - int err, prog, src, dst, duration = 0; + int err, prog, src, duration = 0; struct test_sockmap_update *skel; - __u64 src_cookie, dst_cookie; + struct bpf_map *dst_map; const __u32 zero = 0; char dummy[14] = {0}; __s64 sk; @@ -127,18 +158,14 @@ static void test_sockmap_update(enum bpf_map_type map_type) prog = bpf_program__fd(skel->progs.copy_sock_map); src = bpf_map__fd(skel->maps.src); if (map_type == BPF_MAP_TYPE_SOCKMAP) - dst = bpf_map__fd(skel->maps.dst_sock_map); + dst_map = skel->maps.dst_sock_map; else - dst = bpf_map__fd(skel->maps.dst_sock_hash); + dst_map = skel->maps.dst_sock_hash; err = bpf_map_update_elem(src, &zero, &sk, BPF_NOEXIST); if (CHECK(err, "update_elem(src)", "errno=%u\n", errno)) goto out; - err = bpf_map_lookup_elem(src, &zero, &src_cookie); - if (CHECK(err, "lookup_elem(src, cookie)", "errno=%u\n", errno)) - goto out; - tattr = (struct bpf_prog_test_run_attr){ .prog_fd = prog, .repeat = 1, @@ -151,12 +178,7 @@ static void test_sockmap_update(enum bpf_map_type map_type) "errno=%u retval=%u\n", errno, tattr.retval)) goto out; - err = bpf_map_lookup_elem(dst, &zero, &dst_cookie); - if (CHECK(err, "lookup_elem(dst, cookie)", "errno=%u\n", errno)) - goto out; - - CHECK(dst_cookie != src_cookie, "cookie mismatch", "%llu != %llu\n", - dst_cookie, src_cookie); + compare_cookies(skel->maps.src, dst_map); out: test_sockmap_update__destroy(skel); -- 2.25.1

4 years, 9 months

4
7
0 0

WARNING:at arch/x86/kvm/vmx/vmx.c:4809 handle_exception_nmi+0x5ab/0x5c0

by Naresh Kamboju

While running kselftest kvm evmcs_test the following kernel warning was noticed on x86_64 running linux next 20201001 kernel. WARNING: CPU: 0 PID: 11202 at /usr/src/kernel/arch/x86/kvm/vmx/vmx.c:4809 handle_exception_nmi+0x5ab/0x5c0 Reported-by: Naresh Kamboju <naresh.kamboju(a)linaro.org> steps to reproduce: # cd /opt/kselftests/kvm # ./evmcs_test metadata: git branch: master git repo: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git git commit: d39294091fee6b89d9c4a683bb19441b25098330 git describe: next-20201001 make_kernelversion: 5.9.0-rc7 kernel-config: http://snapshots.linaro.org/openembedded/lkft/lkft/sumo/intel-corei7-64/lkf… # selftests: kvm: evmcs_test [ 492.217268] ------------[ cut here ]------------ [ 492.222034] WARNING: CPU: 0 PID: 11202 at /usr/src/kernel/arch/x86/kvm/vmx/vmx.c:4809 handle_exception_nmi+0x5ab/0x5c0 [ 492.232747] Modules linked in: sch_fq sch_ingress veth algif_hash x86_pkg_temp_thermal fuse [last unloaded: gpio_mockup] [ 492.243664] CPU: 0 PID: 11202 Comm: evmcs_test Tainted: G W 5.9.0-rc7-next-20201001 #1 [ 492.252899] Hardware name: Supermicro SYS-5019S-ML/X11SSH-F, BIOS 2.0b 07/27/2017 [ 492.260398] RIP: 0010:handle_exception_nmi+0x5ab/0x5c0 [ 492.265554] Code: 84 f7 fb ff ff 8b 93 ac 0e 00 00 85 d2 0f 84 e4 fb ff ff c7 83 ac 0e 00 00 00 00 00 00 48 89 df e8 9a f2 fa ff e9 d2 fb ff ff <0f> 0b e9 cc fd ff ff 0f 1f 40 00 66 2e 0f 1f 84 00 00 00 00 00 0f [ 492.284317] RSP: 0018:ffffbf3001323cf8 EFLAGS: 00010246 [ 492.289568] RAX: 0000000000000060 RBX: ffff9f5b08048000 RCX: 0000000000000000 [ 492.296716] RDX: 00000000f359fd01 RSI: 0000000000000000 RDI: 000000008000030e [ 492.303868] RBP: ffffbf3001323d20 R08: 0000000080000306 R09: 0000000000000000 [ 492.311018] R10: ffffbf3001323c30 R11: ffffbf30013e7000 R12: 0000000000000000 [ 492.318167] R13: 0000000000000000 R14: ffff9f5b52714000 R15: 0000000000000000 [ 492.325492] FS: 00007f22a58cc740(0000) GS:ffff9f5b5fc00000(0000) knlGS:0000000000000000 [ 492.333596] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 492.339362] CR2: 0000000000000000 CR3: 00000004013c0006 CR4: 00000000003726f0 [ 492.346513] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 492.353662] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 492.360814] Call Trace: [ 492.363293] vmx_handle_exit+0x102/0x5e0 [ 492.367241] vcpu_enter_guest+0xe27/0x18a0 [ 492.371361] ? lock_acquire+0x9c/0x390 [ 492.375132] ? kvm_arch_vcpu_ioctl_run+0x9c/0x620 [ 492.379865] kvm_arch_vcpu_ioctl_run+0x12b/0x620 [ 492.384501] ? kvm_arch_vcpu_ioctl_run+0x12b/0x620 [ 492.389316] kvm_vcpu_ioctl+0x261/0x670 [ 492.393183] ? security_file_ioctl+0x37/0x50 [ 492.397500] __x64_sys_ioctl+0x96/0xd0 [ 492.401283] do_syscall_64+0x37/0x50 [ 492.404878] entry_SYSCALL_64_after_hwframe+0x44/0xa9 [ 492.409954] RIP: 0033:0x7f22a51ca8f7 [ 492.413551] Code: b3 66 90 48 8b 05 a1 35 2c 00 64 c7 00 26 00 00 00 48 c7 c0 ff ff ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 b8 10 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 71 35 2c 00 f7 d8 64 89 01 48 [ 492.432312] RSP: 002b:00007ffe09251188 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 [ 492.439895] RAX: ffffffffffffffda RBX: 00000000007d23d0 RCX: 00007f22a51ca8f7 [ 492.447043] RDX: 0000000000000000 RSI: 000000000000ae80 RDI: 0000000000000009 [ 492.454195] RBP: 000000000000000b R08: 000000000040d893 R09: 0000000000000005 [ 492.461344] R10: 0000000000000000 R11: 0000000000000246 R12: 00007ffe09251210 [ 492.468495] R13: 00007f22a58c5000 R14: 00007ffe092512a0 R15: 000000000000000b [ 492.475658] CPU: 0 PID: 11202 Comm: evmcs_test Tainted: G W 5.9.0-rc7-next-20201001 #1 [ 492.484879] Hardware name: Supermicro SYS-5019S-ML/X11SSH-F, BIOS 2.0b 07/27/2017 [ 492.492357] Call Trace: [ 492.494803] dump_stack+0x7d/0x9f [ 492.498126] __warn+0x94/0x100 [ 492.501183] ? handle_exception_nmi+0x5ab/0x5c0 [ 492.505715] report_bug+0xc0/0x150 [ 492.509123] handle_bug+0x48/0x80 [ 492.512442] exc_invalid_op+0x18/0x70 [ 492.516108] asm_exc_invalid_op+0x12/0x20 [ 492.520119] RIP: 0010:handle_exception_nmi+0x5ab/0x5c0 [ 492.525257] Code: 84 f7 fb ff ff 8b 93 ac 0e 00 00 85 d2 0f 84 e4 fb ff ff c7 83 ac 0e 00 00 00 00 00 00 48 89 df e8 9a f2 fa ff e9 d2 fb ff ff <0f> 0b e9 cc fd ff ff 0f 1f 40 00 66 2e 0f 1f 84 00 00 00 00 00 0f [ 492.544001] RSP: 0018:ffffbf3001323cf8 EFLAGS: 00010246 [ 492.549229] RAX: 0000000000000060 RBX: ffff9f5b08048000 RCX: 0000000000000000 [ 492.556361] RDX: 00000000f359fd01 RSI: 0000000000000000 RDI: 000000008000030e [ 492.563492] RBP: ffffbf3001323d20 R08: 0000000080000306 R09: 0000000000000000 [ 492.570625] R10: ffffbf3001323c30 R11: ffffbf30013e7000 R12: 0000000000000000 [ 492.577757] R13: 0000000000000000 R14: ffff9f5b52714000 R15: 0000000000000000 [ 492.584900] vmx_handle_exit+0x102/0x5e0 [ 492.588839] vcpu_enter_guest+0xe27/0x18a0 [ 492.592943] ? lock_acquire+0x9c/0x390 [ 492.596697] ? kvm_arch_vcpu_ioctl_run+0x9c/0x620 [ 492.601411] kvm_arch_vcpu_ioctl_run+0x12b/0x620 [ 492.606037] ? kvm_arch_vcpu_ioctl_run+0x12b/0x620 [ 492.610833] kvm_vcpu_ioctl+0x261/0x670 [ 492.614675] ? security_file_ioctl+0x37/0x50 [ 492.618963] __x64_sys_ioctl+0x96/0xd0 [ 492.622725] do_syscall_64+0x37/0x50 [ 492.626308] entry_SYSCALL_64_after_hwframe+0x44/0xa9 [ 492.631362] RIP: 0033:0x7f22a51ca8f7 [ 492.634938] Code: b3 66 90 48 8b 05 a1 35 2c 00 64 c7 00 26 00 00 00 48 c7 c0 ff ff ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 b8 10 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 71 35 2c 00 f7 d8 64 89 01 48 [ 492.653676] RSP: 002b:00007ffe09251188 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 [ 492.661243] RAX: ffffffffffffffda RBX: 00000000007d23d0 RCX: 00007f22a51ca8f7 [ 492.668373] RDX: 0000000000000000 RSI: 000000000000ae80 RDI: 0000000000000009 [ 492.675498] RBP: 000000000000000b R08: 000000000040d893 R09: 0000000000000005 [ 492.682632] R10: 0000000000000000 R11: 0000000000000246 R12: 00007ffe09251210 [ 492.689763] R13: 00007f22a58c5000 R14: 00007ffe092512a0 R15: 000000000000000b [ 492.696921] irq event stamp: 33513 [ 492.700345] hardirqs last enabled at (33523): [<ffffffffa4a3f229>] console_unlock+0x4a9/0x5b0 [ 492.708970] hardirqs last disabled at (33532): [<ffffffffa4a3f183>] console_unlock+0x403/0x5b0 [ 492.717596] softirqs last enabled at (33388): [<ffffffffa5c00308>] __do_softirq+0x308/0x42a [ 492.726043] softirqs last disabled at (33351): [<ffffffffa5a00f82>] asm_call_irq_on_stack+0x12/0x20 [ 492.735099] ---[ end trace 3a8d97eed7321275 ]--- full test log link, https://lkft.validation.linaro.org/scheduler/job/1809553#L6581 -- Linaro LKFT https://lkft.linaro.org

4 years, 9 months

1
0
0 0

[PATCH 0/5] Speed up mremap on large regions

by Kalesh Singh

mremap time can be optimized by moving entries at the PMD/PUD level if the source and destination addresses are PMD/PUD-aligned and PMD/PUD-sized. Enable moving at the PMD and PUD levels on arm64 and x86. Other architectures where this type of move is supported and known to be safe can also opt-in to these optimizations by enabling HAVE_MOVE_PMD and HAVE_MOVE_PUD. Observed Performance Improvements for remapping a PUD-aligned 1GB-sized region on x86 and arm64: - HAVE_MOVE_PMD is already enabled on x86 : N/A - Enabling HAVE_MOVE_PUD on x86 : ~13x speed up - Enabling HAVE_MOVE_PMD on arm64 : ~ 8x speed up - Enabling HAVE_MOVE_PUD on arm64 : ~19x speed up Altogether, HAVE_MOVE_PMD and HAVE_MOVE_PUD give a total of ~150x speed up on arm64. Kalesh Singh (5): kselftests: vm: Add mremap tests arm64: mremap speedup - Enable HAVE_MOVE_PMD mm: Speedup mremap on 1GB or larger regions arm64: mremap speedup - Enable HAVE_MOVE_PUD x86: mremap speedup - Enable HAVE_MOVE_PUD arch/Kconfig | 7 + arch/arm64/Kconfig | 2 + arch/arm64/include/asm/pgtable.h | 1 + arch/x86/Kconfig | 1 + mm/mremap.c | 211 +++++++++++++++++--- tools/testing/selftests/vm/.gitignore | 1 + tools/testing/selftests/vm/Makefile | 1 + tools/testing/selftests/vm/mremap_test.c | 243 +++++++++++++++++++++++ tools/testing/selftests/vm/run_vmtests | 11 + 9 files changed, 448 insertions(+), 30 deletions(-) create mode 100644 tools/testing/selftests/vm/mremap_test.c -- 2.28.0.709.gb0816b6eb0-goog

4 years, 9 months

5
19
0 0

[RFC v1 00/12] kunit: introduce class mocking support.

by Daniel Latypov

# Background KUnit currently lacks any first-class support for mocking. For an overview and discussion on the pros and cons, see https://martinfowler.com/articles/mocksArentStubs.html This patch set introduces the basic machinery needed for mocking: setting and validating expectations, setting default actions, etc. Using that basic infrastructure, we add macros for "class mocking", as it's probably the easiest type of mocking to start with. ## Class mocking By "class mocking", we're referring mocking out function pointers stored in structs like: struct sender { int (*send)(struct sender *sender, int data); }; After the necessary DEFINE_* macros, we can then write code like struct MOCK(sender) mock_sender = CONSTRUCT_MOCK(sender, test); /* Fake an error for a specific input. */ handle = KUNIT_EXPECT_CALL(send(<omitted>, kunit_int_eq(42))); handle->action = kunit_int_return(test, -EINVAL); /* Pass the mocked object to some code under test. */ KUNIT_EXPECT_EQ(test, -EINVAL, send_message(...)); I.e. the goal is to make it easier to test 1) with less dependencies (we don't need to setup a real `sender`) 2) unusual/error conditions more easily. In the future, we hope to build upon this to support mocking in more contexts, e.g. standalone funcs, etc. # TODOs ## Naming This introduces a number of new macros for dealing with mocks, e.g: DEFINE_STRUCT_CLASS_MOCK(METHOD(foo), CLASS(example), RETURNS(int), PARAMS(struct example *, int)); ... KUNIT_EXPECT_CALL(foo(mock_get_ctrl(mock_example), ...); For consistency, we could prefix everything with KUNIT, e.g. `KUNIT_DEFINE_STRUCT_CLASS_MOCK` and `kunit_mock_get_ctrl`, but it feels like the names might be long enough that they would hinder readability. ## Usage For now the only use of class mocking is in kunit-example-test.c As part of changing this from an RFC to a real patch set, we're hoping to include at least one example. Pointers to bits of code where this would be useful that aren't too hairy would be appreciated. E.g. could easily add a test for tools/perf/ui/progress.h, e.g. that ui_progress__init() calls ui_progress_ops.init(), but that likely isn't useful to anyone. Brendan Higgins (9): kunit: test: add kunit_stream a std::stream like logger kunit: test: add concept of post conditions checkpatch: add support for struct MOCK(foo) syntax kunit: mock: add parameter list manipulation macros kunit: mock: add internal mock infrastructure kunit: mock: add basic matchers and actions kunit: mock: add class mocking support kunit: mock: add struct param matcher kunit: mock: implement nice, strict and naggy mock distinctions Daniel Latypov (2): Revert "kunit: move string-stream.h to lib/kunit" kunit: expose kunit_set_failure() for use by mocking Marcelo Schmitt (1): kunit: mock: add macro machinery to pick correct format args include/kunit/assert.h | 3 +- include/kunit/kunit-stream.h | 94 +++ include/kunit/mock.h | 902 +++++++++++++++++++++++++ include/kunit/params.h | 305 +++++++++ {lib => include}/kunit/string-stream.h | 2 + include/kunit/test.h | 9 + lib/kunit/Makefile | 9 +- lib/kunit/assert.c | 2 - lib/kunit/common-mocks.c | 409 +++++++++++ lib/kunit/kunit-example-test.c | 90 +++ lib/kunit/kunit-stream.c | 110 +++ lib/kunit/mock-macro-test.c | 241 +++++++ lib/kunit/mock-test.c | 531 +++++++++++++++ lib/kunit/mock.c | 370 ++++++++++ lib/kunit/string-stream-test.c | 3 +- lib/kunit/string-stream.c | 5 +- lib/kunit/test.c | 15 +- scripts/checkpatch.pl | 4 + 18 files changed, 3091 insertions(+), 13 deletions(-) create mode 100644 include/kunit/kunit-stream.h create mode 100644 include/kunit/mock.h create mode 100644 include/kunit/params.h rename {lib => include}/kunit/string-stream.h (95%) create mode 100644 lib/kunit/common-mocks.c create mode 100644 lib/kunit/kunit-stream.c create mode 100644 lib/kunit/mock-macro-test.c create mode 100644 lib/kunit/mock-test.c create mode 100644 lib/kunit/mock.c base-commit: 10b82d5176488acee2820e5a2cf0f2ec5c3488b6 -- 2.28.0.681.g6f77f65b4e-goog

4 years, 9 months

2
15
0 0

[RFC PATCH 21/22] selftest/x86/amx: Include test cases for the AMX state management

by Chang S. Bae

This selftest exercises the kernel's ability to inherit and context switch AMX state, by verifying that they retain unique data when creating a child process and between multiple threads. Also, ptrace() is used to insert AMX state into existing threads -- both before and after the existing thread has initialized its AMX state. For the signal handling path, verify in the signal handler that the signal frame either include or exclude AMX data -- depending on if the signaled thread has initialized AMX state. Collect the test cases of validating those operations together, as they share some common setup for the AMX state. These test cases do not depend on AMX compiler support, as they employ user-space-XSAVE directly to access AMX state. Signed-off-by: Chang S. Bae <chang.seok.bae(a)intel.com> Reviewed-by: Len Brown <len.brown(a)intel.com> Cc: x86(a)kernel.org Cc: linux-kernel(a)vger.kernel.org Cc: linux-kselftest(a)vger.kernel.org --- tools/testing/selftests/x86/Makefile | 2 +- tools/testing/selftests/x86/amx.c | 736 +++++++++++++++++++++++++++ 2 files changed, 737 insertions(+), 1 deletion(-) create mode 100644 tools/testing/selftests/x86/amx.c diff --git a/tools/testing/selftests/x86/Makefile b/tools/testing/selftests/x86/Makefile index e0c52e5ab49e..6f6e6cabca69 100644 --- a/tools/testing/selftests/x86/Makefile +++ b/tools/testing/selftests/x86/Makefile @@ -17,7 +17,7 @@ TARGETS_C_BOTHBITS := single_step_syscall sysret_ss_attrs syscall_nt test_mremap TARGETS_C_32BIT_ONLY := entry_from_vm86 test_syscall_vdso unwind_vdso \ test_FCMOV test_FCOMI test_FISTTP \ vdso_restorer -TARGETS_C_64BIT_ONLY := fsgsbase sysret_rip syscall_numbering +TARGETS_C_64BIT_ONLY := fsgsbase sysret_rip syscall_numbering amx # Some selftests require 32bit support enabled also on 64bit systems TARGETS_C_32BIT_NEEDED := ldt_gdt ptrace_syscall diff --git a/tools/testing/selftests/x86/amx.c b/tools/testing/selftests/x86/amx.c new file mode 100644 index 000000000000..bf766b22cf77 --- /dev/null +++ b/tools/testing/selftests/x86/amx.c @@ -0,0 +1,736 @@ +// SPDX-License-Identifier: GPL-2.0 + +#define _GNU_SOURCE +#include <err.h> +#include <elf.h> +#include <pthread.h> +#include <sched.h> +#include <signal.h> +#include <stdio.h> +#include <string.h> +#include <stdbool.h> +#include <stdint.h> +#include <stdlib.h> +#include <time.h> +#include <malloc.h> +#include <unistd.h> +#include <ucontext.h> + +#include <linux/futex.h> + +#include <sys/ipc.h> +#include <sys/mman.h> +#include <sys/ptrace.h> +#include <sys/shm.h> +#include <sys/signal.h> +#include <sys/syscall.h> +#include <sys/time.h> +#include <sys/types.h> +#include <sys/wait.h> +#include <sys/uio.h> +#include <sys/ucontext.h> + +#include <x86intrin.h> + +#ifndef __x86_64__ +# error This test is 64-bit only +#endif + +typedef uint8_t u8; +typedef uint16_t u16; +typedef uint32_t u32; +typedef uint64_t u64; + +#define PAGE_SIZE (1 << 12) + +#define NUM_TILES 8 +#define TILE_SIZE 1024 +#define XSAVE_SIZE ((NUM_TILES * TILE_SIZE) + PAGE_SIZE) + +struct xsave_data { + u8 area[XSAVE_SIZE]; +} __attribute__((aligned(64))); + +/* Tile configuration associated: */ +#define MAX_TILES 16 +#define RESERVED_BYTES 14 + +struct tile_config { + u8 palette_id; + u8 start_row; + u8 reserved[RESERVED_BYTES]; + u16 colsb[MAX_TILES]; + u8 rows[MAX_TILES]; +}; + +struct tile_data { + u8 data[NUM_TILES * TILE_SIZE]; +}; + +static inline u64 __xgetbv(u32 index) +{ + u32 eax, edx; + + asm volatile(".byte 0x0f,0x01,0xd0" + : "=a" (eax), "=d" (edx) + : "c" (index)); + return eax + ((u64)edx << 32); +} + +static inline void __cpuid(u32 *eax, u32 *ebx, u32 *ecx, u32 *edx) +{ + asm volatile("cpuid;" + : "=a" (*eax), "=b" (*ebx), "=c" (*ecx), "=d" (*edx) + : "0" (*eax), "2" (*ecx)); +} + +/* Load tile configuration */ +static inline void __ldtilecfg(void *cfg) +{ + asm volatile(".byte 0xc4,0xe2,0x78,0x49,0x00" + : : "a"(cfg)); +} + +/* Load tile data to %tmm0 register only */ +static inline void __tileloadd(void *tile) +{ + asm volatile(".byte 0xc4,0xe2,0x7b,0x4b,0x04,0x10" + : : "a"(tile), "d"(0)); +} + +/* Save extended states */ +static inline void __xsave(void *area, u32 lo, u32 hi) +{ + asm volatile(".byte 0x48,0x0f,0xae,0x27" + : : "D" (area), "a" (lo), "d" (hi) + : "memory"); +} + +/* Restore extended states */ +static inline void __xrstor(void *area, u32 lo, u32 hi) +{ + asm volatile(".byte 0x48,0x0f,0xae,0x2f" + : : "D" (area), "a" (lo), "d" (hi)); +} + +/* Release tile states to init values */ +static inline void __tilerelease(void) +{ + asm volatile(".byte 0xc4, 0xe2, 0x78, 0x49, 0xc0" ::); +} + +/* Hardware info check: */ + +static inline bool check_xsave_supports_xtile(void) +{ + u32 eax, ebx, ecx, edx; + bool available = false; + +#define XSAVE_CPUID 0x1 +#define XSAVE_ECX_BIT 26 +#define XFEATURE_XTILE_CFG 17 +#define XFEATURE_XTILE_DATA 18 +#define XFEATURE_MASK_XTILE ((1 << XFEATURE_XTILE_DATA) | \ + (1 << XFEATURE_XTILE_CFG)) + + eax = XSAVE_CPUID; + ecx = 0; + + __cpuid(&eax, &ebx, &ecx, &edx); + if (!(ecx & (1 << XSAVE_ECX_BIT))) + return available; + + if (__xgetbv(0) & XFEATURE_MASK_XTILE) + available = true; + + return available; +} + +struct xtile_hwinfo { + struct { + u16 bytes_per_tile; + u16 bytes_per_row; + u16 max_names; + u16 max_rows; + } spec; + + struct { + u32 offset; + u32 size; + } xsave; +}; + +static struct xtile_hwinfo xtile; + +static bool __enum_xtile_config(void) +{ + u32 eax, ebx, ecx, edx; + u16 bytes_per_tile; + bool valid = false; + +#define TILE_CPUID 0x1d +#define TILE_PALETTE_CPUID_SUBLEAVE 0x1 + + eax = TILE_CPUID; + ecx = TILE_PALETTE_CPUID_SUBLEAVE; + + __cpuid(&eax, &ebx, &ecx, &edx); + if (!eax || !ebx || !ecx) + return valid; + + xtile.spec.max_names = ebx >> 16; + if (xtile.spec.max_names < NUM_TILES) + return valid; + + bytes_per_tile = eax >> 16; + if (bytes_per_tile < TILE_SIZE) + return valid; + + xtile.spec.bytes_per_row = ebx; + xtile.spec.max_rows = ecx; + valid = true; + + return valid; +} + +static bool __enum_xsave_tile(void) +{ + u32 eax, ebx, ecx, edx; + bool valid = false; + +#define XSTATE_CPUID 0xd +#define XSTATE_USER_STATE_SUBLEAVE 0x0 + + eax = XSTATE_CPUID; + ecx = XFEATURE_XTILE_DATA; + + __cpuid(&eax, &ebx, &ecx, &edx); + if (!eax || !ebx) + return valid; + + xtile.xsave.offset = ebx; + xtile.xsave.size = eax; + valid = true; + + return valid; +} + +static bool __check_xsave_size(void) +{ + u32 eax, ebx, ecx, edx; + bool valid = false; + + eax = XSTATE_CPUID; + ecx = XSTATE_USER_STATE_SUBLEAVE; + + __cpuid(&eax, &ebx, &ecx, &edx); + if (ebx && ebx <= XSAVE_SIZE) + valid = true; + + return valid; +} + +/* + * Check the hardware-provided tile state info and cross-check it with the + * hard-coded values: XSAVE_SIZE, NUM_TILES, and TILE_SIZE. + */ +static int check_xtile_hwinfo(void) +{ + bool success = false; + + if (!__check_xsave_size()) + return success; + + if (!__enum_xsave_tile()) + return success; + + if (!__enum_xtile_config()) + return success; + + if (sizeof(struct tile_data) >= xtile.xsave.size) + success = true; + + return success; +} + +/* The helpers for managing XSAVE area and tile states: */ + +/* Use the uncompacted format without 'init optimization' */ +static void save_xdata(void *data) +{ + __xsave(data, -1, -1); +} + +static void restore_xdata(void *data) +{ + __xrstor(data, -1, -1); +} + +static inline u64 __get_xsave_xstate_bv(void *data) +{ +#define XSAVE_HDR_OFFSET 512 + return *(u64 *)(data + XSAVE_HDR_OFFSET); +} + +static void set_tilecfg(struct tile_config *cfg) +{ + int i; + + memset(cfg, 0, sizeof(*cfg)); + /* The first implementation has one significant palette with id 1 */ + cfg->palette_id = 1; + for (i = 0; i < xtile.spec.max_names; i++) { + cfg->colsb[i] = xtile.spec.bytes_per_row; + cfg->rows[i] = xtile.spec.max_rows; + } +} + +static void load_tilecfg(struct tile_config *cfg) +{ + __ldtilecfg(cfg); +} + +static void make_tiles(void *tiles) +{ + u32 iterations = xtile.xsave.size / sizeof(u32); + static u32 value = 1; + u32 *ptr = tiles; + int i; + + for (i = 0, ptr = tiles; i < iterations; i++, ptr++) + *ptr = value; + value++; +} + +/* + * Initialize the XSAVE area: + * + * Make sure tile configuration loaded already. Load limited tile data (%tmm0 only) + * and save all the states. XSAVE area is ready to complete tile data. + */ +static void init_xdata(void *data) +{ + struct tile_data tiles; + + make_tiles(&tiles); + __tileloadd(&tiles); + __xsave(data, -1, -1); +} + +static inline void *__get_xsave_tile_data_addr(void *data) +{ + return data + xtile.xsave.offset; +} + +static void copy_tiles_to_xdata(void *xdata, void *tiles) +{ + void *dst = __get_xsave_tile_data_addr(xdata); + + memcpy(dst, tiles, xtile.xsave.size); +} + +static int compare_xdata_tiles(void *xdata, void *tiles) +{ + void *tile_data = __get_xsave_tile_data_addr(xdata); + + if (memcmp(tile_data, tiles, xtile.xsave.size)) + return 1; + + return 0; +} + +static int nerrs, errs; + +/* Testing tile data inheritance */ + +static void test_tile_data_inheritance(void) +{ + struct xsave_data xdata; + struct tile_data tiles; + struct tile_config cfg; + pid_t child; + int status; + + set_tilecfg(&cfg); + load_tilecfg(&cfg); + init_xdata(&xdata); + + make_tiles(&tiles); + copy_tiles_to_xdata(&xdata, &tiles); + restore_xdata(&xdata); + + errs = 0; + + child = fork(); + if (child < 0) + err(1, "fork"); + + if (child == 0) { + memset(&xdata, 0, sizeof(xdata)); + save_xdata(&xdata); + if (compare_xdata_tiles(&xdata, &tiles)) { + printf("[FAIL]\tchild failed to inherit tile data during fork()\n"); + nerrs++; + } else { + printf("[OK]\tchild inherited tile data during fork()\n"); + } + _exit(0); + } + wait(&status); +} + +static void test_fork(void) +{ + pid_t child; + int status; + + child = fork(); + if (child < 0) + err(1, "fork"); + + if (child == 0) { + test_tile_data_inheritance(); + _exit(0); + } + + wait(&status); +} + +/* Context switching test */ + +#define ITERATIONS 10 +#define NUM_THREADS 5 + +struct futex_info { + int current; + int next; + int *futex; +}; + +static inline void command_wait(struct futex_info *info, int value) +{ + do { + sched_yield(); + } while (syscall(SYS_futex, info->futex, FUTEX_WAIT, value, 0, 0, 0)); +} + +static inline void command_wake(struct futex_info *info, int value) +{ + do { + *info->futex = value; + while (!syscall(SYS_futex, info->futex, FUTEX_WAKE, 1, 0, 0, 0)) + sched_yield(); + } while (0); +} + +static inline int get_iterative_value(int id) +{ + return ((id << 1) & ~0x1); +} + +static inline int get_endpoint_value(int id) +{ + return ((id << 1) | 0x1); +} + +static void *check_tiles(void *info) +{ + struct futex_info *finfo = (struct futex_info *)info; + struct xsave_data xdata; + struct tile_data tiles; + struct tile_config cfg; + int i; + + set_tilecfg(&cfg); + load_tilecfg(&cfg); + init_xdata(&xdata); + + make_tiles(&tiles); + copy_tiles_to_xdata(&xdata, &tiles); + restore_xdata(&xdata); + + for (i = 0; i < ITERATIONS; i++) { + command_wait(finfo, get_iterative_value(finfo->current)); + + memset(&xdata, 0, sizeof(xdata)); + save_xdata(&xdata); + errs += compare_xdata_tiles(&xdata, &tiles); + + make_tiles(&tiles); + copy_tiles_to_xdata(&xdata, &tiles); + restore_xdata(&xdata); + + command_wake(finfo, get_iterative_value(finfo->next)); + } + + command_wait(finfo, get_endpoint_value(finfo->current)); + __tilerelease(); + return NULL; +} + +static int create_children(int num, struct futex_info *finfo) +{ + const int shm_id = shmget(IPC_PRIVATE, sizeof(int), IPC_CREAT | 0666); + int *futex = shmat(shm_id, NULL, 0); + pthread_t thread; + int i; + + for (i = 0; i < num; i++) { + finfo[i].futex = futex; + finfo[i].current = i + 1; + finfo[i].next = (i + 2) % (num + 1); + + if (pthread_create(&thread, NULL, check_tiles, &finfo[i])) { + err(1, "pthread_create"); + return 1; + } + } + return 0; +} + +static void test_context_switch(void) +{ + struct futex_info *finfo; + cpu_set_t cpuset; + int i; + + printf("[RUN]\t%u context switches of tile states in %d threads\n", + ITERATIONS * NUM_THREADS, NUM_THREADS); + + errs = 0; + + CPU_ZERO(&cpuset); + CPU_SET(0, &cpuset); + if (sched_setaffinity(0, sizeof(cpuset), &cpuset) != 0) + err(1, "sched_setaffinity to CPU 0"); + + finfo = malloc(sizeof(*finfo) * NUM_THREADS); + + if (create_children(NUM_THREADS, finfo)) + return; + + for (i = 0; i < ITERATIONS; i++) { + command_wake(finfo, get_iterative_value(1)); + command_wait(finfo, get_iterative_value(0)); + } + + for (i = 1; i <= NUM_THREADS; i++) + command_wake(finfo, get_endpoint_value(i)); + + if (errs) { + printf("[FAIL]\t%u incorrect tile states\n", errs); + nerrs += errs; + return; + } + + printf("[OK]\tall tile states are correct\n"); +} + +/* Ptrace test */ + +static inline long get_tile_state(pid_t child, struct iovec *iov) +{ + return ptrace(PTRACE_GETREGSET, child, (u32)NT_X86_XSTATE, iov); +} + +static inline long set_tile_state(pid_t child, struct iovec *iov) +{ + return ptrace(PTRACE_SETREGSET, child, (u32)NT_X86_XSTATE, iov); +} + +static int write_tile_state(bool load_tile, pid_t child) +{ + struct xsave_data xdata; + struct tile_data tiles; + struct iovec iov; + + iov.iov_base = &xdata; + iov.iov_len = sizeof(xdata); + + if (get_tile_state(child, &iov)) + err(1, "PTRACE_GETREGSET"); + + make_tiles(&tiles); + copy_tiles_to_xdata(&xdata, &tiles); + if (set_tile_state(child, &iov)) + err(1, "PTRACE_SETREGSET"); + + memset(&xdata, 0, sizeof(xdata)); + if (get_tile_state(child, &iov)) + err(1, "PTRACE_GETREGSET"); + + if (!load_tile) + memset(&tiles, 0, sizeof(tiles)); + + return compare_xdata_tiles(&xdata, &tiles); +} + +static void test_tile_state_write(bool load_tile) +{ + pid_t child; + int status; + + child = fork(); + if (child < 0) + err(1, "fork"); + + if (child == 0) { + printf("[RUN]\tPtrace-induced tile state write, "); + printf("%s tile data loaded\n", load_tile ? "with" : "without"); + + if (ptrace(PTRACE_TRACEME, 0, NULL, NULL)) + err(1, "PTRACE_TRACEME"); + + if (load_tile) { + struct tile_config cfg; + struct tile_data tiles; + + set_tilecfg(&cfg); + load_tilecfg(&cfg); + make_tiles(&tiles); + /* Load only %tmm0 but inducing the #NM */ + __tileloadd(&tiles); + } + + raise(SIGTRAP); + _exit(0); + } + + do { + wait(&status); + } while (WSTOPSIG(status) != SIGTRAP); + + errs = write_tile_state(load_tile, child); + if (errs) { + nerrs++; + printf("[FAIL]\t%s write\n", load_tile ? "incorrect" : "unexpected"); + } else { + printf("[OK]\t%s write\n", load_tile ? "correct" : "no"); + } + + ptrace(PTRACE_DETACH, child, NULL, NULL); + wait(&status); +} + +static void test_ptrace(void) +{ + bool ptracee_loads_tiles; + + ptracee_loads_tiles = true; + test_tile_state_write(ptracee_loads_tiles); + + ptracee_loads_tiles = false; + test_tile_state_write(ptracee_loads_tiles); +} + +/* Signal handling test */ + +static int sigtrapped; +struct tile_data sig_tiles, sighdl_tiles; + +static void sethandler(int sig, void (*handler)(int, siginfo_t *, void *), + int flags) +{ + struct sigaction sa; + + memset(&sa, 0, sizeof(sa)); + sa.sa_sigaction = handler; + sa.sa_flags = SA_SIGINFO | flags; + sigemptyset(&sa.sa_mask); + if (sigaction(sig, &sa, 0)) + err(1, "sigaction"); +} + +static void clearhandler(int sig) +{ + struct sigaction sa; + + memset(&sa, 0, sizeof(sa)); + sa.sa_handler = SIG_DFL; + sigemptyset(&sa.sa_mask); + if (sigaction(sig, &sa, 0)) + err(1, "sigaction"); +} + +static void sighandler(int sig, siginfo_t *info, void *ctx_void) +{ + ucontext_t *uctxt = (ucontext_t *)ctx_void; + struct xsave_data xdata; + struct tile_config cfg; + struct tile_data tiles; + u64 header; + + header = __get_xsave_xstate_bv((void *)uctxt->uc_mcontext.fpregs); + + if (header & (1 << XFEATURE_XTILE_DATA)) + printf("[FAIL]\ttile data was written in sigframe\n"); + else + printf("[OK]\ttile data was skipped in sigframe\n"); + + set_tilecfg(&cfg); + load_tilecfg(&cfg); + init_xdata(&xdata); + + make_tiles(&tiles); + copy_tiles_to_xdata(&xdata, &tiles); + restore_xdata(&xdata); + + save_xdata(&xdata); + if (compare_xdata_tiles(&xdata, &tiles)) + err(1, "tile load file"); + + printf("\tsignal handler: load tile data\n"); + + sigtrapped = sig; +} + +static void test_signal_handling(void) +{ + struct xsave_data xdata = { 0 }; + struct tile_data tiles = { 0 }; + + clearhandler(SIGTRAP); + sethandler(SIGTRAP, sighandler, 1); + sigtrapped = 0; + + printf("[RUN]\tCheck tile state management in handling signal\n"); + + printf("\tbefore signal: initial tile data state\n"); + + raise(SIGTRAP); + + if (sigtrapped == 0) + err(1, "sigtrap"); + + save_xdata(&xdata); + if (compare_xdata_tiles(&xdata, &tiles)) { + printf("[FAIL]\ttile data was not loaded at sigreturn\n"); + nerrs++; + } else { + printf("[OK]\ttile data was re-initialized at sigreturn\n"); + } +} + +int main(void) +{ + /* Check hardware availability at first */ + + if (!check_xsave_supports_xtile()) { + printf("\tTile state is not supported in the XSAVE.\n"); + return 0; + } + + if (!check_xtile_hwinfo()) { + printf("\tAvailable tile state size is insufficient to test.\n"); + return 0; + } + + nerrs = 0; + + test_fork(); + test_context_switch(); + test_ptrace(); + test_signal_handling(); + + return nerrs ? 1 : 0; +} -- 2.17.1

4 years, 9 months

1
0
0 0

[PATCH] kunit: tool: fix display of make errors

by Daniel Latypov

CalledProcessError stores the output of the failed process as `bytes`, not a `str`. So when we log it on build error, the make output is all crammed into one line with "\n" instead of actually printing new lines. After this change, we get readable output with new lines, e.g. > CC lib/kunit/kunit-example-test.o > In file included from ../lib/kunit/test.c:9: > ../include/kunit/test.h:22:1: error: unknown type name ‘invalid_type_that_causes_compile’ > 22 | invalid_type_that_causes_compile errors; > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > make[3]: *** [../scripts/Makefile.build:283: lib/kunit/test.o] Error 1 Secondly, trying to concat exceptions to strings will fail with > TypeError: can only concatenate str (not "OSError") to str so fix this with an explicit cast to str. Signed-off-by: Daniel Latypov <dlatypov(a)google.com> --- tools/testing/kunit/kunit_kernel.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tools/testing/kunit/kunit_kernel.py b/tools/testing/kunit/kunit_kernel.py index e20e2056cb38..0e19089f62f0 100644 --- a/tools/testing/kunit/kunit_kernel.py +++ b/tools/testing/kunit/kunit_kernel.py @@ -36,9 +36,9 @@ class LinuxSourceTreeOperations(object): try: subprocess.check_output(['make', 'mrproper'], stderr=subprocess.STDOUT) except OSError as e: - raise ConfigError('Could not call make command: ' + e) + raise ConfigError('Could not call make command: ' + str(e)) except subprocess.CalledProcessError as e: - raise ConfigError(e.output) + raise ConfigError(e.output.decode()) def make_olddefconfig(self, build_dir, make_options): command = ['make', 'ARCH=um', 'olddefconfig'] @@ -49,9 +49,9 @@ class LinuxSourceTreeOperations(object): try: subprocess.check_output(command, stderr=subprocess.STDOUT) except OSError as e: - raise ConfigError('Could not call make command: ' + e) + raise ConfigError('Could not call make command: ' + str(e)) except subprocess.CalledProcessError as e: - raise ConfigError(e.output) + raise ConfigError(e.output.decode()) def make_allyesconfig(self): kunit_parser.print_with_timestamp( @@ -79,9 +79,9 @@ class LinuxSourceTreeOperations(object): try: subprocess.check_output(command, stderr=subprocess.STDOUT) except OSError as e: - raise BuildError('Could not call execute make: ' + e) + raise BuildError('Could not call execute make: ' + str(e)) except subprocess.CalledProcessError as e: - raise BuildError(e.output) + raise BuildError(e.output.decode()) def linux_bin(self, params, timeout, build_dir, outfile): """Runs the Linux UML binary. Must be named 'linux'.""" base-commit: ccc1d052eff9f3cfe59d201263903fe1d46c79a5 -- 2.28.0.709.gb0816b6eb0-goog

4 years, 9 months

2
1
0 0

[PATCH bpf-next v2 4/4] selftest: bpf: Test copying a sockmap and sockhash

by Lorenz Bauer

Since we can now call map_update_elem(sockmap) from bpf_iter context it's possible to copy a sockmap or sockhash in the kernel. Add a selftest which exercises this. Signed-off-by: Lorenz Bauer <lmb(a)cloudflare.com> --- .../selftests/bpf/prog_tests/sockmap_basic.c | 14 +++++----- .../selftests/bpf/progs/bpf_iter_sockmap.c | 27 +++++++++++++++---- 2 files changed, 30 insertions(+), 11 deletions(-) diff --git a/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c b/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c index e8a4bfb4d9f4..854a508e81ce 100644 --- a/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c +++ b/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c @@ -194,7 +194,7 @@ static void test_sockmap_invalid_update(void) test_sockmap_invalid_update__destroy(skel); } -static void test_sockmap_iter(enum bpf_map_type map_type) +static void test_sockmap_copy(enum bpf_map_type map_type) { DECLARE_LIBBPF_OPTS(bpf_iter_attach_opts, opts); int err, len, src_fd, iter_fd, duration = 0; @@ -242,7 +242,7 @@ static void test_sockmap_iter(enum bpf_map_type map_type) linfo.map.map_fd = src_fd; opts.link_info = &linfo; opts.link_info_len = sizeof(linfo); - link = bpf_program__attach_iter(skel->progs.count_elems, &opts); + link = bpf_program__attach_iter(skel->progs.copy, &opts); if (CHECK(IS_ERR(link), "attach_iter", "attach_iter failed\n")) goto out; @@ -265,6 +265,8 @@ static void test_sockmap_iter(enum bpf_map_type map_type) skel->bss->socks, num_sockets)) goto close_iter; + compare_cookies(src, skel->maps.dst); + close_iter: close(iter_fd); free_link: @@ -294,8 +296,8 @@ void test_sockmap_basic(void) test_sockmap_update(BPF_MAP_TYPE_SOCKHASH); if (test__start_subtest("sockmap update in unsafe context")) test_sockmap_invalid_update(); - if (test__start_subtest("sockmap iter")) - test_sockmap_iter(BPF_MAP_TYPE_SOCKMAP); - if (test__start_subtest("sockhash iter")) - test_sockmap_iter(BPF_MAP_TYPE_SOCKHASH); + if (test__start_subtest("sockmap copy")) + test_sockmap_copy(BPF_MAP_TYPE_SOCKMAP); + if (test__start_subtest("sockhash copy")) + test_sockmap_copy(BPF_MAP_TYPE_SOCKHASH); } diff --git a/tools/testing/selftests/bpf/progs/bpf_iter_sockmap.c b/tools/testing/selftests/bpf/progs/bpf_iter_sockmap.c index 1af7555f6057..f3af0e30cead 100644 --- a/tools/testing/selftests/bpf/progs/bpf_iter_sockmap.c +++ b/tools/testing/selftests/bpf/progs/bpf_iter_sockmap.c @@ -22,21 +22,38 @@ struct { __type(value, __u64); } sockhash SEC(".maps"); +struct { + __uint(type, BPF_MAP_TYPE_SOCKHASH); + __uint(max_entries, 64); + __type(key, __u32); + __type(value, __u64); +} dst SEC(".maps"); + __u32 elems = 0; __u32 socks = 0; SEC("iter/sockmap") -int count_elems(struct bpf_iter__sockmap *ctx) +int copy(struct bpf_iter__sockmap *ctx) { struct sock *sk = ctx->sk; __u32 tmp, *key = ctx->key; int ret; - if (key) - elems++; + if (!key) + return 0; - if (sk) + elems++; + + /* We need a temporary buffer on the stack, since the verifier doesn't + * let us use the pointer from the context as an argument to the helper. + */ + tmp = *key; + + if (sk) { socks++; + return bpf_map_update_elem(&dst, &tmp, sk, 0) != 0; + } - return 0; + ret = bpf_map_delete_elem(&dst, &tmp); + return ret && ret != -ENOENT; } -- 2.25.1

4 years, 9 months

2
4
0 0

[PATCH bpf-next v3 0/6] bpf: BTF support for ksyms

by Hao Luo

v2 -> v3: - Rename functions and variables in verifier for better readability. - Stick to logging message convention in libbpf. - Move bpf_per_cpu_ptr and bpf_this_cpu_ptr from trace-specific helper set to base helper set. - More specific test in ksyms_btf. - Fix return type cast in bpf_*_cpu_ptr. - Fix btf leak in ksyms_btf selftest. - Fix return error code for kallsyms_find(). v1 -> v2: - Move check_pseudo_btf_id from check_ld_imm() to replace_map_fd_with_map_ptr() and rename the latter. - Add bpf_this_cpu_ptr(). - Use bpf_core_types_are_compat() in libbpf.c for checking type compatibility. - Rewrite typed ksym extern type in BTF with int to save space. - Minor revision of bpf_per_cpu_ptr()'s comments. - Avoid using long in tests that use skeleton. - Refactored test_ksyms.c by moving kallsyms_find() to trace_helpers.c - Fold the patches that sync include/linux/uapi and tools/include/linux/uapi. rfc -> v1: - Encode VAR's btf_id for PSEUDO_BTF_ID. - More checks in verifier. Checking the btf_id passed as PSEUDO_BTF_ID is valid VAR, its name and type. - Checks in libbpf on type compatibility of ksyms. - Add bpf_per_cpu_ptr() to access kernel percpu vars. Introduced new ARG and RET types for this helper. This patch series extends the previously added __ksym externs with btf support. Right now the __ksym externs are treated as pure 64-bit scalar value. Libbpf replaces ld_imm64 insn of __ksym by its kernel address at load time. This patch series extend those externs with their btf info. Note that btf support for __ksym must come with the kernel btf that has VARs encoded to work properly. The corresponding chagnes in pahole is available at [1] (with a fix at [2] for gcc 4.9+). The first 3 patches in this series add support for general kernel global variables, which include verifier checking (01/06), libpf support (02/06) and selftests for getting typed ksym extern's kernel address (03/06). The next 3 patches extends that capability further by introducing helpers bpf_per_cpu_ptr() and bpf_this_cpu_ptr(), which allows accessing kernel percpu variables correctly (04/06 and 05/06). The tests of this feature were performed against pahole that is extended with [1] and [2]. For kernel BTF that does not have VARs encoded, the selftests will be skipped. [1] https://git.kernel.org/pub/scm/devel/pahole/pahole.git/commit/?id=f3d9054ba… [2] https://www.spinics.net/lists/dwarves/msg00451.html Hao Luo (6): bpf: Introduce pseudo_btf_id bpf/libbpf: BTF support for typed ksyms selftests/bpf: ksyms_btf to test typed ksyms bpf: Introduce bpf_per_cpu_ptr() bpf: Introduce bpf_this_cpu_ptr() bpf/selftests: Test for bpf_per_cpu_ptr() and bpf_this_cpu_ptr() include/linux/bpf.h | 6 + include/linux/bpf_verifier.h | 7 + include/linux/btf.h | 26 +++ include/uapi/linux/bpf.h | 67 +++++- kernel/bpf/btf.c | 25 --- kernel/bpf/helpers.c | 32 +++ kernel/bpf/verifier.c | 190 ++++++++++++++++-- kernel/trace/bpf_trace.c | 4 + tools/include/uapi/linux/bpf.h | 67 +++++- tools/lib/bpf/libbpf.c | 112 +++++++++-- .../testing/selftests/bpf/prog_tests/ksyms.c | 38 ++-- .../selftests/bpf/prog_tests/ksyms_btf.c | 88 ++++++++ .../selftests/bpf/progs/test_ksyms_btf.c | 55 +++++ tools/testing/selftests/bpf/trace_helpers.c | 27 +++ tools/testing/selftests/bpf/trace_helpers.h | 4 + 15 files changed, 653 insertions(+), 95 deletions(-) create mode 100644 tools/testing/selftests/bpf/prog_tests/ksyms_btf.c create mode 100644 tools/testing/selftests/bpf/progs/test_ksyms_btf.c -- 2.28.0.618.gf4bc123cb7-goog

4 years, 9 months

3
15
0 0

[RFC PATCH 4/4] selftest/x86/signal: Include test cases for validating sigaltstack

by Chang S. Bae

The test measures the kernel's signal delivery with different (enough vs. insufficient) stack sizes. Signed-off-by: Chang S. Bae <chang.seok.bae(a)intel.com> Reviewed-by: Len Brown <len.brown(a)intel.com> Cc: x86(a)kernel.org Cc: linux-kselftest(a)vger.kernel.org Cc: linux-kernel(a)vger.kernel.org --- tools/testing/selftests/x86/Makefile | 2 +- tools/testing/selftests/x86/sigaltstack.c | 126 ++++++++++++++++++++++ 2 files changed, 127 insertions(+), 1 deletion(-) create mode 100644 tools/testing/selftests/x86/sigaltstack.c diff --git a/tools/testing/selftests/x86/Makefile b/tools/testing/selftests/x86/Makefile index 6703c7906b71..e0c52e5ab49e 100644 --- a/tools/testing/selftests/x86/Makefile +++ b/tools/testing/selftests/x86/Makefile @@ -13,7 +13,7 @@ CAN_BUILD_WITH_NOPIE := $(shell ./check_cc.sh $(CC) trivial_program.c -no-pie) TARGETS_C_BOTHBITS := single_step_syscall sysret_ss_attrs syscall_nt test_mremap_vdso \ check_initial_reg_state sigreturn iopl ioperm \ test_vdso test_vsyscall mov_ss_trap \ - syscall_arg_fault fsgsbase_restore + syscall_arg_fault fsgsbase_restore sigaltstack TARGETS_C_32BIT_ONLY := entry_from_vm86 test_syscall_vdso unwind_vdso \ test_FCMOV test_FCOMI test_FISTTP \ vdso_restorer diff --git a/tools/testing/selftests/x86/sigaltstack.c b/tools/testing/selftests/x86/sigaltstack.c new file mode 100644 index 000000000000..353679df6901 --- /dev/null +++ b/tools/testing/selftests/x86/sigaltstack.c @@ -0,0 +1,126 @@ +// SPDX-License-Identifier: GPL-2.0-only + +#define _GNU_SOURCE +#include <signal.h> +#include <stdio.h> +#include <stdbool.h> +#include <string.h> +#include <err.h> +#include <errno.h> +#include <limits.h> +#include <sys/mman.h> +#include <sys/auxv.h> +#include <sys/prctl.h> +#include <sys/resource.h> +#include <setjmp.h> + +/* sigaltstack()-enforced minimum stack */ +#define ENFORCED_MINSIGSTKSZ 2048 + +#ifndef AT_MINSIGSTKSZ +# define AT_MINSIGSTKSZ 51 +#endif + +static int nerrs; + +static bool sigalrm_expected; + +static unsigned long at_minstack_size; + +static void sethandler(int sig, void (*handler)(int, siginfo_t *, void *), + int flags) +{ + struct sigaction sa; + + memset(&sa, 0, sizeof(sa)); + sa.sa_sigaction = handler; + sa.sa_flags = SA_SIGINFO | flags; + sigemptyset(&sa.sa_mask); + if (sigaction(sig, &sa, 0)) + err(1, "sigaction"); +} + +static void clearhandler(int sig) +{ + struct sigaction sa; + + memset(&sa, 0, sizeof(sa)); + sa.sa_handler = SIG_DFL; + sigemptyset(&sa.sa_mask); + if (sigaction(sig, &sa, 0)) + err(1, "sigaction"); +} + +static int setup_altstack(void *start, unsigned long size) +{ + stack_t ss; + + memset(&ss, 0, sizeof(ss)); + ss.ss_size = size; + ss.ss_sp = start; + + return sigaltstack(&ss, NULL); +} + +static jmp_buf jmpbuf; + +static void sigsegv(int sig, siginfo_t *info, void *ctx_void) +{ + if (sigalrm_expected) { + printf("[FAIL]\tSIGSEGV signal delivered.\n"); + nerrs++; + } else { + printf("[OK]\tSIGSEGV signal expectedly delivered.\n"); + } + + siglongjmp(jmpbuf, 1); +} + +static void sigalrm(int sig, siginfo_t *info, void *ctx_void) +{ + if (!sigalrm_expected) { + printf("[FAIL]\tSIGALRM sigal delivered.\n"); + nerrs++; + } else { + printf("[OK]\tSIGALRM signal expectedly delivered.\n"); + } +} + +static void test_sigaltstack(void *altstack, unsigned long size) +{ + if (setup_altstack(altstack, size)) + err(1, "sigaltstack()"); + + sigalrm_expected = (size > at_minstack_size) ? true : false; + + sethandler(SIGSEGV, sigsegv, 0); + sethandler(SIGALRM, sigalrm, SA_ONSTACK); + + if (sigsetjmp(jmpbuf, 1) == 0) { + printf("[RUN]\tTest an %s sigaltstack\n", + sigalrm_expected ? "enough" : "insufficient"); + raise(SIGALRM); + } + + clearhandler(SIGALRM); + clearhandler(SIGSEGV); +} + +int main(void) +{ + void *altstack; + + at_minstack_size = getauxval(AT_MINSIGSTKSZ); + + altstack = mmap(NULL, at_minstack_size + SIGSTKSZ, PROT_READ | PROT_WRITE, + MAP_PRIVATE | MAP_ANONYMOUS | MAP_STACK, -1, 0); + if (altstack == MAP_FAILED) + err(1, "mmap()"); + + if ((ENFORCED_MINSIGSTKSZ + 1) < at_minstack_size) + test_sigaltstack(altstack, ENFORCED_MINSIGSTKSZ + 1); + + test_sigaltstack(altstack, at_minstack_size + SIGSTKSZ); + + return nerrs == 0 ? 0 : 1; +} -- 2.17.1

4 years, 9 months

1
0
0 0

[PATCH 0/8] selftests/vm: gup_test, hmm-tests, assorted improvements

by John Hubbard

This is based on the latest mmotm. Summary: This series provides two main things, and a number of smaller supporting goodies. The two main points are: 1) Add a new sub-test to gup_test, which in turn is a renamed version of gup_benchmark. This sub-test allows nicer testing of dump_pages(), at least on user-space pages. For quite a while, I was doing a quick hack to gup_test.c whenever I wanted to try out changes to dump_page(). Then Matthew Wilcox asked me what I meant when I said "I used my dump_page() unit test", and I realized that it might be nice to check in a polished up version of that. Details about how it works and how to use it are in the commit description for patch #6. 2) Fixes a limitation of hmm-tests: these tests are incredibly useful, but only if people actually build and run them. And it turns out that libhugetlbfs is a little too effective at throwing a wrench in the works, there. So I've added a little configuration check that removes just two of the 21 hmm-tests, if libhugetlbfs is not available. Further details in the commit description of patch #8. Other smaller things that this series does: a) Remove code duplication by creating gup_test.h. b) Clear up the sub-test organization, and their invocation within run_vmtests.sh. c) Other minor assorted improvements. John Hubbard (8): mm/gup_benchmark: rename to mm/gup_test selftests/vm: use a common gup_test.h selftests/vm: rename run_vmtests --> run_vmtests.sh selftests/vm: minor cleanup: Makefile and gup_test.c selftests/vm: only some gup_test items are really benchmarks selftests/vm: gup_test: introduce the dump_pages() sub-test selftests/vm: run_vmtest.sh: update and clean up gup_test invocation selftests/vm: hmm-tests: remove the libhugetlbfs dependency Documentation/core-api/pin_user_pages.rst | 6 +- arch/s390/configs/debug_defconfig | 2 +- arch/s390/configs/defconfig | 2 +- mm/Kconfig | 21 +- mm/Makefile | 2 +- mm/{gup_benchmark.c => gup_test.c} | 109 ++++++---- mm/gup_test.h | 32 +++ tools/testing/selftests/vm/.gitignore | 3 +- tools/testing/selftests/vm/Makefile | 38 +++- tools/testing/selftests/vm/check_config.sh | 30 +++ tools/testing/selftests/vm/config | 2 +- tools/testing/selftests/vm/gup_benchmark.c | 137 ------------- tools/testing/selftests/vm/gup_test.c | 188 ++++++++++++++++++ tools/testing/selftests/vm/hmm-tests.c | 10 +- .../vm/{run_vmtests => run_vmtest.sh} | 24 ++- 15 files changed, 403 insertions(+), 203 deletions(-) rename mm/{gup_benchmark.c => gup_test.c} (59%) create mode 100644 mm/gup_test.h create mode 100755 tools/testing/selftests/vm/check_config.sh delete mode 100644 tools/testing/selftests/vm/gup_benchmark.c create mode 100644 tools/testing/selftests/vm/gup_test.c rename tools/testing/selftests/vm/{run_vmtests => run_vmtest.sh} (91%) -- 2.28.0

4 years, 9 months

4
27
0 0

Re: [patch 00/13] preempt: Make preempt count unconditional

by Thomas Gleixner

On Mon, Sep 14 2020 at 15:24, Linus Torvalds wrote: > On Mon, Sep 14, 2020 at 2:55 PM Thomas Gleixner <tglx(a)linutronix.de> wrote: >> >> Yes it does generate better code, but I tried hard to spot a difference >> in various metrics exposed by perf. It's all in the noise and I only >> can spot a difference when the actual preemption check after the >> decrement > > I'm somewhat more worried about the small-device case. I just checked on one of my old UP ARM toys which I run at home. The .text increase is about 2% (75k) and none of the tests I ran showed any significant difference. Couldn't verify with perf though as the PMU on that piece of art is unusable. > That said, the diffstat certainly has its very clear charm, and I do > agree that it makes things simpler. > > I'm just not convinced people should ever EVER do things like that "if > (preemptible())" garbage. It sounds like somebody is doing seriously > bad things. OTOH, having a working 'preemptible()' or maybe better named 'can_schedule()' check makes tons of sense to make decisions about allocation modes or other things. We're currently looking through all of in_atomic(), in_interrupt() etc. usage sites and quite some of them are historic and have the clear intent of checking whether the code is called from task context or hard/softirq context. Lots of them are completely broken or just work by chance. But there is clearly historic precendence that context checks are useful, but they only can be useful if we have a consistent mechanism which works everywhere. Of course we could mandate that every interface which might be called from one or the other context has a context argument or provides two variants of the same thing. But I'm not really convinced whether that's a win over having a consistent and reliable set of checks. Thanks, tglx

4 years, 9 months

6
17
0 0

[PATCH bpf-next v3 4/4] selftest: bpf: Test copying a sockmap and sockhash

by Lorenz Bauer

Since we can now call map_update_elem(sockmap) from bpf_iter context it's possible to copy a sockmap or sockhash in the kernel. Add a selftest which exercises this. Signed-off-by: Lorenz Bauer <lmb(a)cloudflare.com> --- .../selftests/bpf/prog_tests/sockmap_basic.c | 14 +++++----- .../selftests/bpf/progs/bpf_iter_sockmap.c | 27 +++++++++++++++---- 2 files changed, 30 insertions(+), 11 deletions(-) diff --git a/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c b/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c index 316c4e271b36..4c4224e3e10a 100644 --- a/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c +++ b/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c @@ -194,7 +194,7 @@ static void test_sockmap_invalid_update(void) test_sockmap_invalid_update__destroy(skel); } -static void test_sockmap_iter(enum bpf_map_type map_type) +static void test_sockmap_copy(enum bpf_map_type map_type) { DECLARE_LIBBPF_OPTS(bpf_iter_attach_opts, opts); int err, len, src_fd, iter_fd, duration = 0; @@ -242,7 +242,7 @@ static void test_sockmap_iter(enum bpf_map_type map_type) linfo.map.map_fd = src_fd; opts.link_info = &linfo; opts.link_info_len = sizeof(linfo); - link = bpf_program__attach_iter(skel->progs.count_elems, &opts); + link = bpf_program__attach_iter(skel->progs.copy, &opts); if (CHECK(IS_ERR(link), "attach_iter", "attach_iter failed\n")) goto out; @@ -265,6 +265,8 @@ static void test_sockmap_iter(enum bpf_map_type map_type) skel->bss->socks, num_sockets)) goto close_iter; + compare_cookies(src, skel->maps.dst); + close_iter: close(iter_fd); free_link: @@ -294,8 +296,8 @@ void test_sockmap_basic(void) test_sockmap_update(BPF_MAP_TYPE_SOCKHASH); if (test__start_subtest("sockmap update in unsafe context")) test_sockmap_invalid_update(); - if (test__start_subtest("sockmap iter")) - test_sockmap_iter(BPF_MAP_TYPE_SOCKMAP); - if (test__start_subtest("sockhash iter")) - test_sockmap_iter(BPF_MAP_TYPE_SOCKHASH); + if (test__start_subtest("sockmap copy")) + test_sockmap_copy(BPF_MAP_TYPE_SOCKMAP); + if (test__start_subtest("sockhash copy")) + test_sockmap_copy(BPF_MAP_TYPE_SOCKHASH); } diff --git a/tools/testing/selftests/bpf/progs/bpf_iter_sockmap.c b/tools/testing/selftests/bpf/progs/bpf_iter_sockmap.c index 1af7555f6057..f3af0e30cead 100644 --- a/tools/testing/selftests/bpf/progs/bpf_iter_sockmap.c +++ b/tools/testing/selftests/bpf/progs/bpf_iter_sockmap.c @@ -22,21 +22,38 @@ struct { __type(value, __u64); } sockhash SEC(".maps"); +struct { + __uint(type, BPF_MAP_TYPE_SOCKHASH); + __uint(max_entries, 64); + __type(key, __u32); + __type(value, __u64); +} dst SEC(".maps"); + __u32 elems = 0; __u32 socks = 0; SEC("iter/sockmap") -int count_elems(struct bpf_iter__sockmap *ctx) +int copy(struct bpf_iter__sockmap *ctx) { struct sock *sk = ctx->sk; __u32 tmp, *key = ctx->key; int ret; - if (key) - elems++; + if (!key) + return 0; - if (sk) + elems++; + + /* We need a temporary buffer on the stack, since the verifier doesn't + * let us use the pointer from the context as an argument to the helper. + */ + tmp = *key; + + if (sk) { socks++; + return bpf_map_update_elem(&dst, &tmp, sk, 0) != 0; + } - return 0; + ret = bpf_map_delete_elem(&dst, &tmp); + return ret && ret != -ENOENT; } -- 2.25.1

4 years, 9 months

1
0
0 0

[PATCH bpf-next v3 3/4] selftests: bpf: remove shared header from sockmap iter test

by Lorenz Bauer

The shared header to define SOCKMAP_MAX_ENTRIES is a bit overkill. Dynamically allocate the sock_fd array based on bpf_map__max_entries instead. Suggested-by: Yonghong Song <yhs(a)fb.com> Signed-off-by: Lorenz Bauer <lmb(a)cloudflare.com> Acked-by: Yonghong Song <yhs(a)fb.com> --- .../selftests/bpf/prog_tests/sockmap_basic.c | 36 +++++++++---------- .../selftests/bpf/progs/bpf_iter_sockmap.c | 5 ++- .../selftests/bpf/progs/bpf_iter_sockmap.h | 3 -- 3 files changed, 20 insertions(+), 24 deletions(-) delete mode 100644 tools/testing/selftests/bpf/progs/bpf_iter_sockmap.h diff --git a/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c b/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c index 3596d3f3039f..316c4e271b36 100644 --- a/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c +++ b/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c @@ -8,8 +8,6 @@ #include "test_sockmap_invalid_update.skel.h" #include "bpf_iter_sockmap.skel.h" -#include "progs/bpf_iter_sockmap.h" - #define TCP_REPAIR 19 /* TCP sock is under repair right now */ #define TCP_REPAIR_ON 1 @@ -201,9 +199,9 @@ static void test_sockmap_iter(enum bpf_map_type map_type) DECLARE_LIBBPF_OPTS(bpf_iter_attach_opts, opts); int err, len, src_fd, iter_fd, duration = 0; union bpf_iter_link_info linfo = {0}; - __s64 sock_fd[SOCKMAP_MAX_ENTRIES]; - __u32 i, num_sockets, max_elems; + __u32 i, num_sockets, num_elems; struct bpf_iter_sockmap *skel; + __s64 *sock_fd = NULL; struct bpf_link *link; struct bpf_map *src; char buf[64]; @@ -212,22 +210,23 @@ static void test_sockmap_iter(enum bpf_map_type map_type) if (CHECK(!skel, "bpf_iter_sockmap__open_and_load", "skeleton open_and_load failed\n")) return; - for (i = 0; i < ARRAY_SIZE(sock_fd); i++) - sock_fd[i] = -1; - - /* Make sure we have at least one "empty" entry to test iteration of - * an empty slot. - */ - num_sockets = ARRAY_SIZE(sock_fd) - 1; - if (map_type == BPF_MAP_TYPE_SOCKMAP) { src = skel->maps.sockmap; - max_elems = bpf_map__max_entries(src); + num_elems = bpf_map__max_entries(src); + num_sockets = num_elems - 1; } else { src = skel->maps.sockhash; - max_elems = num_sockets; + num_elems = bpf_map__max_entries(src) - 1; + num_sockets = num_elems; } + sock_fd = calloc(num_sockets, sizeof(*sock_fd)); + if (CHECK(!sock_fd, "calloc(sock_fd)", "failed to allocate\n")) + goto out; + + for (i = 0; i < num_sockets; i++) + sock_fd[i] = -1; + src_fd = bpf_map__fd(src); for (i = 0; i < num_sockets; i++) { @@ -258,8 +257,8 @@ static void test_sockmap_iter(enum bpf_map_type map_type) goto close_iter; /* test results */ - if (CHECK(skel->bss->elems != max_elems, "elems", "got %u expected %u\n", - skel->bss->elems, max_elems)) + if (CHECK(skel->bss->elems != num_elems, "elems", "got %u expected %u\n", + skel->bss->elems, num_elems)) goto close_iter; if (CHECK(skel->bss->socks != num_sockets, "socks", "got %u expected %u\n", @@ -271,10 +270,11 @@ static void test_sockmap_iter(enum bpf_map_type map_type) free_link: bpf_link__destroy(link); out: - for (i = 0; i < num_sockets; i++) { + for (i = 0; sock_fd && i < num_sockets; i++) if (sock_fd[i] >= 0) close(sock_fd[i]); - } + if (sock_fd) + free(sock_fd); bpf_iter_sockmap__destroy(skel); } diff --git a/tools/testing/selftests/bpf/progs/bpf_iter_sockmap.c b/tools/testing/selftests/bpf/progs/bpf_iter_sockmap.c index 0e27f73dd803..1af7555f6057 100644 --- a/tools/testing/selftests/bpf/progs/bpf_iter_sockmap.c +++ b/tools/testing/selftests/bpf/progs/bpf_iter_sockmap.c @@ -2,7 +2,6 @@ /* Copyright (c) 2020 Cloudflare */ #include "bpf_iter.h" #include "bpf_tracing_net.h" -#include "bpf_iter_sockmap.h" #include <bpf/bpf_helpers.h> #include <bpf/bpf_tracing.h> #include <errno.h> @@ -11,14 +10,14 @@ char _license[] SEC("license") = "GPL"; struct { __uint(type, BPF_MAP_TYPE_SOCKMAP); - __uint(max_entries, SOCKMAP_MAX_ENTRIES); + __uint(max_entries, 64); __type(key, __u32); __type(value, __u64); } sockmap SEC(".maps"); struct { __uint(type, BPF_MAP_TYPE_SOCKHASH); - __uint(max_entries, SOCKMAP_MAX_ENTRIES); + __uint(max_entries, 64); __type(key, __u32); __type(value, __u64); } sockhash SEC(".maps"); diff --git a/tools/testing/selftests/bpf/progs/bpf_iter_sockmap.h b/tools/testing/selftests/bpf/progs/bpf_iter_sockmap.h deleted file mode 100644 index 35a675d13c0f..000000000000 --- a/tools/testing/selftests/bpf/progs/bpf_iter_sockmap.h +++ /dev/null @@ -1,3 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0 */ - -#define SOCKMAP_MAX_ENTRIES (64) -- 2.25.1

4 years, 9 months

1
0
0 0

[PATCH bpf-next v3 2/4] selftests: bpf: Add helper to compare socket cookies

by Lorenz Bauer

We compare socket cookies to ensure that insertion into a sockmap worked. Pull this out into a helper function for use in other tests. Signed-off-by: Lorenz Bauer <lmb(a)cloudflare.com> --- .../selftests/bpf/prog_tests/sockmap_basic.c | 50 +++++++++++++------ 1 file changed, 36 insertions(+), 14 deletions(-) diff --git a/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c b/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c index 4b7a527e7e82..3596d3f3039f 100644 --- a/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c +++ b/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c @@ -50,6 +50,37 @@ static int connected_socket_v4(void) return -1; } +static void compare_cookies(struct bpf_map *src, struct bpf_map *dst) +{ + __u32 i, max_entries = bpf_map__max_entries(src); + int err, duration = 0, src_fd, dst_fd; + + src_fd = bpf_map__fd(src); + dst_fd = bpf_map__fd(dst); + + for (i = 0; i < max_entries; i++) { + __u64 src_cookie, dst_cookie; + + err = bpf_map_lookup_elem(src_fd, &i, &src_cookie); + if (err && errno == ENOENT) { + err = bpf_map_lookup_elem(dst_fd, &i, &dst_cookie); + CHECK(!err, "map_lookup_elem(dst)", "element %u not deleted\n", i); + CHECK(err && errno != ENOENT, "map_lookup_elem(dst)", "%s\n", + strerror(errno)); + continue; + } + if (CHECK(err, "lookup_elem(src)", "%s\n", strerror(errno))) + continue; + + err = bpf_map_lookup_elem(dst_fd, &i, &dst_cookie); + if (CHECK(err, "lookup_elem(dst)", "%s\n", strerror(errno))) + continue; + + CHECK(dst_cookie != src_cookie, "cookie mismatch", + "%llu != %llu (pos %u)\n", dst_cookie, src_cookie, i); + } +} + /* Create a map, populate it with one socket, and free the map. */ static void test_sockmap_create_update_free(enum bpf_map_type map_type) { @@ -109,9 +140,9 @@ static void test_skmsg_helpers(enum bpf_map_type map_type) static void test_sockmap_update(enum bpf_map_type map_type) { struct bpf_prog_test_run_attr tattr; - int err, prog, src, dst, duration = 0; + int err, prog, src, duration = 0; struct test_sockmap_update *skel; - __u64 src_cookie, dst_cookie; + struct bpf_map *dst_map; const __u32 zero = 0; char dummy[14] = {0}; __s64 sk; @@ -127,18 +158,14 @@ static void test_sockmap_update(enum bpf_map_type map_type) prog = bpf_program__fd(skel->progs.copy_sock_map); src = bpf_map__fd(skel->maps.src); if (map_type == BPF_MAP_TYPE_SOCKMAP) - dst = bpf_map__fd(skel->maps.dst_sock_map); + dst_map = skel->maps.dst_sock_map; else - dst = bpf_map__fd(skel->maps.dst_sock_hash); + dst_map = skel->maps.dst_sock_hash; err = bpf_map_update_elem(src, &zero, &sk, BPF_NOEXIST); if (CHECK(err, "update_elem(src)", "errno=%u\n", errno)) goto out; - err = bpf_map_lookup_elem(src, &zero, &src_cookie); - if (CHECK(err, "lookup_elem(src, cookie)", "errno=%u\n", errno)) - goto out; - tattr = (struct bpf_prog_test_run_attr){ .prog_fd = prog, .repeat = 1, @@ -151,12 +178,7 @@ static void test_sockmap_update(enum bpf_map_type map_type) "errno=%u retval=%u\n", errno, tattr.retval)) goto out; - err = bpf_map_lookup_elem(dst, &zero, &dst_cookie); - if (CHECK(err, "lookup_elem(dst, cookie)", "errno=%u\n", errno)) - goto out; - - CHECK(dst_cookie != src_cookie, "cookie mismatch", "%llu != %llu\n", - dst_cookie, src_cookie); + compare_cookies(skel->maps.src, dst_map); out: test_sockmap_update__destroy(skel); -- 2.25.1

4 years, 9 months

1
0
0 0

[PATCH v7 bpf-next 0/8] bpf: add helpers to support BTF-based kernel data display

by Alan Maguire

This series attempts to provide a simple way for BPF programs (and in future other consumers) to utilize BPF Type Format (BTF) information to display kernel data structures in-kernel. The use case this functionality is applied to here is to support a snprintf()-like helper to copy a BTF representation of kernel data to a string, and a BPF seq file helper to display BTF data for an iterator. There is already support in kernel/bpf/btf.c for "show" functionality; the changes here generalize that support from seq-file specific verifier display to the more generic case and add another specific use case; rather than seq_printf()ing the show data, it is copied to a supplied string using a snprintf()-like function. Other future consumers of the show functionality could include a bpf_printk_btf() function which printk()ed the data instead. Oops messaging in particular would be an interesting application for such functionality. The above potential use case hints at a potential reply to a reasonable objection that such typed display should be solved by tracing programs, where the in-kernel tracing records data and the userspace program prints it out. While this is certainly the recommended approach for most cases, I believe having an in-kernel mechanism would be valuable also. Critically in BPF programs it greatly simplifies debugging and tracing of such data to invoking a simple helper. One challenge raised in an earlier iteration of this work - where the BTF printing was implemented as a printk() format specifier - was that the amount of data printed per printk() was large, and other format specifiers were far simpler. Here we sidestep that concern by printing components of the BTF representation as we go for the seq file case, and in the string case the snprintf()-like operation is intended to be a basis for perf event or ringbuf output. The reasons for avoiding bpf_trace_printk are that 1. bpf_trace_printk() strings are restricted in size and cannot display anything beyond trivial data structures; and 2. bpf_trace_printk() is for debugging purposes only. As Alexei suggested, a bpf_trace_puts() helper could solve this in the future but it still would be limited by the 1000 byte limit for traced strings. Default output for an sk_buff looks like this (zeroed fields are omitted): (struct sk_buff){ .transport_header = (__u16)65535, .mac_header = (__u16)65535, .end = (sk_buff_data_t)192, .head = (unsigned char *)0x000000007524fd8b, .data = (unsigned char *)0x000000007524fd8b, .truesize = (unsigned int)768, .users = (refcount_t){ .refs = (atomic_t){ .counter = (int)1, }, }, } Flags can modify aspects of output format; see patch 3 for more details. Changes since v6: - Updated safe data size to 32, object name size to 80. This increases the number of safe copies done, but performance is not a key goal here. WRT name size the largest type name length in bpf-next according to "pahole -s" is 64 bytes, so that still gives room for additional type qualifiers, parens etc within the name limit (Alexei, patch 2) - Remove inlines and converted as many #defines to functions as was possible. In a few cases - btf_show_type_value[s]() specifically - I left these as macros as btf_show_type_value[s]() prepends and appends format strings to the format specifier (in order to include indentation, delimiters etc so a macro makes that simpler (Alexei, patch 2) - Handle btf_resolve_size() error in btf_show_obj_safe() (Alexei, patch 2) - Removed clang loop unroll in BTF snprintf test (Alexei) - switched to using bpf_core_type_id_kernel(type) as suggested by Andrii, and Alexei noted that __builtin_btf_type_id(,1) should be used (patch 4) - Added skip logic if __builtin_btf_type_id is not available (patches 4,8) - Bumped limits on bpf iters to support printing larger structures (Alexei, patch 5) - Updated overflow bpf_iter tests to reflect new iter max size (patch 6) - Updated seq helper to use type id only (Alexei, patch 7) - Updated BTF task iter test to use task struct instead of struct fs_struct since new limits allow a task_struct to be displayed (patch 8) - Fixed E2BIG handling in iter task (Alexei, patch 8) Changes since v5: - Moved btf print prepare into patch 3, type show seq with flags into patch 2 (Alexei, patches 2,3) - Fixed build bot warnings around static declarations and printf attributes - Renamed functions to snprintf_btf/seq_printf_btf (Alexei, patches 3-6) Changes since v4: - Changed approach from a BPF trace event-centric design to one utilizing a snprintf()-like helper and an iter helper (Alexei, patches 3,5) - Added tests to verify BTF output (patch 4) - Added support to tests for verifying BTF type_id-based display as well as type name via __builtin_btf_type_id (Andrii, patch 4). - Augmented task iter tests to cover the BTF-based seq helper. Because a task_struct's BTF-based representation would overflow the PAGE_SIZE limit on iterator data, the "struct fs_struct" (task->fs) is displayed for each task instead (Alexei, patch 6). Changes since v3: - Moved to RFC since the approach is different (and bpf-next is closed) - Rather than using a printk() format specifier as the means of invoking BTF-enabled display, a dedicated BPF helper is used. This solves the issue of printk() having to output large amounts of data using a complex mechanism such as BTF traversal, but still provides a way for the display of such data to be achieved via BPF programs. Future work could include a bpf_printk_btf() function to invoke display via printk() where the elements of a data structure are printk()ed one at a time. Thanks to Petr Mladek, Andy Shevchenko and Rasmus Villemoes who took time to look at the earlier printk() format-specifier-focused version of this and provided feedback clarifying the problems with that approach. - Added trace id to the bpf_trace_printk events as a means of separating output from standard bpf_trace_printk() events, ensuring it can be easily parsed by the reader. - Added bpf_trace_btf() helper tests which do simple verification of the various display options. Changes since v2: - Alexei and Yonghong suggested it would be good to use probe_kernel_read() on to-be-shown data to ensure safety during operation. Safe copy via probe_kernel_read() to a buffer object in "struct btf_show" is used to support this. A few different approaches were explored including dynamic allocation and per-cpu buffers. The downside of dynamic allocation is that it would be done during BPF program execution for bpf_trace_printk()s using %pT format specifiers. The problem with per-cpu buffers is we'd have to manage preemption and since the display of an object occurs over an extended period and in printk context where we'd rather not change preemption status, it seemed tricky to manage buffer safety while considering preemption. The approach of utilizing stack buffer space via the "struct btf_show" seemed like the simplest approach. The stack size of the associated functions which have a "struct btf_show" on their stack to support show operation (btf_type_snprintf_show() and btf_type_seq_show()) stays under 500 bytes. The compromise here is the safe buffer we use is small - 256 bytes - and as a result multiple probe_kernel_read()s are needed for larger objects. Most objects of interest are smaller than this (e.g. "struct sk_buff" is 224 bytes), and while task_struct is a notable exception at ~8K, performance is not the priority for BTF-based display. (Alexei and Yonghong, patch 2). - safe buffer use is the default behaviour (and is mandatory for BPF) but unsafe display - meaning no safe copy is done and we operate on the object itself - is supported via a 'u' option. - pointers are prefixed with 0x for clarity (Alexei, patch 2) - added additional comments and explanations around BTF show code, especially around determining whether objects such zeroed. Also tried to comment safe object scheme used. (Yonghong, patch 2) - added late_initcall() to initialize vmlinux BTF so that it would not have to be initialized during printk operation (Alexei, patch 5) - removed CONFIG_BTF_PRINTF config option as it is not needed; CONFIG_DEBUG_INFO_BTF can be used to gate test behaviour and determining behaviour of type-based printk can be done via retrieval of BTF data; if it's not there BTF was unavailable or broken (Alexei, patches 4,6) - fix bpf_trace_printk test to use vmlinux.h and globals via skeleton infrastructure, removing need for perf events (Andrii, patch 8) Changes since v1: - changed format to be more drgn-like, rendering indented type info along with type names by default (Alexei) - zeroed values are omitted (Arnaldo) by default unless the '0' modifier is specified (Alexei) - added an option to print pointer values without obfuscation. The reason to do this is the sysctls controlling pointer display are likely to be irrelevant in many if not most tracing contexts. Some questions on this in the outstanding questions section below... - reworked printk format specifer so that we no longer rely on format %pT<type> but instead use a struct * which contains type information (Rasmus). This simplifies the printk parsing, makes use more dynamic and also allows specification by BTF id as well as name. - removed incorrect patch which tried to fix dereferencing of resolved BTF info for vmlinux; instead we skip modifiers for the relevant case (array element type determination) (Alexei). - fixed issues with negative snprintf format length (Rasmus) - added test cases for various data structure formats; base types, typedefs, structs, etc. - tests now iterate through all typedef, enum, struct and unions defined for vmlinux BTF and render a version of the target dummy value which is either all zeros or all 0xff values; the idea is this exercises the "skip if zero" and "print everything" cases. - added support in BPF for using the %pT format specifier in bpf_trace_printk() - added BPF tests which ensure %pT format specifier use works (Alexei). Alan Maguire (8): bpf: provide function to get vmlinux BTF information bpf: move to generic BTF show support, apply it to seq files/strings bpf: add bpf_snprintf_btf helper selftests/bpf: add bpf_snprintf_btf helper tests bpf: bump iter seq size to support BTF representation of large data structures selftests/bpf: fix overflow tests to reflect iter size increase bpf: add bpf_seq_printf_btf helper selftests/bpf: add test for bpf_seq_printf_btf helper include/linux/bpf.h | 3 + include/linux/btf.h | 39 + include/uapi/linux/bpf.h | 76 ++ kernel/bpf/bpf_iter.c | 4 +- kernel/bpf/btf.c | 1007 ++++++++++++++++++-- kernel/bpf/core.c | 2 + kernel/bpf/helpers.c | 4 + kernel/bpf/verifier.c | 18 +- kernel/trace/bpf_trace.c | 98 ++ scripts/bpf_helpers_doc.py | 2 + tools/include/uapi/linux/bpf.h | 76 ++ tools/testing/selftests/bpf/prog_tests/bpf_iter.c | 88 +- .../selftests/bpf/prog_tests/snprintf_btf.c | 60 ++ .../selftests/bpf/progs/bpf_iter_task_btf.c | 50 + .../selftests/bpf/progs/netif_receive_skb.c | 249 +++++ 15 files changed, 1659 insertions(+), 117 deletions(-) create mode 100644 tools/testing/selftests/bpf/prog_tests/snprintf_btf.c create mode 100644 tools/testing/selftests/bpf/progs/bpf_iter_task_btf.c create mode 100644 tools/testing/selftests/bpf/progs/netif_receive_skb.c -- 1.8.3.1

4 years, 9 months

4
11
0 0

[PATCH v6 bpf-next 0/6] bpf: add helpers to support BTF-based kernel data display

by Alan Maguire

This series attempts to provide a simple way for BPF programs (and in future other consumers) to utilize BPF Type Format (BTF) information to display kernel data structures in-kernel. The use case this functionality is applied to here is to support a snprintf()-like helper to copy a BTF representation of kernel data to a string, and a BPF seq file helper to display BTF data for an iterator. There is already support in kernel/bpf/btf.c for "show" functionality; the changes here generalize that support from seq-file specific verifier display to the more generic case and add another specific use case; rather than seq_printf()ing the show data, it is copied to a supplied string using a snprintf()-like function. Other future consumers of the show functionality could include a bpf_printk_btf() function which printk()ed the data instead. Oops messaging in particular would be an interesting application for such functionality. The above potential use case hints at a potential reply to a reasonable objection that such typed display should be solved by tracing programs, where the in-kernel tracing records data and the userspace program prints it out. While this is certainly the recommended approach for most cases, I believe having an in-kernel mechanism would be valuable also. Critically in BPF programs it greatly simplifies debugging and tracing of such data to invoking a simple helper. One challenge raised in an earlier iteration of this work - where the BTF printing was implemented as a printk() format specifier - was that the amount of data printed per printk() was large, and other format specifiers were far simpler. Here we sidestep that concern by printing components of the BTF representation as we go for the seq file case, and in the string case the snprintf()-like operation is intended to be a basis for perf event or ringbuf output. The reasons for avoiding bpf_trace_printk are that 1. bpf_trace_printk() strings are restricted in size and cannot display anything beyond trivial data structures; and 2. bpf_trace_printk() is for debugging purposes only. As Alexei suggested, a bpf_trace_puts() helper could solve this in the future but it still would be limited by the 1000 byte limit for traced strings. Default output for an sk_buff looks like this (zeroed fields are omitted): (struct sk_buff){ .transport_header = (__u16)65535, .mac_header = (__u16)65535, .end = (sk_buff_data_t)192, .head = (unsigned char *)0x000000007524fd8b, .data = (unsigned char *)0x000000007524fd8b, .truesize = (unsigned int)768, .users = (refcount_t){ .refs = (atomic_t){ .counter = (int)1, }, }, } Flags can modify aspects of output format; see patch 3 for more details. Changes since v5: - Moved btf print prepare into patch 3, type show seq with flags into patch 2 (Alexei, patches 2,3) - Fixed build bot warnings around static declarations and printf attributes - Renamed functions to snprintf_btf/seq_printf_btf (Alexei, patches 3-6) Changes since v4: - Changed approach from a BPF trace event-centric design to one utilizing a snprintf()-like helper and an iter helper (Alexei, patches 3,5) - Added tests to verify BTF output (patch 4) - Added support to tests for verifying BTF type_id-based display as well as type name via __builtin_btf_type_id (Andrii, patch 4). - Augmented task iter tests to cover the BTF-based seq helper. Because a task_struct's BTF-based representation would overflow the PAGE_SIZE limit on iterator data, the "struct fs_struct" (task->fs) is displayed for each task instead (Alexei, patch 6). Changes since v3: - Moved to RFC since the approach is different (and bpf-next is closed) - Rather than using a printk() format specifier as the means of invoking BTF-enabled display, a dedicated BPF helper is used. This solves the issue of printk() having to output large amounts of data using a complex mechanism such as BTF traversal, but still provides a way for the display of such data to be achieved via BPF programs. Future work could include a bpf_printk_btf() function to invoke display via printk() where the elements of a data structure are printk()ed one at a time. Thanks to Petr Mladek, Andy Shevchenko and Rasmus Villemoes who took time to look at the earlier printk() format-specifier-focused version of this and provided feedback clarifying the problems with that approach. - Added trace id to the bpf_trace_printk events as a means of separating output from standard bpf_trace_printk() events, ensuring it can be easily parsed by the reader. - Added bpf_trace_btf() helper tests which do simple verification of the various display options. Changes since v2: - Alexei and Yonghong suggested it would be good to use probe_kernel_read() on to-be-shown data to ensure safety during operation. Safe copy via probe_kernel_read() to a buffer object in "struct btf_show" is used to support this. A few different approaches were explored including dynamic allocation and per-cpu buffers. The downside of dynamic allocation is that it would be done during BPF program execution for bpf_trace_printk()s using %pT format specifiers. The problem with per-cpu buffers is we'd have to manage preemption and since the display of an object occurs over an extended period and in printk context where we'd rather not change preemption status, it seemed tricky to manage buffer safety while considering preemption. The approach of utilizing stack buffer space via the "struct btf_show" seemed like the simplest approach. The stack size of the associated functions which have a "struct btf_show" on their stack to support show operation (btf_type_snprintf_show() and btf_type_seq_show()) stays under 500 bytes. The compromise here is the safe buffer we use is small - 256 bytes - and as a result multiple probe_kernel_read()s are needed for larger objects. Most objects of interest are smaller than this (e.g. "struct sk_buff" is 224 bytes), and while task_struct is a notable exception at ~8K, performance is not the priority for BTF-based display. (Alexei and Yonghong, patch 2). - safe buffer use is the default behaviour (and is mandatory for BPF) but unsafe display - meaning no safe copy is done and we operate on the object itself - is supported via a 'u' option. - pointers are prefixed with 0x for clarity (Alexei, patch 2) - added additional comments and explanations around BTF show code, especially around determining whether objects such zeroed. Also tried to comment safe object scheme used. (Yonghong, patch 2) - added late_initcall() to initialize vmlinux BTF so that it would not have to be initialized during printk operation (Alexei, patch 5) - removed CONFIG_BTF_PRINTF config option as it is not needed; CONFIG_DEBUG_INFO_BTF can be used to gate test behaviour and determining behaviour of type-based printk can be done via retrieval of BTF data; if it's not there BTF was unavailable or broken (Alexei, patches 4,6) - fix bpf_trace_printk test to use vmlinux.h and globals via skeleton infrastructure, removing need for perf events (Andrii, patch 8) Changes since v1: - changed format to be more drgn-like, rendering indented type info along with type names by default (Alexei) - zeroed values are omitted (Arnaldo) by default unless the '0' modifier is specified (Alexei) - added an option to print pointer values without obfuscation. The reason to do this is the sysctls controlling pointer display are likely to be irrelevant in many if not most tracing contexts. Some questions on this in the outstanding questions section below... - reworked printk format specifer so that we no longer rely on format %pT<type> but instead use a struct * which contains type information (Rasmus). This simplifies the printk parsing, makes use more dynamic and also allows specification by BTF id as well as name. - removed incorrect patch which tried to fix dereferencing of resolved BTF info for vmlinux; instead we skip modifiers for the relevant case (array element type determination) (Alexei). - fixed issues with negative snprintf format length (Rasmus) - added test cases for various data structure formats; base types, typedefs, structs, etc. - tests now iterate through all typedef, enum, struct and unions defined for vmlinux BTF and render a version of the target dummy value which is either all zeros or all 0xff values; the idea is this exercises the "skip if zero" and "print everything" cases. - added support in BPF for using the %pT format specifier in bpf_trace_printk() - added BPF tests which ensure %pT format specifier use works (Alexei). Alan Maguire (6): bpf: provide function to get vmlinux BTF information bpf: move to generic BTF show support, apply it to seq files/strings bpf: add bpf_snprintf_btf helper selftests/bpf: add bpf_snprintf_btf helper tests bpf: add bpf_seq_printf_btf helper selftests/bpf: add test for bpf_seq_printf_btf helper include/linux/bpf.h | 3 + include/linux/btf.h | 39 + include/uapi/linux/bpf.h | 78 ++ kernel/bpf/btf.c | 980 ++++++++++++++++++--- kernel/bpf/core.c | 2 + kernel/bpf/helpers.c | 4 + kernel/bpf/verifier.c | 18 +- kernel/trace/bpf_trace.c | 134 +++ scripts/bpf_helpers_doc.py | 2 + tools/include/uapi/linux/bpf.h | 78 ++ tools/testing/selftests/bpf/prog_tests/bpf_iter.c | 66 ++ .../selftests/bpf/prog_tests/snprintf_btf.c | 54 ++ .../selftests/bpf/progs/bpf_iter_task_btf.c | 49 ++ .../selftests/bpf/progs/netif_receive_skb.c | 260 ++++++ 14 files changed, 1659 insertions(+), 108 deletions(-) create mode 100644 tools/testing/selftests/bpf/prog_tests/snprintf_btf.c create mode 100644 tools/testing/selftests/bpf/progs/bpf_iter_task_btf.c create mode 100644 tools/testing/selftests/bpf/progs/netif_receive_skb.c -- 1.8.3.1

4 years, 9 months

3
14
0 0

[PATCHv5 kselftest next] selftests/run_kselftest.sh: make each test individually selectable

by Hangbin Liu

Currently, after generating run_kselftest.sh, there is no way to choose which test we could run. All the tests are listed together and we have to run all every time. This patch enhanced the run_kselftest.sh to make the tests individually selectable. e.g. $ ./run_kselftest.sh -t "bpf size timers" Before the patch: ================ $ cat run_kselftest.sh \#!/bin/sh BASE_DIR=$(realpath $(dirname $0)) cd $BASE_DIR . ./kselftest/runner.sh ROOT=$PWD if [ "$1" = "--summary" ]; then logfile=$BASE_DIR/output.log cat /dev/null > $logfile fi [ -w /dev/kmsg ] && echo "kselftest: Running tests in android" >> /dev/kmsg cd android run_many \ "run.sh" cd $ROOT ...<snip>... [ -w /dev/kmsg ] && echo "kselftest: Running tests in zram" >> /dev/kmsg cd zram run_many \ "zram.sh" cd $ROOT After the patch: =============== $ cat run_kselftest.sh \#!/bin/sh BASE_DIR=$(realpath $(dirname $0)) . ./kselftest/runner.sh TESTS="android ...<snip>... filesystems/binderfs ...<snip>... zram" run_android() { [ -w /dev/kmsg ] && echo "kselftest: Running tests in android" >> /dev/kmsg cd android run_many \ "run.sh" cd $ROOT } ...<snip>... run_filesystems_binderfs() { [ -w /dev/kmsg ] && echo "kselftest: Running tests in filesystems/binderfs" >> /dev/kmsg cd filesystems/binderfs run_many \ "binderfs_test" cd $ROOT } ...<snip>... run_zram() { [ -w /dev/kmsg ] && echo "kselftest: Running tests in zram" >> /dev/kmsg cd zram run_many \ "zram.sh" cd $ROOT } usage() { cat <<EOF usage: ${0##*/} OPTS -s | --summary Only print summary info and put detailed log in output.log -t | --tests Test name you want to run specifically -h | --help Show this usage info EOF } while true; do case "$1" in -s | --summary ) logfile=$BASE_DIR/output.log; cat /dev/null > $logfile; shift ;; -t | --tests ) TESTS=$2; shift 2 ;; -l | --list ) echo $TESTS; exit 0 ;; -h | --help ) usage; exit 0 ;; "" ) break;; * ) usage; exit 1;; esac done cd $BASE_DIR ROOT=$PWD for folder in $TESTS; do folder=$(echo $folder | tr -s '/-' '_') run_$folder done Signed-off-by: Hangbin Liu <liuhangbin(a)gmail.com> --- v5: Forgot to update commit description for the new added -l option v4: Add parameter -l to list available tests, suggested by Bird, Tim v3: 1) rebase the patch to latest code 2) move `tr -s "/-" "_"` in for loop at the end so user could use test folder name directly. Before the fix, user need to use ./run_kselftest.sh -t 'networking_forwarding'. Now they can just run ./run_kselftest.sh -t 'networking/forwarding' directly. v2: update document and commit description. --- Documentation/dev-tools/kselftest.rst | 8 +++++ tools/testing/selftests/Makefile | 51 +++++++++++++++++++++------ tools/testing/selftests/lib.mk | 2 +- 3 files changed, 50 insertions(+), 11 deletions(-) diff --git a/Documentation/dev-tools/kselftest.rst b/Documentation/dev-tools/kselftest.rst index 469d115a95f1..7b92f9c177f6 100644 --- a/Documentation/dev-tools/kselftest.rst +++ b/Documentation/dev-tools/kselftest.rst @@ -151,6 +151,14 @@ note some tests will require root privileges:: $ cd kselftest $ ./run_kselftest.sh +Or you can run some specific test cases in the installed Kselftests by:: + + $ ./run_kselftest.sh -t "bpf size timers" + +You can view the available tests to run with:: + + $ ./run_kselftest.sh -l + Packaging selftests =================== diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile index 15c1c1359c50..4c8159dd2bd7 100644 --- a/tools/testing/selftests/Makefile +++ b/tools/testing/selftests/Makefile @@ -225,13 +225,9 @@ ifdef INSTALL_PATH @# Ask all targets to emit their test scripts echo "#!/bin/sh" > $(ALL_SCRIPT) echo "BASE_DIR=\$$(realpath \$$(dirname \$$0))" >> $(ALL_SCRIPT) - echo "cd \$$BASE_DIR" >> $(ALL_SCRIPT) echo ". ./kselftest/runner.sh" >> $(ALL_SCRIPT) - echo "ROOT=\$$PWD" >> $(ALL_SCRIPT) - echo "if [ \"\$$1\" = \"--summary\" ]; then" >> $(ALL_SCRIPT) - echo " logfile=\$$BASE_DIR/output.log" >> $(ALL_SCRIPT) - echo " cat /dev/null > \$$logfile" >> $(ALL_SCRIPT) - echo "fi" >> $(ALL_SCRIPT) + echo "TESTS=\"$(TARGETS)\"" >> $(ALL_SCRIPT) + echo "" >> $(ALL_SCRIPT); @# While building run_kselftest.sh skip also non-existent TARGET dirs: @# they could be the result of a build failure and should NOT be @@ -239,15 +235,50 @@ ifdef INSTALL_PATH for TARGET in $(TARGETS); do \ BUILD_TARGET=$$BUILD/$$TARGET; \ [ ! -d $(INSTALL_PATH)/$$TARGET ] && echo "Skipping non-existent dir: $$TARGET" && continue; \ - echo "[ -w /dev/kmsg ] && echo \"kselftest: Running tests in $$TARGET\" >> /dev/kmsg" >> $(ALL_SCRIPT); \ - echo "cd $$TARGET" >> $(ALL_SCRIPT); \ - echo -n "run_many" >> $(ALL_SCRIPT); \ + echo "run_$$TARGET()" | tr -s "/-" "_" >> $(ALL_SCRIPT); \ + echo "{" >> $(ALL_SCRIPT); \ + echo -e "\t[ -w /dev/kmsg ] && echo \"kselftest: Running tests in $$TARGET\" >> /dev/kmsg" >> $(ALL_SCRIPT); \ + echo -e "\tcd $$TARGET" >> $(ALL_SCRIPT); \ + echo -en "\trun_many" >> $(ALL_SCRIPT); \ echo -n "Emit Tests for $$TARGET\n"; \ $(MAKE) -s --no-print-directory OUTPUT=$$BUILD_TARGET -C $$TARGET emit_tests >> $(ALL_SCRIPT); \ echo "" >> $(ALL_SCRIPT); \ - echo "cd \$$ROOT" >> $(ALL_SCRIPT); \ + echo -e "\tcd \$$ROOT" >> $(ALL_SCRIPT); \ + echo "}" >> $(ALL_SCRIPT); \ + echo "" >> $(ALL_SCRIPT); \ done; + echo "usage()" >> $(ALL_SCRIPT); + echo "{" >> $(ALL_SCRIPT); + echo -e "\tcat <<EOF" >> $(ALL_SCRIPT); + echo "usage: \$${0##*/} OPTS" >> $(ALL_SCRIPT); + echo -e "\t-s | --summary\t\tOnly print summary info and put detailed log in output.log" >> $(ALL_SCRIPT); + echo -e "\t-t | --tests\t\tTest name you want to run specifically" >> $(ALL_SCRIPT); + echo -e "\t-l | --list\t\tList the available tests" >> $(ALL_SCRIPT); + echo -e "\t-h | --help\t\tShow this usage info" >> $(ALL_SCRIPT); + echo "EOF" >> $(ALL_SCRIPT); + echo "}" >> $(ALL_SCRIPT); + echo "" >> $(ALL_SCRIPT); + + echo "while true; do" >> $(ALL_SCRIPT); + echo -e "\tcase \"\$$1\" in" >> $(ALL_SCRIPT); + echo -e "\t-s | --summary ) logfile=\$$BASE_DIR/output.log; cat /dev/null > \$$logfile; shift ;;" >> $(ALL_SCRIPT); + echo -e "\t-t | --tests ) TESTS=\$$2; shift 2 ;;" >> $(ALL_SCRIPT); + echo -e "\t-l | --list ) echo \$$TESTS; exit 0 ;;" >> $(ALL_SCRIPT); + echo -e "\t-h | --help ) usage; exit 0 ;;" >> $(ALL_SCRIPT); + echo -e "\t\"\" ) break;;" >> $(ALL_SCRIPT); + echo -e "\t* ) usage; exit 1;;" >> $(ALL_SCRIPT); + echo -e "\tesac" >> $(ALL_SCRIPT); + echo "done" >> $(ALL_SCRIPT); + echo "" >> $(ALL_SCRIPT); + + echo "cd \$$BASE_DIR" >> $(ALL_SCRIPT) + echo "ROOT=\$$PWD" >> $(ALL_SCRIPT) + + echo "for folder in \$$TESTS; do" >> $(ALL_SCRIPT); \ + echo -e "\tfolder=\$$(echo \$$folder | tr -s '/-' '_')" >> $(ALL_SCRIPT); \ + echo -e "\trun_\$$folder" >> $(ALL_SCRIPT); \ + echo "done" >> $(ALL_SCRIPT); \ chmod u+x $(ALL_SCRIPT) else $(error Error: set INSTALL_PATH to use install) diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk index 51124b962d56..3c4c94a5d184 100644 --- a/tools/testing/selftests/lib.mk +++ b/tools/testing/selftests/lib.mk @@ -108,7 +108,7 @@ emit_tests: for TEST in $(TEST_GEN_PROGS) $(TEST_CUSTOM_PROGS) $(TEST_PROGS); do \ BASENAME_TEST=`basename $$TEST`; \ echo " \\"; \ - echo -n " \"$$BASENAME_TEST\""; \ + echo -ne "\t\t\"$$BASENAME_TEST\""; \ done; \ # define if isn't already. It is undefined in make O= case. -- 2.25.4

4 years, 9 months

4
8
0 0

[PATCH tip/core/rcu 12/15] rcutorture: Cleanup PREEMPT_COUNT leftovers

by paulmck＠kernel.org

From: Thomas Gleixner <tglx(a)linutronix.de> CONFIG_PREEMPT_COUNT is now unconditionally enabled and will be removed. Cleanup the leftovers before doing so. Signed-off-by: Thomas Gleixner <tglx(a)linutronix.de> Cc: "Paul E. McKenney" <paulmck(a)kernel.org> Cc: Josh Triplett <josh(a)joshtriplett.org> Cc: Steven Rostedt <rostedt(a)goodmis.org> Cc: Mathieu Desnoyers <mathieu.desnoyers(a)efficios.com> Cc: Lai Jiangshan <jiangshanlai(a)gmail.com> Cc: Shuah Khan <shuah(a)kernel.org> Cc: rcu(a)vger.kernel.org Cc: linux-kselftest(a)vger.kernel.org Signed-off-by: Paul E. McKenney <paulmck(a)kernel.org> --- tools/testing/selftests/rcutorture/configs/rcu/SRCU-t | 1 - tools/testing/selftests/rcutorture/configs/rcu/SRCU-u | 1 - tools/testing/selftests/rcutorture/configs/rcu/TINY01 | 1 - tools/testing/selftests/rcutorture/doc/TINY_RCU.txt | 5 ++--- tools/testing/selftests/rcutorture/doc/TREE_RCU-kconfig.txt | 1 - tools/testing/selftests/rcutorture/formal/srcu-cbmc/src/config.h | 1 - 6 files changed, 2 insertions(+), 8 deletions(-) diff --git a/tools/testing/selftests/rcutorture/configs/rcu/SRCU-t b/tools/testing/selftests/rcutorture/configs/rcu/SRCU-t index 6c78022..553cf65 100644 --- a/tools/testing/selftests/rcutorture/configs/rcu/SRCU-t +++ b/tools/testing/selftests/rcutorture/configs/rcu/SRCU-t @@ -7,4 +7,3 @@ CONFIG_RCU_TRACE=n CONFIG_DEBUG_LOCK_ALLOC=n CONFIG_DEBUG_OBJECTS_RCU_HEAD=n CONFIG_DEBUG_ATOMIC_SLEEP=y -#CHECK#CONFIG_PREEMPT_COUNT=y diff --git a/tools/testing/selftests/rcutorture/configs/rcu/SRCU-u b/tools/testing/selftests/rcutorture/configs/rcu/SRCU-u index c15ada8..99563da 100644 --- a/tools/testing/selftests/rcutorture/configs/rcu/SRCU-u +++ b/tools/testing/selftests/rcutorture/configs/rcu/SRCU-u @@ -7,4 +7,3 @@ CONFIG_RCU_TRACE=n CONFIG_DEBUG_LOCK_ALLOC=y CONFIG_PROVE_LOCKING=y CONFIG_DEBUG_OBJECTS_RCU_HEAD=n -CONFIG_PREEMPT_COUNT=n diff --git a/tools/testing/selftests/rcutorture/configs/rcu/TINY01 b/tools/testing/selftests/rcutorture/configs/rcu/TINY01 index 6db705e..9b22b8e 100644 --- a/tools/testing/selftests/rcutorture/configs/rcu/TINY01 +++ b/tools/testing/selftests/rcutorture/configs/rcu/TINY01 @@ -10,4 +10,3 @@ CONFIG_RCU_TRACE=n #CHECK#CONFIG_RCU_STALL_COMMON=n CONFIG_DEBUG_LOCK_ALLOC=n CONFIG_DEBUG_OBJECTS_RCU_HEAD=n -CONFIG_PREEMPT_COUNT=n diff --git a/tools/testing/selftests/rcutorture/doc/TINY_RCU.txt b/tools/testing/selftests/rcutorture/doc/TINY_RCU.txt index a75b169..d30cedf 100644 --- a/tools/testing/selftests/rcutorture/doc/TINY_RCU.txt +++ b/tools/testing/selftests/rcutorture/doc/TINY_RCU.txt @@ -3,11 +3,10 @@ This document gives a brief rationale for the TINY_RCU test cases. Kconfig Parameters: -CONFIG_DEBUG_LOCK_ALLOC -- Do all three and none of the three. -CONFIG_PREEMPT_COUNT +CONFIG_DEBUG_LOCK_ALLOC -- Do both and none of the two. CONFIG_RCU_TRACE -The theory here is that randconfig testing will hit the other six possible +The theory here is that randconfig testing will hit the other two possible combinations of these parameters. diff --git a/tools/testing/selftests/rcutorture/doc/TREE_RCU-kconfig.txt b/tools/testing/selftests/rcutorture/doc/TREE_RCU-kconfig.txt index 1b96d68..cfdd48f 100644 --- a/tools/testing/selftests/rcutorture/doc/TREE_RCU-kconfig.txt +++ b/tools/testing/selftests/rcutorture/doc/TREE_RCU-kconfig.txt @@ -43,7 +43,6 @@ CONFIG_64BIT Used only to check CONFIG_RCU_FANOUT value, inspection suffices. -CONFIG_PREEMPT_COUNT CONFIG_PREEMPT_RCU Redundant with CONFIG_PREEMPT, ignore. diff --git a/tools/testing/selftests/rcutorture/formal/srcu-cbmc/src/config.h b/tools/testing/selftests/rcutorture/formal/srcu-cbmc/src/config.h index 283d710..d0d485d 100644 --- a/tools/testing/selftests/rcutorture/formal/srcu-cbmc/src/config.h +++ b/tools/testing/selftests/rcutorture/formal/srcu-cbmc/src/config.h @@ -8,7 +8,6 @@ #undef CONFIG_HOTPLUG_CPU #undef CONFIG_MODULES #undef CONFIG_NO_HZ_FULL_SYSIDLE -#undef CONFIG_PREEMPT_COUNT #undef CONFIG_PREEMPT_RCU #undef CONFIG_PROVE_RCU #undef CONFIG_RCU_NOCB_CPU -- 2.9.5

4 years, 9 months

1
0
0 0

[PATCH 0/2] selftests: Extract run_kselftest.sh and generate stand-alone test list

by Kees Cook

Hi! I really like Hangbin Liu's intent[1] but I think we need to be a little more clean about the implementation. This extracts run_kselftest.sh from the Makefile so it can actually be changed without embeds, etc. Instead, generate the test list into a text file. Everything gets much simpler. :) And in patch 2, I add back Hangin Liu's new options (with some extra added) with knowledge of "collections" (i.e. Makefile TARGETS) and subtests. This should work really well with LAVA too, which needs to manipulate the lists of tests being run. Thoughts? -Kees [1] https://lore.kernel.org/lkml/20200914022227.437143-1-liuhangbin@gmail.com/ Kees Cook (2): selftests: Extract run_kselftest.sh and generate stand-alone test list selftests/run_kselftest.sh: Make each test individually selectable tools/testing/selftests/Makefile | 26 ++----- tools/testing/selftests/lib.mk | 5 +- tools/testing/selftests/run_kselftest.sh | 89 ++++++++++++++++++++++++ 3 files changed, 98 insertions(+), 22 deletions(-) create mode 100755 tools/testing/selftests/run_kselftest.sh -- 2.25.1

4 years, 9 months

2
4
0 0

[PATCH v1] kunit: tool: handle when .kunit exists but .kunitconfig does not

by Brendan Higgins

Right now .kunitconfig and the build dir are automatically created if the build dir does not exists; however, if the build dir is present and .kunitconfig is not, kunit_tool will crash. Fix this by checking for both the build dir as well as the .kunitconfig. NOTE: This depends on commit 5578d008d9e0 ("kunit: tool: fix running kunit_tool from outside kernel tree") Link: https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/c… Signed-off-by: Brendan Higgins <brendanhiggins(a)google.com> --- tools/testing/kunit/kunit.py | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/tools/testing/kunit/kunit.py b/tools/testing/kunit/kunit.py index e2caf4e24ecb2..8ab17e21a3578 100755 --- a/tools/testing/kunit/kunit.py +++ b/tools/testing/kunit/kunit.py @@ -243,6 +243,8 @@ def main(argv, linux=None): if cli_args.subcommand == 'run': if not os.path.exists(cli_args.build_dir): os.mkdir(cli_args.build_dir) + + if not os.path.exists(kunit_kernel.kunitconfig_path): create_default_kunitconfig() if not linux: @@ -258,10 +260,12 @@ def main(argv, linux=None): if result.status != KunitStatus.SUCCESS: sys.exit(1) elif cli_args.subcommand == 'config': - if cli_args.build_dir: - if not os.path.exists(cli_args.build_dir): - os.mkdir(cli_args.build_dir) - create_default_kunitconfig() + if cli_args.build_dir and ( + not os.path.exists(cli_args.build_dir)): + os.mkdir(cli_args.build_dir) + + if not os.path.exists(kunit_kernel.kunitconfig_path): + create_default_kunitconfig() if not linux: linux = kunit_kernel.LinuxSourceTree() base-commit: d96fe1a5485fa978a6e3690adc4dbe4d20b5baa4 -- 2.28.0.681.g6f77f65b4e-goog

4 years, 9 months

1
0
0 0

[PATCH v3 0/7] xfrm: Add compat layer

by Dmitry Safonov

Changes since v2: - added struct xfrm_translator as API to register xfrm_compat.ko with xfrm_state.ko. This allows compilation of translator as a loadable module - fixed indention and collected reviewed-by (Johannes Berg) - moved boilerplate from commit messages into cover-letter (Steffen Klassert) - found on KASAN build and fixed non-initialised stack variable usage in the translator The resulting v2/v3 diff can be found here: https://gist.github.com/0x7f454c46/8f68311dfa1f240959fdbe7c77ed2259 Patches as a .git branch: https://github.com/0x7f454c46/linux/tree/xfrm-compat-v3 Changes since v1: - reworked patches set to use translator - separated the compat layer into xfrm_compat.c, compiled under XFRM_USER_COMPAT config - 32-bit messages now being sent in frag_list (like wext-core does) - instead of __packed add compat_u64 members in compat structures - selftest reworked to kselftest lib API - added netlink dump testing to the selftest XFRM is disabled for compatible users because of the UABI difference. The difference is in structures paddings and in the result the size of netlink messages differ. Possibility for compatible application to manage xfrm tunnels was disabled by: the commmit 19d7df69fdb2 ("xfrm: Refuse to insert 32 bit userspace socket policies on 64 bit systems") and the commit 74005991b78a ("xfrm: Do not parse 32bits compiled xfrm netlink msg on 64bits host"). This is my second attempt to resolve the xfrm/compat problem by adding the 64=>32 and 32=>64 bit translators those non-visibly to a user provide translation between compatible user and kernel. Previous attempt was to interrupt the message ABI according to a syscall by xfrm_user, which resulted in over-complicated code [1]. Florian Westphal provided the idea of translator and some draft patches in the discussion. In these patches, his idea is reused and some of his initial code is also present. There were a couple of attempts to solve xfrm compat problem: https://lkml.org/lkml/2017/1/20/733 https://patchwork.ozlabs.org/patch/44600/ http://netdev.vger.kernel.narkive.com/2Gesykj6/patch-net-next-xfrm-correctl… All the discussions end in the conclusion that xfrm should have a full compatible layer to correctly work with 32-bit applications on 64-bit kernels: https://lkml.org/lkml/2017/1/23/413 https://patchwork.ozlabs.org/patch/433279/ In some recent lkml discussion, Linus said that it's worth to fix this problem and not giving people an excuse to stay on 32-bit kernel: https://lkml.org/lkml/2018/2/13/752 There is also an selftest for ipsec tunnels. It doesn't depend on any library and compat version can be easy build with: make CFLAGS=-m32 net/ipsec [1]: https://lkml.kernel.org/r/20180726023144.31066-1-dima@arista.com Cc: "David S. Miller" <davem(a)davemloft.net> Cc: Florian Westphal <fw(a)strlen.de> Cc: Herbert Xu <herbert(a)gondor.apana.org.au> Cc: Jakub Kicinski <kuba(a)kernel.org> Cc: Johannes Berg <johannes(a)sipsolutions.net> Cc: Steffen Klassert <steffen.klassert(a)secunet.com> Cc: Stephen Suryaputra <ssuryaextr(a)gmail.com> Cc: Dmitry Safonov <0x7f454c46(a)gmail.com> Cc: netdev(a)vger.kernel.org Dmitry Safonov (7): xfrm: Provide API to register translator module xfrm/compat: Add 64=>32-bit messages translator xfrm/compat: Attach xfrm dumps to 64=>32 bit translator netlink/compat: Append NLMSG_DONE/extack to frag_list xfrm/compat: Add 32=>64-bit messages translator xfrm/compat: Translate 32-bit user_policy from sockptr selftest/net/xfrm: Add test for ipsec tunnel MAINTAINERS | 1 + include/net/xfrm.h | 33 + net/netlink/af_netlink.c | 47 +- net/xfrm/Kconfig | 11 + net/xfrm/Makefile | 1 + net/xfrm/xfrm_compat.c | 625 +++++++ net/xfrm/xfrm_state.c | 77 +- net/xfrm/xfrm_user.c | 110 +- tools/testing/selftests/net/.gitignore | 1 + tools/testing/selftests/net/Makefile | 1 + tools/testing/selftests/net/ipsec.c | 2195 ++++++++++++++++++++++++ 11 files changed, 3066 insertions(+), 36 deletions(-) create mode 100644 net/xfrm/xfrm_compat.c create mode 100644 tools/testing/selftests/net/ipsec.c base-commit: ba4f184e126b751d1bffad5897f263108befc780 -- 2.28.0

4 years, 9 months

2
2
0 0

[PATCH bpf-next v2 3/4] selftests: bpf: remove shared header from sockmap iter test

by Lorenz Bauer

The shared header to define SOCKMAP_MAX_ENTRIES is a bit overkill. Dynamically allocate the sock_fd array based on bpf_map__max_entries instead. Suggested-by: Yonghong Song <yhs(a)fb.com> Signed-off-by: Lorenz Bauer <lmb(a)cloudflare.com> Acked-by: Yonghong Song <yhs(a)fb.com> --- .../selftests/bpf/prog_tests/sockmap_basic.c | 36 +++++++++---------- .../selftests/bpf/progs/bpf_iter_sockmap.c | 5 ++- .../selftests/bpf/progs/bpf_iter_sockmap.h | 3 -- 3 files changed, 20 insertions(+), 24 deletions(-) delete mode 100644 tools/testing/selftests/bpf/progs/bpf_iter_sockmap.h diff --git a/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c b/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c index 67d3301bdf81..e8a4bfb4d9f4 100644 --- a/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c +++ b/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c @@ -8,8 +8,6 @@ #include "test_sockmap_invalid_update.skel.h" #include "bpf_iter_sockmap.skel.h" -#include "progs/bpf_iter_sockmap.h" - #define TCP_REPAIR 19 /* TCP sock is under repair right now */ #define TCP_REPAIR_ON 1 @@ -201,9 +199,9 @@ static void test_sockmap_iter(enum bpf_map_type map_type) DECLARE_LIBBPF_OPTS(bpf_iter_attach_opts, opts); int err, len, src_fd, iter_fd, duration = 0; union bpf_iter_link_info linfo = {0}; - __s64 sock_fd[SOCKMAP_MAX_ENTRIES]; - __u32 i, num_sockets, max_elems; + __u32 i, num_sockets, num_elems; struct bpf_iter_sockmap *skel; + __s64 *sock_fd = NULL; struct bpf_link *link; struct bpf_map *src; char buf[64]; @@ -212,22 +210,23 @@ static void test_sockmap_iter(enum bpf_map_type map_type) if (CHECK(!skel, "bpf_iter_sockmap__open_and_load", "skeleton open_and_load failed\n")) return; - for (i = 0; i < ARRAY_SIZE(sock_fd); i++) - sock_fd[i] = -1; - - /* Make sure we have at least one "empty" entry to test iteration of - * an empty slot. - */ - num_sockets = ARRAY_SIZE(sock_fd) - 1; - if (map_type == BPF_MAP_TYPE_SOCKMAP) { src = skel->maps.sockmap; - max_elems = bpf_map__max_entries(src); + num_elems = bpf_map__max_entries(src); + num_sockets = num_elems - 1; } else { src = skel->maps.sockhash; - max_elems = num_sockets; + num_elems = bpf_map__max_entries(src) - 1; + num_sockets = num_elems; } + sock_fd = calloc(num_sockets, sizeof(*sock_fd)); + if (CHECK(!sock_fd, "calloc(sock_fd)", "failed to allocate\n")) + goto out; + + for (i = 0; i < num_sockets; i++) + sock_fd[i] = -1; + src_fd = bpf_map__fd(src); for (i = 0; i < num_sockets; i++) { @@ -258,8 +257,8 @@ static void test_sockmap_iter(enum bpf_map_type map_type) goto close_iter; /* test results */ - if (CHECK(skel->bss->elems != max_elems, "elems", "got %u expected %u\n", - skel->bss->elems, max_elems)) + if (CHECK(skel->bss->elems != num_elems, "elems", "got %u expected %u\n", + skel->bss->elems, num_elems)) goto close_iter; if (CHECK(skel->bss->socks != num_sockets, "socks", "got %u expected %u\n", @@ -271,10 +270,11 @@ static void test_sockmap_iter(enum bpf_map_type map_type) free_link: bpf_link__destroy(link); out: - for (i = 0; i < num_sockets; i++) { + for (i = 0; sock_fd && i < num_sockets; i++) if (sock_fd[i] >= 0) close(sock_fd[i]); - } + if (sock_fd) + free(sock_fd); bpf_iter_sockmap__destroy(skel); } diff --git a/tools/testing/selftests/bpf/progs/bpf_iter_sockmap.c b/tools/testing/selftests/bpf/progs/bpf_iter_sockmap.c index 0e27f73dd803..1af7555f6057 100644 --- a/tools/testing/selftests/bpf/progs/bpf_iter_sockmap.c +++ b/tools/testing/selftests/bpf/progs/bpf_iter_sockmap.c @@ -2,7 +2,6 @@ /* Copyright (c) 2020 Cloudflare */ #include "bpf_iter.h" #include "bpf_tracing_net.h" -#include "bpf_iter_sockmap.h" #include <bpf/bpf_helpers.h> #include <bpf/bpf_tracing.h> #include <errno.h> @@ -11,14 +10,14 @@ char _license[] SEC("license") = "GPL"; struct { __uint(type, BPF_MAP_TYPE_SOCKMAP); - __uint(max_entries, SOCKMAP_MAX_ENTRIES); + __uint(max_entries, 64); __type(key, __u32); __type(value, __u64); } sockmap SEC(".maps"); struct { __uint(type, BPF_MAP_TYPE_SOCKHASH); - __uint(max_entries, SOCKMAP_MAX_ENTRIES); + __uint(max_entries, 64); __type(key, __u32); __type(value, __u64); } sockhash SEC(".maps"); diff --git a/tools/testing/selftests/bpf/progs/bpf_iter_sockmap.h b/tools/testing/selftests/bpf/progs/bpf_iter_sockmap.h deleted file mode 100644 index 35a675d13c0f..000000000000 --- a/tools/testing/selftests/bpf/progs/bpf_iter_sockmap.h +++ /dev/null @@ -1,3 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0 */ - -#define SOCKMAP_MAX_ENTRIES (64) -- 2.25.1

4 years, 9 months

1
0
0 0

[PATCH v6 0/9] Syscall User Dispatch

by Gabriel Krisman Bertazi

Hi, The v6 of this patch series include only the type change requested by Andy on the vdso patch, but since v5 included some bigger changes, I'm documenting them in this cover letter as well. Please note this applies on top of Linus tree, and it succeeds seccomp and syscall user dispatch selftests. v5 cover letter -------------- This is v5 of Syscall User Dispatch. It has some big changes in comparison to v4. First of all, it allows the vdso trampoline code for architectures that support it. This is exposed through an arch hook. It also addresses the concern about what happens when a bad selector is provided, instead of SIGSEGV, we fail with SIGSYS, which is more debug-able. Another major change is that it is now based on top of Gleixner's common syscall entry work, and is supposed to only be used by that code. Therefore, the entry symbol is not exported outside of kernel/entry/ code. The biggest change in this version is the attempt to avoid using one of the final TIF flags on x86 32 bit, without increasing the size of that variable to 64 bit. My expectation is that, with this work, plus the removal of TIF_IA32, TIF_X32 and TIF_FORCE_TF, we might be able to avoid changing this field to 64 bits at all. Instead, this follows the suggestion by Andy to have a generic TIF flag for SECCOMP and this mechanism, and use another field to decide which one is enabled. The code for this is not complex, so it seems like a viable approach. Finally, this version adds some documentation to the feature. Kees, I dropped your reviewed-by on patch 5, given the amount of changes. Thanks, Previous submissions are archived at: RFC/v1: https://lkml.org/lkml/2020/7/8/96 v2: https://lkml.org/lkml/2020/7/9/17 v3: https://lkml.org/lkml/2020/7/12/4 v4: https://www.spinics.net/lists/linux-kselftest/msg16377.html v5: https://lkml.org/lkml/2020/8/10/1320 Gabriel Krisman Bertazi (9): kernel: Support TIF_SYSCALL_INTERCEPT flag kernel: entry: Support TIF_SYSCAL_INTERCEPT on common entry code x86: vdso: Expose sigreturn address on vdso to the kernel signal: Expose SYS_USER_DISPATCH si_code type kernel: Implement selective syscall userspace redirection kernel: entry: Support Syscall User Dispatch for common syscall entry x86: Enable Syscall User Dispatch selftests: Add kselftest for syscall user dispatch doc: Document Syscall User Dispatch .../admin-guide/syscall-user-dispatch.rst | 87 ++++++ arch/Kconfig | 21 ++ arch/x86/Kconfig | 1 + arch/x86/entry/vdso/vdso2c.c | 2 + arch/x86/entry/vdso/vdso32/sigreturn.S | 2 + arch/x86/entry/vdso/vma.c | 15 + arch/x86/include/asm/elf.h | 1 + arch/x86/include/asm/thread_info.h | 4 +- arch/x86/include/asm/vdso.h | 2 + arch/x86/kernel/signal_compat.c | 2 +- fs/exec.c | 8 + include/linux/entry-common.h | 6 +- include/linux/sched.h | 8 +- include/linux/seccomp.h | 20 +- include/linux/syscall_intercept.h | 71 +++++ include/linux/syscall_user_dispatch.h | 29 ++ include/uapi/asm-generic/siginfo.h | 3 +- include/uapi/linux/prctl.h | 5 + kernel/entry/Makefile | 1 + kernel/entry/common.c | 32 +- kernel/entry/common.h | 15 + kernel/entry/syscall_user_dispatch.c | 101 ++++++ kernel/fork.c | 10 +- kernel/seccomp.c | 7 +- kernel/sys.c | 5 + tools/testing/selftests/Makefile | 1 + .../syscall_user_dispatch/.gitignore | 2 + .../selftests/syscall_user_dispatch/Makefile | 9 + .../selftests/syscall_user_dispatch/config | 1 + .../syscall_user_dispatch.c | 292 ++++++++++++++++++ 30 files changed, 744 insertions(+), 19 deletions(-) create mode 100644 Documentation/admin-guide/syscall-user-dispatch.rst create mode 100644 include/linux/syscall_intercept.h create mode 100644 include/linux/syscall_user_dispatch.h create mode 100644 kernel/entry/common.h create mode 100644 kernel/entry/syscall_user_dispatch.c create mode 100644 tools/testing/selftests/syscall_user_dispatch/.gitignore create mode 100644 tools/testing/selftests/syscall_user_dispatch/Makefile create mode 100644 tools/testing/selftests/syscall_user_dispatch/config create mode 100644 tools/testing/selftests/syscall_user_dispatch/syscall_user_dispatch.c -- 2.28.0

4 years, 9 months

9
39
0 0

[PATCH v8 1/3] rseq/membarrier: add MEMBARRIER_CMD_PRIVATE_EXPEDITED_RSEQ

by Peter Oskolkov

This patchset is based on Google-internal RSEQ work done by Paul Turner and Andrew Hunter. When working with per-CPU RSEQ-based memory allocations, it is sometimes important to make sure that a global memory location is no longer accessed from RSEQ critical sections. For example, there can be two per-CPU lists, one is "active" and accessed per-CPU, while another one is inactive and worked on asynchronously "off CPU" (e.g. garbage collection is performed). Then at some point the two lists are swapped, and a fast RCU-like mechanism is required to make sure that the previously active list is no longer accessed. This patch introduces such a mechanism: in short, membarrier() syscall issues an IPI to a CPU, restarting a potentially active RSEQ critical section on the CPU. v1->v2: - removed the ability to IPI all CPUs in a single sycall; - use task->mm rather than task->group_leader to identify tasks belonging to the same process. v2->v3: - re-added the ability to IPI all CPUs in a single syscall; - integrated with membarrier_private_expedited() to make sure only CPUs running tasks with the same mm as the current task are interrupted; - also added MEMBARRIER_CMD_REGISTER_PRIVATE_EXPEDITED_RSEQ; - flags in membarrier_private_expedited are never actually bit flags but always distinct values (i.e. never two flags are combined), so I modified bit testing to full equation comparison for simplicity (otherwise the code needs to work when several bits are set, for example). v3->v4: - added the third parameter to membarrier syscall: @cpu_id: if @flags == MEMBARRIER_CMD_FLAG_CPU, then @cpu_id indicates the cpu on which RSEQ CS should be restarted. v4->v5: - added @cpu_id parameter to sys_membarrier in syscalls.h. v5->v6: - made membarrier_private_expedited more efficient in a single-cpu case; - a couple of minor refactorings. v6->v7: - made @flags an unsigned int in sys_membarrier; - a couple of minor refactorings. v7->v8: - replaced BUG_ON with WARN_ON_ONCE in membarrier.c. The second patch in the patchset adds a selftest of this feature. Signed-off-by: Peter Oskolkov <posk(a)google.com> --- include/linux/sched/mm.h | 3 + include/linux/syscalls.h | 2 +- include/uapi/linux/membarrier.h | 26 ++++++ kernel/sched/membarrier.c | 136 +++++++++++++++++++++++++------- 4 files changed, 136 insertions(+), 31 deletions(-) diff --git a/include/linux/sched/mm.h b/include/linux/sched/mm.h index f889e332912f..15bfb06f2884 100644 --- a/include/linux/sched/mm.h +++ b/include/linux/sched/mm.h @@ -348,10 +348,13 @@ enum { MEMBARRIER_STATE_GLOBAL_EXPEDITED = (1U << 3), MEMBARRIER_STATE_PRIVATE_EXPEDITED_SYNC_CORE_READY = (1U << 4), MEMBARRIER_STATE_PRIVATE_EXPEDITED_SYNC_CORE = (1U << 5), + MEMBARRIER_STATE_PRIVATE_EXPEDITED_RSEQ_READY = (1U << 6), + MEMBARRIER_STATE_PRIVATE_EXPEDITED_RSEQ = (1U << 7), }; enum { MEMBARRIER_FLAG_SYNC_CORE = (1U << 0), + MEMBARRIER_FLAG_RSEQ = (1U << 1), }; #ifdef CONFIG_ARCH_HAS_MEMBARRIER_CALLBACKS diff --git a/include/linux/syscalls.h b/include/linux/syscalls.h index 75ac7f8ae93c..466c993e52bf 100644 --- a/include/linux/syscalls.h +++ b/include/linux/syscalls.h @@ -974,7 +974,7 @@ asmlinkage long sys_execveat(int dfd, const char __user *filename, const char __user *const __user *argv, const char __user *const __user *envp, int flags); asmlinkage long sys_userfaultfd(int flags); -asmlinkage long sys_membarrier(int cmd, int flags); +asmlinkage long sys_membarrier(int cmd, int flags, int cpu_id); asmlinkage long sys_mlock2(unsigned long start, size_t len, int flags); asmlinkage long sys_copy_file_range(int fd_in, loff_t __user *off_in, int fd_out, loff_t __user *off_out, diff --git a/include/uapi/linux/membarrier.h b/include/uapi/linux/membarrier.h index 5891d7614c8c..737605897f36 100644 --- a/include/uapi/linux/membarrier.h +++ b/include/uapi/linux/membarrier.h @@ -114,6 +114,26 @@ * If this command is not implemented by an * architecture, -EINVAL is returned. * Returns 0 on success. + * @MEMBARRIER_CMD_PRIVATE_EXPEDITED_RSEQ: + * Ensure the caller thread, upon return from + * system call, that all its running thread + * siblings have any currently running rseq + * critical sections restarted if @flags + * parameter is 0; if @flags parameter is + * MEMBARRIER_CMD_FLAG_CPU, + * then this operation is performed only + * on CPU indicated by @cpu_id. If this command is + * not implemented by an architecture, -EINVAL + * is returned. A process needs to register its + * intent to use the private expedited rseq + * command prior to using it, otherwise + * this command returns -EPERM. + * @MEMBARRIER_CMD_REGISTER_PRIVATE_EXPEDITED_RSEQ: + * Register the process intent to use + * MEMBARRIER_CMD_PRIVATE_EXPEDITED_RSEQ. + * If this command is not implemented by an + * architecture, -EINVAL is returned. + * Returns 0 on success. * @MEMBARRIER_CMD_SHARED: * Alias to MEMBARRIER_CMD_GLOBAL. Provided for * header backward compatibility. @@ -131,9 +151,15 @@ enum membarrier_cmd { MEMBARRIER_CMD_REGISTER_PRIVATE_EXPEDITED = (1 << 4), MEMBARRIER_CMD_PRIVATE_EXPEDITED_SYNC_CORE = (1 << 5), MEMBARRIER_CMD_REGISTER_PRIVATE_EXPEDITED_SYNC_CORE = (1 << 6), + MEMBARRIER_CMD_PRIVATE_EXPEDITED_RSEQ = (1 << 7), + MEMBARRIER_CMD_REGISTER_PRIVATE_EXPEDITED_RSEQ = (1 << 8), /* Alias for header backward compatibility. */ MEMBARRIER_CMD_SHARED = MEMBARRIER_CMD_GLOBAL, }; +enum membarrier_cmd_flag { + MEMBARRIER_CMD_FLAG_CPU = (1 << 0), +}; + #endif /* _UAPI_LINUX_MEMBARRIER_H */ diff --git a/kernel/sched/membarrier.c b/kernel/sched/membarrier.c index 168479a7d61b..e23e74d52db5 100644 --- a/kernel/sched/membarrier.c +++ b/kernel/sched/membarrier.c @@ -18,6 +18,14 @@ #define MEMBARRIER_PRIVATE_EXPEDITED_SYNC_CORE_BITMASK 0 #endif +#ifdef CONFIG_RSEQ +#define MEMBARRIER_CMD_PRIVATE_EXPEDITED_RSEQ_BITMASK \ + (MEMBARRIER_CMD_PRIVATE_EXPEDITED_RSEQ \ + | MEMBARRIER_CMD_REGISTER_PRIVATE_EXPEDITED_RSEQ_BITMASK) +#else +#define MEMBARRIER_CMD_PRIVATE_EXPEDITED_RSEQ_BITMASK 0 +#endif + #define MEMBARRIER_CMD_BITMASK \ (MEMBARRIER_CMD_GLOBAL | MEMBARRIER_CMD_GLOBAL_EXPEDITED \ | MEMBARRIER_CMD_REGISTER_GLOBAL_EXPEDITED \ @@ -30,6 +38,11 @@ static void ipi_mb(void *info) smp_mb(); /* IPIs should be serializing but paranoid. */ } +static void ipi_rseq(void *info) +{ + rseq_preempt(current); +} + static void ipi_sync_rq_state(void *info) { struct mm_struct *mm = (struct mm_struct *) info; @@ -129,19 +142,27 @@ static int membarrier_global_expedited(void) return 0; } -static int membarrier_private_expedited(int flags) +static int membarrier_private_expedited(int flags, int cpu_id) { - int cpu; cpumask_var_t tmpmask; struct mm_struct *mm = current->mm; + smp_call_func_t ipi_func = ipi_mb; - if (flags & MEMBARRIER_FLAG_SYNC_CORE) { + if (flags == MEMBARRIER_FLAG_SYNC_CORE) { if (!IS_ENABLED(CONFIG_ARCH_HAS_MEMBARRIER_SYNC_CORE)) return -EINVAL; if (!(atomic_read(&mm->membarrier_state) & MEMBARRIER_STATE_PRIVATE_EXPEDITED_SYNC_CORE_READY)) return -EPERM; + } else if (flags == MEMBARRIER_FLAG_RSEQ) { + if (!IS_ENABLED(CONFIG_RSEQ)) + return -EINVAL; + if (!(atomic_read(&mm->membarrier_state) & + MEMBARRIER_STATE_PRIVATE_EXPEDITED_RSEQ_READY)) + return -EPERM; + ipi_func = ipi_rseq; } else { + WARN_ON_ONCE(flags); if (!(atomic_read(&mm->membarrier_state) & MEMBARRIER_STATE_PRIVATE_EXPEDITED_READY)) return -EPERM; @@ -156,35 +177,59 @@ static int membarrier_private_expedited(int flags) */ smp_mb(); /* system call entry is not a mb. */ - if (!zalloc_cpumask_var(&tmpmask, GFP_KERNEL)) + if (cpu_id < 0 && !zalloc_cpumask_var(&tmpmask, GFP_KERNEL)) return -ENOMEM; cpus_read_lock(); - rcu_read_lock(); - for_each_online_cpu(cpu) { + + if (cpu_id >= 0) { struct task_struct *p; - /* - * Skipping the current CPU is OK even through we can be - * migrated at any point. The current CPU, at the point - * where we read raw_smp_processor_id(), is ensured to - * be in program order with respect to the caller - * thread. Therefore, we can skip this CPU from the - * iteration. - */ - if (cpu == raw_smp_processor_id()) - continue; - p = rcu_dereference(cpu_rq(cpu)->curr); - if (p && p->mm == mm) - __cpumask_set_cpu(cpu, tmpmask); + if (cpu_id >= nr_cpu_ids || !cpu_online(cpu_id)) + goto out; + if (cpu_id == raw_smp_processor_id()) + goto out; + rcu_read_lock(); + p = rcu_dereference(cpu_rq(cpu_id)->curr); + if (!p || p->mm != mm) { + rcu_read_unlock(); + goto out; + } + rcu_read_unlock(); + } else { + int cpu; + + rcu_read_lock(); + for_each_online_cpu(cpu) { + struct task_struct *p; + + /* + * Skipping the current CPU is OK even through we can be + * migrated at any point. The current CPU, at the point + * where we read raw_smp_processor_id(), is ensured to + * be in program order with respect to the caller + * thread. Therefore, we can skip this CPU from the + * iteration. + */ + if (cpu == raw_smp_processor_id()) + continue; + p = rcu_dereference(cpu_rq(cpu)->curr); + if (p && p->mm == mm) + __cpumask_set_cpu(cpu, tmpmask); + } + rcu_read_unlock(); } - rcu_read_unlock(); preempt_disable(); - smp_call_function_many(tmpmask, ipi_mb, NULL, 1); + if (cpu_id >= 0) + smp_call_function_single(cpu_id, ipi_func, NULL, 1); + else + smp_call_function_many(tmpmask, ipi_func, NULL, 1); preempt_enable(); - free_cpumask_var(tmpmask); +out: + if (cpu_id < 0) + free_cpumask_var(tmpmask); cpus_read_unlock(); /* @@ -283,11 +328,18 @@ static int membarrier_register_private_expedited(int flags) set_state = MEMBARRIER_STATE_PRIVATE_EXPEDITED, ret; - if (flags & MEMBARRIER_FLAG_SYNC_CORE) { + if (flags == MEMBARRIER_FLAG_SYNC_CORE) { if (!IS_ENABLED(CONFIG_ARCH_HAS_MEMBARRIER_SYNC_CORE)) return -EINVAL; ready_state = MEMBARRIER_STATE_PRIVATE_EXPEDITED_SYNC_CORE_READY; + } else if (flags == MEMBARRIER_FLAG_RSEQ) { + if (!IS_ENABLED(CONFIG_RSEQ)) + return -EINVAL; + ready_state = + MEMBARRIER_STATE_PRIVATE_EXPEDITED_RSEQ_READY; + } else { + WARN_ON_ONCE(flags); } /* @@ -299,6 +351,8 @@ static int membarrier_register_private_expedited(int flags) return 0; if (flags & MEMBARRIER_FLAG_SYNC_CORE) set_state |= MEMBARRIER_STATE_PRIVATE_EXPEDITED_SYNC_CORE; + if (flags & MEMBARRIER_FLAG_RSEQ) + set_state |= MEMBARRIER_STATE_PRIVATE_EXPEDITED_RSEQ; atomic_or(set_state, &mm->membarrier_state); ret = sync_runqueues_membarrier_state(mm); if (ret) @@ -310,8 +364,15 @@ static int membarrier_register_private_expedited(int flags) /** * sys_membarrier - issue memory barriers on a set of threads - * @cmd: Takes command values defined in enum membarrier_cmd. - * @flags: Currently needs to be 0. For future extensions. + * @cmd: Takes command values defined in enum membarrier_cmd. + * @flags: Currently needs to be 0 for all commands other than + * MEMBARRIER_CMD_PRIVATE_EXPEDITED_RSEQ: in the latter + * case it can be MEMBARRIER_CMD_FLAG_CPU, indicating that @cpu_id + * contains the CPU on which to interrupt (= restart) + * the RSEQ critical section. + * @cpu_id: if @flags == MEMBARRIER_CMD_FLAG_CPU, indicates the cpu on which + * RSEQ CS should be interrupted (@cmd must be + * MEMBARRIER_CMD_PRIVATE_EXPEDITED_RSEQ). * * If this system call is not implemented, -ENOSYS is returned. If the * command specified does not exist, not available on the running @@ -337,10 +398,21 @@ static int membarrier_register_private_expedited(int flags) * smp_mb() X O O * sys_membarrier() O O O */ -SYSCALL_DEFINE2(membarrier, int, cmd, int, flags) +SYSCALL_DEFINE3(membarrier, int, cmd, unsigned int, flags, int, cpu_id) { - if (unlikely(flags)) - return -EINVAL; + switch (cmd) { + case MEMBARRIER_CMD_PRIVATE_EXPEDITED_RSEQ: + if (unlikely(flags && flags != MEMBARRIER_CMD_FLAG_CPU)) + return -EINVAL; + break; + default: + if (unlikely(flags)) + return -EINVAL; + } + + if (!(flags & MEMBARRIER_CMD_FLAG_CPU)) + cpu_id = -1; + switch (cmd) { case MEMBARRIER_CMD_QUERY: { @@ -362,13 +434,17 @@ SYSCALL_DEFINE2(membarrier, int, cmd, int, flags) case MEMBARRIER_CMD_REGISTER_GLOBAL_EXPEDITED: return membarrier_register_global_expedited(); case MEMBARRIER_CMD_PRIVATE_EXPEDITED: - return membarrier_private_expedited(0); + return membarrier_private_expedited(0, cpu_id); case MEMBARRIER_CMD_REGISTER_PRIVATE_EXPEDITED: return membarrier_register_private_expedited(0); case MEMBARRIER_CMD_PRIVATE_EXPEDITED_SYNC_CORE: - return membarrier_private_expedited(MEMBARRIER_FLAG_SYNC_CORE); + return membarrier_private_expedited(MEMBARRIER_FLAG_SYNC_CORE, cpu_id); case MEMBARRIER_CMD_REGISTER_PRIVATE_EXPEDITED_SYNC_CORE: return membarrier_register_private_expedited(MEMBARRIER_FLAG_SYNC_CORE); + case MEMBARRIER_CMD_PRIVATE_EXPEDITED_RSEQ: + return membarrier_private_expedited(MEMBARRIER_FLAG_RSEQ, cpu_id); + case MEMBARRIER_CMD_REGISTER_PRIVATE_EXPEDITED_RSEQ: + return membarrier_register_private_expedited(MEMBARRIER_FLAG_RSEQ); default: return -EINVAL; } -- 2.28.0.709.gb0816b6eb0-goog

4 years, 9 months

3
8
0 0

[PATCH bpf-next 4/4] selftest: bpf: Test copying a sockmap and sockhash

by Lorenz Bauer

Since we can now call map_update_elem(sockmap) from bpf_iter context it's possible to copy a sockmap or sockhash in the kernel. Add a selftest which exercises this. Signed-off-by: Lorenz Bauer <lmb(a)cloudflare.com> --- .../selftests/bpf/prog_tests/sockmap_basic.c | 14 +++++----- .../selftests/bpf/progs/bpf_iter_sockmap.c | 27 +++++++++++++++---- 2 files changed, 30 insertions(+), 11 deletions(-) diff --git a/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c b/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c index e8a4bfb4d9f4..854a508e81ce 100644 --- a/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c +++ b/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c @@ -194,7 +194,7 @@ static void test_sockmap_invalid_update(void) test_sockmap_invalid_update__destroy(skel); } -static void test_sockmap_iter(enum bpf_map_type map_type) +static void test_sockmap_copy(enum bpf_map_type map_type) { DECLARE_LIBBPF_OPTS(bpf_iter_attach_opts, opts); int err, len, src_fd, iter_fd, duration = 0; @@ -242,7 +242,7 @@ static void test_sockmap_iter(enum bpf_map_type map_type) linfo.map.map_fd = src_fd; opts.link_info = &linfo; opts.link_info_len = sizeof(linfo); - link = bpf_program__attach_iter(skel->progs.count_elems, &opts); + link = bpf_program__attach_iter(skel->progs.copy, &opts); if (CHECK(IS_ERR(link), "attach_iter", "attach_iter failed\n")) goto out; @@ -265,6 +265,8 @@ static void test_sockmap_iter(enum bpf_map_type map_type) skel->bss->socks, num_sockets)) goto close_iter; + compare_cookies(src, skel->maps.dst); + close_iter: close(iter_fd); free_link: @@ -294,8 +296,8 @@ void test_sockmap_basic(void) test_sockmap_update(BPF_MAP_TYPE_SOCKHASH); if (test__start_subtest("sockmap update in unsafe context")) test_sockmap_invalid_update(); - if (test__start_subtest("sockmap iter")) - test_sockmap_iter(BPF_MAP_TYPE_SOCKMAP); - if (test__start_subtest("sockhash iter")) - test_sockmap_iter(BPF_MAP_TYPE_SOCKHASH); + if (test__start_subtest("sockmap copy")) + test_sockmap_copy(BPF_MAP_TYPE_SOCKMAP); + if (test__start_subtest("sockhash copy")) + test_sockmap_copy(BPF_MAP_TYPE_SOCKHASH); } diff --git a/tools/testing/selftests/bpf/progs/bpf_iter_sockmap.c b/tools/testing/selftests/bpf/progs/bpf_iter_sockmap.c index 1af7555f6057..f3af0e30cead 100644 --- a/tools/testing/selftests/bpf/progs/bpf_iter_sockmap.c +++ b/tools/testing/selftests/bpf/progs/bpf_iter_sockmap.c @@ -22,21 +22,38 @@ struct { __type(value, __u64); } sockhash SEC(".maps"); +struct { + __uint(type, BPF_MAP_TYPE_SOCKHASH); + __uint(max_entries, 64); + __type(key, __u32); + __type(value, __u64); +} dst SEC(".maps"); + __u32 elems = 0; __u32 socks = 0; SEC("iter/sockmap") -int count_elems(struct bpf_iter__sockmap *ctx) +int copy(struct bpf_iter__sockmap *ctx) { struct sock *sk = ctx->sk; __u32 tmp, *key = ctx->key; int ret; - if (key) - elems++; + if (!key) + return 0; - if (sk) + elems++; + + /* We need a temporary buffer on the stack, since the verifier doesn't + * let us use the pointer from the context as an argument to the helper. + */ + tmp = *key; + + if (sk) { socks++; + return bpf_map_update_elem(&dst, &tmp, sk, 0) != 0; + } - return 0; + ret = bpf_map_delete_elem(&dst, &tmp); + return ret && ret != -ENOENT; } -- 2.25.1

4 years, 9 months

1
0
0 0

[PATCH bpf-next 3/4] bpf: selftests: remove shared header from sockmap iter test

by Lorenz Bauer

The shared header to define SOCKMAP_MAX_ENTRIES is a bit overkill. Dynamically allocate the sock_fd array based on bpf_map__max_entries instead. Suggested-by: Yonghong Song <yhs(a)fb.com> Signed-off-by: Lorenz Bauer <lmb(a)cloudflare.com> Acked-by: Yonghong Song <yhs(a)fb.com> --- .../selftests/bpf/prog_tests/sockmap_basic.c | 36 +++++++++---------- .../selftests/bpf/progs/bpf_iter_sockmap.c | 5 ++- .../selftests/bpf/progs/bpf_iter_sockmap.h | 3 -- 3 files changed, 20 insertions(+), 24 deletions(-) delete mode 100644 tools/testing/selftests/bpf/progs/bpf_iter_sockmap.h diff --git a/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c b/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c index 67d3301bdf81..e8a4bfb4d9f4 100644 --- a/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c +++ b/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c @@ -8,8 +8,6 @@ #include "test_sockmap_invalid_update.skel.h" #include "bpf_iter_sockmap.skel.h" -#include "progs/bpf_iter_sockmap.h" - #define TCP_REPAIR 19 /* TCP sock is under repair right now */ #define TCP_REPAIR_ON 1 @@ -201,9 +199,9 @@ static void test_sockmap_iter(enum bpf_map_type map_type) DECLARE_LIBBPF_OPTS(bpf_iter_attach_opts, opts); int err, len, src_fd, iter_fd, duration = 0; union bpf_iter_link_info linfo = {0}; - __s64 sock_fd[SOCKMAP_MAX_ENTRIES]; - __u32 i, num_sockets, max_elems; + __u32 i, num_sockets, num_elems; struct bpf_iter_sockmap *skel; + __s64 *sock_fd = NULL; struct bpf_link *link; struct bpf_map *src; char buf[64]; @@ -212,22 +210,23 @@ static void test_sockmap_iter(enum bpf_map_type map_type) if (CHECK(!skel, "bpf_iter_sockmap__open_and_load", "skeleton open_and_load failed\n")) return; - for (i = 0; i < ARRAY_SIZE(sock_fd); i++) - sock_fd[i] = -1; - - /* Make sure we have at least one "empty" entry to test iteration of - * an empty slot. - */ - num_sockets = ARRAY_SIZE(sock_fd) - 1; - if (map_type == BPF_MAP_TYPE_SOCKMAP) { src = skel->maps.sockmap; - max_elems = bpf_map__max_entries(src); + num_elems = bpf_map__max_entries(src); + num_sockets = num_elems - 1; } else { src = skel->maps.sockhash; - max_elems = num_sockets; + num_elems = bpf_map__max_entries(src) - 1; + num_sockets = num_elems; } + sock_fd = calloc(num_sockets, sizeof(*sock_fd)); + if (CHECK(!sock_fd, "calloc(sock_fd)", "failed to allocate\n")) + goto out; + + for (i = 0; i < num_sockets; i++) + sock_fd[i] = -1; + src_fd = bpf_map__fd(src); for (i = 0; i < num_sockets; i++) { @@ -258,8 +257,8 @@ static void test_sockmap_iter(enum bpf_map_type map_type) goto close_iter; /* test results */ - if (CHECK(skel->bss->elems != max_elems, "elems", "got %u expected %u\n", - skel->bss->elems, max_elems)) + if (CHECK(skel->bss->elems != num_elems, "elems", "got %u expected %u\n", + skel->bss->elems, num_elems)) goto close_iter; if (CHECK(skel->bss->socks != num_sockets, "socks", "got %u expected %u\n", @@ -271,10 +270,11 @@ static void test_sockmap_iter(enum bpf_map_type map_type) free_link: bpf_link__destroy(link); out: - for (i = 0; i < num_sockets; i++) { + for (i = 0; sock_fd && i < num_sockets; i++) if (sock_fd[i] >= 0) close(sock_fd[i]); - } + if (sock_fd) + free(sock_fd); bpf_iter_sockmap__destroy(skel); } diff --git a/tools/testing/selftests/bpf/progs/bpf_iter_sockmap.c b/tools/testing/selftests/bpf/progs/bpf_iter_sockmap.c index 0e27f73dd803..1af7555f6057 100644 --- a/tools/testing/selftests/bpf/progs/bpf_iter_sockmap.c +++ b/tools/testing/selftests/bpf/progs/bpf_iter_sockmap.c @@ -2,7 +2,6 @@ /* Copyright (c) 2020 Cloudflare */ #include "bpf_iter.h" #include "bpf_tracing_net.h" -#include "bpf_iter_sockmap.h" #include <bpf/bpf_helpers.h> #include <bpf/bpf_tracing.h> #include <errno.h> @@ -11,14 +10,14 @@ char _license[] SEC("license") = "GPL"; struct { __uint(type, BPF_MAP_TYPE_SOCKMAP); - __uint(max_entries, SOCKMAP_MAX_ENTRIES); + __uint(max_entries, 64); __type(key, __u32); __type(value, __u64); } sockmap SEC(".maps"); struct { __uint(type, BPF_MAP_TYPE_SOCKHASH); - __uint(max_entries, SOCKMAP_MAX_ENTRIES); + __uint(max_entries, 64); __type(key, __u32); __type(value, __u64); } sockhash SEC(".maps"); diff --git a/tools/testing/selftests/bpf/progs/bpf_iter_sockmap.h b/tools/testing/selftests/bpf/progs/bpf_iter_sockmap.h deleted file mode 100644 index 35a675d13c0f..000000000000 --- a/tools/testing/selftests/bpf/progs/bpf_iter_sockmap.h +++ /dev/null @@ -1,3 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0 */ - -#define SOCKMAP_MAX_ENTRIES (64) -- 2.25.1

4 years, 9 months

1
0
0 0

[PATCH bpf-next 2/4] selftests: bpf: Add helper to compare socket cookies

by Lorenz Bauer

We compare socket cookies to ensure that insertion into a sockmap worked. Pull this out into a helper function for use in other tests. Signed-off-by: Lorenz Bauer <lmb(a)cloudflare.com> --- .../selftests/bpf/prog_tests/sockmap_basic.c | 50 +++++++++++++------ 1 file changed, 36 insertions(+), 14 deletions(-) diff --git a/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c b/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c index 4b7a527e7e82..67d3301bdf81 100644 --- a/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c +++ b/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c @@ -50,6 +50,37 @@ static int connected_socket_v4(void) return -1; } +static void compare_cookies(struct bpf_map *src, struct bpf_map *dst) +{ + __u32 i, max_entries = bpf_map__max_entries(src); + int err, duration, src_fd, dst_fd; + + src_fd = bpf_map__fd(src); + dst_fd = bpf_map__fd(dst); + + for (i = 0; i < max_entries; i++) { + __u64 src_cookie, dst_cookie; + + err = bpf_map_lookup_elem(src_fd, &i, &src_cookie); + if (err && errno == ENOENT) { + err = bpf_map_lookup_elem(dst_fd, &i, &dst_cookie); + CHECK(!err, "map_lookup_elem(dst)", "element %u not deleted\n", i); + CHECK(err && errno != ENOENT, "map_lookup_elem(dst)", "%s\n", + strerror(errno)); + continue; + } + if (CHECK(err, "lookup_elem(src)", "%s\n", strerror(errno))) + continue; + + err = bpf_map_lookup_elem(dst_fd, &i, &dst_cookie); + if (CHECK(err, "lookup_elem(dst)", "%s\n", strerror(errno))) + continue; + + CHECK(dst_cookie != src_cookie, "cookie mismatch", + "%llu != %llu (pos %u)\n", dst_cookie, src_cookie, i); + } +} + /* Create a map, populate it with one socket, and free the map. */ static void test_sockmap_create_update_free(enum bpf_map_type map_type) { @@ -109,9 +140,9 @@ static void test_skmsg_helpers(enum bpf_map_type map_type) static void test_sockmap_update(enum bpf_map_type map_type) { struct bpf_prog_test_run_attr tattr; - int err, prog, src, dst, duration = 0; + int err, prog, src, duration = 0; struct test_sockmap_update *skel; - __u64 src_cookie, dst_cookie; + struct bpf_map *dst_map; const __u32 zero = 0; char dummy[14] = {0}; __s64 sk; @@ -127,18 +158,14 @@ static void test_sockmap_update(enum bpf_map_type map_type) prog = bpf_program__fd(skel->progs.copy_sock_map); src = bpf_map__fd(skel->maps.src); if (map_type == BPF_MAP_TYPE_SOCKMAP) - dst = bpf_map__fd(skel->maps.dst_sock_map); + dst_map = skel->maps.dst_sock_map; else - dst = bpf_map__fd(skel->maps.dst_sock_hash); + dst_map = skel->maps.dst_sock_hash; err = bpf_map_update_elem(src, &zero, &sk, BPF_NOEXIST); if (CHECK(err, "update_elem(src)", "errno=%u\n", errno)) goto out; - err = bpf_map_lookup_elem(src, &zero, &src_cookie); - if (CHECK(err, "lookup_elem(src, cookie)", "errno=%u\n", errno)) - goto out; - tattr = (struct bpf_prog_test_run_attr){ .prog_fd = prog, .repeat = 1, @@ -151,12 +178,7 @@ static void test_sockmap_update(enum bpf_map_type map_type) "errno=%u retval=%u\n", errno, tattr.retval)) goto out; - err = bpf_map_lookup_elem(dst, &zero, &dst_cookie); - if (CHECK(err, "lookup_elem(dst, cookie)", "errno=%u\n", errno)) - goto out; - - CHECK(dst_cookie != src_cookie, "cookie mismatch", "%llu != %llu\n", - dst_cookie, src_cookie); + compare_cookies(skel->maps.src, dst_map); out: test_sockmap_update__destroy(skel); -- 2.25.1

4 years, 9 months

1
0
0 0

[PATCH] kbuild: explicitly specify the build id style

by Bill Wendling

ld's --build-id defaults to "sha1" style, while lld defaults to "fast". The build IDs are very different between the two, which may confuse programs that reference them. Signed-off-by: Bill Wendling <morbo(a)google.com> --- Makefile | 4 ++-- arch/arm/vdso/Makefile | 2 +- arch/arm64/kernel/vdso/Makefile | 2 +- arch/arm64/kernel/vdso32/Makefile | 2 +- arch/mips/vdso/Makefile | 2 +- arch/riscv/kernel/vdso/Makefile | 2 +- arch/s390/kernel/vdso64/Makefile | 2 +- arch/sparc/vdso/Makefile | 2 +- arch/x86/entry/vdso/Makefile | 2 +- tools/testing/selftests/bpf/Makefile | 2 +- 10 files changed, 11 insertions(+), 11 deletions(-) diff --git a/Makefile b/Makefile index 2b66d3398878..7e6f41c9803a 100644 --- a/Makefile +++ b/Makefile @@ -973,8 +973,8 @@ KBUILD_CPPFLAGS += $(KCPPFLAGS) KBUILD_AFLAGS += $(KAFLAGS) KBUILD_CFLAGS += $(KCFLAGS) -KBUILD_LDFLAGS_MODULE += --build-id -LDFLAGS_vmlinux += --build-id +KBUILD_LDFLAGS_MODULE += --build-id=sha1 +LDFLAGS_vmlinux += --build-id=sha1 ifeq ($(CONFIG_STRIP_ASM_SYMS),y) LDFLAGS_vmlinux += $(call ld-option, -X,) diff --git a/arch/arm/vdso/Makefile b/arch/arm/vdso/Makefile index a54f70731d9f..150ce6e6a5d3 100644 --- a/arch/arm/vdso/Makefile +++ b/arch/arm/vdso/Makefile @@ -19,7 +19,7 @@ ccflags-y += -DDISABLE_BRANCH_PROFILING -DBUILD_VDSO32 ldflags-$(CONFIG_CPU_ENDIAN_BE8) := --be8 ldflags-y := -Bsymbolic --no-undefined -soname=linux-vdso.so.1 \ -z max-page-size=4096 -nostdlib -shared $(ldflags-y) \ - --hash-style=sysv --build-id \ + --hash-style=sysv --build-id=sha1 \ -T obj-$(CONFIG_VDSO) += vdso.o diff --git a/arch/arm64/kernel/vdso/Makefile b/arch/arm64/kernel/vdso/Makefile index 45d5cfe46429..871915097f9d 100644 --- a/arch/arm64/kernel/vdso/Makefile +++ b/arch/arm64/kernel/vdso/Makefile @@ -24,7 +24,7 @@ btildflags-$(CONFIG_ARM64_BTI_KERNEL) += -z force-bti # routines, as x86 does (see 6f121e548f83 ("x86, vdso: Reimplement vdso.so # preparation in build-time C")). ldflags-y := -shared -nostdlib -soname=linux-vdso.so.1 --hash-style=sysv \ - -Bsymbolic $(call ld-option, --no-eh-frame-hdr) --build-id -n \ + -Bsymbolic $(call ld-option, --no-eh-frame-hdr) --build-id=sha1 -n \ $(btildflags-y) -T ccflags-y := -fno-common -fno-builtin -fno-stack-protector -ffixed-x18 diff --git a/arch/arm64/kernel/vdso32/Makefile b/arch/arm64/kernel/vdso32/Makefile index d6adb4677c25..4fa4b3fe8efb 100644 --- a/arch/arm64/kernel/vdso32/Makefile +++ b/arch/arm64/kernel/vdso32/Makefile @@ -128,7 +128,7 @@ VDSO_LDFLAGS += -Wl,-Bsymbolic -Wl,--no-undefined -Wl,-soname=linux-vdso.so.1 VDSO_LDFLAGS += -Wl,-z,max-page-size=4096 -Wl,-z,common-page-size=4096 VDSO_LDFLAGS += -nostdlib -shared -mfloat-abi=soft VDSO_LDFLAGS += -Wl,--hash-style=sysv -VDSO_LDFLAGS += -Wl,--build-id +VDSO_LDFLAGS += -Wl,--build-id=sha1 VDSO_LDFLAGS += $(call cc32-ldoption,-fuse-ld=bfd) diff --git a/arch/mips/vdso/Makefile b/arch/mips/vdso/Makefile index 57fe83235281..5810cc12bc1d 100644 --- a/arch/mips/vdso/Makefile +++ b/arch/mips/vdso/Makefile @@ -61,7 +61,7 @@ endif # VDSO linker flags. ldflags-y := -Bsymbolic --no-undefined -soname=linux-vdso.so.1 \ $(filter -E%,$(KBUILD_CFLAGS)) -nostdlib -shared \ - -G 0 --eh-frame-hdr --hash-style=sysv --build-id -T + -G 0 --eh-frame-hdr --hash-style=sysv --build-id=sha1 -T CFLAGS_REMOVE_vdso.o = -pg diff --git a/arch/riscv/kernel/vdso/Makefile b/arch/riscv/kernel/vdso/Makefile index 478e7338ddc1..7d6a94d45ec9 100644 --- a/arch/riscv/kernel/vdso/Makefile +++ b/arch/riscv/kernel/vdso/Makefile @@ -49,7 +49,7 @@ $(obj)/vdso.so.dbg: $(src)/vdso.lds $(obj-vdso) FORCE # refer to these symbols in the kernel code rather than hand-coded addresses. SYSCFLAGS_vdso.so.dbg = -shared -s -Wl,-soname=linux-vdso.so.1 \ - -Wl,--build-id -Wl,--hash-style=both + -Wl,--build-id=sha1 -Wl,--hash-style=both $(obj)/vdso-dummy.o: $(src)/vdso.lds $(obj)/rt_sigreturn.o FORCE $(call if_changed,vdsold) diff --git a/arch/s390/kernel/vdso64/Makefile b/arch/s390/kernel/vdso64/Makefile index 4a66a1cb919b..edc473b32e42 100644 --- a/arch/s390/kernel/vdso64/Makefile +++ b/arch/s390/kernel/vdso64/Makefile @@ -19,7 +19,7 @@ KBUILD_AFLAGS_64 += -m64 -s KBUILD_CFLAGS_64 := $(filter-out -m64,$(KBUILD_CFLAGS)) KBUILD_CFLAGS_64 += -m64 -fPIC -shared -fno-common -fno-builtin ldflags-y := -fPIC -shared -nostdlib -soname=linux-vdso64.so.1 \ - --hash-style=both --build-id -T + --hash-style=both --build-id=sha1 -T $(targets:%=$(obj)/%.dbg): KBUILD_CFLAGS = $(KBUILD_CFLAGS_64) $(targets:%=$(obj)/%.dbg): KBUILD_AFLAGS = $(KBUILD_AFLAGS_64) diff --git a/arch/sparc/vdso/Makefile b/arch/sparc/vdso/Makefile index f44355e46f31..469dd23887ab 100644 --- a/arch/sparc/vdso/Makefile +++ b/arch/sparc/vdso/Makefile @@ -115,7 +115,7 @@ quiet_cmd_vdso = VDSO $@ -T $(filter %.lds,$^) $(filter %.o,$^) && \ sh $(srctree)/$(src)/checkundef.sh '$(OBJDUMP)' '$@' -VDSO_LDFLAGS = -shared --hash-style=both --build-id -Bsymbolic +VDSO_LDFLAGS = -shared --hash-style=both --build-id=sha1 -Bsymbolic GCOV_PROFILE := n # diff --git a/arch/x86/entry/vdso/Makefile b/arch/x86/entry/vdso/Makefile index 215376d975a2..ebba25ed9a38 100644 --- a/arch/x86/entry/vdso/Makefile +++ b/arch/x86/entry/vdso/Makefile @@ -176,7 +176,7 @@ quiet_cmd_vdso = VDSO $@ -T $(filter %.lds,$^) $(filter %.o,$^) && \ sh $(srctree)/$(src)/checkundef.sh '$(NM)' '$@' -VDSO_LDFLAGS = -shared --hash-style=both --build-id \ +VDSO_LDFLAGS = -shared --hash-style=both --build-id=sha1 \ $(call ld-option, --eh-frame-hdr) -Bsymbolic GCOV_PROFILE := n diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile index fc946b7ac288..daf186f88a63 100644 --- a/tools/testing/selftests/bpf/Makefile +++ b/tools/testing/selftests/bpf/Makefile @@ -133,7 +133,7 @@ $(OUTPUT)/%:%.c $(OUTPUT)/urandom_read: urandom_read.c $(call msg,BINARY,,$@) - $(Q)$(CC) $(LDFLAGS) -o $@ $< $(LDLIBS) -Wl,--build-id + $(Q)$(CC) $(LDFLAGS) -o $@ $< $(LDLIBS) -Wl,--build-id=sha1 $(OUTPUT)/test_stub.o: test_stub.c $(BPFOBJ) $(call msg,CC,,$@) -- 2.28.0.681.g6f77f65b4e-goog

4 years, 9 months

3
2
0 0

[PATCH] kbuild: explicitly specify the build id style

by Sedat Dilek

[ Please CC me I am not subscribed to all MLs ] [ CC Sami ] Hi Bill, I have tested your patch on top of Sami's latest clang-cfi Git branch. Feel free to add... Tested-by: Sedat Dilek <sedat.dilek(a)gmail.com> # LLVM toolchain version 11.0.0-rc3 on x86-64 Thanks for the patch. Regards, - Sedat -

4 years, 9 months

1
0
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-kselftest-mirror