- Linux-kselftest-mirror - lists.linaro.org

[PATCH net-next] selftests: net: Correct couple of spelling mistakes

by Prabhav Kumar Vaish

Changes : - "excercise" is corrected to "exercise" in drivers/net/mlxsw/spectrum-2/tc_flower.sh - "mutliple" is corrected to "multiple" in drivers/net/netdevsim/ethtool-fec.sh Signed-off-by: Prabhav Kumar Vaish <pvkumar5749404(a)gmail.com> --- .../testing/selftests/drivers/net/mlxsw/spectrum-2/tc_flower.sh | 2 +- tools/testing/selftests/drivers/net/netdevsim/ethtool-fec.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/drivers/net/mlxsw/spectrum-2/tc_flower.sh b/tools/testing/selftests/drivers/net/mlxsw/spectrum-2/tc_flower.sh index 616d3581419c..31252bc8775e 100755 --- a/tools/testing/selftests/drivers/net/mlxsw/spectrum-2/tc_flower.sh +++ b/tools/testing/selftests/drivers/net/mlxsw/spectrum-2/tc_flower.sh @@ -869,7 +869,7 @@ bloom_simple_test() bloom_complex_test() { # Bloom filter index computation is affected from region ID, eRP - # ID and from the region key size. In order to excercise those parts + # ID and from the region key size. In order to exercise those parts # of the Bloom filter code, use a series of regions, each with a # different key size and send packet that should hit all of them. local index diff --git a/tools/testing/selftests/drivers/net/netdevsim/ethtool-fec.sh b/tools/testing/selftests/drivers/net/netdevsim/ethtool-fec.sh index 7d7829f57550..6c52ce1b0450 100755 --- a/tools/testing/selftests/drivers/net/netdevsim/ethtool-fec.sh +++ b/tools/testing/selftests/drivers/net/netdevsim/ethtool-fec.sh @@ -49,7 +49,7 @@ for o in llrs rs; do Active FEC encoding: ${o^^}" done -# Test mutliple bits +# Test multiple bits $ETHTOOL --set-fec $NSIM_NETDEV encoding rs llrs check $? s=$($ETHTOOL --show-fec $NSIM_NETDEV | tail -2) -- 2.34.1

1 year, 4 months

2
1
0 0

[PATCH RFC bpf-next v3 00/16] sleepable bpf_timer (was: allow HID-BPF to do device IOs)

by Benjamin Tissoires

[Partly a RFC/formal submission: there are still FIXMEs in the code] [Also using bpf-next as the base tree for HID changes as there will be conflicting changes otherwise, so I'm personaly fine for the HID commits to go through bpf-next] IMO, patches 1-3 and 9-14 are ready to go, rest is still pending review. For reference, the use cases I have in mind: --- Basically, I need to be able to defer a HID-BPF program for the following reasons (from the aforementioned patch): 1. defer an event: Sometimes we receive an out of proximity event, but the device can not be trusted enough, and we need to ensure that we won't receive another one in the following n milliseconds. So we need to wait those n milliseconds, and eventually re-inject that event in the stack. 2. inject new events in reaction to one given event: We might want to transform one given event into several. This is the case for macro keys where a single key press is supposed to send a sequence of key presses. But this could also be used to patch a faulty behavior, if a device forgets to send a release event. 3. communicate with the device in reaction to one event: We might want to communicate back to the device after a given event. For example a device might send us an event saying that it came back from sleeping state and needs to be re-initialized. Currently we can achieve that by keeping a userspace program around, raise a bpf event, and let that userspace program inject the events and commands. However, we are just keeping that program alive as a daemon for just scheduling commands. There is no logic in it, so it doesn't really justify an actual userspace wakeup. So a kernel workqueue seems simpler to handle. The other part I'm not sure is whether we can say that BPF maps of type queue/stack can be used in sleepable context. I don't see any warning when running the test programs, but that's probably not a guarantee I'm doing the things properly :) Cheers, Benjamin To: Alexei Starovoitov <ast(a)kernel.org> To: Daniel Borkmann <daniel(a)iogearbox.net> To: John Fastabend <john.fastabend(a)gmail.com> To: Andrii Nakryiko <andrii(a)kernel.org> To: Martin KaFai Lau <martin.lau(a)linux.dev> To: Eduard Zingerman <eddyz87(a)gmail.com> To: Song Liu <song(a)kernel.org> To: Yonghong Song <yonghong.song(a)linux.dev> To: KP Singh <kpsingh(a)kernel.org> To: Stanislav Fomichev <sdf(a)google.com> To: Hao Luo <haoluo(a)google.com> To: Jiri Olsa <jolsa(a)kernel.org> To: Jiri Kosina <jikos(a)kernel.org> To: Benjamin Tissoires <benjamin.tissoires(a)redhat.com> To: Jonathan Corbet <corbet(a)lwn.net> To: Shuah Khan <shuah(a)kernel.org> Cc: <bpf(a)vger.kernel.org> Cc: <linux-kernel(a)vger.kernel.org> Cc: <linux-input(a)vger.kernel.org> Cc: <linux-doc(a)vger.kernel.org> Cc: <linux-kselftest(a)vger.kernel.org> Signed-off-by: Benjamin Tissoires <bentiss(a)kernel.org> --- Changes in v3: - fixed the crash from v2 - changed the API to have only BPF_F_TIMER_SLEEPABLE for bpf_timer_start() - split the new kfuncs/verifier patch into several sub-patches, for easier reviews - Link to v2: https://lore.kernel.org/r/20240214-hid-bpf-sleepable-v2-0-5756b054724d@kern… Changes in v2: - make use of bpf_timer (and dropped the custom HID handling) - implemented bpf_timer_set_sleepable_cb as a kfunc - still not implemented global subprogs - no sleepable bpf_timer selftests yet - Link to v1: https://lore.kernel.org/r/20240209-hid-bpf-sleepable-v1-0-4cc895b5adbd@kern… --- Benjamin Tissoires (16): bpf/verifier: allow more maps in sleepable bpf programs bpf/verifier: introduce in_sleepable() helper bpf/verifier: add is_async_callback_calling_insn() helper bpf/helpers: introduce sleepable bpf_timers bpf/verifier: add bpf_timer as a kfunc capable type bpf/helpers: introduce bpf_timer_set_sleepable_cb() kfunc bpf/helpers: mark the callback of bpf_timer_set_sleepable_cb() as sleepable bpf/verifier: do_misc_fixups for is_bpf_timer_set_sleepable_cb_kfunc HID: bpf/dispatch: regroup kfuncs definitions HID: bpf: export hid_hw_output_report as a BPF kfunc selftests/hid: Add test for hid_bpf_hw_output_report HID: bpf: allow to inject HID event from BPF selftests/hid: add tests for hid_bpf_input_report HID: bpf: allow to use bpf_timer_set_sleepable_cb() in tracing callbacks. selftests/hid: add test for bpf_timer selftests/hid: add KASAN to the VM tests Documentation/hid/hid-bpf.rst | 2 +- drivers/hid/bpf/hid_bpf_dispatch.c | 232 ++++++++++++++------- drivers/hid/hid-core.c | 2 + include/linux/bpf_verifier.h | 2 + include/linux/hid_bpf.h | 3 + include/uapi/linux/bpf.h | 4 + kernel/bpf/helpers.c | 140 +++++++++++-- kernel/bpf/verifier.c | 114 ++++++++-- tools/testing/selftests/hid/config.common | 1 + tools/testing/selftests/hid/hid_bpf.c | 195 ++++++++++++++++- tools/testing/selftests/hid/progs/hid.c | 198 ++++++++++++++++++ .../testing/selftests/hid/progs/hid_bpf_helpers.h | 8 + 12 files changed, 795 insertions(+), 106 deletions(-) --- base-commit: 5c331823b3fc52ffd27524bf5b7e0d137114f470 change-id: 20240205-hid-bpf-sleepable-c01260fd91c4 Best regards, -- Benjamin Tissoires <bentiss(a)kernel.org>

1 year, 4 months

5
39
0 0

kselftest/next kselftest-lkdtm: 2 runs, 1 regressions (v6.8-rc1-56-g539cd3f4da3f)

by kernelci.org bot

kselftest/next kselftest-lkdtm: 2 runs, 1 regressions (v6.8-rc1-56-g539cd3f4da3f) Regressions Summary ------------------- platform | arch | lab | compiler | defconfig | regressions ----------------+------+---------------+----------+------------------------------+------------ imx6q-sabrelite | arm | lab-collabora | gcc-10 | multi_v7_defconfig+kselftest | 1 Details: https://kernelci.org/test/job/kselftest/branch/next/kernel/v6.8-rc1-56-g539… Test: kselftest-lkdtm Tree: kselftest Branch: next Describe: v6.8-rc1-56-g539cd3f4da3f URL: https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git SHA: 539cd3f4da3fdbe7dc353634e004e4b0e725c35a Test Regressions ---------------- platform | arch | lab | compiler | defconfig | regressions ----------------+------+---------------+----------+------------------------------+------------ imx6q-sabrelite | arm | lab-collabora | gcc-10 | multi_v7_defconfig+kselftest | 1 Details: https://kernelci.org/test/plan/id/65ded31017d8855223637012 Results: 0 PASS, 1 FAIL, 0 SKIP Full config: multi_v7_defconfig+kselftest Compiler: gcc-10 (arm-linux-gnueabihf-gcc (Debian 10.2.1-6) 10.2.1 20210110) Plain log: https://storage.kernelci.org//kselftest/next/v6.8-rc1-56-g539cd3f4da3f/arm/… HTML log: https://storage.kernelci.org//kselftest/next/v6.8-rc1-56-g539cd3f4da3f/arm/… Rootfs: http://storage.kernelci.org/images/rootfs/debian/bullseye-kselftest/2024012… * kselftest-lkdtm.login: https://kernelci.org/test/case/id/65ded31017d8855223637013 failing since 454 days (last pass: v6.1-rc1-23-g00dd59519141, first fail: v6.1-rc1-23-g8008d88e6d16)

1 year, 4 months

1
0
0 0

kselftest/next build: 5 builds: 2 failed, 3 passed, 2 errors, 5 warnings (v6.8-rc1-56-g539cd3f4da3f)

by kernelci.org bot

kselftest/next build: 5 builds: 2 failed, 3 passed, 2 errors, 5 warnings (v6.8-rc1-56-g539cd3f4da3f) Full Build Summary: https://kernelci.org/build/kselftest/branch/next/kernel/v6.8-rc1-56-g539cd3… Tree: kselftest Branch: next Git Describe: v6.8-rc1-56-g539cd3f4da3f Git Commit: 539cd3f4da3fdbe7dc353634e004e4b0e725c35a Git URL: https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git Built: 4 unique architectures Build Failures Detected: i386: i386_defconfig+kselftest: (gcc-10) FAIL x86_64: x86_64_defconfig+kselftest: (gcc-10) FAIL Errors and Warnings Detected: arm64: defconfig+kselftest (gcc-10): 1 warning arm: multi_v7_defconfig+kselftest (gcc-10): 1 warning i386: i386_defconfig+kselftest (gcc-10): 1 error, 1 warning x86_64: x86_64_defconfig+kselftest (gcc-10): 1 error, 1 warning x86_64_defconfig+kselftest (clang-16): 1 warning Errors summary: 2 include/linux/fortify-string.h:57:29: error: ‘__builtin_memcpy’ offset 32 is out of the bounds [0, 0] [-Werror=array-bounds] Warnings summary: 2 include/linux/fortify-string.h:57:29: warning: ‘__builtin_memcpy’ offset 32 is out of the bounds [0, 0] [-Warray-bounds] 2 cc1: all warnings being treated as errors 1 vmlinux.o: warning: objtool: set_ftrace_ops_ro+0x39: relocation to !ENDBR: .text+0x14cfd6 ================================================================================ Detailed per-defconfig build reports: -------------------------------------------------------------------------------- defconfig+kselftest (arm64, gcc-10) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: include/linux/fortify-string.h:57:29: warning: ‘__builtin_memcpy’ offset 32 is out of the bounds [0, 0] [-Warray-bounds] -------------------------------------------------------------------------------- i386_defconfig+kselftest (i386, gcc-10) — FAIL, 1 error, 1 warning, 0 section mismatches Errors: include/linux/fortify-string.h:57:29: error: ‘__builtin_memcpy’ offset 32 is out of the bounds [0, 0] [-Werror=array-bounds] Warnings: cc1: all warnings being treated as errors -------------------------------------------------------------------------------- multi_v7_defconfig+kselftest (arm, gcc-10) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: include/linux/fortify-string.h:57:29: warning: ‘__builtin_memcpy’ offset 32 is out of the bounds [0, 0] [-Warray-bounds] -------------------------------------------------------------------------------- x86_64_defconfig+kselftest (x86_64, gcc-10) — FAIL, 1 error, 1 warning, 0 section mismatches Errors: include/linux/fortify-string.h:57:29: error: ‘__builtin_memcpy’ offset 32 is out of the bounds [0, 0] [-Werror=array-bounds] Warnings: cc1: all warnings being treated as errors -------------------------------------------------------------------------------- x86_64_defconfig+kselftest (x86_64, clang-16) — PASS, 0 errors, 1 warning, 0 section mismatches Warnings: vmlinux.o: warning: objtool: set_ftrace_ops_ro+0x39: relocation to !ENDBR: .text+0x14cfd6 --- For more info write to <info(a)kernelci.org>

1 year, 4 months

1
0
0 0

[PATCH v2] drm: tests: Fix invalid printf format specifiers in KUnit tests

by David Gow

The drm_buddy_test's alloc_contiguous test used a u64 for the page size, which was then updated to be an 'unsigned long' to avoid 64-bit multiplication division helpers. However, the variable is logged by some KUNIT_ASSERT_EQ_MSG() using the '%d' or '%llu' format specifiers, the former of which is always wrong, and the latter is no longer correct now that ps is no longer a u64. Fix these to all use '%lu'. Also, drm_mm_test calls KUNIT_FAIL() with an empty string as the message. gcc and clang warns if a printf format string is empty, so give these some more detailed error messages, which should be more useful anyway. Fixes: a64056bb5a32 ("drm/tests/drm_buddy: add alloc_contiguous test") Fixes: fca7526b7d89 ("drm/tests/drm_buddy: fix build failure on 32-bit targets") Fixes: fc8d29e298cf ("drm: selftest: convert drm_mm selftest to KUnit") Reviewed-by: Matthew Auld <matthew.auld(a)intel.com> Acked-by: Christian König <christian.koenig(a)amd.com> Tested-by: Guenter Roeck <linux(a)roeck-us.net> Reviewed-by: Justin Stitt <justinstitt(a)google.com> Signed-off-by: David Gow <davidgow(a)google.com> --- Changes since v1: https://lore.kernel.org/linux-kselftest/20240221092728.1281499-8-davidgow@g… - Split this patch out, as the others have been applied already. - Rebase on 6.8-rc6 - Add everyone's {Reviewed,Acked,Tested}-by tags. Thanks! --- drivers/gpu/drm/tests/drm_buddy_test.c | 14 +++++++------- drivers/gpu/drm/tests/drm_mm_test.c | 6 +++--- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/tests/drm_buddy_test.c b/drivers/gpu/drm/tests/drm_buddy_test.c index 2f32fb2f12e7..3dbfa3078449 100644 --- a/drivers/gpu/drm/tests/drm_buddy_test.c +++ b/drivers/gpu/drm/tests/drm_buddy_test.c @@ -55,30 +55,30 @@ static void drm_test_buddy_alloc_contiguous(struct kunit *test) KUNIT_ASSERT_FALSE_MSG(test, drm_buddy_alloc_blocks(&mm, 0, mm_size, ps, ps, list, 0), - "buddy_alloc hit an error size=%u\n", + "buddy_alloc hit an error size=%lu\n", ps); } while (++i < n_pages); KUNIT_ASSERT_TRUE_MSG(test, drm_buddy_alloc_blocks(&mm, 0, mm_size, 3 * ps, ps, &allocated, DRM_BUDDY_CONTIGUOUS_ALLOCATION), - "buddy_alloc didn't error size=%u\n", 3 * ps); + "buddy_alloc didn't error size=%lu\n", 3 * ps); drm_buddy_free_list(&mm, &middle); KUNIT_ASSERT_TRUE_MSG(test, drm_buddy_alloc_blocks(&mm, 0, mm_size, 3 * ps, ps, &allocated, DRM_BUDDY_CONTIGUOUS_ALLOCATION), - "buddy_alloc didn't error size=%u\n", 3 * ps); + "buddy_alloc didn't error size=%lu\n", 3 * ps); KUNIT_ASSERT_TRUE_MSG(test, drm_buddy_alloc_blocks(&mm, 0, mm_size, 2 * ps, ps, &allocated, DRM_BUDDY_CONTIGUOUS_ALLOCATION), - "buddy_alloc didn't error size=%u\n", 2 * ps); + "buddy_alloc didn't error size=%lu\n", 2 * ps); drm_buddy_free_list(&mm, &right); KUNIT_ASSERT_TRUE_MSG(test, drm_buddy_alloc_blocks(&mm, 0, mm_size, 3 * ps, ps, &allocated, DRM_BUDDY_CONTIGUOUS_ALLOCATION), - "buddy_alloc didn't error size=%u\n", 3 * ps); + "buddy_alloc didn't error size=%lu\n", 3 * ps); /* * At this point we should have enough contiguous space for 2 blocks, * however they are never buddies (since we freed middle and right) so @@ -87,13 +87,13 @@ static void drm_test_buddy_alloc_contiguous(struct kunit *test) KUNIT_ASSERT_FALSE_MSG(test, drm_buddy_alloc_blocks(&mm, 0, mm_size, 2 * ps, ps, &allocated, DRM_BUDDY_CONTIGUOUS_ALLOCATION), - "buddy_alloc hit an error size=%u\n", 2 * ps); + "buddy_alloc hit an error size=%lu\n", 2 * ps); drm_buddy_free_list(&mm, &left); KUNIT_ASSERT_FALSE_MSG(test, drm_buddy_alloc_blocks(&mm, 0, mm_size, 3 * ps, ps, &allocated, DRM_BUDDY_CONTIGUOUS_ALLOCATION), - "buddy_alloc hit an error size=%u\n", 3 * ps); + "buddy_alloc hit an error size=%lu\n", 3 * ps); total = 0; list_for_each_entry(block, &allocated, link) diff --git a/drivers/gpu/drm/tests/drm_mm_test.c b/drivers/gpu/drm/tests/drm_mm_test.c index 1eb0c304f960..f37c0d765865 100644 --- a/drivers/gpu/drm/tests/drm_mm_test.c +++ b/drivers/gpu/drm/tests/drm_mm_test.c @@ -157,7 +157,7 @@ static void drm_test_mm_init(struct kunit *test) /* After creation, it should all be one massive hole */ if (!assert_one_hole(test, &mm, 0, size)) { - KUNIT_FAIL(test, ""); + KUNIT_FAIL(test, "mm not one hole on creation"); goto out; } @@ -171,14 +171,14 @@ static void drm_test_mm_init(struct kunit *test) /* After filling the range entirely, there should be no holes */ if (!assert_no_holes(test, &mm)) { - KUNIT_FAIL(test, ""); + KUNIT_FAIL(test, "mm has holes when filled"); goto out; } /* And then after emptying it again, the massive hole should be back */ drm_mm_remove_node(&tmp); if (!assert_one_hole(test, &mm, 0, size)) { - KUNIT_FAIL(test, ""); + KUNIT_FAIL(test, "mm does not have single hole after emptying"); goto out; } -- 2.44.0.rc1.240.g4c46232300-goog

1 year, 4 months

1
0
0 0

[PATCH v2 0/4] Improvements to livepatch kselftests on top of kselftest-next

by Marcos Paulo de Souza

The changes on lib.mk are both for simplification and also clarification, like in the case of not handling TEST_GEN_MODS_DIR directly. There is a new patch to solve one issue reported by build bot. These changes apply on top of the current kselftest-next branch. Please review! Signed-off-by: Marcos Paulo de Souza <mpdesouza(a)suse.com> --- Changes in v2: - Added a new patch to avoid building the modules/running the tests if kernel-devel is not installed. Resolving an issue reported by the build bot. - Reordered the patches, showing the more simple ones first. Besides patch 0002, all the other three didn't changed since v1. - Link to v1: https://lore.kernel.org/r/20240215-lp-selftests-fixes-v1-0-89f4a6f5cddc@sus… --- Marcos Paulo de Souza (4): selftests: livepatch: Add initial .gitignore selftests: livepatch: Avoid running the tests if kernel-devel is missing selftests: lib.mk: Do not process TEST_GEN_MODS_DIR selftests: lib.mk: Simplify TEST_GEN_MODS_DIR handling tools/testing/selftests/lib.mk | 19 +++++++------------ tools/testing/selftests/livepatch/.gitignore | 1 + tools/testing/selftests/livepatch/functions.sh | 13 +++++++++++++ .../testing/selftests/livepatch/test_modules/Makefile | 6 ++++++ 4 files changed, 27 insertions(+), 12 deletions(-) --- base-commit: 6f1a214d446b2f2f9c8c4b96755a8f0316ba4436 change-id: 20240215-lp-selftests-fixes-7d4bab3c0712 Best regards, -- Marcos Paulo de Souza <mpdesouza(a)suse.com>

1 year, 4 months

2
6
0 0

[PATCH v6 0/5] selftests/resctrl: Add non-contiguous CBMs in Intel CAT selftest

by Maciej Wieczor-Retman

Non-contiguous CBM support for Intel CAT has been merged into the kernel with Commit 0e3cd31f6e90 ("x86/resctrl: Enable non-contiguous CBMs in Intel CAT") but there is no selftest that would validate if this feature works correctly. The selftest needs to verify if writing non-contiguous CBMs to the schemata file behaves as expected in comparison to the information about non-contiguous CBMs support. The patch series is based on a rework of resctrl selftests that's currently in review [1]. The patch also implements a similar functionality presented in the bash script included in the cover letter of the original non-contiguous CBMs in Intel CAT series [3]. Changelog v6: - Add Reinette's reviewed-by tag to patch 2/5. - Fix ret type in noncont test. - Add a check for bit_center value in noncont test. - Add resource pointer check in resctrl_mon_feature_exists. - Fix patch 4 leaking into patch 3 by mistake. Changelog v5: - Add a few reviewed-by tags. - Make some minor text changes in patch messages and comments. - Redo resctrl_mon_feature_exists() to be more generic and fix some of my errors in refactoring feature checking. Changelog v4: - Changes to error failure return values in non-contiguous test. - Some minor text refactoring without functional changes. Changelog v3: - Rebase onto v4 of Ilpo's series [1]. - Split old patch 3/4 into two parts. One doing refactoring and one adding a new function. - Some changes to all the patches after Reinette's review. Changelog v2: - Rebase onto v4 of Ilpo's series [2]. - Add two patches that prepare helpers for the new test. - Move Ilpo's patch that adds test grouping to this series. - Apply Ilpo's suggestion to the patch that adds a new test. [1] https://lore.kernel.org/all/20231215150515.36983-1-ilpo.jarvinen@linux.inte… [2] https://lore.kernel.org/all/20231211121826.14392-1-ilpo.jarvinen@linux.inte… [3] https://lore.kernel.org/all/cover.1696934091.git.maciej.wieczor-retman@inte… Older versions of this series: [v1] https://lore.kernel.org/all/20231109112847.432687-1-maciej.wieczor-retman@i… [v2] https://lore.kernel.org/all/cover.1702392177.git.maciej.wieczor-retman@inte… [v3] https://lore.kernel.org/all/cover.1706180726.git.maciej.wieczor-retman@inte… [v4] https://lore.kernel.org/all/cover.1707130307.git.maciej.wieczor-retman@inte… [v5] https://lore.kernel.org/all/cover.1707487039.git.maciej.wieczor-retman@inte… Ilpo Järvinen (1): selftests/resctrl: Add test groups and name L3 CAT test L3_CAT Maciej Wieczor-Retman (4): selftests/resctrl: Add a helper for the non-contiguous test selftests/resctrl: Split validate_resctrl_feature_request() selftests/resctrl: Add resource_info_file_exists() selftests/resctrl: Add non-contiguous CBMs CAT test tools/testing/selftests/resctrl/cat_test.c | 92 +++++++++++++++++- tools/testing/selftests/resctrl/cmt_test.c | 2 +- tools/testing/selftests/resctrl/mba_test.c | 2 +- tools/testing/selftests/resctrl/mbm_test.c | 6 +- tools/testing/selftests/resctrl/resctrl.h | 10 +- .../testing/selftests/resctrl/resctrl_tests.c | 18 +++- tools/testing/selftests/resctrl/resctrlfs.c | 96 ++++++++++++++++--- 7 files changed, 203 insertions(+), 23 deletions(-) -- 2.43.0

1 year, 4 months

4
16
0 0

[PATCH 0/9] kunit: Fix printf format specifier issues in KUnit assertions

by David Gow

KUnit has several macros which accept a log message, which can contain printf format specifiers. Some of these (the explicit log macros) already use the __printf() gcc attribute to ensure the format specifiers are valid, but those which could fail the test, and hence used __kunit_do_failed_assertion() behind the scenes, did not. These include: - KUNIT_EXPECT_*_MSG() - KUNIT_ASSERT_*_MSG() - KUNIT_FAIL() This series adds the __printf() attribute, and fixes all of the issues uncovered. (Or, at least, all of those I could find with an x86_64 allyesconfig, and the default KUnit config on a number of other architectures. Please test!) The issues in question basically take the following forms: - int / long / long long confusion: typically a type being updated, but the format string not. - Use of integer format specifiers (%d/%u/%li/etc) for types like size_t or pointer differences (technically ptrdiff_t), which would only work on some architectures. - Use of integer format specifiers in combination with PTR_ERR(), where %pe would make more sense. - Use of empty messages which, whilst technically not incorrect, are not useful and trigger a gcc warning. We'd like to get these (or equivalent) in for 6.9 if possible, so please do take a look if possible. Thanks, -- David Reported-by: Linus Torvalds <torvalds(a)linux-foundation.org> Closes: https://lore.kernel.org/linux-kselftest/CAHk-=wgJMOquDO5f8ShH1f4rzZwzApNVCw… David Gow (9): kunit: test: Log the correct filter string in executor_test lib/cmdline: Fix an invalid format specifier in an assertion msg lib: memcpy_kunit: Fix an invalid format specifier in an assertion msg time: test: Fix incorrect format specifier rtc: test: Fix invalid format specifier. net: test: Fix printf format specifier in skb_segment kunit test drm: tests: Fix invalid printf format specifiers in KUnit tests drm/xe/tests: Fix printf format specifiers in xe_migrate test kunit: Annotate _MSG assertion variants with gnu printf specifiers drivers/gpu/drm/tests/drm_buddy_test.c | 14 +++++++------- drivers/gpu/drm/tests/drm_mm_test.c | 6 +++--- drivers/gpu/drm/xe/tests/xe_migrate.c | 8 ++++---- drivers/rtc/lib_test.c | 2 +- include/kunit/test.h | 12 ++++++------ kernel/time/time_test.c | 2 +- lib/cmdline_kunit.c | 2 +- lib/kunit/executor_test.c | 2 +- lib/memcpy_kunit.c | 4 ++-- net/core/gso_test.c | 2 +- 10 files changed, 27 insertions(+), 27 deletions(-) -- 2.44.0.rc0.258.g7320e95886-goog

1 year, 4 months

12
42
0 0

[BUG] selftests: cgroup: KMEMLEAK in cgroup/test_cpuset_prs.sh

by Mirsad Todorovac

Hi, everybody, In the latest vanilla torvalds tree kernel v6.8-rc6-11-g45ec2f5f6ed3 on an Ubuntu 23.10 system, there KMEMLEAK detected a couple of memory leaks: Visually it appears like the same leak repeated six times, but I reckoned it might be of importance to review them all. It happened on two boxes, and both have AMD Ryzen processors 7 and 9. Please find attached the build .config Best regards, Mirsad Todorovac # cat /sys/kernel/debug/kmemleak [stack decoded] unreferenced object 0xffff8d49bd92a720 (size 8): comm "test_cpuset_prs", pid 9213, jiffies 4294953562 hex dump (first 8 bytes): 00 00 00 00 00 00 00 00 ........ backtrace (crc 0): kmemleak_alloc (/home/marvin/linux/kernel/linux_torvalds/mm/kmemleak.c:1045) __kmalloc_node (/home/marvin/linux/kernel/linux_torvalds/./include/linux/kmemleak.h:42 /home/marvin/linux/kernel/linux_torvalds/mm/slub.c:3817 /home/marvin/linux/kernel/linux_torvalds/mm/slub.c:3860 /home/marvin/linux/kernel/linux_torvalds/mm/slub.c:3980 /home/marvin/linux/kernel/linux_torvalds/mm/slub.c:3988) alloc_cpumask_var_node (/home/marvin/linux/kernel/linux_torvalds/lib/cpumask.c:71) cpuset_write_resmask (/home/marvin/linux/kernel/linux_torvalds/kernel/cgroup/cpuset.c:643 /home/marvin/linux/kernel/linux_torvalds/kernel/cgroup/cpuset.c:2601 /home/marvin/linux/kernel/linux_torvalds/kernel/cgroup/cpuset.c:3630) cgroup_file_write (/home/marvin/linux/kernel/linux_torvalds/kernel/cgroup/cgroup.c:4092) kernfs_fop_write_iter (/home/marvin/linux/kernel/linux_torvalds/fs/kernfs/file.c:334) vfs_write (/home/marvin/linux/kernel/linux_torvalds/./include/linux/fs.h:2087 /home/marvin/linux/kernel/linux_torvalds/fs/read_write.c:497 /home/marvin/linux/kernel/linux_torvalds/fs/read_write.c:590) ksys_write (/home/marvin/linux/kernel/linux_torvalds/fs/read_write.c:643) __x64_sys_write (/home/marvin/linux/kernel/linux_torvalds/fs/read_write.c:652) do_syscall_64 (/home/marvin/linux/kernel/linux_torvalds/arch/x86/entry/common.c:52 /home/marvin/linux/kernel/linux_torvalds/arch/x86/entry/common.c:83) entry_SYSCALL_64_after_hwframe (/home/marvin/linux/kernel/linux_torvalds/arch/x86/entry/entry_64.S:129) unreferenced object 0xffff8d49bd92a488 (size 8): comm "test_cpuset_prs", pid 9213, jiffies 4294953562 hex dump (first 8 bytes): 00 00 00 00 00 00 00 00 ........ backtrace (crc 0): kmemleak_alloc (/home/marvin/linux/kernel/linux_torvalds/mm/kmemleak.c:1045) __kmalloc_node (/home/marvin/linux/kernel/linux_torvalds/./include/linux/kmemleak.h:42 /home/marvin/linux/kernel/linux_torvalds/mm/slub.c:3817 /home/marvin/linux/kernel/linux_torvalds/mm/slub.c:3860 /home/marvin/linux/kernel/linux_torvalds/mm/slub.c:3980 /home/marvin/linux/kernel/linux_torvalds/mm/slub.c:3988) alloc_cpumask_var_node (/home/marvin/linux/kernel/linux_torvalds/lib/cpumask.c:71) cpuset_write_resmask (/home/marvin/linux/kernel/linux_torvalds/kernel/cgroup/cpuset.c:646 /home/marvin/linux/kernel/linux_torvalds/kernel/cgroup/cpuset.c:2601 /home/marvin/linux/kernel/linux_torvalds/kernel/cgroup/cpuset.c:3630) cgroup_file_write (/home/marvin/linux/kernel/linux_torvalds/kernel/cgroup/cgroup.c:4092) kernfs_fop_write_iter (/home/marvin/linux/kernel/linux_torvalds/fs/kernfs/file.c:334) vfs_write (/home/marvin/linux/kernel/linux_torvalds/./include/linux/fs.h:2087 /home/marvin/linux/kernel/linux_torvalds/fs/read_write.c:497 /home/marvin/linux/kernel/linux_torvalds/fs/read_write.c:590) ksys_write (/home/marvin/linux/kernel/linux_torvalds/fs/read_write.c:643) __x64_sys_write (/home/marvin/linux/kernel/linux_torvalds/fs/read_write.c:652) do_syscall_64 (/home/marvin/linux/kernel/linux_torvalds/arch/x86/entry/common.c:52 /home/marvin/linux/kernel/linux_torvalds/arch/x86/entry/common.c:83) entry_SYSCALL_64_after_hwframe (/home/marvin/linux/kernel/linux_torvalds/arch/x86/entry/entry_64.S:129) unreferenced object 0xffff8d49bd92a890 (size 8): comm "test_cpuset_prs", pid 9213, jiffies 4294953562 hex dump (first 8 bytes): 00 00 00 00 00 00 00 00 ........ backtrace (crc 0): kmemleak_alloc (/home/marvin/linux/kernel/linux_torvalds/mm/kmemleak.c:1045) __kmalloc_node (/home/marvin/linux/kernel/linux_torvalds/./include/linux/kmemleak.h:42 /home/marvin/linux/kernel/linux_torvalds/mm/slub.c:3817 /home/marvin/linux/kernel/linux_torvalds/mm/slub.c:3860 /home/marvin/linux/kernel/linux_torvalds/mm/slub.c:3980 /home/marvin/linux/kernel/linux_torvalds/mm/slub.c:3988) alloc_cpumask_var_node (/home/marvin/linux/kernel/linux_torvalds/lib/cpumask.c:71) cpuset_write_resmask (/home/marvin/linux/kernel/linux_torvalds/kernel/cgroup/cpuset.c:649 /home/marvin/linux/kernel/linux_torvalds/kernel/cgroup/cpuset.c:2601 /home/marvin/linux/kernel/linux_torvalds/kernel/cgroup/cpuset.c:3630) cgroup_file_write (/home/marvin/linux/kernel/linux_torvalds/kernel/cgroup/cgroup.c:4092) kernfs_fop_write_iter (/home/marvin/linux/kernel/linux_torvalds/fs/kernfs/file.c:334) vfs_write (/home/marvin/linux/kernel/linux_torvalds/./include/linux/fs.h:2087 /home/marvin/linux/kernel/linux_torvalds/fs/read_write.c:497 /home/marvin/linux/kernel/linux_torvalds/fs/read_write.c:590) ksys_write (/home/marvin/linux/kernel/linux_torvalds/fs/read_write.c:643) __x64_sys_write (/home/marvin/linux/kernel/linux_torvalds/fs/read_write.c:652) do_syscall_64 (/home/marvin/linux/kernel/linux_torvalds/arch/x86/entry/common.c:52 /home/marvin/linux/kernel/linux_torvalds/arch/x86/entry/common.c:83) entry_SYSCALL_64_after_hwframe (/home/marvin/linux/kernel/linux_torvalds/arch/x86/entry/entry_64.S:129) unreferenced object 0xffff8d48c12f3720 (size 8): comm "test_cpuset_prs", pid 28081, jiffies 4295018483 hex dump (first 8 bytes): 00 00 00 00 00 00 00 00 ........ backtrace (crc 0): kmemleak_alloc (/home/marvin/linux/kernel/linux_torvalds/mm/kmemleak.c:1045) __kmalloc_node (/home/marvin/linux/kernel/linux_torvalds/./include/linux/kmemleak.h:42 /home/marvin/linux/kernel/linux_torvalds/mm/slub.c:3817 /home/marvin/linux/kernel/linux_torvalds/mm/slub.c:3860 /home/marvin/linux/kernel/linux_torvalds/mm/slub.c:3980 /home/marvin/linux/kernel/linux_torvalds/mm/slub.c:3988) alloc_cpumask_var_node (/home/marvin/linux/kernel/linux_torvalds/lib/cpumask.c:71) cpuset_write_resmask (/home/marvin/linux/kernel/linux_torvalds/kernel/cgroup/cpuset.c:643 /home/marvin/linux/kernel/linux_torvalds/kernel/cgroup/cpuset.c:2601 /home/marvin/linux/kernel/linux_torvalds/kernel/cgroup/cpuset.c:3630) cgroup_file_write (/home/marvin/linux/kernel/linux_torvalds/kernel/cgroup/cgroup.c:4092) kernfs_fop_write_iter (/home/marvin/linux/kernel/linux_torvalds/fs/kernfs/file.c:334) vfs_write (/home/marvin/linux/kernel/linux_torvalds/./include/linux/fs.h:2087 /home/marvin/linux/kernel/linux_torvalds/fs/read_write.c:497 /home/marvin/linux/kernel/linux_torvalds/fs/read_write.c:590) ksys_write (/home/marvin/linux/kernel/linux_torvalds/fs/read_write.c:643) __x64_sys_write (/home/marvin/linux/kernel/linux_torvalds/fs/read_write.c:652) do_syscall_64 (/home/marvin/linux/kernel/linux_torvalds/arch/x86/entry/common.c:52 /home/marvin/linux/kernel/linux_torvalds/arch/x86/entry/common.c:83) entry_SYSCALL_64_after_hwframe (/home/marvin/linux/kernel/linux_torvalds/arch/x86/entry/entry_64.S:129) unreferenced object 0xffff8d48c12f3180 (size 8): comm "test_cpuset_prs", pid 28081, jiffies 4295018483 hex dump (first 8 bytes): 00 00 00 00 00 00 00 00 ........ backtrace (crc 0): kmemleak_alloc (/home/marvin/linux/kernel/linux_torvalds/mm/kmemleak.c:1045) __kmalloc_node (/home/marvin/linux/kernel/linux_torvalds/./include/linux/kmemleak.h:42 /home/marvin/linux/kernel/linux_torvalds/mm/slub.c:3817 /home/marvin/linux/kernel/linux_torvalds/mm/slub.c:3860 /home/marvin/linux/kernel/linux_torvalds/mm/slub.c:3980 /home/marvin/linux/kernel/linux_torvalds/mm/slub.c:3988) alloc_cpumask_var_node (/home/marvin/linux/kernel/linux_torvalds/lib/cpumask.c:71) cpuset_write_resmask (/home/marvin/linux/kernel/linux_torvalds/kernel/cgroup/cpuset.c:646 /home/marvin/linux/kernel/linux_torvalds/kernel/cgroup/cpuset.c:2601 /home/marvin/linux/kernel/linux_torvalds/kernel/cgroup/cpuset.c:3630) cgroup_file_write (/home/marvin/linux/kernel/linux_torvalds/kernel/cgroup/cgroup.c:4092) kernfs_fop_write_iter (/home/marvin/linux/kernel/linux_torvalds/fs/kernfs/file.c:334) vfs_write (/home/marvin/linux/kernel/linux_torvalds/./include/linux/fs.h:2087 /home/marvin/linux/kernel/linux_torvalds/fs/read_write.c:497 /home/marvin/linux/kernel/linux_torvalds/fs/read_write.c:590) ksys_write (/home/marvin/linux/kernel/linux_torvalds/fs/read_write.c:643) __x64_sys_write (/home/marvin/linux/kernel/linux_torvalds/fs/read_write.c:652) do_syscall_64 (/home/marvin/linux/kernel/linux_torvalds/arch/x86/entry/common.c:52 /home/marvin/linux/kernel/linux_torvalds/arch/x86/entry/common.c:83) entry_SYSCALL_64_after_hwframe (/home/marvin/linux/kernel/linux_torvalds/arch/x86/entry/entry_64.S:129) unreferenced object 0xffff8d48c12f3188 (size 8): comm "test_cpuset_prs", pid 28081, jiffies 4295018483 hex dump (first 8 bytes): 00 00 00 00 00 00 00 00 ........ backtrace (crc 0): kmemleak_alloc (/home/marvin/linux/kernel/linux_torvalds/mm/kmemleak.c:1045) __kmalloc_node (/home/marvin/linux/kernel/linux_torvalds/./include/linux/kmemleak.h:42 /home/marvin/linux/kernel/linux_torvalds/mm/slub.c:3817 /home/marvin/linux/kernel/linux_torvalds/mm/slub.c:3860 /home/marvin/linux/kernel/linux_torvalds/mm/slub.c:3980 /home/marvin/linux/kernel/linux_torvalds/mm/slub.c:3988) alloc_cpumask_var_node (/home/marvin/linux/kernel/linux_torvalds/lib/cpumask.c:71) cpuset_write_resmask (/home/marvin/linux/kernel/linux_torvalds/kernel/cgroup/cpuset.c:649 /home/marvin/linux/kernel/linux_torvalds/kernel/cgroup/cpuset.c:2601 /home/marvin/linux/kernel/linux_torvalds/kernel/cgroup/cpuset.c:3630) cgroup_file_write (/home/marvin/linux/kernel/linux_torvalds/kernel/cgroup/cgroup.c:4092) kernfs_fop_write_iter (/home/marvin/linux/kernel/linux_torvalds/fs/kernfs/file.c:334) vfs_write (/home/marvin/linux/kernel/linux_torvalds/./include/linux/fs.h:2087 /home/marvin/linux/kernel/linux_torvalds/fs/read_write.c:497 /home/marvin/linux/kernel/linux_torvalds/fs/read_write.c:590) ksys_write (/home/marvin/linux/kernel/linux_torvalds/fs/read_write.c:643) __x64_sys_write (/home/marvin/linux/kernel/linux_torvalds/fs/read_write.c:652) do_syscall_64 (/home/marvin/linux/kernel/linux_torvalds/arch/x86/entry/common.c:52 /home/marvin/linux/kernel/linux_torvalds/arch/x86/entry/common.c:83) entry_SYSCALL_64_after_hwframe (/home/marvin/linux/kernel/linux_torvalds/arch/x86/entry/entry_64.S:129) -- CARNet system engineer Faculty of Graphic Arts | Academy of Fine Arts University of Zagreb CARNet sistem inženjer Grafički fakultet | Akademija likovnih umjetnosti Sveučilište u Zagrebu

1 year, 4 months

2
1
0 0

Re: [RESEND PATCH] selftests/overlayfs: fix compilation error in overlayfs

by Shuah Khan

On 2/27/24 00:42, Meng Li wrote: > make -C tools/testing/selftests, compiling dev_in_maps fail. > In file included from dev_in_maps.c:10: > /usr/include/x86_64-linux-gnu/sys/mount.h:35:3: error: expected identifier before numeric constant > 35 | MS_RDONLY = 1, /* Mount read-only. */ > | ^~~~~~~~~ > > That sys/mount.h has to be included before linux/mount.h. > > Signed-off-by: Meng Li <li.meng(a)amd.com> > --- > tools/testing/selftests/filesystems/overlayfs/dev_in_maps.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > I don't see this problem when I build it on my system when I run: make -C tools/testing/selftests or make -C tools/testing/selftests/filesystems/overlayfs Are you running this after doing headers_install? thanks, -- Shuah

1 year, 4 months

2
2
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

Linux-kselftest-mirror