From: Nicolin Chen nicolinc@nvidia.com Sent: Monday, October 28, 2024 6:49 AM
On Sun, Oct 27, 2024 at 11:02:31PM +0800, Zhangfei Gao wrote:
On Sat, 26 Oct 2024 at 07:51, Nicolin Chen nicolinc@nvidia.com wrote:
+/* Caller should xa_lock(&viommu->vdevs) to protect the return value
*/
+struct device *iommufd_viommu_find_dev(struct iommufd_viommu
*viommu,
unsigned long vdev_id)+{
struct iommufd_vdevice *vdev;lockdep_is_held(&viommu->vdevs.xa_lock);vdev = xa_load(&viommu->vdevs, vdev_id);return vdev ? vdev->idev->dev : NULL;+}
Got this error?
ld: Unexpected GOT/PLT entries detected! ld: Unexpected run-time procedure linkages detected! ld: drivers/iommu/iommufd/driver.o: in function
`iommufd_viommu_find_dev':
linux/drivers/iommu/iommufd/driver.c:47: undefined reference to `lockdep_is_held' make[2]: *** [scripts/Makefile.vmlinux:34: vmlinux] Error 1 make[1]: *** [/home/linaro/iommufd/linux/Makefile:1166: vmlinux] Error
2
make: *** [Makefile:224: __sub-make] Error 2
Should fix it with:
- lockdep_is_held(&viommu->vdevs.xa_lock);
- lockdep_assert_held(&viommu->vdevs.xa_lock);
with that,
Reviewed-by: Kevin Tian kevin.tian@intel.com