Re: [PATCH bpf-next v5 9/9] bpf: xfrm: Add selftest for bpf_xdp_get_xfrm_state()

On Thu, Dec 14, 2023 at 12:24 PM Daniel Xu dxu@dxuuu.xyz wrote:

Looks like only x86 supports exceptions (looking at bpf_jit_supports_exceptions()).

This causes selftests in this patchset to fail on !x86, which is unfortunate. We probably want to be running these tests on all the major archs, so I will drop the assertion patches from this patchset.

But since they're generally useful and I've already written the selftests for it, I could put them up in another patchset? Or maybe not cuz you're gonna fix it later anyways. WDYT?

Yeah. don't use bpf_assert in generic tests yet. Only tests that test bpf_assert should use it.

Pls send the ones you wrote separately, so they stay in email archives and we can pick them up later.