On Sat, Jun 3, 2023 at 10:13 PM Simon Horman simon.horman@corigine.com wrote:
On Fri, Jun 02, 2023 at 02:59:54PM +0800, menglong8.dong@gmail.com wrote:
From: Menglong Dong imagedong@tencent.com
According to the current kernel version, below is a statistics of the function arguments count:
argument count | FUNC_PROTO count 7 | 367 8 | 196 9 | 71 10 | 43 11 | 22 12 | 10 13 | 15 14 | 4 15 | 0 16 | 1
It's hard to statisics the function count, so I use FUNC_PROTO in the btf of vmlinux instead. The function with 16 arguments is ZSTD_buildCTable(), which I think can be ignored.
Therefore, let's make the maximum of function arguments count 14. It used to be 12, but it seems that there is no harm to make it big enough.
Reviewed-by: Jiang Biao benbjiang@tencent.com Signed-off-by: Menglong Dong imagedong@tencent.com
include/linux/bpf.h | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/include/linux/bpf.h b/include/linux/bpf.h index f58895830ada..8b997779faf7 100644 --- a/include/linux/bpf.h +++ b/include/linux/bpf.h @@ -961,10 +961,10 @@ enum bpf_cgroup_storage_type {
#define MAX_BPF_CGROUP_STORAGE_TYPE __BPF_CGROUP_STORAGE_MAX
-/* The longest tracepoint has 12 args.
- See include/trace/bpf_probe.h
+/* The maximun number of the kernel function arguments.
Hi Menglong Dong,
as it looks like there will be a v3 anyway, please consider correcting the spelling of maximum.
According to the advice of Alexei Starovoitov, it seems we don't need to modify it here anymore. Anyway, Thank you for reminding me of this spelling mistake :)
...