On 9/12/24 09:23, Jakub Kicinski wrote:
On Thu, 12 Sep 2024 08:31:18 +0200 Anders Roxell wrote:
Fixes: 1d0dc857b5d8 ("selftests: drv-net: add checksum tests") Signed-off-by: Anders Roxell anders.roxell@linaro.org
tools/testing/selftests/Makefile | 1 + 1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile index 3b7df5477317..fc3681270afe 100644 --- a/tools/testing/selftests/Makefile +++ b/tools/testing/selftests/Makefile @@ -64,6 +64,7 @@ TARGETS += net TARGETS += net/af_unix TARGETS += net/forwarding TARGETS += net/hsr +TARGETS += net/lib TARGETS += net/mptcp TARGETS += net/netfilter TARGETS += net/openvswitch
Please make sure you always include a commit message. Among other things writing one would force you to understand the code, and in this case understand that this target is intentionally left out. Look around the Makefile for references to net/lib, you'll figure it out.
+1 - thank you for outlining the benefits of writing a change log which includes the details.
This patch is missing the changelog completely - change log is an important part of sending a patch.
The patch is incorrect.
thanks, -- Shuah