Re: [PATCH net-next v2 3/5] netconsole: append msgid to sysdata

On Sat, Jun 14, 2025 at 8:51 PM Jakub Kicinski kuba@kernel.org wrote:

On Thu, 12 Jun 2025 13:02:16 -0700 Gustavo Luiz Duarte wrote:

...

diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c index 3bf8777fcd01..baa9862c1bc3 100644 --- a/drivers/net/netconsole.c +++ b/drivers/net/netconsole.c @@ -155,6 +155,8 @@ struct netconsole_target { size_t userdata_length; /* bit-wise with sysdata_feature bits */ u32 sysdata_fields;

• /* protected by target_list_lock */
  

• u32                     msgcounter;
  

#endif

kdoc is complaining that:

drivers/net/netconsole.c:167 struct member 'msgcounter' not described in 'netconsole_target'

Good catch. I'm sending v3 to fix this (will also add kdoc check to my pre-send checklist). Thanks for the review!