Re: [V2 PATCH 1/8] KVM: selftests: move common startup logic to kvm_util.c

On Thu, Sep 15, 2022 at 12:04:41AM +0000, Vishal Annapurve wrote:

Consolidate common startup logic in one place by implementing a single setup function with __attribute((constructor)) for all selftests within kvm_util.c.

This allows moving logic like: /* Tell stdout not to buffer its content */ setbuf(stdout, NULL); to a single file for all selftests.

This will also allow any required setup at entry in future to be done in common main function.

More context is discussed at: https://lore.kernel.org/lkml/Ywa9T+jKUpaHLu%2Fl@google.com/

Suggested-by: Sean Christopherson seanjc@google.com Signed-off-by: Vishal Annapurve vannapurve@google.com

---

Reviewed-by: Andrew Jones andrew.jones@linux.dev