Re: [PATCH-cgroup 3/4] cgroup/cpuset: Keep track of CPUs in isolated partitions

On 10/18/23 05:26, Tejun Heo wrote:

On Fri, Oct 13, 2023 at 02:11:21PM -0400, Waiman Long wrote: ...

...

@@ -3875,6 +3931,13 @@ static struct cftype dfl_files[] = { .flags = CFTYPE_ONLY_ON_ROOT | CFTYPE_DEBUG, },

• {

• .name = "cpus.isolated",
  

• .seq_show = cpuset_common_seq_show,
  

• .private = FILE_ISOLATED_CPULIST,
  

• .flags = CFTYPE_ONLY_ON_ROOT | CFTYPE_DEBUG,
  

• },

I'd much rather show this in a wq sysfs file along with other related masks, and not in a DEBUG file.

It can certainly be exposed as a permanent addition to the cgroup control files instead of a debug only file. However this set of isolated CPUs may be used by others not just by workqueue. So I doubt if it should be a sysfs file in the workqueue directory. I can see if it is possible to put a symlink there point back to the cgroupfs.

Thanks, Longman