Re: [PATCH 0/3] Reanme the definitions of INTERRUPT_PENDING, NMI_PENDING and TSC_OFFSETING

On Fri, Dec 06, 2019 at 04:45:23PM +0800, Xiaoyao Li wrote:

When reading the codes, I find the definitions of interrupt-window exiting and nmi-window exiting don't match the names in latest intel SDM.

I prefer KVM's names even though they diverge from the SDM. The "window exiting" terminology is very literal, which is desirable for the SDM because it doesn't leave any wiggle room. But for software, IMO the "event pending" terminology is preferable as it's more descriptive of the intended use of the control, e.g. KVM sets VIRTUAL_{INTR,NMI}_PENDING when it has a virtual event to inject and clears it after injecting said event.