On Sun 2020-10-25 22:48:40, Rasmus Villemoes wrote:
Two out of three users of the kselftest_module.h header manually define the failed_tests/total_tests variables instead of making use of the KSTM_MODULE_GLOBALS() macro. However, instead of just replacing those definitions with an invocation of that macro, just unconditionally define them in the header file itself.
A coming change will add a few more global variables, and at least one of those will be referenced from kstm_report() - however, that's not possible currently, since when the definition is postponed until the test module invokes KSTM_MODULE_GLOBALS(), the variable is not defined by the time the compiler parses kstm_report().
Signed-off-by: Rasmus Villemoes linux@rasmusvillemoes.dk
Reviewed-by: Petr Mladek pmladek@suse.com
Best Regards, Petr