On Tue, Dec 17, 2024 at 03:10:28PM +0000, Mark Brown wrote:
On Tue, Dec 17, 2024 at 01:54:39PM +0000, Marc Zyngier wrote:
Mark Brown broonie@kernel.org wrote:
The selftests are shipped as part of the kernel source and frequently used for testing the kernel, it's all one source base and we want to ensure that for example the test fix gets backported if the relevant kernel patch does.
That's not what Fixes: describes. If you want to invent a new tag that expresses a dependency, do that. Don't use these tags to misrepresent what the patches does.
No, this isn't a new use - a Fixes: tag indicates that the referenced commit introduced the problem being fixed and that is exactly what's going on here. Like I say the selftests are not a completely separate project, they are a part of the same source release as the rest of the kernel and it is helpful to track information like this.
A Fixes tag suggests a bug in the referenced commit, which isn't the case here.
I agree that having some relation between the two is useful for determining the scope of a backport, but conveniently in this case the test failure was introduced in 6.13.
I've taken the fix for 6.13, w/ the tag dropped.