Hi David,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master] [cannot apply to mcgrof/modules-next joel-aspeed/for-next ulf-hansson-mmc-mirror/next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch]
url: https://github.com/intel-lab-lkp/linux/commits/David-Gow/Rework-KUnit-test-e... base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 4b35035bcf80ddb47c0112c4fbd84a63a2836a18 config: s390-allmodconfig (https://download.01.org/0day-ci/archive/20220618/202206181950.qNG3jcE8-lkp@i...) compiler: s390-linux-gcc (GCC) 11.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/14ff6ae01a41e301f1409874dd5aa3... git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review David-Gow/Rework-KUnit-test-execution-in-modules/20220618-170653 git checkout 14ff6ae01a41e301f1409874dd5aa38f73bc96f5 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash lib/kunit/
If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot lkp@intel.com
All errors (new ones prefixed by >>):
lib/kunit/test.c: In function 'kunit_module_init':
lib/kunit/test.c:618:28: error: 'struct module' has no member named 'num_kunit_suites'
618 | for (i = 0; i < mod->num_kunit_suites; i++) | ^~
lib/kunit/test.c:619:45: error: 'struct module' has no member named 'kunit_suites'
619 | __kunit_test_suites_init(mod->kunit_suites[i]); | ^~ lib/kunit/test.c: In function 'kunit_module_exit': lib/kunit/test.c:626:28: error: 'struct module' has no member named 'num_kunit_suites' 626 | for (i = 0; i < mod->num_kunit_suites; i++) | ^~ lib/kunit/test.c:627:45: error: 'struct module' has no member named 'kunit_suites' 627 | __kunit_test_suites_exit(mod->kunit_suites[i]); | ^~
vim +618 lib/kunit/test.c
612 613 #ifdef CONFIG_MODULES 614 static void kunit_module_init(struct module *mod) 615 { 616 unsigned int i; 617
618 for (i = 0; i < mod->num_kunit_suites; i++) 619 __kunit_test_suites_init(mod->kunit_suites[i]);
620 } 621