Re: [PATCH 2/4] selftests/arm: Add signal tests

On Sun, Apr 07, 2024 at 02:28:06AM +0500, Muhammad Usama Anjum wrote:

On 4/5/24 1:44 PM, Dev Jain wrote:

...

• ksft_print_msg("%s :: %s\n", current->name, current->descr);
• if (test_setup(current) && test_init(current)) {

• test_run(current);
  

• test_cleanup(current);
  

• }
• test_result(current);
• return current->result;

+}

This test isn't TAP compliant. Please make this and all tests TAP compilant. The 1/4 patch has example of TAP usage.

It's based on the 64 bit version of these tests which are also not TAP compliant. TBH I'm not sure how worthwile it is to fix at all given that they're all single test executables anyway, if it does get fixed it'd be good to do the arm64 ones as well.

...

• } else {

• fprintf(stdout, "==>> completed. FAIL(0)\n");
  

• td->result = KSFT_FAIL;
  

• }
• if (force_exit)

• exit(td->result);
  

+}

Please delete unneeded context from mails when replying. Doing this makes it much easier to find your reply in the message, helping ensure it won't be missed by people scrolling through the irrelevant quoted material.